Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

Madhavan Srinivasan writes: > From: Hemant Kumar > > This patch does three things : > - Enables "opal.c" to create a platform device for the IMC interface >according to the appropriate compatibility string. > - Find the reserved-memory

Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

Madhavan Srinivasan writes: > From: Hemant Kumar > > This patch does three things : > - Enables "opal.c" to create a platform device for the IMC interface >according to the appropriate compatibility string. > - Find the reserved-memory region details from the system device tree >and

Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

On Tuesday 04 April 2017 07:18 AM, Daniel Axtens wrote: Hi, + do { + pages = PAGE_SIZE * i; + pcni->vbase[i++] = (u64)phys_to_virt(pcni->pbase + +pages); + }

Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

On Tuesday 04 April 2017 07:18 AM, Daniel Axtens wrote: Hi, + do { + pages = PAGE_SIZE * i; + pcni->vbase[i++] = (u64)phys_to_virt(pcni->pbase + +pages); + }

Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

On Tuesday 04 April 2017 06:28 AM, Daniel Axtens wrote: Hi all, I'm trying to get my head around these patches - at this point I'm just doing a first pass, so I may have more substantive structural comments later on. In the mean time - here are some minor C nits: + * Copyright (C) 2016

Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

On Tuesday 04 April 2017 06:28 AM, Daniel Axtens wrote: Hi all, I'm trying to get my head around these patches - at this point I'm just doing a first pass, so I may have more substantive structural comments later on. In the mean time - here are some minor C nits: + * Copyright (C) 2016

Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

Hi, > + do { > + pages = PAGE_SIZE * i; > + pcni->vbase[i++] = (u64)phys_to_virt(pcni->pbase + > + pages); > + } while (i < (pcni->size / PAGE_SIZE)); I also just noticed that

Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

Hi, > + do { > + pages = PAGE_SIZE * i; > + pcni->vbase[i++] = (u64)phys_to_virt(pcni->pbase + > + pages); > + } while (i < (pcni->size / PAGE_SIZE)); I also just noticed that

Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

Hi all, I'm trying to get my head around these patches - at this point I'm just doing a first pass, so I may have more substantive structural comments later on. In the mean time - here are some minor C nits: > + * Copyright (C) 2016 Madhavan Srinivasan, IBM Corporation. > + * (C) 2016

Re: [PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

Hi all, I'm trying to get my head around these patches - at this point I'm just doing a first pass, so I may have more substantive structural comments later on. In the mean time - here are some minor C nits: > + * Copyright (C) 2016 Madhavan Srinivasan, IBM Corporation. > + * (C) 2016

[PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

From: Hemant Kumar This patch does three things : - Enables "opal.c" to create a platform device for the IMC interface according to the appropriate compatibility string. - Find the reserved-memory region details from the system device tree and get the base

[PATCH v6 02/11] powerpc/powernv: Autoload IMC device driver module

From: Hemant Kumar This patch does three things : - Enables "opal.c" to create a platform device for the IMC interface according to the appropriate compatibility string. - Find the reserved-memory region details from the system device tree and get the base address of HOMER (Reserved