Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On 6 April 2017 at 07:30, Leo Yan wrote: > Coresight includes debug module and usually the module connects with CPU > debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has > description for related info in "Part H: External Debug". > > Chapter H7 "The

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On 6 April 2017 at 07:30, Leo Yan wrote: > Coresight includes debug module and usually the module connects with CPU > debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has > description for related info in "Part H: External Debug". > > Chapter H7 "The Sample-based Profiling

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On 19 April 2017 at 09:30, Leo Yan wrote: > On Wed, Apr 19, 2017 at 08:52:12AM -0600, Mathieu Poirier wrote: > > [...] > >> >> > +static bool debug_enable; >> >> > +module_param_named(enable, debug_enable, bool, 0600); >> >> > +MODULE_PARM_DESC(enable, "Knob to enable debug

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On 19 April 2017 at 09:30, Leo Yan wrote: > On Wed, Apr 19, 2017 at 08:52:12AM -0600, Mathieu Poirier wrote: > > [...] > >> >> > +static bool debug_enable; >> >> > +module_param_named(enable, debug_enable, bool, 0600); >> >> > +MODULE_PARM_DESC(enable, "Knob to enable debug functionality " >> >>

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On Wed, Apr 19, 2017 at 08:52:12AM -0600, Mathieu Poirier wrote: [...] > >> > +static bool debug_enable; > >> > +module_param_named(enable, debug_enable, bool, 0600); > >> > +MODULE_PARM_DESC(enable, "Knob to enable debug functionality " > >> > +"(default is 0, which means is

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On Wed, Apr 19, 2017 at 08:52:12AM -0600, Mathieu Poirier wrote: [...] > >> > +static bool debug_enable; > >> > +module_param_named(enable, debug_enable, bool, 0600); > >> > +MODULE_PARM_DESC(enable, "Knob to enable debug functionality " > >> > +"(default is 0, which means is

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On Wed, Apr 19, 2017 at 03:32:39PM +0100, Suzuki K Poulose wrote: [...] > >>>+static int debug_probe(struct amba_device *adev, const struct amba_id *id) > >>>+{ > >>>+ void __iomem *base; > >>>+ struct device *dev = >dev; > >>>+ struct debug_drvdata *drvdata; > >>>+ struct resource *res =

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On Wed, Apr 19, 2017 at 03:32:39PM +0100, Suzuki K Poulose wrote: [...] > >>>+static int debug_probe(struct amba_device *adev, const struct amba_id *id) > >>>+{ > >>>+ void __iomem *base; > >>>+ struct device *dev = >dev; > >>>+ struct debug_drvdata *drvdata; > >>>+ struct resource *res =

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On 18 April 2017 at 18:18, Leo Yan wrote: > On Tue, Apr 18, 2017 at 11:40:50AM -0600, Mathieu Poirier wrote: >> On Thu, Apr 06, 2017 at 09:30:59PM +0800, Leo Yan wrote: >> > Coresight includes debug module and usually the module connects with CPU >> > debug logic. ARMv8

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On 18 April 2017 at 18:18, Leo Yan wrote: > On Tue, Apr 18, 2017 at 11:40:50AM -0600, Mathieu Poirier wrote: >> On Thu, Apr 06, 2017 at 09:30:59PM +0800, Leo Yan wrote: >> > Coresight includes debug module and usually the module connects with CPU >> > debug logic. ARMv8 architecture reference

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On 19/04/17 15:28, Leo Yan wrote: Hi Suzuki, On Wed, Apr 19, 2017 at 02:23:04PM +0100, Suzuki K Poulose wrote: Hi Leo, This version looks good to me. I have two minor comments below. Thanks for reviewing. Will take the suggestions. Just check a bit for last comment. [...] +static int

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On 19/04/17 15:28, Leo Yan wrote: Hi Suzuki, On Wed, Apr 19, 2017 at 02:23:04PM +0100, Suzuki K Poulose wrote: Hi Leo, This version looks good to me. I have two minor comments below. Thanks for reviewing. Will take the suggestions. Just check a bit for last comment. [...] +static int

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

Hi Suzuki, On Wed, Apr 19, 2017 at 02:23:04PM +0100, Suzuki K Poulose wrote: > Hi Leo, > > This version looks good to me. I have two minor comments below. Thanks for reviewing. Will take the suggestions. Just check a bit for last comment. [...] > >+static int debug_probe(struct amba_device

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

Hi Suzuki, On Wed, Apr 19, 2017 at 02:23:04PM +0100, Suzuki K Poulose wrote: > Hi Leo, > > This version looks good to me. I have two minor comments below. Thanks for reviewing. Will take the suggestions. Just check a bit for last comment. [...] > >+static int debug_probe(struct amba_device

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On 06/04/17 14:30, Leo Yan wrote: Coresight includes debug module and usually the module connects with CPU debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has description for related info in "Part H: External Debug". Chapter H7 "The Sample-based Profiling Extension"

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On 06/04/17 14:30, Leo Yan wrote: Coresight includes debug module and usually the module connects with CPU debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has description for related info in "Part H: External Debug". Chapter H7 "The Sample-based Profiling Extension"

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On Tue, Apr 18, 2017 at 11:40:50AM -0600, Mathieu Poirier wrote: > On Thu, Apr 06, 2017 at 09:30:59PM +0800, Leo Yan wrote: > > Coresight includes debug module and usually the module connects with CPU > > debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has > > description for

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On Tue, Apr 18, 2017 at 11:40:50AM -0600, Mathieu Poirier wrote: > On Thu, Apr 06, 2017 at 09:30:59PM +0800, Leo Yan wrote: > > Coresight includes debug module and usually the module connects with CPU > > debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has > > description for

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On Thu, Apr 06, 2017 at 09:30:59PM +0800, Leo Yan wrote: > Coresight includes debug module and usually the module connects with CPU > debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has > description for related info in "Part H: External Debug". > > Chapter H7 "The Sample-based

Re: [PATCH v6 6/8] coresight: add support for CPU debug module

On Thu, Apr 06, 2017 at 09:30:59PM +0800, Leo Yan wrote: > Coresight includes debug module and usually the module connects with CPU > debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has > description for related info in "Part H: External Debug". > > Chapter H7 "The Sample-based

[PATCH v6 6/8] coresight: add support for CPU debug module

Coresight includes debug module and usually the module connects with CPU debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has description for related info in "Part H: External Debug". Chapter H7 "The Sample-based Profiling Extension" introduces several sampling registers, e.g.

[PATCH v6 6/8] coresight: add support for CPU debug module

Coresight includes debug module and usually the module connects with CPU debug logic. ARMv8 architecture reference manual (ARM DDI 0487A.k) has description for related info in "Part H: External Debug". Chapter H7 "The Sample-based Profiling Extension" introduces several sampling registers, e.g.