Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-13 Thread Paul E. McKenney
On Tue, Apr 13, 2021 at 10:49:11PM +0200, Thomas Gleixner wrote: > Paul, > > On Mon, Apr 12 2021 at 16:18, Paul E. McKenney wrote: > > On Mon, Apr 12, 2021 at 10:37:10PM +0200, Thomas Gleixner wrote: > >> On Mon, Apr 12 2021 at 12:57, Paul E. McKenney wrote: > >> > On Mon, Apr 12, 2021 at

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-13 Thread Thomas Gleixner
Paul, On Mon, Apr 12 2021 at 16:18, Paul E. McKenney wrote: > On Mon, Apr 12, 2021 at 10:37:10PM +0200, Thomas Gleixner wrote: >> On Mon, Apr 12 2021 at 12:57, Paul E. McKenney wrote: >> > On Mon, Apr 12, 2021 at 08:54:03PM +0200, Thomas Gleixner wrote: >> >> > I will send a new series out later

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Paul E. McKenney
On Mon, Apr 12, 2021 at 10:37:10PM +0200, Thomas Gleixner wrote: > On Mon, Apr 12 2021 at 12:57, Paul E. McKenney wrote: > > On Mon, Apr 12, 2021 at 08:54:03PM +0200, Thomas Gleixner wrote: > >> > I will send a new series out later today, Pacific Time. > >> > >> Can you do me a favour and send it

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Thomas Gleixner
On Mon, Apr 12 2021 at 12:57, Paul E. McKenney wrote: > On Mon, Apr 12, 2021 at 08:54:03PM +0200, Thomas Gleixner wrote: >> > I will send a new series out later today, Pacific Time. >> >> Can you do me a favour and send it standalone and not as yet another >> reply to this existing thread maze. A

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Paul E. McKenney
On Mon, Apr 12, 2021 at 08:54:03PM +0200, Thomas Gleixner wrote: > Paul, > > On Mon, Apr 12 2021 at 11:20, Paul E. McKenney wrote: > > On Mon, Apr 12, 2021 at 03:08:16PM +0200, Thomas Gleixner wrote: > >> The reason for irqsave is again historical AFAICT and nobody bothered to > >> clean it up.

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Thomas Gleixner
Paul, On Mon, Apr 12 2021 at 11:20, Paul E. McKenney wrote: > On Mon, Apr 12, 2021 at 03:08:16PM +0200, Thomas Gleixner wrote: >> The reason for irqsave is again historical AFAICT and nobody bothered to >> clean it up. spin_lock_bh() should be sufficient to serialize against >> the watchdog

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Paul E. McKenney
On Mon, Apr 12, 2021 at 03:08:16PM +0200, Thomas Gleixner wrote: > On Sun, Apr 11 2021 at 21:21, Paul E. McKenney wrote: > > On Sun, Apr 11, 2021 at 09:46:12AM -0700, Paul E. McKenney wrote: > >> So I need to is inline clocksource_verify_percpu_wq() > >> into clocksource_verify_percpu() and then

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-12 Thread Thomas Gleixner
On Sun, Apr 11 2021 at 21:21, Paul E. McKenney wrote: > On Sun, Apr 11, 2021 at 09:46:12AM -0700, Paul E. McKenney wrote: >> So I need to is inline clocksource_verify_percpu_wq() >> into clocksource_verify_percpu() and then move the call to >> clocksource_verify_percpu() to

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-11 Thread Paul E. McKenney
On Sun, Apr 11, 2021 at 09:46:12AM -0700, Paul E. McKenney wrote: > On Sun, Apr 11, 2021 at 12:33:44PM +0200, Thomas Gleixner wrote: > > On Sat, Apr 10 2021 at 17:20, Paul E. McKenney wrote: > > > On Sat, Apr 10, 2021 at 11:00:25AM +0200, Thomas Gleixner wrote: > > >> > + if

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-11 Thread Paul E. McKenney
On Sun, Apr 11, 2021 at 12:33:44PM +0200, Thomas Gleixner wrote: > On Sat, Apr 10 2021 at 17:20, Paul E. McKenney wrote: > > On Sat, Apr 10, 2021 at 11:00:25AM +0200, Thomas Gleixner wrote: > >> > +if (WARN_ON_ONCE(!cs)) > >> > +return; > >> > +pr_warn("Checking

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-11 Thread Thomas Gleixner
On Sat, Apr 10 2021 at 17:20, Paul E. McKenney wrote: > On Sat, Apr 10, 2021 at 11:00:25AM +0200, Thomas Gleixner wrote: >> > + if (WARN_ON_ONCE(!cs)) >> > + return; >> > + pr_warn("Checking clocksource %s synchronization from CPU %d.\n", >> > + cs->name, smp_processor_id());

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-10 Thread Paul E. McKenney
On Sat, Apr 10, 2021 at 11:00:25AM +0200, Thomas Gleixner wrote: > On Fri, Apr 02 2021 at 15:49, paulmck wrote: > > > > +static void clocksource_verify_percpu_wq(struct work_struct *unused) > > +{ > > + int cpu; > > + struct clocksource *cs; > > + int64_t cs_nsec; > > + u64 csnow_begin; >

Re: [PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-10 Thread Thomas Gleixner
On Fri, Apr 02 2021 at 15:49, paulmck wrote: > > +static void clocksource_verify_percpu_wq(struct work_struct *unused) > +{ > + int cpu; > + struct clocksource *cs; > + int64_t cs_nsec; > + u64 csnow_begin; > + u64 csnow_end; > + u64 delta; Please use reverse fir tree

[PATCH v7 clocksource 3/5] clocksource: Check per-CPU clock synchronization when marked unstable

2021-04-02 Thread paulmck
From: "Paul E. McKenney" Some sorts of per-CPU clock sources have a history of going out of synchronization with each other. However, this problem has purportedy been solved in the past ten years. Except that it is all too possible that the problem has instead simply been made less likely,