Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-06-24 at 19:39 +0800, Horng-Shyang Liao wrote: > On Tue, 2016-06-21 at 15:46 +0800, Horng-Shyang Liao wrote: > > On Tue, 2016-06-21 at 10:03 +0800, CK Hu wrote: > > > On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > > > > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-06-24 at 19:39 +0800, Horng-Shyang Liao wrote: > On Tue, 2016-06-21 at 15:46 +0800, Horng-Shyang Liao wrote: > > On Tue, 2016-06-21 at 10:03 +0800, CK Hu wrote: > > > On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > > > > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 15:46 +0800, Horng-Shyang Liao wrote: > On Tue, 2016-06-21 at 10:03 +0800, CK Hu wrote: > > On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > > > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > > > > [Snip...] > > > > > > > > > + > > > > > +static int

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 15:46 +0800, Horng-Shyang Liao wrote: > On Tue, 2016-06-21 at 10:03 +0800, CK Hu wrote: > > On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > > > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > > > > [Snip...] > > > > > > > > > + > > > > > +static int

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Thu, 2016-06-23 at 15:54 +0800, Horng-Shyang Liao wrote: > Hi CK, > > On Thu, 2016-06-23 at 14:03 +0800, CK Hu wrote: > > Hi, HS: > > > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > > [...] > > > > > + > > > +/* events for CMDQ and display */ > > > +enum cmdq_event { > > > + /*

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Thu, 2016-06-23 at 15:54 +0800, Horng-Shyang Liao wrote: > Hi CK, > > On Thu, 2016-06-23 at 14:03 +0800, CK Hu wrote: > > Hi, HS: > > > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > > [...] > > > > > + > > > +/* events for CMDQ and display */ > > > +enum cmdq_event { > > > + /*

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi CK, On Thu, 2016-06-23 at 14:03 +0800, CK Hu wrote: > Hi, HS: > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > [...] > > > + > > +/* events for CMDQ and display */ > > +enum cmdq_event { > > + /* Display start of frame(SOF) events */ > > + CMDQ_EVENT_DISP_OVL0_SOF = 11, > > +

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi CK, On Thu, 2016-06-23 at 14:03 +0800, CK Hu wrote: > Hi, HS: > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > [...] > > > + > > +/* events for CMDQ and display */ > > +enum cmdq_event { > > + /* Display start of frame(SOF) events */ > > + CMDQ_EVENT_DISP_OVL0_SOF = 11, > > +

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi, HS: On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > CMDQ is used to help read/write registers with critical time limitation, > such as updating display configuration during the vblank. It controls > Global Command

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi, HS: On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > CMDQ is used to help read/write registers with critical time limitation, > such as updating display configuration during the vblank. It controls > Global Command

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 06/22/2016 07:43 AM, Horng-Shyang Liao wrote: On Tue, 2016-06-21 at 15:41 +0200, Matthias Brugger wrote: On 21/06/16 07:52, Horng-Shyang Liao wrote: On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: On 17/06/16 10:28, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 06/22/2016 07:43 AM, Horng-Shyang Liao wrote: On Tue, 2016-06-21 at 15:41 +0200, Matthias Brugger wrote: On 21/06/16 07:52, Horng-Shyang Liao wrote: On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: On 17/06/16 10:28, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 15:41 +0200, Matthias Brugger wrote: > > On 21/06/16 07:52, Horng-Shyang Liao wrote: > > On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: > >> > >> On 17/06/16 10:28, Horng-Shyang Liao wrote: > >>> Hi Matthias, > >>> > >>> On Tue, 2016-06-14 at 20:07 +0800,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 15:41 +0200, Matthias Brugger wrote: > > On 21/06/16 07:52, Horng-Shyang Liao wrote: > > On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: > >> > >> On 17/06/16 10:28, Horng-Shyang Liao wrote: > >>> Hi Matthias, > >>> > >>> On Tue, 2016-06-14 at 20:07 +0800,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 21/06/16 07:52, Horng-Shyang Liao wrote: On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: On 17/06/16 10:28, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 21/06/16 07:52, Horng-Shyang Liao wrote: On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: On 17/06/16 10:28, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 10:03 +0800, CK Hu wrote: > On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > > > Hi, HS: > > > > > > One comment inline. > > > > > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > > > > This patch is

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Tue, 2016-06-21 at 10:03 +0800, CK Hu wrote: > On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > > > Hi, HS: > > > > > > One comment inline. > > > > > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > > > > This patch is

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: > > On 17/06/16 10:28, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: > >> Hi Matthias, > >> > >> On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: > >>> > >>> On

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-06-17 at 17:57 +0200, Matthias Brugger wrote: > > On 17/06/16 10:28, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: > >> Hi Matthias, > >> > >> On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: > >>> > >>> On

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > > Hi, HS: > > > > One comment inline. > > > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > > CMDQ

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Mon, 2016-06-20 at 19:22 +0800, Horng-Shyang Liao wrote: > On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > > Hi, HS: > > > > One comment inline. > > > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > > CMDQ

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > Hi, HS: > > One comment inline. > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Mon, 2016-06-20 at 18:41 +0800, CK Hu wrote: > Hi, HS: > > One comment inline. > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi, HS: One comment inline. On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > CMDQ is used to help read/write registers with critical time limitation, > such as updating display configuration during the vblank. It

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi, HS: One comment inline. On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > CMDQ is used to help read/write registers with critical time limitation, > such as updating display configuration during the vblank. It

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 14/06/16 14:07, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: On 14/06/16 09:44, Horng-Shyang Liao wrote: Hi Matthias, On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: On 08/06/16 14:25, Horng-Shyang Liao wrote: Hi

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 14/06/16 14:07, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: On 14/06/16 09:44, Horng-Shyang Liao wrote: Hi Matthias, On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: On 08/06/16 14:25, Horng-Shyang Liao wrote: Hi

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 17/06/16 10:28, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: On 14/06/16 09:44, Horng-Shyang Liao wrote: Hi Matthias, On Wed, 2016-06-08 at 17:35 +0200,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 17/06/16 10:28, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: On 14/06/16 09:44, Horng-Shyang Liao wrote: Hi Matthias, On Wed, 2016-06-08 at 17:35 +0200,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: > Hi Matthias, > > On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: > > > > On 14/06/16 09:44, Horng-Shyang Liao wrote: > > > Hi Matthias, > > > > > > On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-14 at 20:07 +0800, Horng-Shyang Liao wrote: > Hi Matthias, > > On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: > > > > On 14/06/16 09:44, Horng-Shyang Liao wrote: > > > Hi Matthias, > > > > > > On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: > > On 14/06/16 09:44, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: > >> > >> On 08/06/16 14:25, Horng-Shyang Liao wrote: > >>> Hi Matthias, > >>> > >>> On Wed,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-14 at 12:17 +0200, Matthias Brugger wrote: > > On 14/06/16 09:44, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: > >> > >> On 08/06/16 14:25, Horng-Shyang Liao wrote: > >>> Hi Matthias, > >>> > >>> On Wed,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 14/06/16 09:44, Horng-Shyang Liao wrote: Hi Matthias, On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: On 08/06/16 14:25, Horng-Shyang Liao wrote: Hi Matthias, On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: On 08/06/16 07:40, Horng-Shyang Liao wrote: Hi

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 14/06/16 09:44, Horng-Shyang Liao wrote: Hi Matthias, On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: On 08/06/16 14:25, Horng-Shyang Liao wrote: Hi Matthias, On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: On 08/06/16 07:40, Horng-Shyang Liao wrote: Hi

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: > > On 08/06/16 14:25, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: > >> > >> On 08/06/16 07:40, Horng-Shyang Liao wrote: > >>> Hi Matthias, > >>> > >>> On Tue,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Wed, 2016-06-08 at 17:35 +0200, Matthias Brugger wrote: > > On 08/06/16 14:25, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: > >> > >> On 08/06/16 07:40, Horng-Shyang Liao wrote: > >>> Hi Matthias, > >>> > >>> On Tue,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 08/06/16 14:25, Horng-Shyang Liao wrote: Hi Matthias, On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: On 08/06/16 07:40, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: On 03/06/16 15:11, Matthias Brugger wrote: [...]

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 08/06/16 14:25, Horng-Shyang Liao wrote: Hi Matthias, On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: On 08/06/16 07:40, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: On 03/06/16 15:11, Matthias Brugger wrote: [...]

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: > > On 08/06/16 07:40, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: > >> > >> On 03/06/16 15:11, Matthias Brugger wrote: > >>> > >>> > >> [...] > >> >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Wed, 2016-06-08 at 12:45 +0200, Matthias Brugger wrote: > > On 08/06/16 07:40, Horng-Shyang Liao wrote: > > Hi Matthias, > > > > On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: > >> > >> On 03/06/16 15:11, Matthias Brugger wrote: > >>> > >>> > >> [...] > >> >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 08/06/16 07:40, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: On 03/06/16 15:11, Matthias Brugger wrote: [...] + +smp_mb(); /* modify jump before enable thread */ +} + +cmdq_thread_writel(thread,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 08/06/16 07:40, Horng-Shyang Liao wrote: Hi Matthias, On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: On 03/06/16 15:11, Matthias Brugger wrote: [...] + +smp_mb(); /* modify jump before enable thread */ +} + +cmdq_thread_writel(thread,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: > > On 03/06/16 15:11, Matthias Brugger wrote: > > > > > [...] > > >> + > >> +smp_mb(); /* modify jump before enable thread */ > >> +} > >> + > >> +

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-07 at 18:59 +0200, Matthias Brugger wrote: > > On 03/06/16 15:11, Matthias Brugger wrote: > > > > > [...] > > >> + > >> +smp_mb(); /* modify jump before enable thread */ > >> +} > >> + > >> +

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-07 at 19:04 +0200, Matthias Brugger wrote: > > On 30/05/16 05:19, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > > such as updating display

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Tue, 2016-06-07 at 19:04 +0200, Matthias Brugger wrote: > > On 30/05/16 05:19, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > > such as updating display

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 30/05/16 05:19, HS Liao wrote: This patch is first version of Mediatek Command Queue(CMDQ) driver. The CMDQ is used to help read/write registers with critical time limitation, such as updating display configuration during the vblank. It controls Global Command Engine (GCE) hardware to

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 30/05/16 05:19, HS Liao wrote: This patch is first version of Mediatek Command Queue(CMDQ) driver. The CMDQ is used to help read/write registers with critical time limitation, such as updating display configuration during the vblank. It controls Global Command Engine (GCE) hardware to

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 03/06/16 15:11, Matthias Brugger wrote: [...] + +smp_mb(); /* modify jump before enable thread */ +} + +cmdq_thread_writel(thread, task->pa_base + task->command_size, + CMDQ_THR_END_ADDR); +cmdq_thread_resume(thread); +} +

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 03/06/16 15:11, Matthias Brugger wrote: [...] + +smp_mb(); /* modify jump before enable thread */ +} + +cmdq_thread_writel(thread, task->pa_base + task->command_size, + CMDQ_THR_END_ADDR); +cmdq_thread_resume(thread); +} +

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-06-03 at 18:41 +0530, Jassi Brar wrote: > On Fri, Jun 3, 2016 at 4:48 PM, Matthias Brugger > wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > >> On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > > >>> I keep thinking about how to get rid

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, 2016-06-03 at 18:41 +0530, Jassi Brar wrote: > On Fri, Jun 3, 2016 at 4:48 PM, Matthias Brugger > wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > >> On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > > >>> I keep thinking about how to get rid of the two data

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, Jassi, On Fri, 2016-06-03 at 18:41 +0530, Jassi Brar wrote: > On Fri, Jun 3, 2016 at 4:48 PM, Matthias Brugger > wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > >> On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > > >>> I keep thinking

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, Jassi, On Fri, 2016-06-03 at 18:41 +0530, Jassi Brar wrote: > On Fri, Jun 3, 2016 at 4:48 PM, Matthias Brugger > wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > >> On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > > >>> I keep thinking about how to get rid of

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, Jun 3, 2016 at 4:48 PM, Matthias Brugger wrote: > On 03/06/16 08:12, Horng-Shyang Liao wrote: >> On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: >>> I keep thinking about how to get rid of the two data structures, >>> task_busy_list and the

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On Fri, Jun 3, 2016 at 4:48 PM, Matthias Brugger wrote: > On 03/06/16 08:12, Horng-Shyang Liao wrote: >> On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: >>> I keep thinking about how to get rid of the two data structures, >>> task_busy_list and the task_release_wq. We need the latter

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 03/06/16 14:13, Horng-Shyang Liao wrote: Hi Matthias, On Fri, 2016-06-03 at 13:18 +0200, Matthias Brugger wrote: On 03/06/16 08:12, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: On 01/06/16 11:57,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 03/06/16 14:13, Horng-Shyang Liao wrote: Hi Matthias, On Fri, 2016-06-03 at 13:18 +0200, Matthias Brugger wrote: On 03/06/16 08:12, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: On 01/06/16 11:57,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Fri, 2016-06-03 at 13:18 +0200, Matthias Brugger wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > >> > >> On 01/06/16 11:57, Horng-Shyang Liao wrote: >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Matthias, On Fri, 2016-06-03 at 13:18 +0200, Matthias Brugger wrote: > > On 03/06/16 08:12, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > >> > >> On 01/06/16 11:57, Horng-Shyang Liao wrote: >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 03/06/16 08:12, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: On 01/06/16 11:57, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugger wrote:

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 03/06/16 08:12, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: On 01/06/16 11:57, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugger wrote:

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > > On 01/06/16 11:57, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugger wrote: > >> > >> On 31/05/16 10:36,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Thu, 2016-06-02 at 10:46 +0200, Matthias Brugger wrote: > > On 01/06/16 11:57, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugger wrote: > >> > >> On 31/05/16 10:36,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 01/06/16 11:57, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugger wrote: On 31/05/16 10:36, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugger wrote:

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 01/06/16 11:57, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugger wrote: On 31/05/16 10:36, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugger wrote:

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugger wrote: > > On 31/05/16 10:36, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugger wrote: > >> > >> On 30/05/16 05:19,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Tue, 2016-05-31 at 22:04 +0200, Matthias Brugger wrote: > > On 31/05/16 10:36, Horng-Shyang Liao wrote: > > Hi Mathias, > > > > Please see my inline reply. > > > > On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugger wrote: > >> > >> On 30/05/16 05:19,

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 31/05/16 10:36, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugger wrote: On 30/05/16 05:19, HS Liao wrote: This patch is first version of Mediatek Command Queue(CMDQ) driver. The CMDQ is used to help read/write

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 31/05/16 10:36, Horng-Shyang Liao wrote: Hi Mathias, Please see my inline reply. On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugger wrote: On 30/05/16 05:19, HS Liao wrote: This patch is first version of Mediatek Command Queue(CMDQ) driver. The CMDQ is used to help read/write

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugger wrote: > > On 30/05/16 05:19, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi Mathias, Please see my inline reply. On Mon, 2016-05-30 at 17:31 +0200, Matthias Brugger wrote: > > On 30/05/16 05:19, HS Liao wrote: > > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > > CMDQ is used to help read/write registers with critical time limitation, > >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 30/05/16 05:19, HS Liao wrote: This patch is first version of Mediatek Command Queue(CMDQ) driver. The CMDQ is used to help read/write registers with critical time limitation, such as updating display configuration during the vblank. It controls Global Command Engine (GCE) hardware to

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

On 30/05/16 05:19, HS Liao wrote: This patch is first version of Mediatek Command Queue(CMDQ) driver. The CMDQ is used to help read/write registers with critical time limitation, such as updating display configuration during the vblank. It controls Global Command Engine (GCE) hardware to

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi CK, Reply inline. On Mon, 2016-05-30 at 14:49 +0800, CK Hu wrote: > Hi, HS: > > Some comments inline. > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: ... > > +static void cmdq_thread_irq_handler(struct cmdq *cmdq, int tid) > > +{ > > + struct cmdq_thread *thread = >thread[tid]; > >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi CK, Reply inline. On Mon, 2016-05-30 at 14:49 +0800, CK Hu wrote: > Hi, HS: > > Some comments inline. > > On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: ... > > +static void cmdq_thread_irq_handler(struct cmdq *cmdq, int tid) > > +{ > > + struct cmdq_thread *thread = >thread[tid]; > >

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi, HS: Some comments inline. On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > CMDQ is used to help read/write registers with critical time limitation, > such as updating display configuration during the vblank. It

Re: [PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

Hi, HS: Some comments inline. On Mon, 2016-05-30 at 11:19 +0800, HS Liao wrote: > This patch is first version of Mediatek Command Queue(CMDQ) driver. The > CMDQ is used to help read/write registers with critical time limitation, > such as updating display configuration during the vblank. It

[PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

This patch is first version of Mediatek Command Queue(CMDQ) driver. The CMDQ is used to help read/write registers with critical time limitation, such as updating display configuration during the vblank. It controls Global Command Engine (GCE) hardware to achieve this requirement. Currently, CMDQ

[PATCH v8 2/3] CMDQ: Mediatek CMDQ driver

This patch is first version of Mediatek Command Queue(CMDQ) driver. The CMDQ is used to help read/write registers with critical time limitation, such as updating display configuration during the vblank. It controls Global Command Engine (GCE) hardware to achieve this requirement. Currently, CMDQ