Re: [PATCH v8 3/8] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()

Hi Heiko 在 2016/5/12 2:26, Heiko Stuebner 写道: Am Mittwoch, 11. Mai 2016, 03:24:07 schrieb David Wu: Call rk3x_i2c_setup() before rk3x_i2c_start() That beginning of the sentence could use a tiny improvement, like rk3x_i2c_setup() gets called directly before rk3x_i2c_start()

Re: [PATCH v8 3/8] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()

Hi Heiko 在 2016/5/12 2:26, Heiko Stuebner 写道: Am Mittwoch, 11. Mai 2016, 03:24:07 schrieb David Wu: Call rk3x_i2c_setup() before rk3x_i2c_start() That beginning of the sentence could use a tiny improvement, like rk3x_i2c_setup() gets called directly before rk3x_i2c_start()

Re: [PATCH v8 3/8] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()

Am Mittwoch, 11. Mai 2016, 03:24:07 schrieb David Wu: > Call rk3x_i2c_setup() before rk3x_i2c_start() That beginning of the sentence could use a tiny improvement, like rk3x_i2c_setup() gets called directly before rk3x_i2c_start() to make it obvious what happens in the code. But a

Re: [PATCH v8 3/8] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()

Am Mittwoch, 11. Mai 2016, 03:24:07 schrieb David Wu: > Call rk3x_i2c_setup() before rk3x_i2c_start() That beginning of the sentence could use a tiny improvement, like rk3x_i2c_setup() gets called directly before rk3x_i2c_start() to make it obvious what happens in the code. But a

[PATCH v8 3/8] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()

Call rk3x_i2c_setup() before rk3x_i2c_start() and the last thing in setup was to clean the IPD, so no reason to do it at the beginning of start. Signed-off-by: David Wu Reviewed-by: Douglas Anderson --- Change in v8: - none

[PATCH v8 3/8] i2c: rk3x: Remove redundant rk3x_i2c_clean_ipd()

Call rk3x_i2c_setup() before rk3x_i2c_start() and the last thing in setup was to clean the IPD, so no reason to do it at the beginning of start. Signed-off-by: David Wu Reviewed-by: Douglas Anderson --- Change in v8: - none drivers/i2c/busses/i2c-rk3x.c | 1 - 1 file changed, 1 deletion(-)