Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

2016-05-22 Thread Minchan Kim
On Thu, May 19, 2016 at 11:18:43AM -0400, Dan Streetman wrote: > Change the return type of zs_pool_stat_create() to void, and > remove the logic to abort pool creation if the stat debugfs > dir/file could not be created. > > The debugfs stat file is for debugging/information only, and doesn't >

Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

2016-05-22 Thread Minchan Kim
On Thu, May 19, 2016 at 11:18:43AM -0400, Dan Streetman wrote: > Change the return type of zs_pool_stat_create() to void, and > remove the logic to abort pool creation if the stat debugfs > dir/file could not be created. > > The debugfs stat file is for debugging/information only, and doesn't >

Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

2016-05-20 Thread Dan Streetman
On Fri, May 20, 2016 at 12:08 AM, Sergey Senozhatsky wrote: > On (05/19/16 11:18), Dan Streetman wrote: > [..] >> zs_stat_root = debugfs_create_dir("zsmalloc", NULL); >> if (!zs_stat_root) >> - return -ENOMEM; >> - >> - return 0; >> +

Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

2016-05-20 Thread Dan Streetman
On Fri, May 20, 2016 at 12:08 AM, Sergey Senozhatsky wrote: > On (05/19/16 11:18), Dan Streetman wrote: > [..] >> zs_stat_root = debugfs_create_dir("zsmalloc", NULL); >> if (!zs_stat_root) >> - return -ENOMEM; >> - >> - return 0; >> + pr_warn("debugfs

Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

2016-05-19 Thread Sergey Senozhatsky
On (05/19/16 11:18), Dan Streetman wrote: [..] > zs_stat_root = debugfs_create_dir("zsmalloc", NULL); > if (!zs_stat_root) > - return -ENOMEM; > - > - return 0; > + pr_warn("debugfs 'zsmalloc' stat dir creation failed\n"); > } > > static void __exit

Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

2016-05-19 Thread Sergey Senozhatsky
On (05/19/16 11:18), Dan Streetman wrote: [..] > zs_stat_root = debugfs_create_dir("zsmalloc", NULL); > if (!zs_stat_root) > - return -ENOMEM; > - > - return 0; > + pr_warn("debugfs 'zsmalloc' stat dir creation failed\n"); > } > > static void __exit

Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

2016-05-19 Thread Ganesh Mahendran
2016-05-19 23:18 GMT+08:00 Dan Streetman : > Change the return type of zs_pool_stat_create() to void, and > remove the logic to abort pool creation if the stat debugfs > dir/file could not be created. > > The debugfs stat file is for debugging/information only, and doesn't >

Re: [PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

2016-05-19 Thread Ganesh Mahendran
2016-05-19 23:18 GMT+08:00 Dan Streetman : > Change the return type of zs_pool_stat_create() to void, and > remove the logic to abort pool creation if the stat debugfs > dir/file could not be created. > > The debugfs stat file is for debugging/information only, and doesn't > affect operation of

[PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

2016-05-19 Thread Dan Streetman
Change the return type of zs_pool_stat_create() to void, and remove the logic to abort pool creation if the stat debugfs dir/file could not be created. The debugfs stat file is for debugging/information only, and doesn't affect operation of zsmalloc; there is no reason to abort creating the pool

[PATCHv2] mm/zsmalloc: don't fail if can't create debugfs info

2016-05-19 Thread Dan Streetman
Change the return type of zs_pool_stat_create() to void, and remove the logic to abort pool creation if the stat debugfs dir/file could not be created. The debugfs stat file is for debugging/information only, and doesn't affect operation of zsmalloc; there is no reason to abort creating the pool