Re: [PATCHv2 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Eduardo Valentin
On Wed, Jun 22, 2016 at 07:36:11AM -0700, Eduardo Valentin wrote: > On Wed, Jun 22, 2016 at 03:03:45PM +0530, Keerthy wrote: > > > > > > On Wednesday 22 June 2016 10:45 AM, Eduardo Valentin wrote: > > >Because several drivers do the following pattern: > > >.set_mode() > > >... > > >

Re: [PATCHv2 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Eduardo Valentin
On Wed, Jun 22, 2016 at 07:36:11AM -0700, Eduardo Valentin wrote: > On Wed, Jun 22, 2016 at 03:03:45PM +0530, Keerthy wrote: > > > > > > On Wednesday 22 June 2016 10:45 AM, Eduardo Valentin wrote: > > >Because several drivers do the following pattern: > > >.set_mode() > > >... > > >

Re: [PATCHv2 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Eduardo Valentin
On Wed, Jun 22, 2016 at 03:03:45PM +0530, Keerthy wrote: > > > On Wednesday 22 June 2016 10:45 AM, Eduardo Valentin wrote: > >Because several drivers do the following pattern: > >.set_mode() > >... > >local_data->mode = new_mode; > >thermal_zone_device_update(tz); > > > >makes sense

Re: [PATCHv2 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Eduardo Valentin
On Wed, Jun 22, 2016 at 03:03:45PM +0530, Keerthy wrote: > > > On Wednesday 22 June 2016 10:45 AM, Eduardo Valentin wrote: > >Because several drivers do the following pattern: > >.set_mode() > >... > >local_data->mode = new_mode; > >thermal_zone_device_update(tz); > > > >makes sense

Re: [PATCHv2 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Keerthy
On Wednesday 22 June 2016 10:45 AM, Eduardo Valentin wrote: Because several drivers do the following pattern: .set_mode() ... local_data->mode = new_mode; thermal_zone_device_update(tz); makes sense to simply do the thermal_zone_device_update() in thermal core, after setting the

Re: [PATCHv2 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-22 Thread Keerthy
On Wednesday 22 June 2016 10:45 AM, Eduardo Valentin wrote: Because several drivers do the following pattern: .set_mode() ... local_data->mode = new_mode; thermal_zone_device_update(tz); makes sense to simply do the thermal_zone_device_update() in thermal core, after setting the

[PATCHv2 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-21 Thread Eduardo Valentin
Because several drivers do the following pattern: .set_mode() ... local_data->mode = new_mode; thermal_zone_device_update(tz); makes sense to simply do the thermal_zone_device_update() in thermal core, after setting the new mode. Also, this patch also remove deadlocks on drivers that

[PATCHv2 1/1] thermal: core: call thermal_zone_device_update() after mode update

2016-06-21 Thread Eduardo Valentin
Because several drivers do the following pattern: .set_mode() ... local_data->mode = new_mode; thermal_zone_device_update(tz); makes sense to simply do the thermal_zone_device_update() in thermal core, after setting the new mode. Also, this patch also remove deadlocks on drivers that