Re: 2.2.18pre10: A few warnings less...

2000-09-27 Thread Trond Myklebust
> " " == Horst von Brand <[EMAIL PROTECTED]> writes: > - There are several headers for NFS: > include/linux/nfs.h include/linux/nfs2.h > include/linux/nfs3.h include/linux/nfsd/const.h > Several constants defined in nfs?.h are repeated in > nfsd/const.h,

Re: 2.2.18pre10: A few warnings less...

2000-09-27 Thread Urban Widmark
On Tue, 26 Sep 2000, Horst von Brand wrote: > - The whole nls stuff is a bunch of tables plus a few functions and > structures that look like boilerplate code to my (untrained) eye. I'd > rewrite the whole lot as the tables plus an #included file that gives the > rest, to reduce the

Re: 2.2.18pre10: A few warnings less...

2000-09-27 Thread Urban Widmark
On Tue, 26 Sep 2000, Horst von Brand wrote: - The whole nls stuff is a bunch of tables plus a few functions and structures that look like boilerplate code to my (untrained) eye. I'd rewrite the whole lot as the tables plus an #included file that gives the rest, to reduce the

Re: 2.2.18pre10: A few warnings less...

2000-09-27 Thread Trond Myklebust
" " == Horst von Brand [EMAIL PROTECTED] writes: - There are several headers for NFS: include/linux/nfs.h include/linux/nfs2.h include/linux/nfs3.h include/linux/nfsd/const.h Several constants defined in nfs?.h are repeated in nfsd/const.h, which on

2.2.18pre10: A few warnings less...

2000-09-26 Thread Horst von Brand
A few extra notes: - Several places use long (or unsigned long) formats for the result of ntohl(), this is a 32-bit quantity. Makes no difference on ia32, but could bite on Alpha (an int is 32, a long is 64 there) - There are several headers for NFS: include/linux/nfs.h

2.2.18pre10: A few warnings less...

2000-09-26 Thread Horst von Brand
A few extra notes: - Several places use long (or unsigned long) formats for the result of ntohl(), this is a 32-bit quantity. Makes no difference on ia32, but could bite on Alpha (an int is 32, a long is 64 there) - There are several headers for NFS: include/linux/nfs.h