Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-07 Thread Andrew Patterson
On Thu, 2008-01-03 at 17:17 -0700, Andrew Patterson wrote: > On Fri, 2008-01-04 at 09:07 +0900, Tejun Heo wrote: > > Hello, > > > > Andrew Patterson wrote: > > > It looks like this is a shell issue. After looking through the sysfs > > > code, I realized that this problem seems to be driven from

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-07 Thread Andrew Patterson
On Thu, 2008-01-03 at 17:17 -0700, Andrew Patterson wrote: On Fri, 2008-01-04 at 09:07 +0900, Tejun Heo wrote: Hello, Andrew Patterson wrote: It looks like this is a shell issue. After looking through the sysfs code, I realized that this problem seems to be driven from user-land.

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Andrey Borzenkov
On Friday 04 January 2008, Andrew Patterson wrote: > On Thu, 2008-01-03 at 17:17 -0700, Andrew Patterson wrote: > > On Fri, 2008-01-04 at 09:07 +0900, Tejun Heo wrote: > > > Hello, > > > > > > Andrew Patterson wrote: > > > > It looks like this is a shell issue. After looking through the sysfs >

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Andrew Patterson
On Thu, 2008-01-03 at 17:17 -0700, Andrew Patterson wrote: > On Fri, 2008-01-04 at 09:07 +0900, Tejun Heo wrote: > > Hello, > > > > Andrew Patterson wrote: > > > It looks like this is a shell issue. After looking through the sysfs > > > code, I realized that this problem seems to be driven from

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Andrew Patterson
On Fri, 2008-01-04 at 09:07 +0900, Tejun Heo wrote: > Hello, > > Andrew Patterson wrote: > > It looks like this is a shell issue. After looking through the sysfs > > code, I realized that this problem seems to be driven from user-land. > > So I performed some experiments: > > > > 1. Wrote

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Tejun Heo
Hello, Andrew Patterson wrote: > It looks like this is a shell issue. After looking through the sysfs > code, I realized that this problem seems to be driven from user-land. > So I performed some experiments: > > 1. Wrote a simple program that just used write(2) to write to the >

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Andrew Patterson
On Mon, 2007-12-03 at 14:15 -0700, Andrew Patterson wrote: > On Thu, 2007-11-29 at 10:07 +0900, Tejun Heo wrote: > > Andrew Patterson wrote: > > > I tried with clean 2.6.24-rc3 and get the same bad behavior. This is on > > > an ia64 box, so maybe that is an issue. I can try on an x86 box as well.

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Andrew Patterson
On Mon, 2007-12-03 at 14:15 -0700, Andrew Patterson wrote: On Thu, 2007-11-29 at 10:07 +0900, Tejun Heo wrote: Andrew Patterson wrote: I tried with clean 2.6.24-rc3 and get the same bad behavior. This is on an ia64 box, so maybe that is an issue. I can try on an x86 box as well. Oh,

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Tejun Heo
Hello, Andrew Patterson wrote: It looks like this is a shell issue. After looking through the sysfs code, I realized that this problem seems to be driven from user-land. So I performed some experiments: 1. Wrote a simple program that just used write(2) to write to the sysfs

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Andrew Patterson
On Thu, 2008-01-03 at 17:17 -0700, Andrew Patterson wrote: On Fri, 2008-01-04 at 09:07 +0900, Tejun Heo wrote: Hello, Andrew Patterson wrote: It looks like this is a shell issue. After looking through the sysfs code, I realized that this problem seems to be driven from user-land.

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2008-01-03 Thread Andrey Borzenkov
On Friday 04 January 2008, Andrew Patterson wrote: On Thu, 2008-01-03 at 17:17 -0700, Andrew Patterson wrote: On Fri, 2008-01-04 at 09:07 +0900, Tejun Heo wrote: Hello, Andrew Patterson wrote: It looks like this is a shell issue. After looking through the sysfs code, I

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-12-21 Thread Greg KH
On Mon, Dec 03, 2007 at 02:15:58PM -0700, Andrew Patterson wrote: > On Thu, 2007-11-29 at 10:07 +0900, Tejun Heo wrote: > > Andrew Patterson wrote: > > > I tried with clean 2.6.24-rc3 and get the same bad behavior. This is on > > > an ia64 box, so maybe that is an issue. I can try on an x86 box

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-12-21 Thread Greg KH
On Mon, Dec 03, 2007 at 02:15:58PM -0700, Andrew Patterson wrote: On Thu, 2007-11-29 at 10:07 +0900, Tejun Heo wrote: Andrew Patterson wrote: I tried with clean 2.6.24-rc3 and get the same bad behavior. This is on an ia64 box, so maybe that is an issue. I can try on an x86 box as well.

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-12-03 Thread Andrew Patterson
On Thu, 2007-11-29 at 10:07 +0900, Tejun Heo wrote: > Andrew Patterson wrote: > > I tried with clean 2.6.24-rc3 and get the same bad behavior. This is on > > an ia64 box, so maybe that is an issue. I can try on an x86 box as well. > > Oh, one other thing. I tried a "uname -r" to make sure I had

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-12-03 Thread Andrew Patterson
On Thu, 2007-11-29 at 10:07 +0900, Tejun Heo wrote: Andrew Patterson wrote: I tried with clean 2.6.24-rc3 and get the same bad behavior. This is on an ia64 box, so maybe that is an issue. I can try on an x86 box as well. Oh, one other thing. I tried a uname -r to make sure I had the

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-28 Thread Tejun Heo
Andrew Patterson wrote: > I tried with clean 2.6.24-rc3 and get the same bad behavior. This is on > an ia64 box, so maybe that is an issue. I can try on an x86 box as well. > Oh, one other thing. I tried a "uname -r" to make sure I had the > correct kernel booted and got: > > # uname -r >

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-28 Thread Greg KH
On Wed, Nov 28, 2007 at 12:31:40PM -0700, Andrew Patterson wrote: > On Wed, 2007-11-28 at 16:42 +0900, Tejun Heo wrote: > > Greg KH wrote: > > > On Mon, Nov 26, 2007 at 08:31:16PM -0800, Andrew Morton wrote: > > >> On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson <[EMAIL PROTECTED]> > > >>

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-28 Thread Andrew Patterson
On Wed, 2007-11-28 at 16:42 +0900, Tejun Heo wrote: > Greg KH wrote: > > On Mon, Nov 26, 2007 at 08:31:16PM -0800, Andrew Morton wrote: > >> On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson <[EMAIL PROTECTED]> > >> wrote: > >> > >>> The buf in fs/sysfs.c:subsys_attr_store() does not seem to be

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-28 Thread Andrew Patterson
On Wed, 2007-11-28 at 16:42 +0900, Tejun Heo wrote: Greg KH wrote: On Mon, Nov 26, 2007 at 08:31:16PM -0800, Andrew Morton wrote: On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson [EMAIL PROTECTED] wrote: The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-28 Thread Greg KH
On Wed, Nov 28, 2007 at 12:31:40PM -0700, Andrew Patterson wrote: On Wed, 2007-11-28 at 16:42 +0900, Tejun Heo wrote: Greg KH wrote: On Mon, Nov 26, 2007 at 08:31:16PM -0800, Andrew Morton wrote: On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson [EMAIL PROTECTED] wrote: The

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-28 Thread Tejun Heo
Andrew Patterson wrote: I tried with clean 2.6.24-rc3 and get the same bad behavior. This is on an ia64 box, so maybe that is an issue. I can try on an x86 box as well. Oh, one other thing. I tried a uname -r to make sure I had the correct kernel booted and got: # uname -r 2.6.24-rc3 x

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-27 Thread Tejun Heo
Greg KH wrote: > On Mon, Nov 26, 2007 at 08:31:16PM -0800, Andrew Morton wrote: >> On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson <[EMAIL PROTECTED]> >> wrote: >> >>> The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated >>> correctly when returning a negative value

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-27 Thread Tejun Heo
Greg KH wrote: On Mon, Nov 26, 2007 at 08:31:16PM -0800, Andrew Morton wrote: On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson [EMAIL PROTECTED] wrote: The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated correctly when returning a negative value (indicating that an

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-26 Thread Tejun Heo
Greg KH wrote: > On Mon, Nov 26, 2007 at 08:31:16PM -0800, Andrew Morton wrote: >> On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson <[EMAIL PROTECTED]> >> wrote: >> >>> The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated >>> correctly when returning a negative value

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-26 Thread Greg KH
On Mon, Nov 26, 2007 at 08:31:16PM -0800, Andrew Morton wrote: > On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson <[EMAIL PROTECTED]> wrote: > > > The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated > > correctly when returning a negative value (indicating that an error > >

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-26 Thread Andrew Morton
On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson <[EMAIL PROTECTED]> wrote: > The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated > correctly when returning a negative value (indicating that an error > condition has occurred) is returned. If a negative value is returned, >

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-26 Thread Andrew Morton
On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson [EMAIL PROTECTED] wrote: The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated correctly when returning a negative value (indicating that an error condition has occurred) is returned. If a negative value is returned, the

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-26 Thread Greg KH
On Mon, Nov 26, 2007 at 08:31:16PM -0800, Andrew Morton wrote: On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson [EMAIL PROTECTED] wrote: The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated correctly when returning a negative value (indicating that an error condition

Re: Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-26 Thread Tejun Heo
Greg KH wrote: On Mon, Nov 26, 2007 at 08:31:16PM -0800, Andrew Morton wrote: On Wed, 21 Nov 2007 15:16:59 -0700 Andrew Patterson [EMAIL PROTECTED] wrote: The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated correctly when returning a negative value (indicating that an

Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-21 Thread Andrew Patterson
The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated correctly when returning a negative value (indicating that an error condition has occurred) is returned. If a negative value is returned, the next subsequent call to subsys_attr_store will have the contents of buf appended to

Error returns not handled correctly by sysfs.c:subsys_attr_store()

2007-11-21 Thread Andrew Patterson
The buf in fs/sysfs.c:subsys_attr_store() does not seem to be updated correctly when returning a negative value (indicating that an error condition has occurred) is returned. If a negative value is returned, the next subsequent call to subsys_attr_store will have the contents of buf appended to