Re: crypto: sun4i-ss: error with kmap

2020-12-07 Thread Thomas Gleixner
On Mon, Dec 07 2020 at 13:18, Corentin Labbe wrote: > On Mon, Dec 07, 2020 at 01:15:49AM +0100, Thomas Gleixner wrote: > So if I understand correctly, basicly I cannot have two atomic kmap at > the same time since it made unmapping them in the right order complex. You can, but the ordering has

Re: crypto: sun4i-ss: error with kmap

2020-12-07 Thread Corentin Labbe
On Mon, Dec 07, 2020 at 01:15:49AM +0100, Thomas Gleixner wrote: > On Sun, Dec 06 2020 at 22:40, Corentin Labbe wrote: > > On Sat, Dec 05, 2020 at 08:48:15PM +0100, Thomas Gleixner wrote: > >> So this maps two pages and unmaps the first one. That's all called from > >> sun4i_ss_opti_poll() and the

Re: crypto: sun4i-ss: error with kmap

2020-12-06 Thread Thomas Gleixner
On Sun, Dec 06 2020 at 22:40, Corentin Labbe wrote: > On Sat, Dec 05, 2020 at 08:48:15PM +0100, Thomas Gleixner wrote: >> So this maps two pages and unmaps the first one. That's all called from >> sun4i_ss_opti_poll() and the bug is clearly visible there: >> >> sg_miter_next(); >>

Re: crypto: sun4i-ss: error with kmap

2020-12-06 Thread Corentin Labbe
On Sat, Dec 05, 2020 at 08:48:15PM +0100, Thomas Gleixner wrote: > Corentin, > > On Sat, Dec 05 2020 at 19:43, Corentin Labbe wrote: > > On Fri, Dec 04, 2020 at 09:58:21PM +0100, Thomas Gleixner wrote: > >> Can you please replace the debug patch with the one below and try again? > >> That stops

Re: crypto: sun4i-ss: error with kmap

2020-12-05 Thread Julia Lawall
On Sat, 5 Dec 2020, Thomas Gleixner wrote: > Corentin, > > On Sat, Dec 05 2020 at 19:43, Corentin Labbe wrote: > > On Fri, Dec 04, 2020 at 09:58:21PM +0100, Thomas Gleixner wrote: > >> Can you please replace the debug patch with the one below and try again? > >> That stops the trace right on

Re: crypto: sun4i-ss: error with kmap

2020-12-05 Thread Thomas Gleixner
Corentin, On Sat, Dec 05 2020 at 19:43, Corentin Labbe wrote: > On Fri, Dec 04, 2020 at 09:58:21PM +0100, Thomas Gleixner wrote: >> Can you please replace the debug patch with the one below and try again? >> That stops the trace right on the condition. > > Hello, the result could be found at

Re: crypto: sun4i-ss: error with kmap

2020-12-05 Thread Corentin Labbe
On Fri, Dec 04, 2020 at 09:58:21PM +0100, Thomas Gleixner wrote: > On Fri, Dec 04 2020 at 20:27, Corentin Labbe wrote: > > On Fri, Dec 04, 2020 at 04:08:27PM +0100, Thomas Gleixner wrote: > >> On Fri, Dec 04 2020 at 14:26, Corentin Labbe wrote: > >> > On Fri, Dec 04, 2020 at 12:34:05AM +0100,

Re: crypto: sun4i-ss: error with kmap

2020-12-04 Thread Thomas Gleixner
On Fri, Dec 04 2020 at 20:27, Corentin Labbe wrote: > On Fri, Dec 04, 2020 at 04:08:27PM +0100, Thomas Gleixner wrote: >> On Fri, Dec 04 2020 at 14:26, Corentin Labbe wrote: >> > On Fri, Dec 04, 2020 at 12:34:05AM +0100, Thomas Gleixner wrote: >> >> The unmap comes from sg_miter_stop() and looking

Re: crypto: sun4i-ss: error with kmap

2020-12-04 Thread Corentin Labbe
On Fri, Dec 04, 2020 at 04:08:27PM +0100, Thomas Gleixner wrote: > On Fri, Dec 04 2020 at 14:26, Corentin Labbe wrote: > > On Fri, Dec 04, 2020 at 12:34:05AM +0100, Thomas Gleixner wrote: > >> The unmap comes from sg_miter_stop() and looking at the previous > >> map/unmap cycles there are never

Re: crypto: sun4i-ss: error with kmap

2020-12-04 Thread Thomas Gleixner
On Fri, Dec 04 2020 at 14:26, Corentin Labbe wrote: > On Fri, Dec 04, 2020 at 12:34:05AM +0100, Thomas Gleixner wrote: >> The unmap comes from sg_miter_stop() and looking at the previous >> map/unmap cycles there are never nested maps. >> >> [ 996.943030] cryptset-316 0d..4 73943317us :

Re: crypto: sun4i-ss: error with kmap

2020-12-04 Thread Corentin Labbe
On Fri, Dec 04, 2020 at 12:34:05AM +0100, Thomas Gleixner wrote: > On Thu, Dec 03 2020 at 18:38, Corentin Labbe wrote: > > On Wed, Dec 02, 2020 at 09:59:36PM +0100, Thomas Gleixner wrote: > >> On Wed, Dec 02 2020 at 20:55, Corentin Labbe wrote: > >> > On Tue, Dec 01, 2020 at 04:15:08PM +0100,

Re: crypto: sun4i-ss: error with kmap

2020-12-03 Thread Thomas Gleixner
On Thu, Dec 03 2020 at 18:38, Corentin Labbe wrote: > On Wed, Dec 02, 2020 at 09:59:36PM +0100, Thomas Gleixner wrote: >> On Wed, Dec 02 2020 at 20:55, Corentin Labbe wrote: >> > On Tue, Dec 01, 2020 at 04:15:08PM +0100, Thomas Gleixner wrote: >> > >> > The result could be seen at

Re: crypto: sun4i-ss: error with kmap

2020-12-03 Thread Corentin Labbe
On Wed, Dec 02, 2020 at 09:59:36PM +0100, Thomas Gleixner wrote: > On Wed, Dec 02 2020 at 20:55, Corentin Labbe wrote: > > On Tue, Dec 01, 2020 at 04:15:08PM +0100, Thomas Gleixner wrote: > > > > The result could be seen at http://kernel.montjoie.ovh/129768.log > > The log is 9Mb, but the ftrace

Re: crypto: sun4i-ss: error with kmap

2020-12-02 Thread Thomas Gleixner
On Wed, Dec 02 2020 at 20:55, Corentin Labbe wrote: > On Tue, Dec 01, 2020 at 04:15:08PM +0100, Thomas Gleixner wrote: > > The result could be seen at http://kernel.montjoie.ovh/129768.log > The log is 9Mb, but the ftrace dump seems not terminated, tell me if you need > more. Correct, the

Re: crypto: sun4i-ss: error with kmap

2020-12-02 Thread Corentin Labbe
On Tue, Dec 01, 2020 at 04:15:08PM +0100, Thomas Gleixner wrote: > On Tue, Dec 01 2020 at 15:45, Corentin Labbe wrote: > > On Tue, Dec 01, 2020 at 03:16:36PM +0100, Thomas Gleixner wrote: > > In fact the warn was a bit later so I added: > >preempt_disable(); > > idx =

Re: crypto: sun4i-ss: error with kmap

2020-12-01 Thread Thomas Gleixner
On Tue, Dec 01 2020 at 15:45, Corentin Labbe wrote: > On Tue, Dec 01, 2020 at 03:16:36PM +0100, Thomas Gleixner wrote: > In fact the warn was a bit later so I added: >preempt_disable(); > idx = arch_kmap_local_unmap_idx(kmap_local_idx(), addr); > - WARN_ON_ONCE(addr !=

Re: crypto: sun4i-ss: error with kmap

2020-12-01 Thread Corentin Labbe
On Tue, Dec 01, 2020 at 03:16:36PM +0100, Thomas Gleixner wrote: > On Tue, Dec 01 2020 at 14:52, Corentin Labbe wrote: > > On Tue, Dec 01, 2020 at 02:28:54PM +0100, Thomas Gleixner wrote: > > The patch made the board too busy logging and fail to boot until the test. > > Stupid me. Of course this

Re: crypto: sun4i-ss: error with kmap

2020-12-01 Thread Thomas Gleixner
On Tue, Dec 01 2020 at 14:52, Corentin Labbe wrote: > On Tue, Dec 01, 2020 at 02:28:54PM +0100, Thomas Gleixner wrote: > The patch made the board too busy logging and fail to boot until the test. Stupid me. Of course this wants to be conditional. Thanks, tglx --- diff --git

Re: crypto: sun4i-ss: error with kmap

2020-12-01 Thread Corentin Labbe
On Tue, Dec 01, 2020 at 02:28:54PM +0100, Thomas Gleixner wrote: > On Tue, Dec 01 2020 at 14:01, Corentin Labbe wrote: > > +[ 213.050152] [ cut here ] > > +[ 213.050207] WARNING: CPU: 0 PID: 18430 at mm/highmem.c:581 > > kunmap_local_indexed+0x194/0x1d4 > > +[

Re: crypto: sun4i-ss: error with kmap

2020-12-01 Thread Thomas Gleixner
On Tue, Dec 01 2020 at 14:01, Corentin Labbe wrote: > +[ 213.050152] [ cut here ] > +[ 213.050207] WARNING: CPU: 0 PID: 18430 at mm/highmem.c:581 > kunmap_local_indexed+0x194/0x1d4 > +[ 213.050214] Modules linked in: sm4_generic authenc vmac xcbc hmac >

crypto: sun4i-ss: error with kmap

2020-12-01 Thread Corentin Labbe
Hello When testing 20201130, I hit this problem: +[ 213.050152] [ cut here ] +[ 213.050207] WARNING: CPU: 0 PID: 18430 at mm/highmem.c:581 kunmap_local_indexed+0x194/0x1d4 +[ 213.050214] Modules linked in: sm4_generic authenc vmac xcbc hmac streebog_generic