On Thu, 12 Apr 2001, Linus Torvalds wrote:
>
>
> On Thu, 12 Apr 2001, Marcelo Tosatti wrote:
> >
> > Comments?
> >
> > --- fs/inode.c~ Thu Mar 22 16:04:13 2001
> > +++ fs/inode.c Thu Apr 12 15:18:22 2001
> > @@ -347,6 +347,11 @@
> > #endif
> >
> > spin_lock(_lock);
> > + while
On Thu, 12 Apr 2001, Marcelo Tosatti wrote:
>
> On Thu, 12 Apr 2001, Linus Torvalds wrote:
>
> > On Thu, 12 Apr 2001, Marcelo Tosatti wrote:
> > >
> > > Comments?
> > >
> > > --- fs/inode.c~ Thu Mar 22 16:04:13 2001
> > > +++ fs/inode.cThu Apr 12 15:18:22 2001
> > > @@ -347,6 +347,11
On Thu, 12 Apr 2001, Linus Torvalds wrote:
> On Thu, 12 Apr 2001, Marcelo Tosatti wrote:
> >
> > Comments?
> >
> > --- fs/inode.c~ Thu Mar 22 16:04:13 2001
> > +++ fs/inode.c Thu Apr 12 15:18:22 2001
> > @@ -347,6 +347,11 @@
> > #endif
> >
> > spin_lock(_lock);
> > + while
On Thu, 12 Apr 2001, Marcelo Tosatti wrote:
>
> Comments?
>
> --- fs/inode.c~ Thu Mar 22 16:04:13 2001
> +++ fs/inode.cThu Apr 12 15:18:22 2001
> @@ -347,6 +347,11 @@
> #endif
>
> spin_lock(_lock);
> + while (inode->i_state & I_LOCK) {
> +
Hi,
generic_osync_inode() (called by generic_file_write()) is not checking if
the inode being synced has the I_LOCK bit set before checking the I_DIRTY
bit.
AFAICS, the following problem can happen:
sync()
...
sync_one()
reset I_DIRTY, set I_LOCK
filemap_fdatasync() <-- #window
Hi,
generic_osync_inode() (called by generic_file_write()) is not checking if
the inode being synced has the I_LOCK bit set before checking the I_DIRTY
bit.
AFAICS, the following problem can happen:
sync()
...
sync_one()
reset I_DIRTY, set I_LOCK
filemap_fdatasync() -- #window
write_inode()
On Thu, 12 Apr 2001, Marcelo Tosatti wrote:
Comments?
--- fs/inode.c~ Thu Mar 22 16:04:13 2001
+++ fs/inode.cThu Apr 12 15:18:22 2001
@@ -347,6 +347,11 @@
#endif
spin_lock(inode_lock);
+ while (inode-i_state I_LOCK) {
+ spin_unlock(inode_lock);
On Thu, 12 Apr 2001, Linus Torvalds wrote:
On Thu, 12 Apr 2001, Marcelo Tosatti wrote:
Comments?
--- fs/inode.c~ Thu Mar 22 16:04:13 2001
+++ fs/inode.c Thu Apr 12 15:18:22 2001
@@ -347,6 +347,11 @@
#endif
spin_lock(inode_lock);
+ while (inode-i_state
On Thu, 12 Apr 2001, Marcelo Tosatti wrote:
On Thu, 12 Apr 2001, Linus Torvalds wrote:
On Thu, 12 Apr 2001, Marcelo Tosatti wrote:
Comments?
--- fs/inode.c~ Thu Mar 22 16:04:13 2001
+++ fs/inode.cThu Apr 12 15:18:22 2001
@@ -347,6 +347,11 @@
#endif
On Thu, 12 Apr 2001, Linus Torvalds wrote:
On Thu, 12 Apr 2001, Marcelo Tosatti wrote:
Comments?
--- fs/inode.c~ Thu Mar 22 16:04:13 2001
+++ fs/inode.c Thu Apr 12 15:18:22 2001
@@ -347,6 +347,11 @@
#endif
spin_lock(inode_lock);
+ while (inode-i_state
10 matches
Mail list logo