Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-02 Thread Benjamin Herrenschmidt
>> I would suggest the opposite approach instead: make the PPC just support >> isa_readx/isa_writex instead. > >We can certainly do that, no problem. > >BUT that won't get a token ring pcmcia card working in the newer >powerbooks, such as the titanium G4 powerbook, because the PCI host >bridge

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-02 Thread Jonathan Lundell
At 3:46 PM -0700 2001-05-01, Linus Torvalds wrote: >On Tue, 1 May 2001, Russell King wrote: > > >> In which case, can we change the following in IO-mapping.txt please? > >Oh, sorry. I misread your question. The _return_ value is a cookie. > >The first argument should basically be the start of a

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-02 Thread mike_phillips
> We can certainly do that, no problem. > BUT that won't get a token ring pcmcia card working in the newer > powerbooks, such as the titanium G4 powerbook, because the PCI host > bridge doesn't map any cpu addresses to the bottom 16MB of PCI memory > space. This is not a problem as far as

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-02 Thread Geert Uytterhoeven
On 1 May 2001, Linus Torvalds wrote: > In article <[EMAIL PROTECTED]>, > <[EMAIL PROTECTED]> wrote: > >>[EMAIL PROTECTED] wrote: > >>> > >>> To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the > >>> isa_read/write's have to be changed to regular read/write due to the >

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-02 Thread Geert Uytterhoeven
On 1 May 2001, Linus Torvalds wrote: In article [EMAIL PROTECTED], [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the isa_read/write's have to be changed to regular read/write due to the lack of the

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-02 Thread mike_phillips
We can certainly do that, no problem. BUT that won't get a token ring pcmcia card working in the newer powerbooks, such as the titanium G4 powerbook, because the PCI host bridge doesn't map any cpu addresses to the bottom 16MB of PCI memory space. This is not a problem as far as pcmcia

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-02 Thread Jonathan Lundell
At 3:46 PM -0700 2001-05-01, Linus Torvalds wrote: On Tue, 1 May 2001, Russell King wrote: In which case, can we change the following in IO-mapping.txt please? Oh, sorry. I misread your question. The _return_ value is a cookie. The first argument should basically be the start of a struct

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-02 Thread Benjamin Herrenschmidt
I would suggest the opposite approach instead: make the PPC just support isa_readx/isa_writex instead. We can certainly do that, no problem. BUT that won't get a token ring pcmcia card working in the newer powerbooks, such as the titanium G4 powerbook, because the PCI host bridge doesn't map

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Paul Mackerras
Linus Torvalds writes: > I would suggest the opposite approach instead: make the PPC just support > isa_readx/isa_writex instead. We can certainly do that, no problem. BUT that won't get a token ring pcmcia card working in the newer powerbooks, such as the titanium G4 powerbook, because the

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Linus Torvalds
On Tue, 1 May 2001, Russell King wrote: > > In which case, can we change the following in IO-mapping.txt please? Oh, sorry. I misread your question. The _return_ value is a cookie. The first argument should basically be the start of a "struct pci_dev" resource entry, but obviously

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Russell King
On Tue, May 01, 2001 at 02:19:33PM -0700, Linus Torvalds wrote: > On Tue, 1 May 2001, Russell King wrote: > > Talking around this issue, is there any chance of getting the > > official use of the first parameter to ioremap documented in > > Documentation/IO-mapping.txt please? There appears to

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Linus Torvalds
On Tue, 1 May 2001, Russell King wrote: > > Talking around this issue, is there any chance of getting the > official use of the first parameter to ioremap documented in > Documentation/IO-mapping.txt please? There appears to be > confusion as to whether it is: > > a) PCI bus address > b) CPU

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Russell King
On Tue, May 01, 2001 at 10:22:39AM -0700, Linus Torvalds wrote: > I bet that the patch will be smaller too. It's a simple case of > - do the ioremap() _once_ at bootup, save the result in a static >variable somewhere. > - implement the (one-liner) isa_readx/isa_writex functions. > > On

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Arnaldo Carvalho de Melo
Em Tue, May 01, 2001 at 09:52:30AM -0400, [EMAIL PROTECTED] escreveu: > Personally I'd rather not have arch dependent macros in the driver, but I > know there is a good reason why the isa_read/write functions were > introduced in the first place. I did that because I was lazy to use ioremap

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Geert Uytterhoeven
On Tue, 1 May 2001 [EMAIL PROTECTED] wrote: > To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the > isa_read/write's have to be changed to regular read/write due to the lack > of the isa_read/write functions for ppc. > > So, the question is should I simply: > > a) change

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread mike_phillips
> I would suggest the opposite approach instead: make the PPC just > support isa_readx/isa_writex instead. > > Much simpler, and doesn't need changes to (correct) driver sources. > > I bet that the patch will be smaller too. It's a simple case of > - do the ioremap() _once_ at bootup, save the

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Linus Torvalds
In article <[EMAIL PROTECTED]>, <[EMAIL PROTECTED]> wrote: >>[EMAIL PROTECTED] wrote: >>> >>> To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the >>> isa_read/write's have to be changed to regular read/write due to the >lack >>> of the isa_read/write functions for ppc. > >>

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread mike_phillips
>[EMAIL PROTECTED] wrote: >> >> To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the >> isa_read/write's have to be changed to regular read/write due to the lack >> of the isa_read/write functions for ppc. > Treat it like a PCI device and use ioremap(). Then change

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Alan Cox
> > for ioremap and are meant for lazy porting > > You meant isa_read* were for lazy porting. read* require ioremap be > done before hand, even for ISA. Indeed I do - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Brian Gerst
Alan Cox wrote: > > > a) change everything to read/write and friends (the way the driver used to > > be before the isa_read/write function were introduced) > > readb/readw/readl have always worked for ISA bus. They simply avoid the need > for ioremap and are meant for lazy porting You meant

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Brian Gerst
[EMAIL PROTECTED] wrote: > > To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the > isa_read/write's have to be changed to regular read/write due to the lack > of the isa_read/write functions for ppc. Treat it like a PCI device and use ioremap(). Then change isa_readl() to

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Alan Cox
> a) change everything to read/write and friends (the way the driver used to > be before the isa_read/write function were introduced) readb/readw/readl have always worked for ISA bus. They simply avoid the need for ioremap and are meant for lazy porting - To unsubscribe from this list: send

isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread mike_phillips
To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the isa_read/write's have to be changed to regular read/write due to the lack of the isa_read/write functions for ppc. So, the question is should I simply: a) change everything to read/write and friends (the way the driver

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Geert Uytterhoeven
On Tue, 1 May 2001 [EMAIL PROTECTED] wrote: To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the isa_read/write's have to be changed to regular read/write due to the lack of the isa_read/write functions for ppc. So, the question is should I simply: a) change

isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread mike_phillips
To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the isa_read/write's have to be changed to regular read/write due to the lack of the isa_read/write functions for ppc. So, the question is should I simply: a) change everything to read/write and friends (the way the driver

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Alan Cox
a) change everything to read/write and friends (the way the driver used to be before the isa_read/write function were introduced) readb/readw/readl have always worked for ISA bus. They simply avoid the need for ioremap and are meant for lazy porting - To unsubscribe from this list: send the

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Brian Gerst
[EMAIL PROTECTED] wrote: To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the isa_read/write's have to be changed to regular read/write due to the lack of the isa_read/write functions for ppc. Treat it like a PCI device and use ioremap(). Then change isa_readl() to

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Brian Gerst
Alan Cox wrote: a) change everything to read/write and friends (the way the driver used to be before the isa_read/write function were introduced) readb/readw/readl have always worked for ISA bus. They simply avoid the need for ioremap and are meant for lazy porting You meant isa_read*

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Alan Cox
for ioremap and are meant for lazy porting You meant isa_read* were for lazy porting. read* require ioremap be done before hand, even for ISA. Indeed I do - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread mike_phillips
[EMAIL PROTECTED] wrote: To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the isa_read/write's have to be changed to regular read/write due to the lack of the isa_read/write functions for ppc. Treat it like a PCI device and use ioremap(). Then change isa_readl() to

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Linus Torvalds
In article [EMAIL PROTECTED], [EMAIL PROTECTED] wrote: [EMAIL PROTECTED] wrote: To get the pcmcia ibmtr driver (ibmtr/ibmtr_cs) working on ppc, all the isa_read/write's have to be changed to regular read/write due to the lack of the isa_read/write functions for ppc. Treat it like a PCI

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread mike_phillips
I would suggest the opposite approach instead: make the PPC just support isa_readx/isa_writex instead. Much simpler, and doesn't need changes to (correct) driver sources. I bet that the patch will be smaller too. It's a simple case of - do the ioremap() _once_ at bootup, save the result

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Arnaldo Carvalho de Melo
Em Tue, May 01, 2001 at 09:52:30AM -0400, [EMAIL PROTECTED] escreveu: Personally I'd rather not have arch dependent macros in the driver, but I know there is a good reason why the isa_read/write functions were introduced in the first place. I did that because I was lazy to use ioremap in

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Russell King
On Tue, May 01, 2001 at 10:22:39AM -0700, Linus Torvalds wrote: I bet that the patch will be smaller too. It's a simple case of - do the ioremap() _once_ at bootup, save the result in a static variable somewhere. - implement the (one-liner) isa_readx/isa_writex functions. On many

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Linus Torvalds
On Tue, 1 May 2001, Russell King wrote: Talking around this issue, is there any chance of getting the official use of the first parameter to ioremap documented in Documentation/IO-mapping.txt please? There appears to be confusion as to whether it is: a) PCI bus address b) CPU

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Russell King
On Tue, May 01, 2001 at 02:19:33PM -0700, Linus Torvalds wrote: On Tue, 1 May 2001, Russell King wrote: Talking around this issue, is there any chance of getting the official use of the first parameter to ioremap documented in Documentation/IO-mapping.txt please? There appears to be

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Linus Torvalds
On Tue, 1 May 2001, Russell King wrote: In which case, can we change the following in IO-mapping.txt please? Oh, sorry. I misread your question. The _return_ value is a cookie. The first argument should basically be the start of a struct pci_dev resource entry, but obviously

Re: isa_read/write not available on ppc - solution suggestions ??

2001-05-01 Thread Paul Mackerras
Linus Torvalds writes: I would suggest the opposite approach instead: make the PPC just support isa_readx/isa_writex instead. We can certainly do that, no problem. BUT that won't get a token ring pcmcia card working in the newer powerbooks, such as the titanium G4 powerbook, because the PCI