linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi all,

After merging the scsi tree, today's linux-next build (htmldocs) produced
this warning:

Documentation/driver-api/target:19: 
drivers/target/target_core_transport.c:1661: WARNING: Block quote ends without 
a blank line; unexpected unindent.

Introduced by commit

  750a1d93f905 ("scsi: target: core: Break up target_submit_cmd_map_sgls()")

-- 
Cheers,
Stephen Rothwell


pgp5EB1NJ8f99.pgp
Description: OpenPGP digital signature

RE: linux-next: build warning after merge of the scsi tree

[Alim Akhtar]

Hi Stephen

> -Original Message-
> From: Stephen Rothwell 
> Sent: 25 June 2020 09:11
> To: James Bottomley 
> Cc: Linux Next Mailing List ; Linux Kernel
Mailing
> List ; Alim Akhtar
;
> Martin K. Petersen ; Seungwon Jeon
> 
> Subject: linux-next: build warning after merge of the scsi tree
> 
> Hi all,
> 
> After merging the scsi tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> WARNING: modpost: missing MODULE_LICENSE() in drivers/scsi/ufs/ufs-
> exynos.o
> 
Sorry about that, will send a fix patch soon.

> Introduced by commit
> 
>   55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos
SoCs")
> 
> (not sure why I missed this earlier, sorry)
> 
> --
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi all,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

WARNING: modpost: missing MODULE_LICENSE() in drivers/scsi/ufs/ufs-exynos.o

Introduced by commit

  55f4b1f73631 ("scsi: ufs: ufs-exynos: Add UFS host support for Exynos SoCs")

(not sure why I missed this earlier, sorry)

-- 
Cheers,
Stephen Rothwell


pgp2bY4BKRlHm.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi all,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

In file included from include/linux/pci-dma-compat.h:8,
 from include/linux/pci.h:2408,
 from drivers/scsi/mvumi.c:13:
drivers/scsi/mvumi.c: In function 'mvumi_queue_command':
include/linux/dma-mapping.h:608:34: warning: 'sg' may be used uninitialized in 
this function [-Wmaybe-uninitialized]
 #define dma_unmap_sg(d, s, n, r) dma_unmap_sg_attrs(d, s, n, r, 0)
  ^~
drivers/scsi/mvumi.c:192:22: note: 'sg' was declared here
  struct scatterlist *sg;
  ^~

Introduced by commit

  350d66a72adc ("scsi: mvumi: use sg helper to iterate over scatterlist")

-- 
Cheers,
Stephen Rothwell


pgpopeuhnTnKU.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi tree

[Tyrel Datwyler]

On 05/30/2019 08:36 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
> drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used 
> uninitialized in this function [-Wmaybe-uninitialized]
>   if (rc) {
>  ^
> drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
>   int rc;
>   ^~
> 
> Introduced by commit
> 
>   035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action 
> states")
> 

Looks like somebody else noticed the warning and a proposed fix was already sent
out.

-Tyrel

Re: linux-next: build warning after merge of the scsi tree

[Tyrel Datwyler]

On 05/30/2019 08:36 PM, Stephen Rothwell wrote:
> Hi all,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
> drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used 
> uninitialized in this function [-Wmaybe-uninitialized]
>   if (rc) {
>  ^
> drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
>   int rc;
>   ^~
> 
> Introduced by commit
> 
>   035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action 
> states")
> 

Oof, looks like I didn't compile with pedantic enough options, or just didn't
notice the warning. Declaration should be "int rc = 0;". I can send a follow on
patch.

-Tyrel

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi all,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/ibmvscsi/ibmvscsi.c: In function 'ibmvscsi_work':
drivers/scsi/ibmvscsi/ibmvscsi.c:2151:5: warning: 'rc' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
  if (rc) {
 ^
drivers/scsi/ibmvscsi/ibmvscsi.c:2121:6: note: 'rc' was declared here
  int rc;
  ^~

Introduced by commit

  035a3c4046b5 ("scsi: ibmvscsi: redo driver work thread to use enum action 
states")

-- 
Cheers,
Stephen Rothwell


pgpx7DUczOhYC.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

On Thu, 2019-04-04 at 21:30 -0700, Bart Van Assche wrote:
> On 4/4/19 8:25 PM, Stephen Rothwell wrote:
> > Hi James,
> > 
> > After merging the scsi tree, today's linux-next build (powerpc
> > ppc64_defconfig) produced this warning:
> > 
> > drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning:
> > 'lpfc_nvme_lport_unreg_wait' defined but not used [-Wunused-
> > function]
> >   lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
> >   ^~
> > 
> > Introduced by commit
> > 
> >3999df75bccb ("scsi: lpfc: Declare local functions static")
> > 
> > It use is guarded by IS_ENABLED(CONFIG_NVME_FC).
> 
> I will have a closer look at this tomorrow.

In the meantime, we can just revert the patch.  Making functions static
serves no real purpose except it does tell the compiler they have to be
used internally which is where the problem is coming from.  Once the
issue is sorted, the static patch can be reapplied.

James

Re: linux-next: build warning after merge of the scsi tree

[Bart Van Assche]

On 4/4/19 8:25 PM, Stephen Rothwell wrote:

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning: 'lpfc_nvme_lport_unreg_wait' 
defined but not used [-Wunused-function]
  lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
  ^~

Introduced by commit

   3999df75bccb ("scsi: lpfc: Declare local functions static")

It use is guarded by IS_ENABLED(CONFIG_NVME_FC).


I will have a closer look at this tomorrow.

Bart.

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_nvme.c:2140:1: warning: 'lpfc_nvme_lport_unreg_wait' 
defined but not used [-Wunused-function]
 lpfc_nvme_lport_unreg_wait(struct lpfc_vport *vport,
 ^~

Introduced by commit

  3999df75bccb ("scsi: lpfc: Declare local functions static")

It use is guarded by IS_ENABLED(CONFIG_NVME_FC).

-- 
Cheers,
Stephen Rothwell


pgp3fvlNgGyRV.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

On Thu, 18 Oct 2018 21:54:03 -0700 James Bottomley 
 wrote:
>
> It's the merge commit ... it was obviously the wrong choice; I'll fix
> it.

OK, thanks.

-- 
Cheers,
Stephen Rothwell


pgpS8HDlYzZFg.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

On Thu, 18 Oct 2018 21:54:03 -0700 James Bottomley 
 wrote:
>
> It's the merge commit ... it was obviously the wrong choice; I'll fix
> it.

OK, thanks.

-- 
Cheers,
Stephen Rothwell


pgpS8HDlYzZFg.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

On Fri, 2018-10-19 at 15:50 +1100, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/lpfc/lpfc_debugfs.c: In function
> 'lpfc_debugfs_nodelist_open':
> drivers/scsi/lpfc/lpfc_debugfs.c:706:17: warning: 'nrport' may be
> used uninitialized in this function [-Wmaybe-uninitialized]
>switch (nrport->port_state) {
>~~^~~~
> drivers/scsi/lpfc/lpfc_debugfs.c:553:30: note: 'nrport' was declared
> here
>   struct nvme_fc_remote_port *nrport;
>   ^~
> 
> I am not sure where this has come from :-(

It's the merge commit ... it was obviously the wrong choice; I'll fix
it.

James


signature.asc
Description: This is a digitally signed message part

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

On Fri, 2018-10-19 at 15:50 +1100, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> ppc64_defconfig) produced this warning:
> 
> drivers/scsi/lpfc/lpfc_debugfs.c: In function
> 'lpfc_debugfs_nodelist_open':
> drivers/scsi/lpfc/lpfc_debugfs.c:706:17: warning: 'nrport' may be
> used uninitialized in this function [-Wmaybe-uninitialized]
>switch (nrport->port_state) {
>~~^~~~
> drivers/scsi/lpfc/lpfc_debugfs.c:553:30: note: 'nrport' was declared
> here
>   struct nvme_fc_remote_port *nrport;
>   ^~
> 
> I am not sure where this has come from :-(

It's the merge commit ... it was obviously the wrong choice; I'll fix
it.

James


signature.asc
Description: This is a digitally signed message part

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_open':
drivers/scsi/lpfc/lpfc_debugfs.c:706:17: warning: 'nrport' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
   switch (nrport->port_state) {
   ~~^~~~
drivers/scsi/lpfc/lpfc_debugfs.c:553:30: note: 'nrport' was declared here
  struct nvme_fc_remote_port *nrport;
  ^~

I am not sure where this has come from :-(

-- 
Cheers,
Stephen Rothwell


pgpcGTZnRNLfi.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
ppc64_defconfig) produced this warning:

drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_open':
drivers/scsi/lpfc/lpfc_debugfs.c:706:17: warning: 'nrport' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
   switch (nrport->port_state) {
   ~~^~~~
drivers/scsi/lpfc/lpfc_debugfs.c:553:30: note: 'nrport' was declared here
  struct nvme_fc_remote_port *nrport;
  ^~

I am not sure where this has come from :-(

-- 
Cheers,
Stephen Rothwell


pgpcGTZnRNLfi.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

Jens,

>> Message-Id:  <20180706201920.2185565-1-a...@arndb.de>
>> Subject: [PATCH] [v2] sbitmap, scsi/target: add seq_file forward 
>> declaration

>> Martin didn't reply and it's not yet in his tree, although I'm sure it
>> will be soon.

Been out on vacation. I thought I committed it but I guess not. I'll get
to it today.

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

Jens,

>> Message-Id:  <20180706201920.2185565-1-a...@arndb.de>
>> Subject: [PATCH] [v2] sbitmap, scsi/target: add seq_file forward 
>> declaration

>> Martin didn't reply and it's not yet in his tree, although I'm sure it
>> will be soon.

Been out on vacation. I thought I committed it but I guess not. I'll get
to it today.

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: linux-next: build warning after merge of the scsi tree

[Jens Axboe]

On 7/10/18 8:26 AM, James Bottomley wrote:
> On Tue, 2018-07-10 at 08:22 -0600, Jens Axboe wrote:
>> On 7/10/18 8:14 AM, James Bottomley wrote:
>>> On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
 On 7/10/18 1:31 AM, Stephen Rothwell wrote:
>>>
>>> [...]
> I am still seeing these warnings ...

 Martin queued up the forward declaration patch for this one, not
 sure
 why it isn't showing up in the scsi tree yet.
>>>
>>> All the trees are fully up to date ... which commit is it?
>>
>> It's a patch from Arnd, I don't know what commit id it is. But
>> Martin replied a few days ago that it was applied. I don't have
>> the email handy, though.
> 
> You mean
> 
> Message-Id:   <20180706201920.2185565-1-a...@arndb.de>
> Subject:  [PATCH] [v2] sbitmap, scsi/target: add seq_file forward 
> declaration
> 
> ?
> 
> Martin didn't reply and it's not yet in his tree, although I'm sure it
> will be soon.

Yeah that's the one. I now had to look it up, looks like I mixed it up
with the host busy patch from Ming.

We should get it applied. Feel free to add my reviewed-by, if you want.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the scsi tree

[Jens Axboe]

On 7/10/18 8:26 AM, James Bottomley wrote:
> On Tue, 2018-07-10 at 08:22 -0600, Jens Axboe wrote:
>> On 7/10/18 8:14 AM, James Bottomley wrote:
>>> On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
 On 7/10/18 1:31 AM, Stephen Rothwell wrote:
>>>
>>> [...]
> I am still seeing these warnings ...

 Martin queued up the forward declaration patch for this one, not
 sure
 why it isn't showing up in the scsi tree yet.
>>>
>>> All the trees are fully up to date ... which commit is it?
>>
>> It's a patch from Arnd, I don't know what commit id it is. But
>> Martin replied a few days ago that it was applied. I don't have
>> the email handy, though.
> 
> You mean
> 
> Message-Id:   <20180706201920.2185565-1-a...@arndb.de>
> Subject:  [PATCH] [v2] sbitmap, scsi/target: add seq_file forward 
> declaration
> 
> ?
> 
> Martin didn't reply and it's not yet in his tree, although I'm sure it
> will be soon.

Yeah that's the one. I now had to look it up, looks like I mixed it up
with the host busy patch from Ming.

We should get it applied. Feel free to add my reviewed-by, if you want.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

On Tue, 2018-07-10 at 08:22 -0600, Jens Axboe wrote:
> On 7/10/18 8:14 AM, James Bottomley wrote:
> > On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
> > > On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> > 
> > [...]
> > > > I am still seeing these warnings ...
> > > 
> > > Martin queued up the forward declaration patch for this one, not
> > > sure
> > > why it isn't showing up in the scsi tree yet.
> > 
> > All the trees are fully up to date ... which commit is it?
> 
> It's a patch from Arnd, I don't know what commit id it is. But
> Martin replied a few days ago that it was applied. I don't have
> the email handy, though.

You mean

Message-Id: <20180706201920.2185565-1-a...@arndb.de>
Subject:[PATCH] [v2] sbitmap, scsi/target: add seq_file forward 
declaration

?

Martin didn't reply and it's not yet in his tree, although I'm sure it
will be soon.

James

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

On Tue, 2018-07-10 at 08:22 -0600, Jens Axboe wrote:
> On 7/10/18 8:14 AM, James Bottomley wrote:
> > On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
> > > On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> > 
> > [...]
> > > > I am still seeing these warnings ...
> > > 
> > > Martin queued up the forward declaration patch for this one, not
> > > sure
> > > why it isn't showing up in the scsi tree yet.
> > 
> > All the trees are fully up to date ... which commit is it?
> 
> It's a patch from Arnd, I don't know what commit id it is. But
> Martin replied a few days ago that it was applied. I don't have
> the email handy, though.

You mean

Message-Id: <20180706201920.2185565-1-a...@arndb.de>
Subject:[PATCH] [v2] sbitmap, scsi/target: add seq_file forward 
declaration

?

Martin didn't reply and it's not yet in his tree, although I'm sure it
will be soon.

James

Re: linux-next: build warning after merge of the scsi tree

[Jens Axboe]

On 7/10/18 8:14 AM, James Bottomley wrote:
> On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
>> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> [...]
>>> I am still seeing these warnings ...
>>
>> Martin queued up the forward declaration patch for this one, not sure
>> why it isn't showing up in the scsi tree yet.
> 
> All the trees are fully up to date ... which commit is it?

It's a patch from Arnd, I don't know what commit id it is. But
Martin replied a few days ago that it was applied. I don't have
the email handy, though.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the scsi tree

[Jens Axboe]

On 7/10/18 8:14 AM, James Bottomley wrote:
> On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
>> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> [...]
>>> I am still seeing these warnings ...
>>
>> Martin queued up the forward declaration patch for this one, not sure
>> why it isn't showing up in the scsi tree yet.
> 
> All the trees are fully up to date ... which commit is it?

It's a patch from Arnd, I don't know what commit id it is. But
Martin replied a few days ago that it was applied. I don't have
the email handy, though.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
[...]
> > I am still seeing these warnings ...
> 
> Martin queued up the forward declaration patch for this one, not sure
> why it isn't showing up in the scsi tree yet.

All the trees are fully up to date ... which commit is it?

James

Re: linux-next: build warning after merge of the scsi tree

[James Bottomley]

On Tue, 2018-07-10 at 08:09 -0600, Jens Axboe wrote:
> On 7/10/18 1:31 AM, Stephen Rothwell wrote:
[...]
> > I am still seeing these warnings ...
> 
> Martin queued up the forward declaration patch for this one, not sure
> why it isn't showing up in the scsi tree yet.

All the trees are fully up to date ... which commit is it?

James

Re: linux-next: build warning after merge of the scsi tree

[Jens Axboe]

On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 20 Jun 2018 13:29:10 +1000 Stephen Rothwell  
> wrote:
>>
>> After merging the scsi tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>>
>> In file included from include/target/target_core_base.h:7:0,
>>  from drivers/target/target_core_tmr.c:31:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>>   ^~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>>  ^~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>>^~~~
>> In file included from include/target/target_core_base.h:7:0,
>>  from drivers/target/target_core_ua.c:30:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>>   ^~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>>  ^~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>>^~~~
>>
>> Introduced by commit
>>
>>   24af1ccfe12a ("sbitmap: add helpers for dumping to a seq_file")
>>
>> in v4.11.rc1, but exposed by commit
>>
>>   eca7ee1f33e8 ("scsi: target: Convert target drivers to use sbitmap")
> 
> I am still seeing these warnings ...

Martin queued up the forward declaration patch for this one, not sure
why it isn't showing up in the scsi tree yet.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the scsi tree

[Jens Axboe]

On 7/10/18 1:31 AM, Stephen Rothwell wrote:
> Hi all,
> 
> On Wed, 20 Jun 2018 13:29:10 +1000 Stephen Rothwell  
> wrote:
>>
>> After merging the scsi tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>>
>> In file included from include/target/target_core_base.h:7:0,
>>  from drivers/target/target_core_tmr.c:31:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>>   ^~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>>  ^~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>>^~~~
>> In file included from include/target/target_core_base.h:7:0,
>>  from drivers/target/target_core_ua.c:30:
>> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>>   ^~~~
>> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>>  ^~~~
>> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside 
>> parameter list will not be visible outside of this definition or declaration
>>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>>^~~~
>>
>> Introduced by commit
>>
>>   24af1ccfe12a ("sbitmap: add helpers for dumping to a seq_file")
>>
>> in v4.11.rc1, but exposed by commit
>>
>>   eca7ee1f33e8 ("scsi: target: Convert target drivers to use sbitmap")
> 
> I am still seeing these warnings ...

Martin queued up the forward declaration patch for this one, not sure
why it isn't showing up in the scsi tree yet.

-- 
Jens Axboe

Re: linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi all,

On Wed, 20 Jun 2018 13:29:10 +1000 Stephen Rothwell  
wrote:
>
> After merging the scsi tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> In file included from include/target/target_core_base.h:7:0,
>  from drivers/target/target_core_tmr.c:31:
> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>   ^~~~
> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>  ^~~~
> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>^~~~
> In file included from include/target/target_core_base.h:7:0,
>  from drivers/target/target_core_ua.c:30:
> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>   ^~~~
> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>  ^~~~
> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>^~~~
> 
> Introduced by commit
> 
>   24af1ccfe12a ("sbitmap: add helpers for dumping to a seq_file")
> 
> in v4.11.rc1, but exposed by commit
> 
>   eca7ee1f33e8 ("scsi: target: Convert target drivers to use sbitmap")

I am still seeing these warnings ...

-- 
Cheers,
Stephen Rothwell


pgpDvQDJcS764.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi all,

On Wed, 20 Jun 2018 13:29:10 +1000 Stephen Rothwell  
wrote:
>
> After merging the scsi tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> In file included from include/target/target_core_base.h:7:0,
>  from drivers/target/target_core_tmr.c:31:
> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>   ^~~~
> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>  ^~~~
> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>^~~~
> In file included from include/target/target_core_base.h:7:0,
>  from drivers/target/target_core_ua.c:30:
> include/linux/sbitmap.h:331:46: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_show(struct sbitmap *sb, struct seq_file *m);
>   ^~~~
> include/linux/sbitmap.h:342:53: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_bitmap_show(struct sbitmap *sb, struct seq_file *m);
>  ^~~~
> include/linux/sbitmap.h:530:59: warning: 'struct seq_file' declared inside 
> parameter list will not be visible outside of this definition or declaration
>  void sbitmap_queue_show(struct sbitmap_queue *sbq, struct seq_file *m);
>^~~~
> 
> Introduced by commit
> 
>   24af1ccfe12a ("sbitmap: add helpers for dumping to a seq_file")
> 
> in v4.11.rc1, but exposed by commit
> 
>   eca7ee1f33e8 ("scsi: target: Convert target drivers to use sbitmap")

I am still seeing these warnings ...

-- 
Cheers,
Stephen Rothwell


pgpDvQDJcS764.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

Long,

> I will fix this by moving those data structure to kmalloc pre-allocated
> when channel is first created.

Sounds good. I'll drop patch 3 for now and wait for you to resubmit.

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

Long,

> I will fix this by moving those data structure to kmalloc pre-allocated
> when channel is first created.

Sounds good. I'll drop patch 3 for now and wait for you to resubmit.

-- 
Martin K. Petersen  Oracle Linux Engineering

RE: linux-next: build warning after merge of the scsi tree

[Long Li]

> Subject: linux-next: build warning after merge of the scsi tree
> 
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io':
> drivers/scsi/storvsc_drv.c:1402:1: warning: the frame size of 2216 bytes is
> larger than 2048 bytes [-Wframe-larger-than=]  }  ^
> 
> Introduced by commit
> 
>   0b9bc24b8304 ("csi: storvsc: Select channel based on available percentage of
> ring buffer to write")

Thanks for catching this. This is due to the size of struct cpumask is too big, 
when CONFIG_NR_CPUS=8192 is used in most kernel config.

I will fix this by moving those data structure to kmalloc pre-allocated when 
channel is first created.

> 
> --
> Cheers,
> Stephen Rothwell

RE: linux-next: build warning after merge of the scsi tree

[Long Li]

> Subject: linux-next: build warning after merge of the scsi tree
> 
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (x86_64
> allmodconfig) produced this warning:
> 
> drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io':
> drivers/scsi/storvsc_drv.c:1402:1: warning: the frame size of 2216 bytes is
> larger than 2048 bytes [-Wframe-larger-than=]  }  ^
> 
> Introduced by commit
> 
>   0b9bc24b8304 ("csi: storvsc: Select channel based on available percentage of
> ring buffer to write")

Thanks for catching this. This is due to the size of struct cpumask is too big, 
when CONFIG_NR_CPUS=8192 is used in most kernel config.

I will fix this by moving those data structure to kmalloc pre-allocated when 
channel is first created.

> 
> --
> Cheers,
> Stephen Rothwell

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io':
drivers/scsi/storvsc_drv.c:1402:1: warning: the frame size of 2216 bytes is 
larger than 2048 bytes [-Wframe-larger-than=]
 }
 ^

Introduced by commit

  0b9bc24b8304 ("csi: storvsc: Select channel based on available percentage of 
ring buffer to write")

-- 
Cheers,
Stephen Rothwell


pgpQ3f0LB0yFN.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/storvsc_drv.c: In function 'storvsc_do_io':
drivers/scsi/storvsc_drv.c:1402:1: warning: the frame size of 2216 bytes is 
larger than 2048 bytes [-Wframe-larger-than=]
 }
 ^

Introduced by commit

  0b9bc24b8304 ("csi: storvsc: Select channel based on available percentage of 
ring buffer to write")

-- 
Cheers,
Stephen Rothwell


pgpQ3f0LB0yFN.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi tree

[Fam Zheng]

On Thu, 04/06 14:04, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from include/linux/list.h:8:0,
>  from include/linux/module.h:9,
>  from drivers/scsi/sd.c:35:
> drivers/scsi/sd.c: In function 'sd_revalidate_disk':
> include/linux/kernel.h:755:16: warning: comparison of distinct pointer types 
> lacks a cast
>   (void) ( == );   \
> ^
> include/linux/kernel.h:758:2: note: in expansion of macro '__min'
>   __min(typeof(x), typeof(y),   \
>   ^
> include/linux/kernel.h:783:39: note: in expansion of macro 'min'
>   __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); })
>^
> drivers/scsi/sd.c:2959:12: note: in expansion of macro 'min_not_zero'
>rw_max = min_not_zero(logical_to_sectors(sdp, dev_max),
> ^
> 
> Introduced by commit
> 
>   c3e62673ee20 ("scsi: sd: Consider max_xfer_blocks if opt_xfer_blocks is 
> unusable")
> 
> logical_to_sectors() is a sector_t and BLK_DEF_MAX_SECTORS is an "enum
> blk_default_limits" (i.e. int).

Hi Stephen, James,

I will send a patch to fix this warning.

Fam

Re: linux-next: build warning after merge of the scsi tree

[Fam Zheng]

On Thu, 04/06 14:04, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
> 
> In file included from include/linux/list.h:8:0,
>  from include/linux/module.h:9,
>  from drivers/scsi/sd.c:35:
> drivers/scsi/sd.c: In function 'sd_revalidate_disk':
> include/linux/kernel.h:755:16: warning: comparison of distinct pointer types 
> lacks a cast
>   (void) ( == );   \
> ^
> include/linux/kernel.h:758:2: note: in expansion of macro '__min'
>   __min(typeof(x), typeof(y),   \
>   ^
> include/linux/kernel.h:783:39: note: in expansion of macro 'min'
>   __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); })
>^
> drivers/scsi/sd.c:2959:12: note: in expansion of macro 'min_not_zero'
>rw_max = min_not_zero(logical_to_sectors(sdp, dev_max),
> ^
> 
> Introduced by commit
> 
>   c3e62673ee20 ("scsi: sd: Consider max_xfer_blocks if opt_xfer_blocks is 
> unusable")
> 
> logical_to_sectors() is a sector_t and BLK_DEF_MAX_SECTORS is an "enum
> blk_default_limits" (i.e. int).

Hi Stephen, James,

I will send a patch to fix this warning.

Fam

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/list.h:8:0,
 from include/linux/module.h:9,
 from drivers/scsi/sd.c:35:
drivers/scsi/sd.c: In function 'sd_revalidate_disk':
include/linux/kernel.h:755:16: warning: comparison of distinct pointer types 
lacks a cast
  (void) ( == );   \
^
include/linux/kernel.h:758:2: note: in expansion of macro '__min'
  __min(typeof(x), typeof(y),   \
  ^
include/linux/kernel.h:783:39: note: in expansion of macro 'min'
  __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); })
   ^
drivers/scsi/sd.c:2959:12: note: in expansion of macro 'min_not_zero'
   rw_max = min_not_zero(logical_to_sectors(sdp, dev_max),
^

Introduced by commit

  c3e62673ee20 ("scsi: sd: Consider max_xfer_blocks if opt_xfer_blocks is 
unusable")

logical_to_sectors() is a sector_t and BLK_DEF_MAX_SECTORS is an "enum
blk_default_limits" (i.e. int).

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:

In file included from include/linux/list.h:8:0,
 from include/linux/module.h:9,
 from drivers/scsi/sd.c:35:
drivers/scsi/sd.c: In function 'sd_revalidate_disk':
include/linux/kernel.h:755:16: warning: comparison of distinct pointer types 
lacks a cast
  (void) ( == );   \
^
include/linux/kernel.h:758:2: note: in expansion of macro '__min'
  __min(typeof(x), typeof(y),   \
  ^
include/linux/kernel.h:783:39: note: in expansion of macro 'min'
  __x == 0 ? __y : ((__y == 0) ? __x : min(__x, __y)); })
   ^
drivers/scsi/sd.c:2959:12: note: in expansion of macro 'min_not_zero'
   rw_max = min_not_zero(logical_to_sectors(sdp, dev_max),
^

Introduced by commit

  c3e62673ee20 ("scsi: sd: Consider max_xfer_blocks if opt_xfer_blocks is 
unusable")

logical_to_sectors() is a sector_t and BLK_DEF_MAX_SECTORS is an "enum
blk_default_limits" (i.e. int).

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

> "Stephen" == Stephen Rothwell  writes:

Stephen,

Stephen> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
Stephen> drivers/scsi/hpsa.c:2033:5: warning: 'sd' may be used
Stephen> uninitialized in this function [-Wmaybe-uninitialized]
Stephen>   if (!sd)
Stephen>  ^

Stephen> Introduced by commit

Stephen>   4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA
Stephen>   devices")

Fixed this up.

Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

> "Stephen" == Stephen Rothwell  writes:

Stephen,

Stephen> drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
Stephen> drivers/scsi/hpsa.c:2033:5: warning: 'sd' may be used
Stephen> uninitialized in this function [-Wmaybe-uninitialized]
Stephen>   if (!sd)
Stephen>  ^

Stephen> Introduced by commit

Stephen>   4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA
Stephen>   devices")

Fixed this up.

Thanks!

-- 
Martin K. Petersen  Oracle Linux Engineering

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
drivers/scsi/hpsa.c:2033:5: warning: 'sd' may be used uninitialized in this 
function [-Wmaybe-uninitialized]
  if (!sd)
 ^

Introduced by commit

  4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA devices")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/hpsa.c: In function 'hpsa_slave_alloc':
drivers/scsi/hpsa.c:2033:5: warning: 'sd' may be used uninitialized in this 
function [-Wmaybe-uninitialized]
  if (!sd)
 ^

Introduced by commit

  4eb307f7b18d ("scsi: hpsa: use bus '3' for legacy HBA devices")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

> "Bryant" == Bryant G Ly  writes:

Bryant> On 9/12/16, 11:15 PM, "Stephen Rothwell"  wrote:

>> Hi James,
>> 
>> After merging the scsi tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>> 
>> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function
>> 'ibmvscsis_rdma': drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20:
>> warning: unused variable 'srp' [-Wunused-variable] struct srp_cmd
>> *srp = (struct srp_cmd *)iue->sbuf->buf; ^
>> 
>> Introduced by commit
>> 
>> 812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")

Bryant> Looks like cleaning up the print statement made this variable
Bryant> unused so deleting that line would be best.

Please submit a patch to do so.

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: linux-next: build warning after merge of the scsi tree

[Martin K. Petersen]

> "Bryant" == Bryant G Ly  writes:

Bryant> On 9/12/16, 11:15 PM, "Stephen Rothwell"  wrote:

>> Hi James,
>> 
>> After merging the scsi tree, today's linux-next build (powerpc
>> allyesconfig) produced this warning:
>> 
>> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function
>> 'ibmvscsis_rdma': drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20:
>> warning: unused variable 'srp' [-Wunused-variable] struct srp_cmd
>> *srp = (struct srp_cmd *)iue->sbuf->buf; ^
>> 
>> Introduced by commit
>> 
>> 812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")

Bryant> Looks like cleaning up the print statement made this variable
Bryant> unused so deleting that line would be best.

Please submit a patch to do so.

-- 
Martin K. Petersen  Oracle Linux Engineering

Re: linux-next: build warning after merge of the scsi tree

[Bryant G. Ly]

On 9/12/16, 11:15 PM, "Stephen Rothwell"  wrote:

> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20: warning: unused 
variable 'srp' [-Wunused-variable]
> struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf;
> ^
> 
> Introduced by commit
> 
 >  812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")

Looks like cleaning up the print statement made this variable unused so 
deleting that line would be best. 

-Bryant 

Re: linux-next: build warning after merge of the scsi tree

[Bryant G. Ly]

On 9/12/16, 11:15 PM, "Stephen Rothwell"  wrote:

> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20: warning: unused 
variable 'srp' [-Wunused-variable]
> struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf;
> ^
> 
> Introduced by commit
> 
 >  812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")

Looks like cleaning up the print statement made this variable unused so 
deleting that line would be best. 

-Bryant 

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20: warning: unused variable 
'srp' [-Wunused-variable]
struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf;
^

Introduced by commit

  812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")

-- 
Cheers,
Stephen Rothwell

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_rdma':
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3190:20: warning: unused variable 
'srp' [-Wunused-variable]
struct srp_cmd *srp = (struct srp_cmd *)iue->sbuf->buf;
^

Introduced by commit

  812902159d41 ("scsi: ibmvscsis: Code cleanup of print statements")

-- 
Cheers,
Stephen Rothwell

Re: linux-next: build warning after merge of the scsi tree

[Christoph Hellwig]

On Tue, Nov 18, 2014 at 07:21:48PM +1100, Stephen Rothwell wrote:
> Hi James,
> 
> After merging the scsi tree, today's linux-next build (powerpc
> allyesconfig) produced this warning:
> 
> drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_queuecommand_lck':
> drivers/scsi/ibmvscsi/ibmvfc.c:1618:5: warning: unused variable 'tag' 
> [-Wunused-variable]
>   u8 tag[2];

Thanks Stephen, I'll take care of fixing this up.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warning after merge of the scsi tree

[Christoph Hellwig]

On Tue, Nov 18, 2014 at 07:21:48PM +1100, Stephen Rothwell wrote:
 Hi James,
 
 After merging the scsi tree, today's linux-next build (powerpc
 allyesconfig) produced this warning:
 
 drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_queuecommand_lck':
 drivers/scsi/ibmvscsi/ibmvfc.c:1618:5: warning: unused variable 'tag' 
 [-Wunused-variable]
   u8 tag[2];

Thanks Stephen, I'll take care of fixing this up.
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_queuecommand_lck':
drivers/scsi/ibmvscsi/ibmvfc.c:1618:5: warning: unused variable 'tag' 
[-Wunused-variable]
  u8 tag[2];
 ^

Introduced by commit 5066863337af ("scsi: remove abuses of
scsi_populate_tag").

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpmU7jmzpZ0K.pgp
Description: OpenPGP digital signature

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (powerpc
allyesconfig) produced this warning:

drivers/scsi/ibmvscsi/ibmvfc.c: In function 'ibmvfc_queuecommand_lck':
drivers/scsi/ibmvscsi/ibmvfc.c:1618:5: warning: unused variable 'tag' 
[-Wunused-variable]
  u8 tag[2];
 ^

Introduced by commit 5066863337af (scsi: remove abuses of
scsi_populate_tag).

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpmU7jmzpZ0K.pgp
Description: OpenPGP digital signature

Re: linux-next: build warning after merge of the scsi tree

[Sujit Reddy Thumma]

On 9/4/2013 2:48 PM, Sujit Reddy Thumma wrote:

On 9/2/2013 1:58 PM, Stephen Rothwell wrote:

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is
deprecated (declared at
/scratch/sfr/next/include/linux/workqueue.h:624)
[-Wdeprecated-declarations]
flush_work_sync(>eh_work);
^


James, would you like to pick up follow-up patch @
http://marc.info/?l=linux-scsi=137819519527432=2
or let me update the commit c1e846ab4422 fixing this?


Ignore this.
I saw you have dropped the patchset already. I will fix and post the
updated patches soon. Thanks.





Introduced by commit c1e846ab4422 ("[SCSI] ufs: Fix device and host reset
methods").  flush_work_sync was deprecated by commit 43829731dd37
("workqueue: deprecate flush[_delayed]_work_sync()") before v3.7-rc1.





--
Regards,
Sujit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warning after merge of the scsi tree

[Sujit Reddy Thumma]

On 9/2/2013 1:58 PM, Stephen Rothwell wrote:

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is deprecated 
(declared at /scratch/sfr/next/include/linux/workqueue.h:624) 
[-Wdeprecated-declarations]
flush_work_sync(>eh_work);
^


James, would you like to pick up follow-up patch @
http://marc.info/?l=linux-scsi=137819519527432=2
or let me update the commit c1e846ab4422 fixing this?



Introduced by commit c1e846ab4422 ("[SCSI] ufs: Fix device and host reset
methods").  flush_work_sync was deprecated by commit 43829731dd37
("workqueue: deprecate flush[_delayed]_work_sync()") before v3.7-rc1.



--
Regards,
Sujit
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warning after merge of the scsi tree

[Sujit Reddy Thumma]

On 9/2/2013 1:58 PM, Stephen Rothwell wrote:

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is deprecated 
(declared at /scratch/sfr/next/include/linux/workqueue.h:624) 
[-Wdeprecated-declarations]
flush_work_sync(hba-eh_work);
^


James, would you like to pick up follow-up patch @
http://marc.info/?l=linux-scsim=137819519527432w=2
or let me update the commit c1e846ab4422 fixing this?



Introduced by commit c1e846ab4422 ([SCSI] ufs: Fix device and host reset
methods).  flush_work_sync was deprecated by commit 43829731dd37
(workqueue: deprecate flush[_delayed]_work_sync()) before v3.7-rc1.



--
Regards,
Sujit
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: linux-next: build warning after merge of the scsi tree

[Sujit Reddy Thumma]

On 9/4/2013 2:48 PM, Sujit Reddy Thumma wrote:

On 9/2/2013 1:58 PM, Stephen Rothwell wrote:

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is
deprecated (declared at
/scratch/sfr/next/include/linux/workqueue.h:624)
[-Wdeprecated-declarations]
flush_work_sync(hba-eh_work);
^


James, would you like to pick up follow-up patch @
http://marc.info/?l=linux-scsim=137819519527432w=2
or let me update the commit c1e846ab4422 fixing this?


Ignore this.
I saw you have dropped the patchset already. I will fix and post the
updated patches soon. Thanks.





Introduced by commit c1e846ab4422 ([SCSI] ufs: Fix device and host reset
methods).  flush_work_sync was deprecated by commit 43829731dd37
(workqueue: deprecate flush[_delayed]_work_sync()) before v3.7-rc1.





--
Regards,
Sujit
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is deprecated 
(declared at /scratch/sfr/next/include/linux/workqueue.h:624) 
[-Wdeprecated-declarations]
   flush_work_sync(>eh_work);
   ^

Introduced by commit c1e846ab4422 ("[SCSI] ufs: Fix device and host reset
methods").  flush_work_sync was deprecated by commit 43829731dd37
("workqueue: deprecate flush[_delayed]_work_sync()") before v3.7-rc1.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpCVmIBuCsR7.pgp
Description: PGP signature

linux-next: build warning after merge of the scsi tree

[Stephen Rothwell]

Hi James,

After merging the scsi tree, today's linux-next build (x86_64
allmodconfig) produced this warning:

drivers/scsi/ufs/ufshcd.c: In function 'ufshcd_eh_host_reset_handler':
drivers/scsi/ufs/ufshcd.c:2740:3: warning: 'flush_work_sync' is deprecated 
(declared at /scratch/sfr/next/include/linux/workqueue.h:624) 
[-Wdeprecated-declarations]
   flush_work_sync(hba-eh_work);
   ^

Introduced by commit c1e846ab4422 ([SCSI] ufs: Fix device and host reset
methods).  flush_work_sync was deprecated by commit 43829731dd37
(workqueue: deprecate flush[_delayed]_work_sync()) before v3.7-rc1.

-- 
Cheers,
Stephen Rothwells...@canb.auug.org.au


pgpCVmIBuCsR7.pgp
Description: PGP signature