Re: [lustre-devel] staging: lustre: One function call less in class_register_type() after error detection

> In typical deployments outside of testing environment, this function is > called 5 times every system boot and never again. Does this information mean that a bit more fine-tuning is insignificant at such a source code place? >> Did the assignment for the local variable "rc" with a well-known

Re: [lustre-devel] staging: lustre: One function call less in class_register_type() after error detection

> In typical deployments outside of testing environment, this function is > called 5 times every system boot and never again. Does this information mean that a bit more fine-tuning is insignificant at such a source code place? >> Did the assignment for the local variable "rc" with a well-known

Re: [lustre-devel] staging: lustre: One function call less in class_register_type() after error detection

On Jul 28, 2016, at 1:53 AM, SF Markus Elfring wrote: >> This function is called several times during lustre module insert. >> Namely it's called 5 times for 5 types: >> osc, mdc, lov, lmv, mgc. > > Will any extra memory accesses matter for the successful execution > in this use case? I doubt

Re: [lustre-devel] staging: lustre: One function call less in class_register_type() after error detection

On Jul 28, 2016, at 1:53 AM, SF Markus Elfring wrote: >> This function is called several times during lustre module insert. >> Namely it's called 5 times for 5 types: >> osc, mdc, lov, lmv, mgc. > > Will any extra memory accesses matter for the successful execution > in this use case? I doubt

Re: staging: lustre: One function call less in class_register_type() after error detection

> This function is called several times during lustre module insert. > Namely it's called 5 times for 5 types: > osc, mdc, lov, lmv, mgc. Will any extra memory accesses matter for the successful execution in this use case? > It's not called any more than that, so it's not exactly a super

Re: staging: lustre: One function call less in class_register_type() after error detection

> This function is called several times during lustre module insert. > Namely it's called 5 times for 5 types: > osc, mdc, lov, lmv, mgc. Will any extra memory accesses matter for the successful execution in this use case? > It's not called any more than that, so it's not exactly a super

Re: staging: lustre: One function call less in class_register_type() after error detection

On Jul 26, 2016, at 3:56 PM, SF Markus Elfring wrote: >> But kobject_put() already checks for NULL, right? > > Yes. - Such an input parameter validation is performed by the > function implementation. > > >> you just submitted another batch about that in other area. > > I sent update

Re: staging: lustre: One function call less in class_register_type() after error detection

On Jul 26, 2016, at 3:56 PM, SF Markus Elfring wrote: >> But kobject_put() already checks for NULL, right? > > Yes. - Such an input parameter validation is performed by the > function implementation. > > >> you just submitted another batch about that in other area. > > I sent update

Re: staging: lustre: One function call less in class_register_type() after error detection

> But kobject_put() already checks for NULL, right? Yes. - Such an input parameter validation is performed by the function implementation. > you just submitted another batch about that in other area. I sent update suggestions because of this function property for two Linux software modules in

Re: staging: lustre: One function call less in class_register_type() after error detection

> But kobject_put() already checks for NULL, right? Yes. - Such an input parameter validation is performed by the function implementation. > you just submitted another batch about that in other area. I sent update suggestions because of this function property for two Linux software modules in

Re: [PATCH 03/12] staging: lustre: One function call less in class_register_type() after error detection

On Jul 26, 2016, at 3:02 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 26 Jul 2016 13:40:47 +0200 > > The kobject_put() function was called in a few cases by the > class_register_type() function during error handling even if the passed > data

Re: [PATCH 03/12] staging: lustre: One function call less in class_register_type() after error detection

On Jul 26, 2016, at 3:02 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Tue, 26 Jul 2016 13:40:47 +0200 > > The kobject_put() function was called in a few cases by the > class_register_type() function during error handling even if the passed > data structure element did not

[PATCH 03/12] staging: lustre: One function call less in class_register_type() after error detection

From: Markus Elfring Date: Tue, 26 Jul 2016 13:40:47 +0200 The kobject_put() function was called in a few cases by the class_register_type() function during error handling even if the passed data structure element did not contain a pointer for a valid data item.

[PATCH 03/12] staging: lustre: One function call less in class_register_type() after error detection

From: Markus Elfring Date: Tue, 26 Jul 2016 13:40:47 +0200 The kobject_put() function was called in a few cases by the class_register_type() function during error handling even if the passed data structure element did not contain a pointer for a valid data item. Adjust jump targets according to