Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-05 Thread Herbert Xu
On Wed, May 04, 2016 at 06:38:46AM -0700, Tadeusz Struk wrote: > Hi David > On 05/04/2016 02:01 AM, David Howells wrote: > > Do you want to push this via Herbert's tree? > > > > Yes, I think Herbert has some more patches queued for rc-7. > Let me also send a proper one with the signed-off tag. >

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-05 Thread Herbert Xu
On Wed, May 04, 2016 at 06:38:46AM -0700, Tadeusz Struk wrote: > Hi David > On 05/04/2016 02:01 AM, David Howells wrote: > > Do you want to push this via Herbert's tree? > > > > Yes, I think Herbert has some more patches queued for rc-7. > Let me also send a proper one with the signed-off tag. >

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-04 Thread Tadeusz Struk
Hi David On 05/04/2016 02:01 AM, David Howells wrote: > Do you want to push this via Herbert's tree? > Yes, I think Herbert has some more patches queued for rc-7. Let me also send a proper one with the signed-off tag. ---8<--- Subject: crypto: rsa - select crypto mgr dependency The pkcs1pad

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-04 Thread Tadeusz Struk
Hi David On 05/04/2016 02:01 AM, David Howells wrote: > Do you want to push this via Herbert's tree? > Yes, I think Herbert has some more patches queued for rc-7. Let me also send a proper one with the signed-off tag. ---8<--- Subject: crypto: rsa - select crypto mgr dependency The pkcs1pad

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-04 Thread David Howells
Tadeusz Struk wrote: > I think the problem is that pkcs1pad template needs CRYPTO_MANAGER, but > your configuration doesn't enable CRYPTO_MANAGER. Could you try this > please: > > diff --git a/crypto/Kconfig b/crypto/Kconfig > index 93a1fdc..1d33beb 100644 > ---

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-04 Thread David Howells
Tadeusz Struk wrote: > I think the problem is that pkcs1pad template needs CRYPTO_MANAGER, but > your configuration doesn't enable CRYPTO_MANAGER. Could you try this > please: > > diff --git a/crypto/Kconfig b/crypto/Kconfig > index 93a1fdc..1d33beb 100644 > --- a/crypto/Kconfig > +++

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
Tadeusz Struk wrote: > On 05/03/2016 07:26 PM, Jamie Heilman wrote: > >>> Alrighty, presumably relevant bits: > >>> > > > >>> > > X.509: Cert Issuer: Build time autogenerated kernel key > >>> > > X.509: Cert Subject: Build time autogenerated kernel key > >>> > > X.509: Cert Key Algo: rsa > >>> > >

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
Tadeusz Struk wrote: > On 05/03/2016 07:26 PM, Jamie Heilman wrote: > >>> Alrighty, presumably relevant bits: > >>> > > > >>> > > X.509: Cert Issuer: Build time autogenerated kernel key > >>> > > X.509: Cert Subject: Build time autogenerated kernel key > >>> > > X.509: Cert Key Algo: rsa > >>> > >

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Tadeusz Struk
On 05/03/2016 07:26 PM, Jamie Heilman wrote: >>> Alrighty, presumably relevant bits: >>> > > >>> > > X.509: Cert Issuer: Build time autogenerated kernel key >>> > > X.509: Cert Subject: Build time autogenerated kernel key >>> > > X.509: Cert Key Algo: rsa >>> > > X.509: Cert Valid period:

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Tadeusz Struk
On 05/03/2016 07:26 PM, Jamie Heilman wrote: >>> Alrighty, presumably relevant bits: >>> > > >>> > > X.509: Cert Issuer: Build time autogenerated kernel key >>> > > X.509: Cert Subject: Build time autogenerated kernel key >>> > > X.509: Cert Key Algo: rsa >>> > > X.509: Cert Valid period:

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
David Howells wrote: > (cc'ing Tadeusz as he did the pkcs1 padding function) > > Jamie Heilman wrote: > > > > > Problem loading in-kernel X.509 certificate (-2) > > > > > > ENOENT? Hmmm... The only place that is generated is in the crypto layer. > > > That

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
David Howells wrote: > (cc'ing Tadeusz as he did the pkcs1 padding function) > > Jamie Heilman wrote: > > > > > Problem loading in-kernel X.509 certificate (-2) > > > > > > ENOENT? Hmmm... The only place that is generated is in the crypto layer. > > > That suggests missing crypto of some

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
Tadeusz Struk wrote: > Could you please check if this one fixes the problem for you: > https://patchwork.kernel.org/patch/8766361/ That patch is already present by 4.6-rc5 and the problem still exists, so no, it doesn't. -- Jamie Heilman http://audible.transient.net/~jamie/

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
Tadeusz Struk wrote: > Could you please check if this one fixes the problem for you: > https://patchwork.kernel.org/patch/8766361/ That patch is already present by 4.6-rc5 and the problem still exists, so no, it doesn't. -- Jamie Heilman http://audible.transient.net/~jamie/

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Tadeusz Struk
Hi Jamie, On 05/03/2016 01:35 PM, David Howells wrote: > (cc'ing Tadeusz as he did the pkcs1 padding function) > > Jamie Heilman wrote: > Problem loading in-kernel X.509 certificate (-2) >>> >>> ENOENT? Hmmm... The only place that is generated is in the

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Tadeusz Struk
Hi Jamie, On 05/03/2016 01:35 PM, David Howells wrote: > (cc'ing Tadeusz as he did the pkcs1 padding function) > > Jamie Heilman wrote: > Problem loading in-kernel X.509 certificate (-2) >>> >>> ENOENT? Hmmm... The only place that is generated is in the crypto layer. >>> That suggests

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread David Howells
(cc'ing Tadeusz as he did the pkcs1 padding function) Jamie Heilman wrote: > > > Problem loading in-kernel X.509 certificate (-2) > > > > ENOENT? Hmmm... The only place that is generated is in the crypto layer. > > That suggests missing crypto of some sort. > >

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread David Howells
(cc'ing Tadeusz as he did the pkcs1 padding function) Jamie Heilman wrote: > > > Problem loading in-kernel X.509 certificate (-2) > > > > ENOENT? Hmmm... The only place that is generated is in the crypto layer. > > That suggests missing crypto of some sort. > > > > The attached patch

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
Herbert Xu wrote: > On Sat, Apr 30, 2016 at 08:32:48AM +, Jamie Heilman wrote: > > I usually build my kernels to require module signatures and use > > automatic signing. As of v4.6-rc1 I'm getting this on boot: > > > > Problem loading in-kernel X.509 certificate (-2) > > > > I bisected that

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
Herbert Xu wrote: > On Sat, Apr 30, 2016 at 08:32:48AM +, Jamie Heilman wrote: > > I usually build my kernels to require module signatures and use > > automatic signing. As of v4.6-rc1 I'm getting this on boot: > > > > Problem loading in-kernel X.509 certificate (-2) > > > > I bisected that

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
David Howells wrote: > > Problem loading in-kernel X.509 certificate (-2) > > ENOENT? Hmmm... The only place that is generated is in the crypto layer. > That suggests missing crypto of some sort. > > The attached patch enables some debugging in some relevant files if you can > try applying it

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Jamie Heilman
David Howells wrote: > > Problem loading in-kernel X.509 certificate (-2) > > ENOENT? Hmmm... The only place that is generated is in the crypto layer. > That suggests missing crypto of some sort. > > The attached patch enables some debugging in some relevant files if you can > try applying it

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread David Howells
> Problem loading in-kernel X.509 certificate (-2) ENOENT? Hmmm... The only place that is generated is in the crypto layer. That suggests missing crypto of some sort. The attached patch enables some debugging in some relevant files if you can try applying it to your kernel. David --- diff

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread David Howells
> Problem loading in-kernel X.509 certificate (-2) ENOENT? Hmmm... The only place that is generated is in the crypto layer. That suggests missing crypto of some sort. The attached patch enables some debugging in some relevant files if you can try applying it to your kernel. David --- diff

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread David Howells
Jamie Heilman wrote: > I usually build my kernels to require module signatures and use > automatic signing. As of v4.6-rc1 I'm getting this on boot: > > Problem loading in-kernel X.509 certificate (-2) > > I bisected that to commit

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread David Howells
Jamie Heilman wrote: > I usually build my kernels to require module signatures and use > automatic signing. As of v4.6-rc1 I'm getting this on boot: > > Problem loading in-kernel X.509 certificate (-2) > > I bisected that to commit d43de6c780a84def056afaf4fb3e66bdaa1efc00 > (akcipher: Move

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Herbert Xu
On Sat, Apr 30, 2016 at 08:32:48AM +, Jamie Heilman wrote: > I usually build my kernels to require module signatures and use > automatic signing. As of v4.6-rc1 I'm getting this on boot: > > Problem loading in-kernel X.509 certificate (-2) > > I bisected that to commit

Re: v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-05-03 Thread Herbert Xu
On Sat, Apr 30, 2016 at 08:32:48AM +, Jamie Heilman wrote: > I usually build my kernels to require module signatures and use > automatic signing. As of v4.6-rc1 I'm getting this on boot: > > Problem loading in-kernel X.509 certificate (-2) > > I bisected that to commit

v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-04-30 Thread Jamie Heilman
I usually build my kernels to require module signatures and use automatic signing. As of v4.6-rc1 I'm getting this on boot: Problem loading in-kernel X.509 certificate (-2) I bisected that to commit d43de6c780a84def056afaf4fb3e66bdaa1efc00 (akcipher: Move the RSA DER encoding check to the

v4.6-rc1 regression bisected, Problem loading in-kernel X.509 certificate (-2)

2016-04-30 Thread Jamie Heilman
I usually build my kernels to require module signatures and use automatic signing. As of v4.6-rc1 I'm getting this on boot: Problem loading in-kernel X.509 certificate (-2) I bisected that to commit d43de6c780a84def056afaf4fb3e66bdaa1efc00 (akcipher: Move the RSA DER encoding check to the