Jean Delvare wrote:
Hi all,
I am resigning from my role as hardware monitoring subsystem
(drivers/hwmon) maintainer. This is too much work for me, I do not have
the necessary bandwidth to review all the incoming patches, in
particular new drivers, in a timely manner. Patch authors have been
Rudolf Marek wrote:
Hello all,
Maybe we could try following:
1) person post the driver
2) quick review could be done critical fixes only, driver goes to -mm
3) review that goes deeper - check for interface conformity and all the
stuff which could break - fixes for non-critical stuff
4) after
Krzysztof Helt wrote:
This is comments from someone who is newbie to this list.
1a) We need a set of review guidelines / a review checklist.
Here is a start:
Maybe these guidelines can be described in more details and with
links or names of documents with more description.
Yes they
Jean Delvare wrote:
On Wed, 21 Feb 2007 15:19:44 -0500, Dave Jones wrote:
Ah, Fedora has this horror in its initscripts (which explains why I missed
it in my grep)..
# Initialize ACPI bits
if [ -d /proc/acpi ]; then
for module in /lib/modules/$unamer/kernel/drivers/acpi/* ; do
Hi all,
Please keep me CC-ed I'm not on the list. I just found out about this thread
while ivnestegating some autosuspend problems, which I will describe in another
list.
stern at rowland wrote:
Linus Torvalds wrote:
- US_FL_FIX_CAPACITY:
This is a generic SCSI issue, not a USB one,
Hi,
First of all, sorry for not reporting this earlier in the cycle, but
I only got this (new) laptop yesterday ...
With both the 3.5 kernels as well as with the 3.6 kernels, there is
quite some unhappiness being reported in dmesg about the ACPI
tables, esp. surrounding BAT0. But with 3.5 I do
Hi,
On 10/10/2012 10:31 PM, Henrik Rydberg wrote:
Hi Hans, Alan, Greg,
commit 3d97ff63f8997761f12c8fbe8082996c6eeaba1a
Author: Hans de Goede hdego...@redhat.com
Date: Wed Jul 4 09:18:03 2012 +0200
usbdevfs: Use scatter-gather lists for large bulk transfers
breaks an usb programming
?
Henrik, Very nice fix, thanks for debugging this.
Hans, any objection to me taking this?
No objections please take it, this patch is:
Acked-by: Hans de Goede hdego...@redhat.com
And stating the obvious:
CC: sta...@vger.kernel.org
To be backported to 3.6 only
Thanks Regards,
Hans
Hi,
On 10/12/2012 05:08 PM, Henrik Rydberg wrote:
Hi Alan,
Instead of introducing a new local variable, why not simply update
uurb-buffer? That's what we do elsewhere in the code.
It seemed fragile, due to these scary lines:
if (is_in uurb-buffer_length 0)
Hi,
On 10/13/2012 12:20 PM, Henrik Rydberg wrote:
The handling of large output bulk transfers is broken; the same user
page is read over and over again. Fixed with this patch.
Cc: sta...@kernel.org
Acked-by: Peter Stuge pe...@stuge.se
Acked-by: Hans de Goede hdego...@redhat.com
Acked-by: Alan
Hi All,
Please keep me CC-ed as I'm not subscribed.
Some time ago a mail about turning of the leds on usb pendrives once unmounted
by hal was send to the fedora-devel list:
https://www.redhat.com/archives/fedora-devel-list/2007-August/msg01807.html
This mail talked about echo 2 power/state
please use reply to all to keep me cc-ed, I'm not subscribed
Jiri Kosina wrote:
On Fri, 21 Sep 2007, Hans de Goede wrote:
1) Would it be possible to funtionality to the kernel to suspend a device in
such a way that it will automatically unsuspend when used again?
It is possible - USB now
Alan Stern wrote:
The correct answer is that HAL should top polling while the device is
suspended.
In kernels starting with 2.6.23-rc6, the correct way to enable
autosuspend for a USB device is basically like this:
echo D /sys/bus/usb/devices/.../power/autosuspend
echo auto
Alan Stern wrote:
On Sat, 22 Sep 2007, Hans de Goede wrote:
I'm afraid that that doesn't work for usb mass-storage devices.
Here is what I did:
1) kill hal
2) insert usb stick - led lights
3):
echo -n 1 /sys/bus/usb/devices/.../power/autosuspend
echo -n auto /sys/bus/usb/devices
Oliver Neukum wrote:
Am Freitag 21 September 2007 schrieb Jiri Kosina:
On Fri, 21 Sep 2007, Hans de Goede wrote:
Thats not what I had in mind, autosuspend doesn't work (presumably
because hal keeps polling for media change) maybe I should fix hal to
not keep polling for devices which don't
Mark M. Hoffman wrote:
Hi Justin:
(added some CCs)
* Justin Piszcz [EMAIL PROTECTED] [2007-10-14 15:30:18 -0400]:
As a regular user, I cannot see the sensors on the A-bit board, but I can
see the CPU temperature, how come I can see one but not the other?
What does which sensors say as
Jim Cromie wrote:
this patchset (on hwmon-git) re-introduces superio_locks module,
previously RFC'd here, where I 'borrowed' another thread..
http://marc.info/?l=linux-kernelm=115821759424601w=2
The module shares out slots/shared-reservations containing
a mutex, so that multiple modules can
Adrian Bunk wrote:
abituguru3_read_increment_offset() can become static.
Signed-off-by: Adrian Bunk [EMAIL PROTECTED]
Looks good, good catch.
Acked-by: Hans de Goede [EMAIL PROTECTED]
---
--- linux-2.6.23-rc1-mm1/drivers/hwmon/abituguru3.c.old 2007-07-26
08:56:33.0 +0200
Mauro,
Can you pick this one up? I don't have anything pending for gspca,
and to create a tree + pullreq for just a trivial patch is not really
efficient.
Alternatively I can put it on my TODO for when there is more gspca work,
esp. since there is not really a need to hurry with merging this.
Hi John,
Thanks for the new driver! Unfortunately the driver is still
using gspca's own/deprecated control mechanism rather then
the new v4l2-control framework which all drivers now a days
use.
And we've just finished converting all the gspca sub-drivers
to using this new control framework, and
Hi
On 02/12/2013 10:20 PM, Joe Perches wrote:
His email bounces
jwil...@redhat.com should work I think.
Note I think this may be the right call,
but asking him directly is better :)
Regards,
Hans
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a
Hi,
Applied to my gspca tree and included in my pull-req for 3.7 which I just send
out.
Thanks,
Hans
On 09/06/2012 05:24 PM, Peter Senna Tschudin wrote:
From: Peter Senna Tschudin peter.se...@gmail.com
Convert a nonnegative error return code to a negative one, as returned
elsewhere in the
Hi,
On 08/15/2012 07:13 AM, Miklos Szeredi wrote:
Suspend oopses in generic_ide_suspend() because dev_get_drvdata()
returns NULL (dev-p-driver_data == NULL) and this function is not
prepared for this.
I bisected it to 0998d063 (device-core: Ensure drvdata = NULL when no
driver is bound).
Hi,
On 08/15/2012 09:59 PM, Rafael J. Wysocki wrote:
On Wednesday, August 15, 2012, Hans de Goede wrote:
Hi,
On 08/15/2012 07:13 AM, Miklos Szeredi wrote:
Suspend oopses in generic_ide_suspend() because dev_get_drvdata()
returns NULL (dev-p-driver_data == NULL) and this function
/shark2.ko]
undefined!
Reported-by: Dadiv Rientjes rient...@google.com
Cc: Hans de Goede hdego...@redhat.com
Signed-off-by: Mauro Carvalho Chehab mche...@redhat.com
diff --git a/drivers/media/radio/Kconfig b/drivers/media/radio/Kconfig
index 8090b87..be68ec2 100644
--- a/drivers/media/radio
Hi,
On 08/09/2012 10:03 PM, David Rientjes wrote:
On Thu, 9 Aug 2012, Mauro Carvalho Chehab wrote:
Yeah, that would work as well, although the code would look uglier.
IMHO, using select/depend is better.
Agreed, I think it should be depends on LEDS_CLASS rather than select
it if there is a
Hi,
On 08/09/2012 04:42 PM, Guenter Roeck wrote:
On Thu, Aug 09, 2012 at 08:55:26PM +0800, Fengguang Wu wrote:
Hi Guenter,
This commit triggered an oops which can be fixed by the attached diff.
Should it be folded into the original one (preferable for me), or be
resent as a standalone patch?
Reported-by: Dadiv Rientjes rient...@google.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/media/radio/radio-shark2.c | 27 ---
1 file changed, 24 insertions(+), 3 deletions(-)
diff --git a/drivers/media/radio/radio-shark2.c
b/drivers/media/radio/radio
Reported-by: Dadiv Rientjes rient...@google.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/media/radio/radio-shark.c | 26 --
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/drivers/media/radio/radio-shark.c
b/drivers/media/radio/radio
Hi,
On 08/10/2012 10:15 PM, Mauro Carvalho Chehab wrote:
Em 10-08-2012 16:58, Hans de Goede escreveu:
Reported-by: Dadiv Rientjes rient...@google.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/media/radio/radio-shark.c | 26 --
1 file changed, 24
Hi All,
Here is the second revision of my patch-set to fix the build breakage when
the radio-shark* drivers are enabled and CONFIG_LED_CLASS is not enabled.
This new version introduces 2 new cleanup / preparation patches, and take
into account the remarks from Mauro's review of v1.
Regards,
Recent kernels properly clear the usb intfdata pointer when another
driver fails to bind (in the radio-shark* case the usbhid driver would try
to bind first.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/media/radio/radio-shark.c | 9 -
drivers/media/radio/radio-shark2.c
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/media/radio/radio-shark.c | 135 ++
1 file changed, 79 insertions(+), 56 deletions(-)
diff --git a/drivers/media/radio/radio-shark.c
b/drivers/media/radio/radio-shark.c
index 05e12bf..e1970bf 100644
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/media/radio/radio-shark2.c | 122 ++---
1 file changed, 73 insertions(+), 49 deletions(-)
diff --git a/drivers/media/radio/radio-shark2.c
b/drivers/media/radio/radio-shark2.c
index 217483c..7b4efdf
This removes the need for shark_led_work to take the v4l2 lock.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/media/radio/radio-shark.c | 13 ++---
drivers/media/radio/radio-shark2.c | 12 ++--
2 files changed, 4 insertions(+), 21 deletions(-)
diff --git
/media/radio/shark2.ko] undefined!
ERROR: led_classdev_unregister [drivers/media/radio/shark2.ko] undefined!
which is seen if RADIO_SHARK2 is enabled, but LEDS_CLASS is not.
Since RADIO_SHARK2 depends on NEW_LEDS and LEDS_CLASS, select both if
it is enabled.
Cc: Hans de Goede hdego...@redhat.com
Hi,
On 08/22/2012 08:57 PM, Arnd Bergmann wrote:
On Wednesday 22 August 2012, Guenter Roeck wrote:
On Wed, Aug 22, 2012 at 05:22:26PM +0200, Hans de Goede wrote:
Hi,
I've a better fix for this here:
http://git.linuxtv.org/hgoede/gspca.git/shortlog/refs/heads/media-for_v3.6
I already send
Thanks for fixing this for me!
Acked-by: Hans de Goede hdego...@redhat.com
On 07/31/2012 09:56 PM, Mauro Carvalho Chehab wrote:
Em 31-07-2012 14:22, Randy Dunlap escreveu:
drivers/built-in.o: In function `radio_tea5777_set_freq':
radio-tea5777.c:(.text+0x4d8704): undefined reference
Hi all,
On 08/16/2012 10:02 PM, Rafael J. Wysocki wrote:
On Thursday, August 16, 2012, Alan Stern wrote:
On Thu, 16 Aug 2012, Miklos Szeredi wrote:
Yes, this appears to work. Following patch fixes the suspend oops.
Thanks,
Miklos
OK
Miklos, can you please send that to Dave with a proper
Hi,
On 08/17/2012 04:27 PM, Alan Stern wrote:
On Fri, 17 Aug 2012, Alan Stern wrote:
On Fri, 17 Aug 2012, Hans de Goede wrote:
No my patch was a hack to undo the results of the commit causing
the regression in the IDE case. But Alan's approach clearly is
much better! Once we are sure
Hi,
On 07/08/2012 03:01 PM, Martin-Éric Racine wrote:
2012/6/17 Martin-Éric Racine martin-eric.rac...@iki.fi:
pe, 2012-06-15 kello 23:41 -0500, Jonathan Nieder kirjoitti:
Martin-Éric Racine wrote:
usb 1-7: new high-speed USB device number 3 using ehci_hcd
[...]
usb 1-7: New USB device
Hi,
On 07/09/2012 01:33 PM, Martin-Éric Racine wrote:
snip
Hmm, this is then likely caused by the new isoc bandwidth negotiation code
in 3.2, unfortunately the vc032x driver is one of the few gspca drivers
for which I don't have a cam to test with. Can you try to build your own
kernel from
0x21f, the real find and for
0x222, goto.
Signed-off-by: Hans de Goede [EMAIL PROTECTED]
--- linux-2.6.21.x86_64/drivers/hid/hid-input.c.hut 2007-06-12 19:26:58.0 +0200
+++ linux-2.6.21.x86_64/drivers/hid/hid-input.c 2007-06-12 19:33:32.0 +0200
@@ -598,7 +598,9 @@
case 0x21b
Hi all,
As some of you might know from my earlier post/thread about atkbd and softraw,
I'm currently working on getting keyboards with internet/easy access keys to
work painlessly / plug and play.
In order to be able to better test / develop this I've bought 2 cheap such
keyboards today,
H. Peter Anvin wrote:
Hans de Goede wrote:
In order to be able to better test / develop this I've bought 2 cheap
such keyboards today, one ps2 and one both usb and ps2 capable.
When comparing usb vs ps2 / testing the keycodes generated for the easy
access
keys on my trust (microsoft compatible
Jiri Kosina wrote:
On Tue, 12 Jun 2007, H. Peter Anvin wrote:
In PS/2 mode it reports E0 32 which gets converted to keycode 150. In
USB mode it reports E0 02 which gets converted to keycode 172.
I don't know if it's the keyboard itself that's being inconsistent, or
if it is the table in
Dmitry Torokhov wrote:
On 6/13/07, Jiri Kosina [EMAIL PROTECTED] wrote:
On Wed, 13 Jun 2007, Hans de Goede wrote:
Good to hear, so as everyone smees to agree, shall I write a (massive,
complex, intrusive) patch to fix this, or are there until now silent
parties that object?
Well, Dmitry
Note: I'm not on the please keep me CC-ed
Hi all,
First a short intro I'm a Linux enthousiast and developer. I mainly write
userspace code, but I've also written 2 kernel drivers of which one is in the
mainline and the other is waiting for review.
I've been experimenting with getting the
Vojtech Pavlik wrote:
On Thu, Jun 07, 2007 at 10:21:33AM +0200, Hans de Goede wrote:
Hans,
I've been experimenting with getting the internetkeys on several
keyboards to work. My biggest problem with this currently is the
following:
Step 1: press key, dmesg says:
atkbd.c: Unknown
Vojtech Pavlik wrote:
On Thu, Jun 07, 2007 at 04:55:23PM +0200, Hans de Goede wrote:
2) Somehow fix things so that selecting the right model in gnome/kde
keyboard-preferences will make the keys work. Like it does now with
softraw=0. Which leads me to asking what are the downsides
probably should DMI whitelist,
too.
I never said it was breaking machines, just that it was accessing
arbitrary I/O ports.
This was already discussed with the driver's author (Hans de Goede,
Cc'd) and I think we agreed on the principle, but it didn't happen yet.
This device only exists on Abit
Hi,
Thanks for the patch I've added this to my gspca tree, and this
will be included in my next pull-request to Mauro for 3.12
Regards,
Hans
On 08/05/2013 10:16 PM, Alexey Khoroshilov wrote:
If v4l2_fh_open() fails in dev_open(), gspca_dev-module left locked.
The patch adds
it all that ugly :)
I've also run various tests and it seems to work as advertised (I've not
managed to trigger the error path though AFAIK).
Acked-by: Hans de Goede hdego...@redhat.com
Sarah Sharp
drivers/usb/host/xhci-mem.c | 106 +---
1 file changed
are moved to
make them static.]
Signed-off-by: Gerd Hoffmann kra...@redhat.com
Signed-off-by: Hans de Goede hdego...@redhat.com
Signed-off-by: Sarah Sharp sarah.a.sh...@linux.intel.com
---
drivers/usb/host/xhci-mem.c | 132 +---
drivers/usb/host/xhci.h
Hi,
On 10/28/2013 01:16 PM, Geert Uytterhoeven wrote:
If SHARK_USE_LEDS=1, but CONFIG_PM=n:
drivers/media/radio/radio-shark.c:275: warning: ‘shark_resume_leds’ defined but
not used
Instead of making the #ifdef logic even more complicated (there are already
two definitions of
Hi,
On 12/06/2013 10:12 AM, Oliver Schinagl wrote:
On 06-12-13 10:01, Thomas Petazzoni wrote:
Dear Tejun Heo,
On Wed, 4 Dec 2013 08:23:12 -0500, Tejun Heo wrote:
But again, point me (for dummies ;) in the right direction and I'll
work on it with some help.
Richard and Shawn recently
The comment was claiming that we were masking all irqs, while the code actually
*un*masks all of them.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Maxime Ripard maxime.rip...@free-electrons.com
---
drivers/irqchip/irq-sun4i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
The ENMI needs to have the ack done *after* clearing the interrupt source,
otherwise we will get a spurious interrupt for each real interrupt. Switch
to the new handle_fasteoi_late_irq handler which gives us the desired behavior.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers
Hi,
On 03/12/2014 11:38 AM, Thomas Gleixner wrote:
On Wed, 12 Mar 2014, Hans de Goede wrote:
snip
And how is that different from the non threaded case?
mask()
ack() -- irq line is still active
handle() -- irq line goes inactive. So this happens
after
after having
read the vector-reg once.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/irqchip/irq-sun4i.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-sun4i.c b/drivers/irqchip/irq-sun4i.c
index a5438d8..5c25048 100644
. The eoi will be issued right before the unmask.
Signed-off-by: Hans de Goede hdego...@redhat.com
In some cases we want to do an ack right before the unmask of an irq.
A typical example of such a case is having an i2c device which uses a level
interrupt. Such devices usually have an interrupt
Hi All,
Here is v2 of my sun4i IRQ 0 / ENMI fixes fixes, changelog below:
v2:
PATCH 1/4 irq: Add handle_fasteoi_late_irq irq handler
New patch by Thomas Gleixner, adding a new irq handler with the call eoi
after the irq-handler has run its course behavior we need to avoid double
irqs on the
Hi,
On 03/12/2014 06:17 PM, Hans de Goede wrote:
From: Thomas Gleixner t...@linutronix.de
Add an irq handler for transparent controllers
Only a single callback will be issued to the chip: an -eoi() call when
the interrupt has been serviced. Same as handle_fasteoi_irq, but
we avoid
Hi,
On 03/13/2014 12:12 PM, Thomas Gleixner wrote:
On Thu, 13 Mar 2014, Maxime Ripard wrote:
On Wed, Mar 12, 2014 at 06:17:07PM +0100, Hans de Goede wrote:
The ENMI needs to have the ack done *after* clearing the interrupt source,
otherwise we will get a spurious interrupt for each real
Hi,
On 03/13/2014 03:46 PM, Thomas Gleixner wrote:
On Wed, 12 Mar 2014, Hans de Goede wrote:
The ENMI needs to have the ack done *after* clearing the interrupt source,
otherwise we will get a spurious interrupt for each real interrupt. Switch
to the new handle_fasteoi_late_irq handler which
: unmask; eoi, now it does
eoi; unmask I believe the new behavior is more correct, but, since
it is a behavior change I thought I should point this out.
I've also given this a test-run on sun4i and it works as advertised.
FWIW, this patch is:
Reviewed-by: Hans de Goede hdego...@redhat.com
Tested
The comment was claiming that we were masking all irqs, while the code actually
*un*masks all of them.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Maxime Ripard maxime.rip...@free-electrons.com
---
drivers/irqchip/irq-sun4i.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Hi All,
Here is v3 of my sun4i IRQ 0 / ENMI fixes patch-set, changelog below:
v2:
PATCH 1/4 irq: Add handle_fasteoi_late_irq irq handler
New patch by Thomas Gleixner, adding a new irq handler with the call eoi
after the irq-handler has run its course behavior we need to avoid double
irqs on the
with
handle_fasteoi_irq. This uses a separate irq_chip struct for IRQ 0,
since we only want this behavior for IRQ 0.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/irqchip/irq-sun4i.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/drivers/irqchip/irq
From: Thomas Gleixner t...@linutronix.de
This flag must be used in combination with handle_fasteoi_irq, when set
handle_fasteoi_irq will delay the calling of chip-irq_eoi until the threaded
handler has run.
Reviewed-by: Hans de Goede hdego...@redhat.com
Tested-by: Hans de Goede hdego
after having
read the vector-reg once.
Signed-off-by: Hans de Goede hdego...@redhat.com
Acked-by: Maxime Ripard maxime.rip...@free-electrons.com
---
drivers/irqchip/irq-sun4i.c | 18 --
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-sun4i.c b
Hi,
On 03/13/2014 07:03 PM, Hans de Goede wrote:
From: Thomas Gleixner t...@linutronix.de
This flag must be used in combination with handle_fasteoi_irq, when set
handle_fasteoi_irq will delay the calling of chip-irq_eoi until the threaded
handler has run.
Reviewed-by: Hans de Goede hdego
Since sun4i and sun5i are single core SOCs there is no need to mask non
oneshot IRQs, to achieve this we use handle_fasteoi_irq with a dummy eoi.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/irqchip/irq-sun4i.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion
Now that we're using handle_fasteio_irq for all interrupts, we can get rid
of having 2 irq_chip structs by making sun4i_irq_ack a nop for all irqs
except irq 0.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/irqchip/irq-sun4i.c | 27 ---
1 file changed, 4
Hi All,
So here is a second patchset for irq-sun4i.c I'm not 100% sure about these
changes. They all seem the right thing to do, but they definitely need a
good review first.
I've run various tests with this set and everything works as advertised.
Regards,
Hans
--
To unsubscribe from this
register like this, if the other bits are writeable (and the data sheet says
they are not) they should be write 1 to clear, since otherwise a read /
modify / write can race with a device raising an interrupt and then clear
the pending bit unintentionally
Signed-off-by: Hans de Goede hdego
Hi,
On 03/14/2014 12:35 PM, Thomas Gleixner wrote:
On Thu, 13 Mar 2014, Hans de Goede wrote:
Since sun4i and sun5i are single core SOCs there is no need to mask non
oneshot IRQs, to achieve this we use handle_fasteoi_irq with a dummy eoi.
This is slightly wrong :)
Even on a SMP system
Hi All,
Here is v2 of my patchset for sun4i-irq.c to use handle_fasteoi_irq for all
irqs + follow up clean-up patch.
Changes since v2:
-adjust commit msg based on Thomas' comments, and merge patch 1 and 2 as
they make more sense as 1 patch
Regards,
Hans
--
To unsubscribe from this list: send
register like this, if the other bits are writeable (and the data sheet says
they are not) they should be write 1 to clear, since otherwise a read /
modify / write can race with a device raising an interrupt and then clear
the pending bit unintentionally
Signed-off-by: Hans de Goede hdego
| IRQCHIP_EOI_IF_HANDLED will now influence
all interrupts rather then just irq 0, but that does not matter as the eoi
is now a nop anyways for all interrupts but irq 0.
Signed-off-by: Hans de Goede hdego...@redhat.com
---
drivers/irqchip/irq-sun4i.c | 18 --
1 file changed, 4 insertions(+), 14 deletions
Hi,
On 03/16/2014 03:05 PM, Tim Gardner wrote:
Gents - while reviewing some patches for arm64 in Ubuntu I noticed that
there is at least one patch sequence in linux-next that breaks the build.
156c5887948cd191417f18026aab9ce26e5a95da ahci-platform: Add support for
devices with more then
Hi,
On 03/17/2014 02:06 PM, Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Thanks for doing these clean-ups.
Acked-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
drivers/ata/ahci_sunxi.c |2 +-
1 file changed, 1 insertion
Hi,
On 03/17/2014 02:08 PM, Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz b.zolnier...@samsung.com
Thanks for doing these clean-ups.
Acked-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
---
drivers/ata/ahci_sunxi.c | 44
to me, and 3/4 are obviously a good idea. Also
all patches look good to me, so this series is:
Acked-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung RD Institute Poland
Samsung Electronics
Bartlomiej Zolnierkiewicz (4):
ata
Hi,
On 02/22/2014 09:31 AM, Maxime Ripard wrote:
snip
This should be before the registration. Otherwise, you're racy.
Nope, we only need this to get the data on sunxi_mmc_remove,
everywhere else the data is found through the mmc-host struct.
Still, if anyone makes a following patch using
Hi,
On 02/28/2014 05:37 PM, Maxime Ripard wrote:
In order for the DMA controller to work for SDRAM to devices transfers, the
AHB
clock should be reparented on the PLL6.
Force that parenting in the clock driver.
Signed-off-by: Maxime Ripard maxime.rip...@free-electrons.com
---
Hi,
Oh, good catch, thanks! Fixed in the sunxi-devel branch
in my *personal* git repo. I'll also push this to the official linux-sunxi
sunxi-devel branch later today.
Regards,
Hans
On 03/10/2014 10:49 PM, mr.nuke...@gmail.com wrote:
On Tuesday, February 11, 2014 1:34:25 PM UTC-6, David
and not on the irqchip.
Cc: Carlo Caione carlo.cai...@gmail.com
Signed-off-by: Hans de Goede hdego...@redhat.com
---
include/linux/interrupt.h | 2 ++
kernel/irq/chip.c | 4
kernel/irq/internals.h| 2 ++
kernel/irq/manage.c | 5 -
4 files changed, 12 insertions(+), 1
Hi All,
So after sleeping a night on this I'm not so sure anymore this patch
is such such a good idea. So self-nack.
Still I welcome feedback on this issue...
On 03/12/2014 12:13 AM, Hans de Goede wrote:
In some cases we want to do an ack right before the unmask of an irq.
A typical example
Hi,
On 02/18/2014 03:22 PM, Maxime Ripard wrote:
On Mon, Feb 17, 2014 at 11:02:41AM +0100, David Lanzendörfer wrote:
Signed-off-by: David Lanzendörfer david.lanzendoer...@o2s.ch
Signed-off-by: Hans de Goede hdego...@redhat.com
---
arch/arm/boot/dts/sun7i-a20-cubieboard2.dts |8
Hi,
On 02/19/2014 12:36 AM, Tejun Heo wrote:
On Mon, Feb 17, 2014 at 12:56:58PM +, Lee Jones wrote:
Cc: Tejun Heo t...@kernel.org
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones lee.jo...@linaro.org
Please consider basing it on top of Hans' refactored ahci_platform.
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hi,
On 02/19/2014 10:46 AM, Maxime Ripard wrote:
Hi Hans,
On Tue, Feb 18, 2014 at 09:49:21PM +0100, Hans de Goede wrote:
Hi,
On 02/18/2014 04:37 PM, Maxime Ripard wrote:
snip
+ +for (i = 0; i data-sg_len; i++) { + pdes
Hi,
On 02/20/2014 08:30 PM, Chris Rankin wrote:
Hi,
I have an old Logitech webcam, with USB IDs 046d:08b3. When I try to use this
camera now, I see this error in the dmesg log:
[ 2883.852464] pwc: isoc_init() submit_urb 0 failed with error -28
This error is apparently ENOSPC,
Hi,
On 02/11/2014 03:17 PM, Nishanth Menon wrote:
On 02/11/2014 07:53 AM, Roger Quadros wrote:
On 02/10/2014 08:10 PM, Roger Quadros wrote:
The OMAP EHCI controller is not compatible with the EHCI
platform HCD driver so don't claim that we are.
This fixes boot on OMAP platforms with
Hi Kefeng,
On 06/10/2014 12:07 PM, kefeng.wang wrote:
Hi Tejun,
I have a question, the hip04 and hix5hd2 soc use the old version of IP, but
they
also have a new version of IP which support FBS and NCQ, and now the new one
is
used by a new soc. How can I distinguish them, use
Hi,
On 05/07/2014 07:10 AM, Koen Kooi wrote:
Op 7 mei 2014, om 05:50 heeft Maxime Ripard
maxime.rip...@free-electrons.com het volgende geschreven:
From: Boris BREZILLON boris.brezil...@free-electrons.com
The APP4 EVB1 development boards embeds an A31, together with some NAND, one
SD
that the PHYs now have one clock per phy, while it used to be only one
for all the PHYs.
Thanks,
Maxime
Thanks for working on this.
Looks good, the entire series is:
Reviewed-by: Hans de Goede hdego...@redhat.com
Regards,
Hans
Boris BREZILLON (2):
usb: ehci-platform: add optional reset
Hi Gregory,
Gregory CLEMENT gregory.clement at free-electrons.com writes:
This patch set adds the USB support for the Armada 38x Armada
375. These SoCs use an xHCI but still need specific initialization,
mainly to setup the windows memory on the mbus. They also use the same
controller that
Hi,
On 05/07/2014 11:21 AM, Sebastian Hesselbarth wrote:
[Adding back the original Cc-List]
On 05/07/2014 10:33 AM, Hans de Goede wrote:
Hi Gregory,
Gregory CLEMENT gregory.clement at free-electrons.com writes:
This patch set adds the USB support for the Armada 38x Armada
375
Hi,
On 05/08/2014 12:00 AM, Maxime Ripard wrote:
On Wed, May 07, 2014 at 10:25:55AM -0400, Alan Stern wrote:
On Tue, 6 May 2014, Maxime Ripard wrote:
From: Boris BREZILLON boris.brezil...@free-electrons.com
On the Allwinner's A31 SoC the reset line connected to the EHCI IP has to
be
1 - 100 of 4303 matches
Mail list logo
