Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-28 Thread Jon Masters
On 01/07/2018 04:48 PM, Thomas Gleixner wrote: > +#ifdef CONFIG_GENERIC_CPU_VULNERABILITIES > + > +ssize_t __weak cpu_show_meltdown(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + return sprintf(buf, "Not affected\n"); > +} > + >

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-28 Thread Jon Masters
On 01/07/2018 04:48 PM, Thomas Gleixner wrote: > +#ifdef CONFIG_GENERIC_CPU_VULNERABILITIES > + > +ssize_t __weak cpu_show_meltdown(struct device *dev, > + struct device_attribute *attr, char *buf) > +{ > + return sprintf(buf, "Not affected\n"); > +} > + >

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-26 Thread Greg Kroah-Hartman
On Fri, Jan 26, 2018 at 05:23:31PM +0100, Andrea Arcangeli wrote: > Hello, > > On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > > +static DEVICE_ATTR(meltdown, 0444, cpu_show_meltdown, NULL); > > +static DEVICE_ATTR(spectre_v1, 0444, cpu_show_spectre_v1, NULL); > > +static

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-26 Thread Greg Kroah-Hartman
On Fri, Jan 26, 2018 at 05:23:31PM +0100, Andrea Arcangeli wrote: > Hello, > > On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > > +static DEVICE_ATTR(meltdown, 0444, cpu_show_meltdown, NULL); > > +static DEVICE_ATTR(spectre_v1, 0444, cpu_show_spectre_v1, NULL); > > +static

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-26 Thread Andrea Arcangeli
Hello, On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > +static DEVICE_ATTR(meltdown, 0444, cpu_show_meltdown, NULL); > +static DEVICE_ATTR(spectre_v1, 0444, cpu_show_spectre_v1, NULL); > +static DEVICE_ATTR(spectre_v2, 0444, cpu_show_spectre_v2, NULL); This sysfs feature

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-26 Thread Andrea Arcangeli
Hello, On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > +static DEVICE_ATTR(meltdown, 0444, cpu_show_meltdown, NULL); > +static DEVICE_ATTR(spectre_v1, 0444, cpu_show_spectre_v1, NULL); > +static DEVICE_ATTR(spectre_v2, 0444, cpu_show_spectre_v2, NULL); This sysfs feature

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-08 Thread Alexey Dobriyan
On Mon, Jan 08, 2018 at 11:54:54AM +, Alan Cox wrote: > On Mon, 8 Jan 2018 08:35:14 +0300 > Alexey Dobriyan wrote: > > > On Sun, Jan 07, 2018 at 10:50:58PM -0500, Konrad Rzeszutek Wilk wrote: > > > On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: > > >

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-08 Thread Alexey Dobriyan
On Mon, Jan 08, 2018 at 11:54:54AM +, Alan Cox wrote: > On Mon, 8 Jan 2018 08:35:14 +0300 > Alexey Dobriyan wrote: > > > On Sun, Jan 07, 2018 at 10:50:58PM -0500, Konrad Rzeszutek Wilk wrote: > > > On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: > > > > Thomas Gleixner

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-08 Thread Alan Cox
On Mon, 8 Jan 2018 08:35:14 +0300 Alexey Dobriyan wrote: > On Sun, Jan 07, 2018 at 10:50:58PM -0500, Konrad Rzeszutek Wilk wrote: > > On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: > > > Thomas Gleixner wrote: > > > > Create

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-08 Thread Alan Cox
On Mon, 8 Jan 2018 08:35:14 +0300 Alexey Dobriyan wrote: > On Sun, Jan 07, 2018 at 10:50:58PM -0500, Konrad Rzeszutek Wilk wrote: > > On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: > > > Thomas Gleixner wrote: > > > > Create /sys/devices/system/cpu/vulnerabilities folder

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-08 Thread Alexey Dobriyan
On 1/8/18, Thomas Gleixner wrote: > On Mon, 8 Jan 2018, Alexey Dobriyan wrote: >> On Sun, Jan 07, 2018 at 10:50:58PM -0500, Konrad Rzeszutek Wilk wrote: >> > On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: >> > > Thomas Gleixner wrote: >> > > > Create

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-08 Thread Alexey Dobriyan
On 1/8/18, Thomas Gleixner wrote: > On Mon, 8 Jan 2018, Alexey Dobriyan wrote: >> On Sun, Jan 07, 2018 at 10:50:58PM -0500, Konrad Rzeszutek Wilk wrote: >> > On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: >> > > Thomas Gleixner wrote: >> > > > Create

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-08 Thread Thomas Gleixner
On Mon, 8 Jan 2018, Alexey Dobriyan wrote: > On Sun, Jan 07, 2018 at 10:50:58PM -0500, Konrad Rzeszutek Wilk wrote: > > On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: > > > Thomas Gleixner wrote: > > > > Create /sys/devices/system/cpu/vulnerabilities folder and files for > > > >

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-08 Thread Thomas Gleixner
On Mon, 8 Jan 2018, Alexey Dobriyan wrote: > On Sun, Jan 07, 2018 at 10:50:58PM -0500, Konrad Rzeszutek Wilk wrote: > > On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: > > > Thomas Gleixner wrote: > > > > Create /sys/devices/system/cpu/vulnerabilities folder and files for > > > >

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Thomas Gleixner
On Mon, 8 Jan 2018, Dominik Brodowski wrote: > On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > > As the meltdown/spectre problem affects several CPU architectures, it makes > > sense to have common way to express whether a system is affected by a > > particular vulnerability or

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Thomas Gleixner
On Mon, 8 Jan 2018, Dominik Brodowski wrote: > On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > > As the meltdown/spectre problem affects several CPU architectures, it makes > > sense to have common way to express whether a system is affected by a > > particular vulnerability or

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Dominik Brodowski
On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > As the meltdown/spectre problem affects several CPU architectures, it makes > sense to have common way to express whether a system is affected by a > particular vulnerability or not. If affected the way to express the > mitigation

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Dominik Brodowski
On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > As the meltdown/spectre problem affects several CPU architectures, it makes > sense to have common way to express whether a system is affected by a > particular vulnerability or not. If affected the way to express the > mitigation

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Greg Kroah-Hartman
On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > As the meltdown/spectre problem affects several CPU architectures, it makes > sense to have common way to express whether a system is affected by a > particular vulnerability or not. If affected the way to express the > mitigation

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Greg Kroah-Hartman
On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > As the meltdown/spectre problem affects several CPU architectures, it makes > sense to have common way to express whether a system is affected by a > particular vulnerability or not. If affected the way to express the > mitigation

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Alexey Dobriyan
On Sun, Jan 07, 2018 at 10:50:58PM -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: > > Thomas Gleixner wrote: > > > Create /sys/devices/system/cpu/vulnerabilities folder and files for > > > meltdown, spectre_v1 and spectre_v2. > > > > It is

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Alexey Dobriyan
On Sun, Jan 07, 2018 at 10:50:58PM -0500, Konrad Rzeszutek Wilk wrote: > On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: > > Thomas Gleixner wrote: > > > Create /sys/devices/system/cpu/vulnerabilities folder and files for > > > meltdown, spectre_v1 and spectre_v2. > > > > It is

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Konrad Rzeszutek Wilk
On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: > Thomas Gleixner wrote: > > Create /sys/devices/system/cpu/vulnerabilities folder and files for > > meltdown, spectre_v1 and spectre_v2. > > It is called "grep -e '^bugs' /proc/cpuinfo". > > kpti is deduceable from .config and

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Konrad Rzeszutek Wilk
On Mon, Jan 08, 2018 at 01:22:04AM +0300, Alexey Dobriyan wrote: > Thomas Gleixner wrote: > > Create /sys/devices/system/cpu/vulnerabilities folder and files for > > meltdown, spectre_v1 and spectre_v2. > > It is called "grep -e '^bugs' /proc/cpuinfo". > > kpti is deduceable from .config and

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Alexey Dobriyan
Thomas Gleixner wrote: > Create /sys/devices/system/cpu/vulnerabilities folder and files for > meltdown, spectre_v1 and spectre_v2. It is called "grep -e '^bugs' /proc/cpuinfo". kpti is deduceable from .config and /proc/cmdline . If people don't know what .config they are running, god bless

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Alexey Dobriyan
Thomas Gleixner wrote: > Create /sys/devices/system/cpu/vulnerabilities folder and files for > meltdown, spectre_v1 and spectre_v2. It is called "grep -e '^bugs' /proc/cpuinfo". kpti is deduceable from .config and /proc/cmdline . If people don't know what .config they are running, god bless

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Konrad Rzeszutek Wilk
On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > As the meltdown/spectre problem affects several CPU architectures, it makes > sense to have common way to express whether a system is affected by a > particular vulnerability or not. If affected the way to express the > mitigation

Re: [patch V2 1/2] sysfs/cpu: Add vulnerability folder

2018-01-07 Thread Konrad Rzeszutek Wilk
On Sun, Jan 07, 2018 at 10:48:00PM +0100, Thomas Gleixner wrote: > As the meltdown/spectre problem affects several CPU architectures, it makes > sense to have common way to express whether a system is affected by a > particular vulnerability or not. If affected the way to express the > mitigation