Re: TPM driver breaks S3 suspend

2018-03-16 Thread Jarkko Sakkinen
On Thu, Mar 15, 2018 at 06:11:19PM +0800, Daniel Drake wrote: > Hi, > > Sorry for the delayed response. > > Unfortunately we had to return the affected machine to the vendor > (Acer Veriton X4110G) although given we have a fairly complete > understanding of the problem, perhaps we can find and

Re: TPM driver breaks S3 suspend

2018-03-16 Thread Jarkko Sakkinen
On Thu, Mar 15, 2018 at 06:11:19PM +0800, Daniel Drake wrote: > Hi, > > Sorry for the delayed response. > > Unfortunately we had to return the affected machine to the vendor > (Acer Veriton X4110G) although given we have a fairly complete > understanding of the problem, perhaps we can find and

Re: TPM driver breaks S3 suspend

2018-03-15 Thread Daniel Drake
Hi, Sorry for the delayed response. Unfortunately we had to return the affected machine to the vendor (Acer Veriton X4110G) although given we have a fairly complete understanding of the problem, perhaps we can find and push a fix anyway. Jarkko Sakkinen wrote:

Re: TPM driver breaks S3 suspend

2018-03-15 Thread Daniel Drake
Hi, Sorry for the delayed response. Unfortunately we had to return the affected machine to the vendor (Acer Veriton X4110G) although given we have a fairly complete understanding of the problem, perhaps we can find and push a fix anyway. Jarkko Sakkinen wrote: > Can you try it on

Re: TPM driver breaks S3 suspend

2018-01-02 Thread Jarkko Sakkinen
On Mon, Dec 25, 2017 at 10:43:40AM +0800, Chris Chiu wrote: > On Mon, Dec 25, 2017 at 4:33 AM, Jarkko Sakkinen > wrote: > > On Thu, Dec 21, 2017 at 04:04:56PM +0800, Chris Chiu wrote: > >> Hi, > >> We have a desktop which has S3 suspend (to RAM) problem due to

Re: TPM driver breaks S3 suspend

2018-01-02 Thread Jarkko Sakkinen
On Mon, Dec 25, 2017 at 10:43:40AM +0800, Chris Chiu wrote: > On Mon, Dec 25, 2017 at 4:33 AM, Jarkko Sakkinen > wrote: > > On Thu, Dec 21, 2017 at 04:04:56PM +0800, Chris Chiu wrote: > >> Hi, > >> We have a desktop which has S3 suspend (to RAM) problem due to > >> error messages as follows.

Re: TPM driver breaks S3 suspend

2017-12-24 Thread Chris Chiu
On Mon, Dec 25, 2017 at 4:33 AM, Jarkko Sakkinen wrote: > On Thu, Dec 21, 2017 at 04:04:56PM +0800, Chris Chiu wrote: >> Hi, >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [ 198.908282] tpm tpm0: Error (38)

Re: TPM driver breaks S3 suspend

2017-12-24 Thread Chris Chiu
On Mon, Dec 25, 2017 at 4:33 AM, Jarkko Sakkinen wrote: > On Thu, Dec 21, 2017 at 04:04:56PM +0800, Chris Chiu wrote: >> Hi, >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend

Re: TPM driver breaks S3 suspend

2017-12-24 Thread Jarkko Sakkinen
> The correct solution should be something like tpm2_auto_startup > (execute selftests, if they fail because of the missing startup > command, execute that and retry the selftests). Interestingly, > tpm1_auto_startup (same purpose as tpm2_auto_startup, but for TPM 1.2 > instead) does not use the

Re: TPM driver breaks S3 suspend

2017-12-24 Thread Jarkko Sakkinen
> The correct solution should be something like tpm2_auto_startup > (execute selftests, if they fail because of the missing startup > command, execute that and retry the selftests). Interestingly, > tpm1_auto_startup (same purpose as tpm2_auto_startup, but for TPM 1.2 > instead) does not use the

Re: TPM driver breaks S3 suspend

2017-12-24 Thread Jarkko Sakkinen
On Thu, Dec 21, 2017 at 05:43:35PM +0800, Chris Chiu wrote: > On Thu, Dec 21, 2017 at 5:22 PM, Paul Menzel wrote: > > Dear Chris, > > > > > > Thank you for bringin gup the issue. > > > >> We have a desktop which has S3 suspend (to RAM) problem due to > >> error

Re: TPM driver breaks S3 suspend

2017-12-24 Thread Jarkko Sakkinen
On Thu, Dec 21, 2017 at 05:43:35PM +0800, Chris Chiu wrote: > On Thu, Dec 21, 2017 at 5:22 PM, Paul Menzel wrote: > > Dear Chris, > > > > > > Thank you for bringin gup the issue. > > > >> We have a desktop which has S3 suspend (to RAM) problem due to > >> error messages as follows. > >> [

Re: TPM driver breaks S3 suspend

2017-12-24 Thread Jarkko Sakkinen
On Thu, Dec 21, 2017 at 04:04:56PM +0800, Chris Chiu wrote: > Hi, > We have a desktop which has S3 suspend (to RAM) problem due to > error messages as follows. > [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend > [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160

Re: TPM driver breaks S3 suspend

2017-12-24 Thread Jarkko Sakkinen
On Thu, Dec 21, 2017 at 04:04:56PM +0800, Chris Chiu wrote: > Hi, > We have a desktop which has S3 suspend (to RAM) problem due to > error messages as follows. > [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend > [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160

RE: TPM driver breaks S3 suspend

2017-12-22 Thread Alexander.Steffen
> On Thu, Dec 21, 2017 at 6:19 PM, wrote: > >> Hi, > >> We have a desktop which has S3 suspend (to RAM) problem due to > >> error messages as follows. > >> [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend > >> [ 198.908289]

RE: TPM driver breaks S3 suspend

2017-12-22 Thread Alexander.Steffen
> On Thu, Dec 21, 2017 at 6:19 PM, wrote: > >> Hi, > >> We have a desktop which has S3 suspend (to RAM) problem due to > >> error messages as follows. > >> [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend > >> [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160 >

Re: TPM driver breaks S3 suspend

2017-12-21 Thread Chris Chiu
On Thu, Dec 21, 2017 at 6:19 PM, wrote: >> Hi, >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend >> [ 198.908289] __pnp_bus_suspend():

Re: TPM driver breaks S3 suspend

2017-12-21 Thread Chris Chiu
On Thu, Dec 21, 2017 at 6:19 PM, wrote: >> Hi, >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend >> [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160 returns >> 38

Re: TPM driver breaks S3 suspend

2017-12-21 Thread Jason Gunthorpe
On Thu, Dec 21, 2017 at 10:19:09AM +, alexander.stef...@infineon.com wrote: > The correct solution should be something like tpm2_auto_startup > (execute selftests, if they fail because of the missing startup > command, execute that and retry the selftests). Interestingly, > tpm1_auto_startup

Re: TPM driver breaks S3 suspend

2017-12-21 Thread Jason Gunthorpe
On Thu, Dec 21, 2017 at 10:19:09AM +, alexander.stef...@infineon.com wrote: > The correct solution should be something like tpm2_auto_startup > (execute selftests, if they fail because of the missing startup > command, execute that and retry the selftests). Interestingly, > tpm1_auto_startup

RE: TPM driver breaks S3 suspend

2017-12-21 Thread Alexander.Steffen
> Hi, > We have a desktop which has S3 suspend (to RAM) problem due to > error messages as follows. > [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend > [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160 returns > 38 > [ 198.908293] dpm_run_callback():

RE: TPM driver breaks S3 suspend

2017-12-21 Thread Alexander.Steffen
> Hi, > We have a desktop which has S3 suspend (to RAM) problem due to > error messages as follows. > [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend > [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160 returns > 38 > [ 198.908293] dpm_run_callback():

Re: TPM driver breaks S3 suspend

2017-12-21 Thread Chris Chiu
On Thu, Dec 21, 2017 at 5:22 PM, Paul Menzel wrote: > Dear Chris, > > > Thank you for bringin gup the issue. > >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [ 198.908282] tpm tpm0: Error (38) sending savestate

Re: TPM driver breaks S3 suspend

2017-12-21 Thread Chris Chiu
On Thu, Dec 21, 2017 at 5:22 PM, Paul Menzel wrote: > Dear Chris, > > > Thank you for bringin gup the issue. > >> We have a desktop which has S3 suspend (to RAM) problem due to >> error messages as follows. >> [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend >> [

Re: TPM driver breaks S3 suspend

2017-12-21 Thread Paul Menzel
Dear Chris, Thank you for bringin gup the issue. We have a desktop which has S3 suspend (to RAM) problem due to error messages as follows. [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160 returns 38 [

Re: TPM driver breaks S3 suspend

2017-12-21 Thread Paul Menzel
Dear Chris, Thank you for bringin gup the issue. We have a desktop which has S3 suspend (to RAM) problem due to error messages as follows. [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160 returns 38 [

TPM driver breaks S3 suspend

2017-12-21 Thread Chris Chiu
Hi, We have a desktop which has S3 suspend (to RAM) problem due to error messages as follows. [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160 returns 38 [ 198.908293] dpm_run_callback(): pnp_bus_suspend+0x0/0x20

TPM driver breaks S3 suspend

2017-12-21 Thread Chris Chiu
Hi, We have a desktop which has S3 suspend (to RAM) problem due to error messages as follows. [ 198.908282] tpm tpm0: Error (38) sending savestate before suspend [ 198.908289] __pnp_bus_suspend(): tpm_pm_suspend+0x0/0x160 returns 38 [ 198.908293] dpm_run_callback(): pnp_bus_suspend+0x0/0x20