Re: [RFC 3/7] iommufd: Add iommufd_device_bind_pasid()

2023-11-07 Thread Yi Liu
On 2023/10/10 16:19, Tian, Kevin wrote: From: Liu, Yi L Sent: Monday, October 9, 2023 4:51 PM +struct iommufd_device *iommufd_device_bind_pasid(struct iommufd_ctx *ictx, +struct device *dev, +u32 pas

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-07 Thread Yunsheng Lin
On 2023/11/8 6:10, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 3:44 PM David Ahern wrote: >> >> On 11/5/23 7:44 PM, Mina Almasry wrote: >>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >>> index eeeda849115c..1c351c138a5b 100644 >>> --- a/include/linux/netdevice.h >>> +++ b/

Re: [RFC PATCH v3 04/12] netdev: support binding dma-buf to netdevice

2023-11-07 Thread Yunsheng Lin
On 2023/11/8 5:59, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 11:46 PM Yunsheng Lin wrote: >> >> On 2023/11/6 10:44, Mina Almasry wrote: >>> + >>> +void __netdev_devmem_binding_free(struct netdev_dmabuf_binding *binding) >>> +{ >>> + size_t size, avail; >>> + >>> + gen_pool_for_each_chun

Re: [RFC PATCH v3 06/12] memory-provider: dmabuf devmem memory provider

2023-11-07 Thread David Ahern
On 11/7/23 5:02 PM, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 1:02 PM Stanislav Fomichev wrote: >> >> On 11/05, Mina Almasry wrote: >>> +static inline bool page_is_page_pool_iov(const struct page *page) >>> +{ >>> + return (unsigned long)page & PP_DEVMEM; >>> +} >> >> Speaking of bpf: one t

Re: [RFC PATCH v3 06/12] memory-provider: dmabuf devmem memory provider

2023-11-07 Thread Mina Almasry
On Mon, Nov 6, 2023 at 1:02 PM Stanislav Fomichev wrote: > > On 11/05, Mina Almasry wrote: > > +static inline bool page_is_page_pool_iov(const struct page *page) > > +{ > > + return (unsigned long)page & PP_DEVMEM; > > +} > > Speaking of bpf: one thing that might be problematic with this PP_DE

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-07 Thread David Ahern
On 11/7/23 4:55 PM, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 4:03 PM Willem de Bruijn > wrote: >> >> On Mon, Nov 6, 2023 at 3:55 PM David Ahern wrote: >>> >>> On 11/6/23 4:32 PM, Stanislav Fomichev wrote: > The concise notification API returns tokens as a range for > compression, enco

Re: [RFC PATCH v3 10/12] tcp: RX path for devmem TCP

2023-11-07 Thread Mina Almasry
On Mon, Nov 6, 2023 at 4:03 PM Willem de Bruijn wrote: > > On Mon, Nov 6, 2023 at 3:55 PM David Ahern wrote: > > > > On 11/6/23 4:32 PM, Stanislav Fomichev wrote: > > >> The concise notification API returns tokens as a range for > > >> compression, encoding as two 32-bit unsigned integers start +

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-07 Thread Mina Almasry
On Tue, Nov 7, 2023 at 2:55 PM David Ahern wrote: > > On 11/7/23 3:10 PM, Mina Almasry wrote: > > On Mon, Nov 6, 2023 at 3:44 PM David Ahern wrote: > >> > >> On 11/5/23 7:44 PM, Mina Almasry wrote: > >>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > >>> index eeeda849115c..

Re: [PATCH v3 3/3] kselftest: Add new test for detecting unprobed Devicetree devices

2023-11-07 Thread Nícolas F . R . A . Prado
On Mon, Nov 06, 2023 at 11:09:44AM -0600, Rob Herring wrote: > On Thu, Nov 2, 2023 at 12:36 PM Mark Brown wrote: > > > > On Thu, Nov 02, 2023 at 07:15:58PM +0530, Naresh Kamboju wrote: > > > On Thu, 2 Nov 2023 at 17:41, Aishwarya TCV wrote: > > > > > > https://storage.kernelci.org/mainline/master

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-07 Thread David Ahern
On 11/7/23 3:10 PM, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 3:44 PM David Ahern wrote: >> >> On 11/5/23 7:44 PM, Mina Almasry wrote: >>> diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h >>> index eeeda849115c..1c351c138a5b 100644 >>> --- a/include/linux/netdevice.h >>> +++ b

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Stanislav Fomichev
On 11/07, Eric Dumazet wrote: > On Tue, Nov 7, 2023 at 10:05 PM Stanislav Fomichev wrote: > > > > > I don't understand. We require an elaborate setup to receive devmem cmsgs, > > why would some random application receive those? > > > A TCP socket can receive 'valid TCP packets' from many differ

Re: [RFC PATCH v3 05/12] netdev: netdevice devmem allocator

2023-11-07 Thread Mina Almasry
On Mon, Nov 6, 2023 at 3:44 PM David Ahern wrote: > > On 11/5/23 7:44 PM, Mina Almasry wrote: > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index eeeda849115c..1c351c138a5b 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netdevice.h > > @@ -843,6 +84

Re: [RFC PATCH v3 04/12] netdev: support binding dma-buf to netdevice

2023-11-07 Thread Mina Almasry
On Mon, Nov 6, 2023 at 11:46 PM Yunsheng Lin wrote: > > On 2023/11/6 10:44, Mina Almasry wrote: > > + > > +void __netdev_devmem_binding_free(struct netdev_dmabuf_binding *binding) > > +{ > > + size_t size, avail; > > + > > + gen_pool_for_each_chunk(binding->chunk_pool, > > +

Re: [RFC PATCH v3 07/12] page-pool: device memory support

2023-11-07 Thread Mina Almasry
On Tue, Nov 7, 2023 at 12:00 AM Yunsheng Lin wrote: > > On 2023/11/6 10:44, Mina Almasry wrote: > > Overload the LSB of struct page* to indicate that it's a page_pool_iov. > > > > Refactor mm calls on struct page* into helpers, and add page_pool_iov > > handling on those helpers. Modify callers of

Re: [PATCH v6] selftests: rtc: Fixes rtctest error handling.

2023-11-07 Thread Shuah Khan
On 10/7/23 09:43, Atul Kumar Pant wrote: On Sat, Sep 23, 2023 at 11:06:58PM +0530, Atul Kumar Pant wrote: On Thu, Aug 17, 2023 at 02:44:01PM +0530, Atul Kumar Pant wrote: Adds a check to verify if the rtc device file is valid or not and prints a useful error message if the file is not accessibl

Re: [PATCH] selftests: capabilities: namespace create varies for root and normal user

2023-11-07 Thread Shuah Khan
On 9/29/23 06:53, Swarup Laxman Kotiaklapudi wrote: Change namespace creation for root and non-root user differently in create_and_enter_ns() function Sorry for the delay on reviewing this. Can you tell me more about why this change is needed and include it in the change log. thanks, -- Shua

Re: [RFC PATCH v3 08/12] net: support non paged skb frags

2023-11-07 Thread Mina Almasry
On Tue, Nov 7, 2023 at 1:00 AM Yunsheng Lin wrote: > > On 2023/11/6 10:44, Mina Almasry wrote: > > Make skb_frag_page() fail in the case where the frag is not backed > > by a page, and fix its relevent callers to handle this case. > > > > Correctly handle skb_frag refcounting in the page_pool_iovs

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Eric Dumazet
On Tue, Nov 7, 2023 at 10:05 PM Stanislav Fomichev wrote: > > I don't understand. We require an elaborate setup to receive devmem cmsgs, > why would some random application receive those? A TCP socket can receive 'valid TCP packets' from many different sources, especially with BPF hooks... Thi

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Stanislav Fomichev
On 11/07, Mina Almasry wrote: > On Mon, Nov 6, 2023 at 5:06 PM Stanislav Fomichev wrote: > [..] > > > > > And the socket has to know this association; otherwise those tokens > > > > > are useless since they don't carry anything to identify the dmabuf. > > > > > > > > > > I think my other issue wit

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Mina Almasry
On Mon, Nov 6, 2023 at 5:06 PM Stanislav Fomichev wrote: [..] > > > > And the socket has to know this association; otherwise those tokens > > > > are useless since they don't carry anything to identify the dmabuf. > > > > > > > > I think my other issue with MSG_SOCK_DEVMEM being on recvmsg is that

Re: [PATCH] Kunit to check the longest symbol length

2023-11-07 Thread kernel test robot
Hi Sergio, kernel test robot noticed the following build warnings: [auto build test WARNING on linus/master] [also build test WARNING on v6.6 next-20231107] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Stanislav Fomichev
On 11/07, Willem de Bruijn wrote: > On Tue, Nov 7, 2023 at 12:44 PM Stanislav Fomichev wrote: > > > > On 11/06, Willem de Bruijn wrote: > > > > > > > I think my other issue with MSG_SOCK_DEVMEM being on recvmsg is > > > > > > > that > > > > > > > it somehow implies that I have an option of passin

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Willem de Bruijn
On Tue, Nov 7, 2023 at 12:44 PM Stanislav Fomichev wrote: > > On 11/06, Willem de Bruijn wrote: > > > > > > I think my other issue with MSG_SOCK_DEVMEM being on recvmsg is that > > > > > > it somehow implies that I have an option of passing or not passing > > > > > > it > > > > > > for an individ

Re: [PATCH v2 0/6] IOMMUFD: Deliver IO page faults to user space

2023-11-07 Thread Jason Gunthorpe
On Tue, Nov 07, 2023 at 08:35:10AM +, Tian, Kevin wrote: > > From: Jason Gunthorpe > > Sent: Thursday, November 2, 2023 8:48 PM > > > > On Thu, Oct 26, 2023 at 10:49:24AM +0800, Lu Baolu wrote: > > > Hi folks, > > > > > > This series implements the functionality of delivering IO page faults to

Re: [RFC PATCH v3 09/12] net: add support for skbs with unreadable frags

2023-11-07 Thread Stanislav Fomichev
On 11/06, Willem de Bruijn wrote: > > > > > I think my other issue with MSG_SOCK_DEVMEM being on recvmsg is that > > > > > it somehow implies that I have an option of passing or not passing it > > > > > for an individual system call. > > > > > If we know that we're going to use dmabuf with the sock

Re: selftests: arm64: za-fork - ZA state invalid in child

2023-11-07 Thread Naresh Kamboju
On Tue, 7 Nov 2023 at 14:39, Naresh Kamboju wrote: > > Following selftests: arm64: za-fork test failures noticed on qemu-arm64. > But the same test passed on FVP and Juno-r2. > > Are we missing something on qemu-arm64 ? > qemu-system-arm installed at version: 8.1 The Qemu version got updated from

Re: selftests: arm64: fp-stress: Unable to handle kernel paging request at virtual address

2023-11-07 Thread Naresh Kamboju
Hi Mark, On Tue, 7 Nov 2023 at 21:37, Mark Brown wrote: > > On Tue, Nov 07, 2023 at 08:14:59PM +0530, Naresh Kamboju wrote: > > On Tue, 7 Nov 2023 at 19:51, Mark Brown wrote: > > > > This all seems very surprising, especially given that AFAICT there are > > > no changes in stable-6.6-rc for arch

Re: selftests: arm64: fp-stress: Unable to handle kernel paging request at virtual address

2023-11-07 Thread Mark Brown
On Tue, Nov 07, 2023 at 08:14:59PM +0530, Naresh Kamboju wrote: > On Tue, 7 Nov 2023 at 19:51, Mark Brown wrote: > > This all seems very surprising, especially given that AFAICT there are > > no changes in stable-6.6-rc for arch/arm64. > We do not see on the mainline and next. > Is this reported

Re: [RFC PATCH v3 00/12] Device Memory TCP

2023-11-07 Thread David Ahern
Is there a policy about cc'ing moderated lists on patch sets? I thought there was, but not finding anything under Documentation/. Getting a 'needs moderator approval response' on every message is rather annoying.

Re: selftests: arm64: fp-stress: Unable to handle kernel paging request at virtual address

2023-11-07 Thread Naresh Kamboju
On Tue, 7 Nov 2023 at 19:51, Mark Brown wrote: > > On Tue, Nov 07, 2023 at 06:43:25PM +0530, Naresh Kamboju wrote: > > > # # SVE-VL-64-0: Expected > > [390439044000390480003904c0003904000139044001390480013904c0013904000239044002390480023904c0023904000339044003390480033904c003] > > <> > > You'v

Re: [PATCH v3 3/3] kselftest: Add new test for detecting unprobed Devicetree devices

2023-11-07 Thread Mark Brown
On Mon, Nov 06, 2023 at 11:09:44AM -0600, Rob Herring wrote: > A simple solution would be instead of passing the source tree root to > dt-extract-compatibles, pass 'arch', 'drivers', and 'sound' instead. > There shouldn't be compatibles anywhere else. This does seem like a reasonable quick fix th

Re: selftests: arm64: fp-stress: Unable to handle kernel paging request at virtual address

2023-11-07 Thread Mark Brown
On Tue, Nov 07, 2023 at 06:43:25PM +0530, Naresh Kamboju wrote: > # # SVE-VL-64-0: Expected > [390439044000390480003904c0003904000139044001390480013904c0013904000239044002390480023904c0023904000339044003390480033904c003] > <> You've elided *lots* of error reports from the actual test which su

Re: selftests: gpio: crash on arm64

2023-11-07 Thread Naresh Kamboju
Hi Linus and Bartosz, On Tue, 20 Jun 2023 at 22:11, Andy Shevchenko wrote: > > On Tue, Apr 11, 2023 at 10:57:28AM +0200, Linus Walleij wrote: > > On Mon, Apr 10, 2023 at 11:16 AM Naresh Kamboju > > wrote: > > ... > > > Add a pr_info() devm_gpio_chip_release() in drivers/gpio/gpiolib-devres.c > >

Re: selftests: arm64: fp-stress: Unable to handle kernel paging request at virtual address

2023-11-07 Thread Catalin Marinas
On Tue, Nov 07, 2023 at 06:32:13PM +0530, Naresh Kamboju wrote: > # <1>[ 88.160313] Unable to handle kernel paging > request at virtual address 00550f0344550f02 It would really help if the kernel dump was not wrapped. Just use git send-email to post to the list if your email client wraps the log

selftests: arm64: fp-stress: Unable to handle kernel paging request at virtual address

2023-11-07 Thread Naresh Kamboju
Following kernel oops noticed while running kselftests arm64 on qemu-arm64 on stable-rc linux-6.6.y branch. I have re-built vmlinux with the same config and ran decode stackdump. Reported-by: Linux Kernel Functional Testing Logs: # selftests: arm64: fp-stress # TAP version 13 # 1..32 # # 2

Re: selftests: arm64: fp-stress: Unable to handle kernel paging request at virtual address

2023-11-07 Thread Naresh Kamboju
My apologies ! Please ignore this email. I will re-run for arm64 and get back to you. On Tue, 7 Nov 2023 at 18:32, Naresh Kamboju wrote: > > Following kernel oops noticed while running kselftests arm64 on qemu-arm64 > on stable-rc linux-6.6.y branch. > > I have re-built vmlinux with the same con

selftests: arm64: fp-stress: Unable to handle kernel paging request at virtual address

2023-11-07 Thread Naresh Kamboju
Following kernel oops noticed while running kselftests arm64 on qemu-arm64 on stable-rc linux-6.6.y branch. I have re-built vmlinux with the same config and ran decode stackdump. Reported-by: Linux Kernel Functional Testing Logs: # selftests: arm64: fp-stress # TAP version 13 # 1..32 # # 2

[PATCH AUTOSEL 6.5 37/37] selftests/efivarfs: create-read: fix a resource leak

2023-11-07 Thread Sasha Levin
From: zhujun2 [ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ] The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/te

[PATCH AUTOSEL 4.19 5/5] selftests/efivarfs: create-read: fix a resource leak

2023-11-07 Thread Sasha Levin
From: zhujun2 [ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ] The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/te

[PATCH AUTOSEL 4.14 4/4] selftests/efivarfs: create-read: fix a resource leak

2023-11-07 Thread Sasha Levin
From: zhujun2 [ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ] The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/te

[PATCH AUTOSEL 5.4 6/6] selftests/efivarfs: create-read: fix a resource leak

2023-11-07 Thread Sasha Levin
From: zhujun2 [ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ] The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/te

[PATCH AUTOSEL 5.10 11/11] selftests/efivarfs: create-read: fix a resource leak

2023-11-07 Thread Sasha Levin
From: zhujun2 [ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ] The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/te

[PATCH AUTOSEL 5.15 20/20] selftests/efivarfs: create-read: fix a resource leak

2023-11-07 Thread Sasha Levin
From: zhujun2 [ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ] The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/te

[PATCH AUTOSEL 6.1 25/25] selftests/efivarfs: create-read: fix a resource leak

2023-11-07 Thread Sasha Levin
From: zhujun2 [ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ] The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/te

[PATCH AUTOSEL 6.6 40/40] selftests/efivarfs: create-read: fix a resource leak

2023-11-07 Thread Sasha Levin
From: zhujun2 [ Upstream commit 3f6f8a8c5e11a9b384a36df4f40f0c9a653b6975 ] The opened file should be closed in main(), otherwise resource leak will occur that this problem was discovered by code reading Signed-off-by: zhujun2 Signed-off-by: Shuah Khan Signed-off-by: Sasha Levin --- tools/te

Re: [PATCH 23/24] selftests/resctrl: Add L2 CAT test

2023-11-07 Thread Ilpo Järvinen
On Mon, 6 Nov 2023, Reinette Chatre wrote: > On 11/6/2023 9:03 AM, Reinette Chatre wrote: > > On 11/6/2023 1:53 AM, Ilpo Järvinen wrote: > >> On Fri, 3 Nov 2023, Reinette Chatre wrote: > >>> On 11/3/2023 3:39 AM, Ilpo Järvinen wrote: > On Thu, 2 Nov 2023, Reinette Chatre wrote: > > On 10/2

selftests: arm64: za-fork - ZA state invalid in child

2023-11-07 Thread Naresh Kamboju
/linux-next-master/build/next-20231107/testrun/20969859/suite/kselftest-arm64/test/arm64_za-fork/history/ - https://qa-reports.linaro.org/lkft/linux-next-master/build/next-20231107/testrun/20969859/suite/kselftest-arm64/test/arm64_check_gcr_el1_cswitch/log - https://qa-reports.linaro.org/lkft

Re: [RFC PATCH v3 08/12] net: support non paged skb frags

2023-11-07 Thread Yunsheng Lin
On 2023/11/6 10:44, Mina Almasry wrote: > Make skb_frag_page() fail in the case where the frag is not backed > by a page, and fix its relevent callers to handle this case. > > Correctly handle skb_frag refcounting in the page_pool_iovs case. > > Signed-off-by: Mina Almasry > ... > /** > *

RE: [PATCH v2 0/6] IOMMUFD: Deliver IO page faults to user space

2023-11-07 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, November 2, 2023 8:48 PM > > On Thu, Oct 26, 2023 at 10:49:24AM +0800, Lu Baolu wrote: > > Hi folks, > > > > This series implements the functionality of delivering IO page faults to > > user space through the IOMMUFD framework for nested translation. > Nes

Re: [RFC PATCH v3 07/12] page-pool: device memory support

2023-11-07 Thread Yunsheng Lin
On 2023/11/6 10:44, Mina Almasry wrote: > Overload the LSB of struct page* to indicate that it's a page_pool_iov. > > Refactor mm calls on struct page* into helpers, and add page_pool_iov > handling on those helpers. Modify callers of these mm APIs with calls to > these helpers instead. > > In ar