Re: [PATCH net-next 3/3] selftests/net: fix GRO coalesce test and add ext

2023-12-22 Thread kernel test robot
Hi Richard, kernel test robot noticed the following build warnings: [auto build test WARNING on net-next/main] url: https://github.com/intel-lab-lkp/linux/commits/Richard-Gobert/net-gso-add-HBH-extension-header-offload-support/20231222-172059 base: net-next/main patch link: https

Re: [PATCH 1/6] kunit: add parameter generation macro using description from array

2023-12-22 Thread David Gow
On Fri, 22 Dec 2023 at 23:09, Benjamin Berg wrote: > > On Fri, 2023-12-22 at 18:02 +0800, David Gow wrote: > > On Wed, 20 Dec 2023 at 23:20, wrote: > > > > > > From: Benjamin Berg > > > > > > The existing KUNIT_ARRAY_PARAM macro requires a separate function > > > to > > > get the description. Ho

Re: [PATCH] kunit: Fix some comments which were mistakenly kerneldoc

2023-12-22 Thread Randy Dunlap
On 12/22/23 20:18, David Gow wrote: > The KUnit device helpers are documented with kerneldoc in their header > file, but also have short comments over their implementation. These were > mistakenly formatted as kerneldoc comments, even though they're not > valid kerneldoc. It shouldn't cause any

[PATCH] kunit: Fix some comments which were mistakenly kerneldoc

2023-12-22 Thread David Gow
The KUnit device helpers are documented with kerneldoc in their header file, but also have short comments over their implementation. These were mistakenly formatted as kerneldoc comments, even though they're not valid kerneldoc. It shouldn't cause any serious problems -- this file isn't included in

Re: [PATCH net-next v11 00/10] net: ethernet: am65-cpsw: Add mqprio, frame preemption & coalescing

2023-12-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Tue, 19 Dec 2023 12:57:55 +0200 you wrote: > Hi, > > This series adds mqprio qdisc offload in channel mode, > Frame Preemption MAC merge support and RX/TX coalesing > for AM65 CPSW driver. > > In v11 following

Re: [PATCH] selftests/net: remove unneeded semicolon

2023-12-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Tue, 19 Dec 2023 13:54:04 +0800 you wrote: > No functional modification involved. > > ./tools/testing/selftests/net/tcp_ao/setsockopt-closed.c:121:2-3: Unneeded > semicolon. > > Reported-by: Abaci Robot > Clos

Re: [PATCH net-next 0/8] Convert net selftests to run in unique namespace (last part)

2023-12-22 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by David S. Miller : On Tue, 19 Dec 2023 17:48:48 +0800 you wrote: > Here is the last part of converting net selftests to run in unique namespace. > This part converts all left tests. After the conversion, we can run the net > sleftests

Re: [PATCH net-next] selftest/tcp-ao: Rectify out-of-tree build

2023-12-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Tue, 19 Dec 2023 02:03:05 + you wrote: > Trivial fix for out-of-tree build that I wasn't testing previously: > > 1. Create a directory for library object files, fixes: > > gcc lib/kconfig.c -Wall -O2 -g -D_GN

Re: [PATCH][next] selftests/net: Fix various spelling mistakes in TCP-AO tests

2023-12-22 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net-next.git (main) by David S. Miller : On Mon, 18 Dec 2023 13:30:22 + you wrote: > There are a handful of spelling mistakes in test messages in the > TCP-AIO selftests. Fix these. > > Signed-off-by: Colin Ian King > --- > tools/testing/selftests/ne

Re: livepatch: Move modules to selftests and add a new test

2023-12-22 Thread Kernel.org Bugbot
mricon writes via Kernel.org Bugzilla: Oh, hmm... I uncovered a bug in bugbot -- this was a different subthread that I started about b4 and supporting --dry-run-to that Marcos was looking for. Not sure how to fix bugbot yet, but I'm going to close this bug for now. Sorry about the noise, everyo

Re: livepatch: Move modules to selftests and add a new test

2023-12-22 Thread Kernel.org Bugbot
Hello: This conversation is now tracked by Kernel.org Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=218303 There is no need to do anything else, just keep talking. -- Deet-doot-dot, I am a bot. Kernel.org Bugzilla (peebz 0.1)

Re: [PATCH v4] tracing/selftests: Add ownership modification tests for eventfs

2023-12-22 Thread Shuah Khan
On 12/22/23 09:34, Steven Rostedt wrote: From: "Steven Rostedt (Google)" As there were bugs found with the ownership of eventfs dynamic file creation. Add a test to test it. It will remount tracefs with a different gid and check the ownership of the eventfs directory, as well as the system and

Re: [PATCH v3] tracing/selftests: Add ownership modification tests for eventfs

2023-12-22 Thread Steven Rostedt
On Fri, 22 Dec 2023 11:28:31 -0500 Steven Rostedt wrote: > > -- this file has executable permission set unlike the existing > > .tc files in the same directory > > Oh, I forgot to disable that. When developing a new test I make it > standalone as it's easier to test the test, and then cop

[PATCH v4] tracing/selftests: Add ownership modification tests for eventfs

2023-12-22 Thread Steven Rostedt
From: "Steven Rostedt (Google)" As there were bugs found with the ownership of eventfs dynamic file creation. Add a test to test it. It will remount tracefs with a different gid and check the ownership of the eventfs directory, as well as the system and event directories. It will also check the

Re: [PATCH v3] tracing/selftests: Add ownership modification tests for eventfs

2023-12-22 Thread Steven Rostedt
On Fri, 22 Dec 2023 09:15:42 -0700 Shuah Khan wrote: > On 12/21/23 19:16, Steven Rostedt wrote: > > > > Shuah, > > > > This patch has no dependencies. You can take it through your tree for the > > next merge window if you want. If not, I can take it. > > > Tried to apply this and seeing a co

[PATCH RFC v2 22/22] KVM: arm64: selftests: Add SME system registers to get-reg-list

2023-12-22 Thread Mark Brown
SME adds a number of new system registers, update get-reg-list to check for them based on the visibility of SME. Signed-off-by: Mark Brown --- tools/testing/selftests/kvm/aarch64/get-reg-list.c | 32 +- 1 file changed, 31 insertions(+), 1 deletion(-) diff --git a/tools/testi

[PATCH RFC v2 21/22] KVM: arm64: Provide userspace ABI for enabling SME

2023-12-22 Thread Mark Brown
Now that everything else is in place allow userspace to enable SME with a vCPU flag KVM_ARM_VCPU_SME similar to that for SVE, finalized with the same KVM_ARM_VCPU_VEC/SVE flag used for SVE. As with SVE when when SME feature is enabled we default the vector length to the highest vector length that

[PATCH RFC v2 20/22] KVM: arm64: Support SME version configuration via ID registers

2023-12-22 Thread Mark Brown
As well as a substantial set of features which provide additional instructions there are also two current extensions which add new architectural state, SME2 (which adds ZT) and FA64 (which makes FFR valid in streaming mode SVE). Allow all of these to be configured through writes to the ID registers

[PATCH RFC v2 19/22] KVM: arm64: Provide userspace access to ZT0

2023-12-22 Thread Mark Brown
ZT0 is a single register with a refreshingly fixed size 512 bit register which is like ZA accessible only when PSTATE.ZA is set. Add support for it to the userspace API, as with ZA we allow the regster to be read or written regardless of the state of PSTATE.ZA in order to simplify userspace usage.

[PATCH RFC v2 18/22] KVM: arm64: Expose ZA to userspace

2023-12-22 Thread Mark Brown
The SME ZA matrix is a single SVL*SVL register which is available when PSTATE.ZA is set. We follow the pattern established by the architecture itself and expose this to userspace as a series of horizontal SVE vectors with the streaming mode vector length, using the format already established for th

[PATCH RFC v2 17/22] KVM: arm64: Support userspace access to streaming mode SVE registers

2023-12-22 Thread Mark Brown
SME defines a new mode called streaming mode with an associated vector length which may be configured independently to the standard SVE vector length. SVE and SME also have no interdependency, it is valid to implement SME without SVE. When in streaming mode the SVE registers are accessible with the

[PATCH RFC v2 16/22] KVM: arm64: Rename sve_state_reg_region

2023-12-22 Thread Mark Brown
As for SVE we will need to pull parts of dynamically sized registers out of a block of memory for SME so we will use a similar code pattern for this. Rename the current struct sve_state_reg_region in preparation for this. Signed-off-by: Mark Brown --- arch/arm64/kvm/guest.c | 12 ++-- 1

[PATCH RFC v2 15/22] KVM: arm64: Implement SME vector length configuration

2023-12-22 Thread Mark Brown
Configuration for SME vector lengths is done using a virtual register as for SVE, hook up the implementation for the virtual register. Since we do not yet have support for any of the new SME registers stub register access functions are provided. Signed-off-by: Mark Brown --- arch/arm64/include/

[PATCH RFC v2 14/22] KVM: arm64: Manage and handle SME traps

2023-12-22 Thread Mark Brown
Now that we have support for managing SME state for KVM guests add handling for SME exceptions generated by guests. As with SVE these are routed to the generic floating point exception handlers for both VHE and nVHE, the floating point state is handled as a uniform block. Since we do not presentl

[PATCH RFC v2 13/22] KVM: arm64: Context switch SME state for guest

2023-12-22 Thread Mark Brown
If the guest has access to SME then we need to restore state for it and configure SMCR_EL2 to grant the guest access to the vector lengths that it has access to, along with FA64 and ZT0 if they were enabled. SME has three sets of registers, ZA, ZT (only present if SME2 is supported for the guest)

[PATCH RFC v2 12/22] KVM: arm64: Make SVCR a normal system register

2023-12-22 Thread Mark Brown
As a placeholder while SME guests were not supported we provide a u64 in struct kvm_vcpu_arch for the host kernel's floating point save code to use when managing KVM guests. In order to support KVM guests we will need to replace this with a proper KVM system register, do so and update the system re

[PATCH RFC v2 11/22] KVM: arm64: Make SMPRI_EL1 RES0 for SME guests

2023-12-22 Thread Mark Brown
SME priorities are entirely implementation defined and Linux currently has no support for SME priorities so we do not expose them to SME capable guests, reporting SMIDR_EL1.SMPS as 0. This means that on a host which supports SME priorities we need to trap writes to SMPRI_EL1 and make the whole regi

[PATCH RFC v2 10/22] KVM: arm64: Add support for TPIDR2_EL0

2023-12-22 Thread Mark Brown
SME adds a new user register TPIDR2_EL0, implement support for mananging this for guests. We provide system register access to it, disable traps and context switch it along with the other TPIDRs for guests with SME. Signed-off-by: Mark Brown --- arch/arm64/include/asm/kvm_host.h | 3 +++

[PATCH RFC v2 09/22] KVM: arm64: Basic SME system register descriptions

2023-12-22 Thread Mark Brown
Set up the basic system register descriptions for the more straightforward SME registers. All the registers are available from SME 1. Signed-off-by: Mark Brown --- arch/arm64/include/asm/kvm_host.h | 1 + arch/arm64/kvm/sys_regs.c | 23 +++ 2 files changed, 20 insert

[PATCH RFC v2 08/22] KVM: arm64: Rename SVE finalization constants to be more general

2023-12-22 Thread Mark Brown
Due to the overlap between SVE and SME vector length configuration created by streaming mode SVE we will finalize both at once. Rename the existing finalization to use _VEC (vector) for the naming to avoid confusion. Since this includes the userspace API we create an alias KVM_ARM_VCPU_VEC for th

[PATCH RFC v2 07/22] KVM: arm64: Define guest flags for SME

2023-12-22 Thread Mark Brown
Introduce flags for the individually selectable features in SME which add architectural state: - Base SME which adds the system registers and ZA matrix. - SME 2 which adds ZT0. - FA64 which enables access to the full floating point feature set in streaming mode, including adding FFR in strea

[PATCH RFC v2 06/22] KVM: arm64: Make FFR restore optional in __sve_restore_state()

2023-12-22 Thread Mark Brown
Since FFR is an optional feature of SME's streaming SVE mode in order to support load of guest register state when SME is implemented we need to provide callers of __sve_restore_state() access to the flag that the sve_load macro has indicating if FFR should be loaded. Do so, simply a matter of remo

[PATCH RFC v2 05/22] KVM: arm64: Document the KVM ABI for SME

2023-12-22 Thread Mark Brown
SME, the Scalable Matrix Extension, is an arm64 extension which adds support for matrix operations, with core concepts patterned after SVE. SVE introduced some complication in the ABI since it adds new vector floating point registers with runtime configurable size, the size being controlled by a p

[PATCH RFC v2 04/22] KVM: arm64: Store vector lengths in an array

2023-12-22 Thread Mark Brown
SME introduces a second vector length enumerated and configured in the same manner as for SVE. In a similar manner to the host kernel refactor to store an array of vector lengths in order to facilitate sharing code between the two. We do not fully handle vcpu_sve_pffr() since we have not yet intro

[PATCH RFC v2 03/22] KVM: arm64: Move SVE state access macros after feature test macros

2023-12-22 Thread Mark Brown
In preparation for SME support move the macros used to access SVE state after the feature test macros, we will need to test for SME subfeatures to determine the size of the SME state. Signed-off-by: Mark Brown --- arch/arm64/include/asm/kvm_host.h | 40 +++ 1

[PATCH RFC v2 02/22] arm64/fpsimd: Make SVE<->FPSIMD rewriting available to KVM

2023-12-22 Thread Mark Brown
We have routines to rewrite between FPSIMD and SVE data formats, make these visible to the KVM host code so that we can use them to present the FP register state in SVE format for guests which have SME without SVE. Signed-off-by: Mark Brown --- arch/arm64/include/asm/fpsimd.h | 5 + arch/ar

[PATCH RFC v2 01/22] KVM: arm64: Document why we trap SVE access from the host

2023-12-22 Thread Mark Brown
When we exit from a SVE guest we leave the SVE configuration in EL2 as it was for the guest, only switching back to the host configuration on next use by the host. This is perhaps a little surprising, add comments explaining what is going on both in the trap handler and when we configure the traps.

[PATCH RFC v2 00/22] KVM: arm64: Implement support for SME in non-protected guests

2023-12-22 Thread Mark Brown
This series implements support for SME use in non-protected KVM guests. Much of this is very similar to SVE, the main additional challenge that SME presents is that it introduces two new controls which change the registers seen by guests: - PSTATE.ZA enables the ZA matrix register and, if SME2 is

Re: [PATCH v3] tracing/selftests: Add ownership modification tests for eventfs

2023-12-22 Thread Shuah Khan
On 12/21/23 19:16, Steven Rostedt wrote: Shuah, This patch has no dependencies. You can take it through your tree for the next merge window if you want. If not, I can take it. Tried to apply this and seeing a couple of issues: -- missing SPDX -- this file has executable permission set unlike

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-22 Thread Shuah Khan
On 12/22/23 03:09, Johannes Berg wrote: Hi, Thanks for taking a look! On Fri, 2023-12-22 at 18:02 +0800, David Gow wrote: The two initial KUnit patches look fine, modulo a couple of minor docs issues and checkpatch warnings. I can run checkpatch (even if I can't always take it seriously), bu

Re: [PATCH 1/6] kunit: add parameter generation macro using description from array

2023-12-22 Thread Benjamin Berg
On Fri, 2023-12-22 at 18:02 +0800, David Gow wrote: > On Wed, 20 Dec 2023 at 23:20, wrote: > > > > From: Benjamin Berg > > > > The existing KUNIT_ARRAY_PARAM macro requires a separate function > > to > > get the description. However, in a lot of cases the description can > > just be copied dire

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-22 Thread David Gow
On Fri, 22 Dec 2023 at 18:09, Johannes Berg wrote: > > Hi, > > Thanks for taking a look! > > On Fri, 2023-12-22 at 18:02 +0800, David Gow wrote: > > The two initial KUnit patches look fine, modulo a couple of minor docs > > issues and checkpatch warnings. > > I can run checkpatch (even if I can't

[PATCH net-next 4/4] selftests: mptcp: diag: check CURRESTAB counters

2023-12-22 Thread Matthieu Baerts
From: Geliang Tang This patch adds a new helper chk_msk_cestab() to check the current established connections counter MIB_CURRESTAB in diag.sh. Invoke it to check the counter during the connection after every chk_msk_inuse(). Signed-off-by: Geliang Tang Reviewed-by: Matthieu Baerts Signed-off-

[PATCH net-next 3/4] selftests: mptcp: join: check CURRESTAB counters

2023-12-22 Thread Matthieu Baerts
From: Geliang Tang This patch adds a new helper chk_cestab_nr() to check the current established connections counter MIB_CURRESTAB. Set the newly added variables cestab_ns1 and cestab_ns2 to indicate how many connections are expected in ns1 or ns2. Invoke check_cestab() to check the counter duri

[PATCH net-next 2/4] mptcp: use mptcp_set_state

2023-12-22 Thread Matthieu Baerts
From: Geliang Tang This patch replaces all the 'inet_sk_state_store()' calls under net/mptcp with the new helper mptcp_set_state(). Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/460 Signed-off-by: Geliang Tang Acked-by: Paolo Abeni Reviewed-by: Matthieu Baerts Signed-off-by:

[PATCH net-next 1/4] mptcp: add CurrEstab MIB counter support

2023-12-22 Thread Matthieu Baerts
From: Geliang Tang Add a new MIB counter named MPTCP_MIB_CURRESTAB to count current established MPTCP connections, similar to TCP_MIB_CURRESTAB. This is useful to quickly list the number of MPTCP connections without having to iterate over all of them. This patch adds a new helper function mptcp_

[PATCH net-next 0/4] mptcp: add CurrEstab MIB counter

2023-12-22 Thread Matthieu Baerts
This MIB counter is similar to the one of TCP -- CurrEstab -- available in /proc/net/snmp. This is useful to quickly list the number of MPTCP connections without having to iterate over all of them. Patch 1 prepares its support by adding new helper functions: - MPTCP_DEC_STATS(): similar to MPTCP

Re: [PATCH] selftests/livepatch: fix and refactor new dmesg message code

2023-12-22 Thread Marcos Paulo de Souza
On Wed, 2023-12-20 at 10:11 -0500, Joe Lawrence wrote: > The livepatching kselftests rely on comparing expected vs. observed > dmesg output.  After each test, new dmesg entries are determined by > the > 'comm' utility comparing a saved, pre-test copy of dmesg to post-test > dmesg output. > > Alexa

Re: [PATCH net-next v2] net: ctnetlink: support filtering by zone

2023-12-22 Thread Pablo Neira Ayuso
On Mon, Nov 27, 2023 at 11:49:16AM +, Felix Huettner wrote: > conntrack zones are heavily used by tools like openvswitch to run > multiple virtual "routers" on a single machine. In this context each > conntrack zone matches to a single router, thereby preventing > overlapping IPs from becoming

Re: [PATCH v7 9/9] iommu/vt-d: Add iotlb flush for nested domain

2023-12-22 Thread Liu, Yi L
> On Dec 22, 2023, at 15:12, Tian, Kevin wrote: > >  >> >> From: Liu, Yi L >> Sent: Friday, December 22, 2023 3:02 PM >> >> On Dec 22, 2023, at 14:47, Tian, Kevin wrote: >>> >>> From: Yang, Weijiang Sent: Friday, December 22, 2023 11:56 AM > + > +xa_for_

Re: [PATCH v2] selftests: uevent: use shared makefile library

2023-12-22 Thread Antonio Terceiro
On Thu, Dec 21, 2023 at 02:44:52PM -0700, Shuah Khan wrote: > On 12/21/23 13:49, Antonio Terceiro wrote: > > This makes the uevent selftests build not write to the source tree > > unconditionally, as that breaks out of tree builds when the source tree > > is read-only. It also avoids leaving a git

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-22 Thread Johannes Berg
Hi, Thanks for taking a look! On Fri, 2023-12-22 at 18:02 +0800, David Gow wrote: > The two initial KUnit patches look fine, modulo a couple of minor docs > issues and checkpatch warnings.  I can run checkpatch (even if I can't always take it seriously), but do you want to comment more specifica

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-22 Thread David Gow
On Fri, 22 Dec 2023 at 05:47, Shuah Khan wrote: > > On 12/21/23 13:40, Johannes Berg wrote: > > On Thu, 2023-12-21 at 13:06 -0700, Shuah Khan wrote: > >> On 12/21/23 12:39, Johannes Berg wrote: > > This patchset adds a couple of helpers for kunit as well as tests for > cfg80211 and

Re: [PATCH 2/6] kunit: add a convenience allocation wrapper for SKBs

2023-12-22 Thread David Gow
On Wed, 20 Dec 2023 at 23:20, wrote: > > From: Benjamin Berg > > Add a simple convenience helper to allocate and zero fill an SKB for the > use by a kunit test. Also provide a way to free it again in case that > may be desirable. > > This simply mirrors the kunit_kmalloc API. > > Signed-off-by: B

Re: [PATCH 1/6] kunit: add parameter generation macro using description from array

2023-12-22 Thread David Gow
On Wed, 20 Dec 2023 at 23:20, wrote: > > From: Benjamin Berg > > The existing KUNIT_ARRAY_PARAM macro requires a separate function to > get the description. However, in a lot of cases the description can > just be copied directly from the array. Add a second macro that > avoids having to write a

Re: [PATCH] kunit: Protect string comparisons against NULL

2023-12-22 Thread David Gow
On Wed, 20 Dec 2023 at 23:52, Richard Fitzgerald wrote: > > Add NULL checks to KUNIT_BINARY_STR_ASSERTION() so that it will fail > cleanly if either pointer is NULL, instead of causing a NULL pointer > dereference in the strcmp(). > > A test failure could be that a string is unexpectedly NULL. Thi

Re: [PATCH v2 2/2] kunit: Add example of kunit_activate_static_stub() with pointer-to-function

2023-12-22 Thread David Gow
On Thu, 21 Dec 2023 at 18:39, Richard Fitzgerald wrote: > > Adds a variant of example_static_stub_test() that shows use of a > pointer-to-function with kunit_activate_static_stub(). > > A const pointer to the add_one() function is declared. This > pointer-to-function is passed to kunit_activate_st

Re: [PATCH v2 1/2] kunit: Allow passing function pointer to kunit_activate_static_stub()

2023-12-22 Thread David Gow
On Thu, 21 Dec 2023 at 18:39, Richard Fitzgerald wrote: > > Swap the arguments to typecheck_fn() in kunit_activate_static_stub() > so that real_fn_addr can be either the function itself or a pointer > to that function. > > This is useful to simplify redirecting static functions in a module. > Havi

Re: [PATCH] kunit: Fix NULL-dereference in kunit_init_suite() if suite->log is NULL

2023-12-22 Thread David Gow
On Mon, 18 Dec 2023 at 23:17, Richard Fitzgerald wrote: > > suite->log must be checked for NULL before passing it to > string_stream_clear(). This was done in kunit_init_test() but was missing > from kunit_init_suite(). > > Signed-off-by: Richard Fitzgerald > Fixes: 6d696c4695c5 ("kunit: add abil