Re: [PATCH v10 0/4] RISC-V: mm: Make SV48 the default address space

2024-01-19 Thread Yangyu Chen
On 1/20/24 14:49, Charlie Jenkins wrote: On Sat, Jan 20, 2024 at 02:13:14PM +0800, Yangyu Chen wrote: Thanks for your reply. On 1/20/24 09:34, Charlie Jenkins wrote: On Sun, Jan 14, 2024 at 01:26:57AM +0800, Yangyu Chen wrote: Hi, Charlie Although this patchset has been merged I still hav

Re: [PATCH v10 0/4] RISC-V: mm: Make SV48 the default address space

2024-01-19 Thread Charlie Jenkins
On Sat, Jan 20, 2024 at 02:13:14PM +0800, Yangyu Chen wrote: > Thanks for your reply. > > On 1/20/24 09:34, Charlie Jenkins wrote: > > On Sun, Jan 14, 2024 at 01:26:57AM +0800, Yangyu Chen wrote: > > > Hi, Charlie > > > > > > Although this patchset has been merged I still have some questions abou

Re: [PATCH v10 0/4] RISC-V: mm: Make SV48 the default address space

2024-01-19 Thread Yangyu Chen
Thanks for your reply. On 1/20/24 09:34, Charlie Jenkins wrote: On Sun, Jan 14, 2024 at 01:26:57AM +0800, Yangyu Chen wrote: Hi, Charlie Although this patchset has been merged I still have some questions about this patchset. Because it breaks regular mmap if address >= 38 bits on sv48 / sv57 c

Re: [PATCH v10 0/4] RISC-V: mm: Make SV48 the default address space

2024-01-19 Thread Charlie Jenkins
On Sun, Jan 14, 2024 at 01:26:57AM +0800, Yangyu Chen wrote: > Hi, Charlie > > Although this patchset has been merged I still have some questions about > this patchset. Because it breaks regular mmap if address >= 38 bits on > sv48 / sv57 capable systems like qemu. For example, If a userspace prog

Re: Re: lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y

2024-01-19 Thread Vincent Li
On Fri, Jan 19, 2024 at 3:35 PM Andrii Nakryiko wrote: > > On Fri, Jan 19, 2024 at 3:13 PM Vincent Li wrote: > > > > On Fri, Jan 19, 2024 at 2:26 PM Alexei Starovoitov > > wrote: > > > > > > On Fri, Jan 19, 2024 at 7:00 AM Vincent Li > > > wrote: > > > > > > > > On Fri, Jan 19, 2024 at 4:23 AM

Re: Re: lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y

2024-01-19 Thread Andrii Nakryiko
On Fri, Jan 19, 2024 at 3:13 PM Vincent Li wrote: > > On Fri, Jan 19, 2024 at 2:26 PM Alexei Starovoitov > wrote: > > > > On Fri, Jan 19, 2024 at 7:00 AM Vincent Li wrote: > > > > > > On Fri, Jan 19, 2024 at 4:23 AM Eduard Zingerman > > > wrote: > > > > > > > > On Fri, 2024-01-19 at 16:04 +080

Re: Re: lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y

2024-01-19 Thread Vincent Li
On Fri, Jan 19, 2024 at 2:26 PM Alexei Starovoitov wrote: > > On Fri, Jan 19, 2024 at 7:00 AM Vincent Li wrote: > > > > On Fri, Jan 19, 2024 at 4:23 AM Eduard Zingerman wrote: > > > > > > On Fri, 2024-01-19 at 16:04 +0800, Shung-Hsi Yu wrote: > > > > > > [...] > > > > > > > Final goal would be h

Re: [PATCH 1/6] arm64: Unconditionally call unflatten_device_tree()

2024-01-19 Thread Rob Herring
On Thu, Jan 18, 2024 at 03:26:43PM +, Mark Rutland wrote: > On Tue, Jan 16, 2024 at 05:27:18PM -0800, Stephen Boyd wrote: > > Quoting Mark Rutland (2024-01-16 03:51:14) > > > Hi Stephen, > > > > > > On Fri, Jan 12, 2024 at 12:07:44PM -0800, Stephen Boyd wrote: > > > > Call this function uncond

Re: [PATCH net] selftests: net: fix rps_default_mask with >32 CPUs

2024-01-19 Thread Jakub Kicinski
On Fri, 19 Jan 2024 21:07:19 + Simon Horman wrote: > AFAIK this will only remove the first incidence of a comma. > So I'm assuming this breaks with >64 CPUs. Good point! I'll use ${var//,} in v2. -- pw-bot: cr

Re: Re: lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y

2024-01-19 Thread Alexei Starovoitov
On Fri, Jan 19, 2024 at 7:00 AM Vincent Li wrote: > > On Fri, Jan 19, 2024 at 4:23 AM Eduard Zingerman wrote: > > > > On Fri, 2024-01-19 at 16:04 +0800, Shung-Hsi Yu wrote: > > > > [...] > > > > > Final goal would be have BPF selftests compiled and test against our own > > > kernel, without havin

Re: [PATCH net 2/2] selftests: forwarding: Remove executable bits from lib.sh

2024-01-19 Thread Benjamin Poirier
On 2024-01-16 09:32 +0100, Paolo Abeni wrote: > On Wed, 2024-01-10 at 09:14 -0500, Benjamin Poirier wrote: > > The lib.sh script is meant to be sourced from other scripts, not executed > > directly. Therefore, remove the executable bits from lib.sh's permissions. > > LGTM, but there is any special

Re: [PATCH net] selftests: net: fix rps_default_mask with >32 CPUs

2024-01-19 Thread Simon Horman
On Fri, Jan 19, 2024 at 07:12:48AM -0800, Jakub Kicinski wrote: > If there is more than 32 cpus the bitmask will start to contain > commas, leading to: > > ./rps_default_mask.sh: line 36: [: ,: integer expression > expected > > Remove the commas, bash doesn't interpret leading ze

[PATCH] selftests/mm: Update va_high_addr_switch.sh to check CPU for la57 flag

2024-01-19 Thread Audra Mitchell
In order for the page table level 5 to be in use, the CPU must have the setting enabled in addition to the CONFIG option. Check for the flag to be set to avoid false test failures on systems that do not have this cpu flag set. Signed-off-by: Audra Mitchell --- tools/testing/selftests/mm/va_high_

Re: [PATCH 3/3] selftests/net: Clean-up double assignment

2024-01-19 Thread Simon Horman
On Fri, Jan 19, 2024 at 06:37:46PM +, Dmitry Safonov wrote: > Hi Simon, > > On 1/19/24 16:25, Simon Horman wrote: > > On Thu, Jan 18, 2024 at 02:51:36AM +, Dmitry Safonov wrote: > >> Yeah, copy'n'paste typo. > >> > >> Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test") >

Re: [PATCH 0/3] selftests/net: A couple of typos fixes in key-management test

2024-01-19 Thread Dmitry Safonov
On 1/18/24 17:13, Jakub Kicinski wrote: > On Thu, 18 Jan 2024 17:04:25 + Dmitry Safonov wrote: >>> Somewhat unrelated to these fixes but related to the tcp_ao selftests >>> in general - could you please also add a config file so that it's >>> easy to build a minimal kernel for running the tests

Re: [PATCH 3/3] selftests/net: Clean-up double assignment

2024-01-19 Thread Dmitry Safonov
Hi Simon, On 1/19/24 16:25, Simon Horman wrote: > On Thu, Jan 18, 2024 at 02:51:36AM +, Dmitry Safonov wrote: >> Yeah, copy'n'paste typo. >> >> Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test") >> Reported-by: Nassiri, Mohammad >> Closes: >> https://lore.kernel.org/all/dm

Re: [PATCH 1/3] selftests/net: Argument value mismatch when calling verify_counters()

2024-01-19 Thread Dmitry Safonov
Hi Simon, On 1/19/24 16:26, Simon Horman wrote: > On Thu, Jan 18, 2024 at 02:51:34AM +, Dmitry Safonov wrote: >> From: Mohammad Nassiri >> >> The end_server() function only operates in the server thread >> and always takes an accept socket instead of a listen socket as >> its input argument.

Re: [PATCH v4 4/4] selftest/bpf: Test a perf bpf program that suppresses side effects.

2024-01-19 Thread Song Liu
On Thu, Jan 18, 2024 at 4:14 PM Kyle Huey wrote: > Acked-by: Song Liu with a couple nitpicks below. [...] > +int sigio_count, sigtrap_count; > + > +static void handle_sigio(int sig __always_unused) > +{ > + ++sigio_count; > +} > + > +static void handle_sigtrap(int signum __always_unused,

Re: [PATCH v2 4/4] selftests/resctrl: Add non-contiguous CBMs CAT test

2024-01-19 Thread Reinette Chatre
Hi Maciej, On 1/18/2024 11:37 PM, Maciej Wieczór-Retman wrote: > On 2024-01-18 at 09:15:46 -0800, Reinette Chatre wrote: >> On 1/18/2024 4:02 AM, Maciej Wieczór-Retman wrote: >>> On 2024-01-17 at 10:49:06 -0800, Reinette Chatre wrote: On 1/17/2024 12:26 AM, Maciej Wieczór-Retman wrote: >

Re: [PATCH 1/3] selftests/net: Argument value mismatch when calling verify_counters()

2024-01-19 Thread Simon Horman
On Thu, Jan 18, 2024 at 02:51:34AM +, Dmitry Safonov wrote: > From: Mohammad Nassiri > > The end_server() function only operates in the server thread > and always takes an accept socket instead of a listen socket as > its input argument. To align with this, invert the boolean values > used wh

Re: [PATCH 3/3] selftests/net: Clean-up double assignment

2024-01-19 Thread Simon Horman
On Thu, Jan 18, 2024 at 02:51:36AM +, Dmitry Safonov wrote: > Yeah, copy'n'paste typo. > > Fixes: 3c3ead555648 ("selftests/net: Add TCP-AO key-management test") > Reported-by: Nassiri, Mohammad > Closes: > https://lore.kernel.org/all/dm6pr04mb4202bc58a9fd5bdd24a16e8ec5...@dm6pr04mb4202.nampr

Re: [PATCH] selftests/mm: run_vmtests.sh: add missing tests

2024-01-19 Thread Ryan Roberts
Hi Muhammad, Afraid this patch is causing a regression on our CI system when it turned up in linux-next today. Additionally, 2 of thetests you have added are failing because the scripts are not exported correctly... On 16/01/2024 09:06, Muhammad Usama Anjum wrote: > Add missing tests to run_vmtes

[PATCH net] selftests: net: fix rps_default_mask with >32 CPUs

2024-01-19 Thread Jakub Kicinski
If there is more than 32 cpus the bitmask will start to contain commas, leading to: ./rps_default_mask.sh: line 36: [: ,: integer expression expected Remove the commas, bash doesn't interpret leading zeroes as oct so that should be good enough. Fixes: c12e0d5f267d ("self-tests:

Re: Re: lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y

2024-01-19 Thread Vincent Li
On Fri, Jan 19, 2024 at 4:23 AM Eduard Zingerman wrote: > > On Fri, 2024-01-19 at 16:04 +0800, Shung-Hsi Yu wrote: > > [...] > > > Final goal would be have BPF selftests compiled and test against our own > > kernel, without having to come up with a specific kernel flavor that is > > used to build

Re: 回复: [PATCH v4] selftests/move_mount_set_group:Make tests build with old libc

2024-01-19 Thread Christian Brauner
> May I take the liberty to ask why I don't see patch applied to above branch? Just wasn't pushed yet. It is now.

Re: [PATCH v6 2/3] livepatch: Move tests from lib/livepatch to selftests/livepatch

2024-01-19 Thread Alexander Gordeev
On Fri, Jan 19, 2024 at 02:11:01PM +0100, Alexander Gordeev wrote: > FWIW, for s390 part: > > Alexander Gordeev Acked-by: Alexander Gordeev

[PATCH v2] selftests: mm: fix map_hugetlb failure on 64K page size systems

2024-01-19 Thread Nico Pache
On systems with 64k page size and 512M huge page sizes, the allocation and test succeeds but errors out at the munmap. As the comment states, munmap will failure if its not HUGEPAGE aligned. This is due to the length of the mapping being 1/2 the size of the hugepage causing the munmap to not be hug

Re: [PATCH] selftests: mm: fix map_hugetlb failure on 64K page size systems

2024-01-19 Thread Nico Pache
NACK. I accidentally sent an older version of this patch. Following up with V2. On Fri, Jan 19, 2024 at 5:58 AM Nico Pache wrote: > > On systems with 64k page size and 512M huge page sizes, the allocation > and test succeeds but errors out at the munmap. As the comment states, > munmap will fail

Re: [PATCH v6 2/3] livepatch: Move tests from lib/livepatch to selftests/livepatch

2024-01-19 Thread Alexander Gordeev
On Fri, Jan 12, 2024 at 02:43:51PM -0300, Marcos Paulo de Souza wrote: Hi Marcos, ... > arch/s390/configs/debug_defconfig | 1 - > arch/s390/configs/defconfig| 1 - > lib/Kconfig.debug | 22 -- ... > diff --git a/ar

[PATCH] selftests: mm: fix map_hugetlb failure on 64K page size systems

2024-01-19 Thread Nico Pache
On systems with 64k page size and 512M huge page sizes, the allocation and test succeeds but errors out at the munmap. As the comment states, munmap will failure if its not HUGEPAGE aligned. This is due to the length of the mapping being 1/2 the size of the hugepage causing the munmap to not be hug

Re: [PATCH v4] selftests/landlock:Fix two build issues

2024-01-19 Thread Mickaël Salaün
On Mon, Jan 15, 2024 at 06:24:09PM +0800, Hu Yadi wrote: > From: "Hu.Yadi" > > Two issues comes up while building selftest/landlock on my side > (gcc 7.3/glibc-2.28/kernel-4.19) > > the first one is as to gettid > > net_test.c: In function ‘set_service’: > net_test.c:91:45: warning: implicit de

Re: [PATCH v1] landlock: Add support for KUnit tests

2024-01-19 Thread Günther Noack
Thank you, this is really nice! Only tiny style nitpicks here. Reviewed-by: G�nther Noack On Thu, Jan 18, 2024 at 12:36:32PM +0100, Micka�l Sala�n wrote: > Add the SECURITY_LANDLOCK_KUNIT_TEST option to enable KUnit tests for > Landlock. The minimal required configuration is listed in th

Re: Re: lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y

2024-01-19 Thread Eduard Zingerman
On Fri, 2024-01-19 at 16:04 +0800, Shung-Hsi Yu wrote: [...] > Final goal would be have BPF selftests compiled and test against our own > kernel, without having to come up with a specific kernel flavor that is > used to build and run the selftest. For v5.14 and v5.19-based kernel it > works: comp

Re: [RFC PATCH 0/8] cgroup/cpuset: Support RCU_NOCB on isolated partitions

2024-01-19 Thread Paul E. McKenney
On Wed, Jan 17, 2024 at 11:35:03AM -0500, Waiman Long wrote: > This patch series is based on the RFC patch from Frederic [1]. Instead > of offering RCU_NOCB as a separate option, it is now lumped into a > root-only cpuset.cpus.isolation_full flag that will enable all the > additional CPU isolation

Re: [PATCH 3/8] iommufd: Support attach/replace hwpt per pasid

2024-01-19 Thread Yi Liu
On 2024/1/18 21:38, Jason Gunthorpe wrote: On Thu, Jan 18, 2024 at 05:28:01PM +0800, Yi Liu wrote: On 2024/1/17 20:56, Jason Gunthorpe wrote: On Wed, Jan 17, 2024 at 04:24:24PM +0800, Yi Liu wrote: Above indeed makes more sense if there can be concurrent attach/replace/detach on a single pasid

[PATCH V14 7/7] Documentation: introduce amd-pstate preferrd core mode kernel command line options

2024-01-19 Thread Meng Li
amd-pstate driver support enable/disable preferred core. Default enabled on platforms supporting amd-pstate preferred core. Disable amd-pstate preferred core with "amd_prefcore=disable" added to the kernel command line. Signed-off-by: Meng Li Reviewed-by: Mario Limonciello Reviewed-by: Wyes Karn

[PATCH V14 6/7] Documentation: amd-pstate: introduce amd-pstate preferred core

2024-01-19 Thread Meng Li
Introduce amd-pstate preferred core. check preferred core state set by the kernel parameter: $ cat /sys/devices/system/cpu/amd-pstate/prefcore Tested-by: Oleksandr Natalenko Reviewed-by: Wyes Karny Reviewed-by: Mario Limonciello Reviewed-by: Huang Rui Reviewed-by: Perry Yuan Signed-off-by: M

[PATCH V14 5/7] cpufreq: amd-pstate: Update amd-pstate preferred core ranking dynamically

2024-01-19 Thread Meng Li
Preferred core rankings can be changed dynamically by the platform based on the workload and platform conditions and accounting for thermals and aging. When this occurs, cpu priority need to be set. Tested-by: Oleksandr Natalenko Reviewed-by: Mario Limonciello Reviewed-by: Wyes Karny Reviewed-b

[PATCH V14 4/7] cpufreq: Add a notification message that the highest perf has changed

2024-01-19 Thread Meng Li
BIOS issues the notify 0x85 to OS that the highest performance changed. And it will affect the ranking of the preferred core. AMD-pstate driver will set the priority of cores based on the preferred core ranking. Tested-by: Oleksandr Natalenko Reviewed-by: Mario Limonciello Reviewed-by: Huang Rui

[PATCH V14 3/7] cpufreq: amd-pstate: Enable amd-pstate preferred core supporting.

2024-01-19 Thread Meng Li
amd-pstate driver utilizes the functions and data structures provided by the ITMT architecture to enable the scheduler to favor scheduling on cores which can be get a higher frequency with lower voltage. We call it amd-pstate preferrred core. Here sched_set_itmt_core_prio() is called to set priori

[PATCH V14 2/7] ACPI: CPPC: Add get the highest performance cppc control

2024-01-19 Thread Meng Li
Add support for getting the highest performance to the generic CPPC driver. This enables downstream drivers such as amd-pstate to discover and use these values. Please refer to Chapter 8.4.6.1.1.1. Highest Performance of ACPI Specification 6.5 for details on continuous performance control of CPPC.

[PATCH V14 1/7] x86: Drop CPU_SUP_INTEL from SCHED_MC_PRIO for the expansion.

2024-01-19 Thread Meng Li
amd-pstate driver also uses SCHED_MC_PRIO, so decouple the requirement of CPU_SUP_INTEL from the dependencies to allow compilation in kernels without Intel CPU support. Tested-by: Oleksandr Natalenko Reviewed-by: Mario Limonciello Reviewed-by: Huang Rui Reviewed-by: Perry Yuan Signed-off-by: M

[PATCH V14 0/7] amd-pstate preferred core

2024-01-19 Thread Meng Li
Hi all: The core frequency is subjected to the process variation in semiconductors. Not all cores are able to reach the maximum frequency respecting the infrastructure limits. Consequently, AMD has redefined the concept of maximum frequency of a part. This means that a fraction of cores can reach

Re: Re: lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y

2024-01-19 Thread Shung-Hsi Yu
On Thu, Jan 18, 2024 at 05:58:20PM +0200, Eduard Zingerman wrote: > On Thu, 2024-01-18 at 19:58 +0800, Shung-Hsi Yu wrote: > > Compilation of lsm_cgroup.c will fail if the vmlinux.h comes from a > > kernel that does _not_ have CONFIG_PACKET=y. The reason is that the > > definition of struct sockadd