[PATCH] selftests/mm: Dont fail testsuite due to a lack of hugepages

2024-02-29 Thread Nico Pache
On systems that have large core counts and large page sizes, but limited memory, the userfaultfd test hugepage requirement is too large. Exiting early due to missing one test's requirements is a rather aggressive strategy, and prevents a lot of other tests from running. Remove the early exit to

Re: [RFC PATCH v5 13/29] KVM: selftests: TDX: Add TDX IO writes test

2024-02-29 Thread Binbin Wu
On 12/13/2023 4:46 AM, Sagi Shahar wrote: The test verifies IO writes of various sizes from the guest to the host. Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../selftests/kvm/include/x86_64/tdx/tdcall.h | 3 +

Re: [RFC PATCH v5 09/29] KVM: selftests: TDX: Add report_fatal_error test

2024-02-29 Thread Binbin Wu
On 12/13/2023 4:46 AM, Sagi Shahar wrote: The test checks report_fatal_error functionality. Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../selftests/kvm/include/x86_64/tdx/tdx.h| 6 ++- .../kvm/include/x86_64/tdx/tdx_util.h | 1

Re: [RFC PATCH v5 12/29] KVM: selftests: TDX: Add basic get_td_vmcall_info test

2024-02-29 Thread Binbin Wu
On 12/13/2023 4:46 AM, Sagi Shahar wrote: The test calls get_td_vmcall_info from the guest and verifies the expected returned values. Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../selftests/kvm/include/x86_64/tdx/tdx.h| 3 +

Re: [RFC PATCH v5 08/29] KVM: selftests: TDX: Add TDX lifecycle test

2024-02-29 Thread Yan Zhao
> diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdcall.S > b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdcall.S > new file mode 100644 > index ..df9c1ed4bb2d > --- /dev/null > +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdcall.S > @@ -0,0 +1,90 @@ > +/*

Re: [PATCH v4 15/15] KVM: riscv: selftests: Add a test for counter overflow

2024-02-29 Thread Anup Patel
On Thu, Feb 29, 2024 at 6:32 AM Atish Patra wrote: > > Add a test for verifying overflow interrupt. Currently, it relies on > overflow support on cycle/instret events. This test works for cycle/ > instret events which support sampling via hpmcounters on the platform. > There are no ISA extensions

Re: [PATCH v4 14/15] KVM: riscv: selftests: Add a test for PMU snapshot functionality

2024-02-29 Thread Anup Patel
On Thu, Feb 29, 2024 at 6:32 AM Atish Patra wrote: > > Verify PMU snapshot functionality by setting up the shared memory > correctly and reading the counter values from the shared memory > instead of the CSR. > > Signed-off-by: Atish Patra LGTM. Reviewed-by: Anup Patel Regards, Anup > --- >

Re: [PATCH v4 13/15] KVM: riscv: selftests: Add SBI PMU selftest

2024-02-29 Thread Anup Patel
On Thu, Feb 29, 2024 at 6:32 AM Atish Patra wrote: > > This test implements basic sanity test and cycle/instret event > counting tests. > > Signed-off-by: Atish Patra I feel the test should have been called sbi_pmu_test but no need to revise this series. I will take care of it at the time of

Re: [PATCH v4 12/15] KVM: riscv: selftests: Add SBI PMU extension definitions

2024-02-29 Thread Anup Patel
On Thu, Feb 29, 2024 at 6:32 AM Atish Patra wrote: > > The SBI PMU extension definition is required for upcoming SBI PMU > selftests. > > Signed-off-by: Atish Patra LGTM. Reviewed-by: Anup Patel Regards, Anup > --- > .../selftests/kvm/include/riscv/processor.h | 67 +++ >

Re: [PATCH v4 11/15] KVM: riscv: selftests: Add Sscofpmf to get-reg-list test

2024-02-29 Thread Anup Patel
On Thu, Feb 29, 2024 at 6:32 AM Atish Patra wrote: > > The KVM RISC-V allows Sscofpmf extension for Guest/VM so let us > add this extension to get-reg-list test. > > Signed-off-by: Atish Patra LGTM. Reviewed-by: Anup Patel Regards, Anup > --- >

Re: [kselftests/powerpc] Primitives test build failure with linux-next

2024-02-29 Thread Sachin Sant
> On 01-Mar-2024, at 3:48 AM, Michael Ellerman wrote: > > Sachin Sant writes: >> Powerpc specific selftests (specifically powerpc/primitives) included in >> linux-next >> tree fails to build with following error >> >> gcc -std=gnu99 -O2 -Wall -Wer

Re: [PATCH v2 0/7] tracing/probes: Support function parameter access from return probe

2024-02-29 Thread Steven Rostedt
On Thu, 29 Feb 2024 17:52:16 +0900 Masami Hiramatsu (Google) wrote: > Lol, I haven't allocate the entry data size when initialize rethook. > That's a bug. > Please try below. I'll wait to review patches 5,6,7 as I'm guessing this will have a v3? -- Steve

Re: [PATCH v2 4/7] tracing: Remove redundant #else block for BTF args from README

2024-02-29 Thread Steven Rostedt
On Mon, 26 Feb 2024 12:58:33 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Remove redundant #else block for BTF args from README message. > This is a cleanup, so no change on the message. Reviewed-by: Steven Rostedt (Google) -- Steve > > Signed-off-by:

Re: [PATCH v2 3/7] tracing/probes: cleanup: Set trace_probe::nr_args at trace_probe_init

2024-02-29 Thread Steven Rostedt
On Mon, 26 Feb 2024 12:58:23 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Instead of incrementing the trace_probe::nr_args, init it at > trace_probe_init(). > This is a cleanup, so the behavior is not changed. The change is fine, but the change log does not

Re: [PATCH v2 2/7] tracing/probes: Cleanup probe argument parser

2024-02-29 Thread Steven Rostedt
On Mon, 26 Feb 2024 12:58:13 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Cleanup traceprobe_parse_probe_arg_body() to split out the > type parser and post-processing part of fetch_insn. > This makes no functional change. > > Signed-off-by: Masami Hiramatsu

Re: [PATCH v2 1/7] tracing/fprobe-event: cleanup: Fix a wrong comment in fprobe event

2024-02-29 Thread Steven Rostedt
On Mon, 26 Feb 2024 12:58:03 +0900 "Masami Hiramatsu (Google)" wrote: > From: Masami Hiramatsu (Google) > > Despite the fprobe event, "Kretprobe" was commented. So fix it. > > Signed-off-by: Masami Hiramatsu (Google) Reviewed-by: Steven Rostedt (Google) -- Steve > --- >

Re: [PATCH v4 12/12] selftests: ip_local_port_range: use XFAIL instead of SKIP

2024-02-29 Thread Xin Long
On Thu, Feb 29, 2024 at 3:27 PM Jakub Sitnicki wrote: > > On Wed, Feb 28, 2024 at 04:59 PM -08, Jakub Kicinski wrote: > > SCTP does not support IP_LOCAL_PORT_RANGE and we know it, > > so use XFAIL instead of SKIP. > > > > Reviewed-by: Kees Cook > > Signed-off-by: Jakub Kicinski > > --- > >

Re: [kselftests/powerpc] Primitives test build failure with linux-next

2024-02-29 Thread Michael Ellerman
Andy Shevchenko writes: > On Thu, Feb 29, 2024 at 3:53 PM Sachin Sant wrote: >> >> Powerpc specific selftests (specifically powerpc/primitives) included in >> linux-next >> tree fails to build with following error >> >> gcc -std=gnu99 -O2 -Wall -Wer

Re: [kselftests/powerpc] Primitives test build failure with linux-next

2024-02-29 Thread Michael Ellerman
Sachin Sant writes: > Powerpc specific selftests (specifically powerpc/primitives) included in > linux-next > tree fails to build with following error > > gcc -std=gnu99 -O2 -Wall -Werror > -DGIT_VERSION='"next-20240229-0-gf303a3e2bcfb-dirty"' > -I/home/

Re: [PATCH v8 33/38] kselftest/arm64: Add a GCS test program built with the system libc

2024-02-29 Thread Thiago Jung Bauermann
Mark Brown writes: > [[PGP Signed Part:Undecided]] > On Thu, Feb 22, 2024 at 11:24:59PM -0300, Thiago Jung Bauermann wrote: >> Mark Brown writes: > >> > I believe based on prior discussions that you're running this using >> > shrinkwrap - can you confirm exactly how please, including things

Re: [PATCH v6] bpf: Replace bpf_lpm_trie_key 0-length array with flexible array

2024-02-29 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to bpf/bpf-next.git (master) by Daniel Borkmann : On Thu, 22 Feb 2024 07:56:15 -0800 you wrote: > Replace deprecated 0-length array in struct bpf_lpm_trie_key with > flexible array. Found with GCC 13: > > ../kernel/bpf/lpm_trie.c:207:51: warning: array subscript i

Re: [PATCH v8 33/38] kselftest/arm64: Add a GCS test program built with the system libc

2024-02-29 Thread Mark Brown
On Thu, Feb 22, 2024 at 11:24:59PM -0300, Thiago Jung Bauermann wrote: > Mark Brown writes: > > I believe based on prior discussions that you're running this using > > shrinkwrap - can you confirm exactly how please, including things like > > which firmware configuration you're using? I'm using

Re: [PATCH v2 0/3] RISC-V: mm: do not treat hint addr on mmap as the upper bound to search

2024-02-29 Thread Yangyu Chen
On 2024/3/1 03:21, Palmer Dabbelt wrote: On Thu, 29 Feb 2024 04:10:03 PST (-0800), c...@cyyself.name wrote: This patch has not been reviewed for more than a month. There is another patch that did the same fix but in another way and still has not been reviewed like this. I'm here to do a

Re: lock warnings in dev_addr_lists test

2024-02-29 Thread Guenter Roeck
On 2/29/24 00:10, David Gow wrote: On Thu, 29 Feb 2024 at 03:45, Guenter Roeck wrote: Hi, when running the dev_addr_lists unit test with lock debugging enabled, I always get the following lockdep warning. [7.031327] [7.031393] WARNING:

Re: [PATCH v4 12/12] selftests: ip_local_port_range: use XFAIL instead of SKIP

2024-02-29 Thread Jakub Sitnicki
On Wed, Feb 28, 2024 at 04:59 PM -08, Jakub Kicinski wrote: > SCTP does not support IP_LOCAL_PORT_RANGE and we know it, > so use XFAIL instead of SKIP. > > Reviewed-by: Kees Cook > Signed-off-by: Jakub Kicinski > --- > tools/testing/selftests/net/ip_local_port_range.c | 6 +++--- > 1 file

Re: [PATCH v10] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests

2024-02-29 Thread Guenter Roeck
On 2/29/24 11:38, Charlie Jenkins wrote: [ ... ] Tough one. I can't enable CONFIG_NET_TEST on nios2, parisc, and arm with THUMB enabled due to crashes or hangs in gso tests. I accept that. Downside is that I have to disable CONFIG_NET_TEST on those architectures/platforms entirely, meaning a

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Linus Torvalds
On Thu, 29 Feb 2024 at 01:23, Nikolai Kondrashov wrote: > > However, I think a better approach would be *not* to add the .gitlab-ci.yaml > file in the root of the source tree, but instead change the very same repo > setting to point to a particular entry YAML, *inside* the repo (somewhere > under

Re: [PATCH net-next 1/3] net: gro: set {inner_,}network_header in receive phase

2024-02-29 Thread Eric Dumazet
On Thu, Feb 29, 2024 at 2:22 PM Richard Gobert wrote: > > > > Eric Dumazet wrote: > > > > My intuition is that this patch has a high cost for normal GRO processing. > > SW-GRO is already a bottleneck on ARM cores in smart NICS. > > > > I would suggest instead using parameters to give both the

Re: [PATCH v10] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests

2024-02-29 Thread Charlie Jenkins
On Wed, Feb 28, 2024 at 07:40:43AM -0800, Guenter Roeck wrote: > On 2/28/24 02:15, Geert Uytterhoeven wrote: > > CC testing > > > > On Wed, Feb 28, 2024 at 8:59 AM Guenter Roeck wrote: > > > On 2/27/24 23:25, Christophe Leroy wrote: > > > [ ... ] > > > > > > > > > > This test case is supposed

Re: [PATCH v2 0/3] RISC-V: mm: do not treat hint addr on mmap as the upper bound to search

2024-02-29 Thread Palmer Dabbelt
On Thu, 29 Feb 2024 04:10:03 PST (-0800), c...@cyyself.name wrote: This patch has not been reviewed for more than a month. There is another patch that did the same fix but in another way and still has not been reviewed like this. I'm here to do a comparison of some choices briefly to let the

Re: [PATCH] cpufreq: amd-pstate: adjust min/max limit perf

2024-02-29 Thread Rafael J. Wysocki
On Tue, Feb 27, 2024 at 4:36 PM Mario Limonciello wrote: > > On 2/27/2024 01:39, Meng Li wrote: > > The min/max limit perf values calculated based on frequency > > may exceed the reasonable range of perf(highest perf, lowest perf). > > > > Signed-off-by: Meng Li > Reviewed-by: Mario Limonciello

Re: [PATCH v3 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-29 Thread T.J. Mercier
On Thu, Feb 29, 2024 at 1:21 AM Muhammad Usama Anjum wrote: > > Conform the layout, informational and status messages to TAP. No > functional change is intended other than the layout of output messages. > > Signed-off-by: Muhammad Usama Anjum > --- > Changes since v2: > - Minor improvements in

Re: [PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-29 Thread T.J. Mercier
On Thu, Feb 29, 2024 at 1:14 AM Muhammad Usama Anjum wrote: > > On 2/28/24 11:47 PM, T.J. Mercier wrote: > > On Wed, Feb 28, 2024 at 3:46 AM Muhammad Usama Anjum > > wrote: > >> > >> On 2/27/24 10:18 PM, T.J. Mercier wrote: > >>> On Tue, Feb 27, 2024 at 4:21 AM Muhammad Usama Anjum > >>> wrote:

Re: [PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-29 Thread T.J. Mercier
On Thu, Feb 29, 2024 at 1:03 AM Muhammad Usama Anjum wrote: > > On 2/28/24 11:51 PM, T.J. Mercier wrote: > > On Tue, Feb 27, 2024 at 4:21 AM Muhammad Usama Anjum > > wrote: > > > > .. > > > >> +static int numer_of_heaps(void) > >> +{ > >> + DIR *d = opendir(DEVPATH); > >> + struct

Re: [kselftests/powerpc] Primitives test build failure with linux-next

2024-02-29 Thread Andy Shevchenko
On Thu, Feb 29, 2024 at 3:53 PM Sachin Sant wrote: > > Powerpc specific selftests (specifically powerpc/primitives) included in > linux-next > tree fails to build with following error > > gcc -std=gnu99 -O2 -Wall -Werror > -DGIT_VERSION='"next-20240229-0-gf303a3e2bcfb

Re: [PATCH v5] kselftest: Add basic test for probing the rust sample modules

2024-02-29 Thread Miguel Ojeda
On Thu, Feb 29, 2024 at 4:53 PM Laura Nao wrote: > > Add new basic kselftest that checks if the available rust sample modules > can be added and removed correctly. > > Signed-off-by: Laura Nao > Reviewed-by: Sergio Gonzalez Collado > Reviewed-by: Muhammad Usama Anjum Thanks for this Laura!

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nicolas Dufresne
Hi, Le jeudi 29 février 2024 à 16:16 +0200, Nikolai Kondrashov a écrit : > On 2/29/24 2:20 PM, Guillaume Tucker wrote: > > Hello, > > > > On 28/02/2024 23:55, Helen Koike wrote: > > > Dear Kernel Community, > > > > > > This patch introduces a `.gitlab-ci` file along with a `ci/` folder, > > >

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nicolas Dufresne
Hi Tim, just replying below to one of your comment which I happen to be involved in, but I'll let others reply for the more specific comments. Le jeudi 29 février 2024 à 02:44 +, Bird, Tim a écrit : > > -Original Message- > > From: Helen Koike > > > > > > Hey all, > > > >

Re: [PATCH v4] kselftest: Add basic test for probing the rust sample modules

2024-02-29 Thread Laura Nao
Hi Shuah, On 2/28/24 01:01, Shuah Khan wrote: > Hi Laura, > > On 2/26/24 03:16, Laura Nao wrote: >> Add new basic kselftest that checks if the available rust sample modules >> can be added and removed correctly. >> >> Signed-off-by: Laura Nao >> Reviewed-by: Sergio Gonzalez Collado >>

[PATCH v5] kselftest: Add basic test for probing the rust sample modules

2024-02-29 Thread Laura Nao
Add new basic kselftest that checks if the available rust sample modules can be added and removed correctly. Signed-off-by: Laura Nao Reviewed-by: Sergio Gonzalez Collado Reviewed-by: Muhammad Usama Anjum --- Depends on: -

[PATCH AUTOSEL 5.4 1/5] selftests: tls: use exact comparison in recv_partial

2024-02-29 Thread Sasha Levin
From: Jakub Kicinski [ Upstream commit 49d821064c44cb5ffdf272905236012ea9ce50e3 ] This exact case was fail for async crypto and we weren't catching it. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Signed-off-by: David S. Miller Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.10 2/7] selftests: tls: use exact comparison in recv_partial

2024-02-29 Thread Sasha Levin
From: Jakub Kicinski [ Upstream commit 49d821064c44cb5ffdf272905236012ea9ce50e3 ] This exact case was fail for async crypto and we weren't catching it. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Signed-off-by: David S. Miller Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 5.15 2/7] selftests: tls: use exact comparison in recv_partial

2024-02-29 Thread Sasha Levin
From: Jakub Kicinski [ Upstream commit 49d821064c44cb5ffdf272905236012ea9ce50e3 ] This exact case was fail for async crypto and we weren't catching it. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Signed-off-by: David S. Miller Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.1 05/12] selftests: tls: use exact comparison in recv_partial

2024-02-29 Thread Sasha Levin
From: Jakub Kicinski [ Upstream commit 49d821064c44cb5ffdf272905236012ea9ce50e3 ] This exact case was fail for async crypto and we weren't catching it. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Signed-off-by: David S. Miller Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.6 11/21] selftests: tls: use exact comparison in recv_partial

2024-02-29 Thread Sasha Levin
From: Jakub Kicinski [ Upstream commit 49d821064c44cb5ffdf272905236012ea9ce50e3 ] This exact case was fail for async crypto and we weren't catching it. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Signed-off-by: David S. Miller Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.6 09/21] selftests: openvswitch: Add validation for the recursion test

2024-02-29 Thread Sasha Levin
From: Aaron Conole [ Upstream commit bd128f62c365504e1268dc09fcccdfb1f091e93a ] Add a test case into the netlink checks that will show the number of nested action recursions won't exceed 16. Going to 17 on a small clone call isn't enough to exhaust the stack on (most) systems, so it should be

[PATCH AUTOSEL 6.7 12/26] selftests: tls: use exact comparison in recv_partial

2024-02-29 Thread Sasha Levin
From: Jakub Kicinski [ Upstream commit 49d821064c44cb5ffdf272905236012ea9ce50e3 ] This exact case was fail for async crypto and we weren't catching it. Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman Signed-off-by: David S. Miller Signed-off-by: Sasha Levin ---

[PATCH AUTOSEL 6.7 10/26] selftests: openvswitch: Add validation for the recursion test

2024-02-29 Thread Sasha Levin
From: Aaron Conole [ Upstream commit bd128f62c365504e1268dc09fcccdfb1f091e93a ] Add a test case into the netlink checks that will show the number of nested action recursions won't exceed 16. Going to 17 on a small clone call isn't enough to exhaust the stack on (most) systems, so it should be

[PATCH net-next] selftests/tc-testing: require an up to date iproute2 for blockcast tests

2024-02-29 Thread Pedro Tammela
Add the dependsOn test check for all the mirred blockcast tests. It will prevent the issue reported by LKFT which happens when an older iproute2 is used to run the current tdc. Tests are skipped if the dependsOn check fails. Reported-by: Linux Kernel Functional Testing Signed-off-by: Pedro

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nikolai Kondrashov
On 2/29/24 2:20 PM, Guillaume Tucker wrote: Hello, On 28/02/2024 23:55, Helen Koike wrote: Dear Kernel Community, This patch introduces a `.gitlab-ci` file along with a `ci/` folder, defining a basic test pipeline triggered by code pushes to a GitLab-CI instance. This initial version includes

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nikolai Kondrashov
On 2/29/24 2:25 PM, Laurent Pinchart wrote: On Thu, Feb 29, 2024 at 02:20:41PM +0200, Laurent Pinchart wrote: On Thu, Feb 29, 2024 at 12:53:38PM +0100, Guillaume Tucker wrote: On 29/02/2024 12:41, Mark Brown wrote: On Thu, Feb 29, 2024 at 01:19:19PM +0200, Laurent Pinchart wrote: On Thu, Feb

[PATCH] tools/testing/selftests/bpf/test_tc_tunnel.sh: Prevent client connect before server bind

2024-02-29 Thread Alessandro Carminati (Red Hat)
In some systems, the netcat server can incur in delay to start listening. When this happens, the test can randomly fail in various points. This is an example error message: # ip gre none gso # encap 192.168.1.1 to 192.168.1.2, type gre, mac none len 2000 # test basic connectivity #

[kselftests/powerpc] Primitives test build failure with linux-next

2024-02-29 Thread Sachin Sant
Powerpc specific selftests (specifically powerpc/primitives) included in linux-next tree fails to build with following error gcc -std=gnu99 -O2 -Wall -Werror -DGIT_VERSION='"next-20240229-0-gf303a3e2bcfb-dirty"' -I/home/sachin/linux-next/tools/testing/selftests/powerpc/include -I/h

Re: [PATCH 2/3] selftest/powerpc: Add flags.mk to support pmu buildable

2024-02-29 Thread Sachin Sant
> On 29-Feb-2024, at 3:07 PM, Madhavan Srinivasan wrote: > > When running `make -C powerpc/pmu run_tests` from top level selftests > directory, currently this error is being reported > > make: Entering directory > '/home/maddy/linux/tools/testing/selftests/powerpc/pmu' > Makefile:40:

Re: [PATCH net-next 1/3] net: gro: set {inner_,}network_header in receive phase

2024-02-29 Thread Richard Gobert
Eric Dumazet wrote: > > My intuition is that this patch has a high cost for normal GRO processing. > SW-GRO is already a bottleneck on ARM cores in smart NICS. > > I would suggest instead using parameters to give both the nhoff and thoff > values > this would avoid many conditionals in the

Re: [RFC PATCH v5 10/29] KVM: selftests: TDX: Adding test case for TDX port IO

2024-02-29 Thread Binbin Wu
On 12/13/2023 4:46 AM, Sagi Shahar wrote: From: Erdem Aktas Verifies TDVMCALL READ and WRITE operations. Signed-off-by: Erdem Aktas Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../kvm/include/x86_64/tdx/test_util.h| 34

Re: [PATCH v3 3/8] KVM: selftests: Move setting a vCPU's entry point to a dedicated API

2024-02-29 Thread Mark Brown
On Wed, Feb 28, 2024 at 01:19:48PM -0800, Sean Christopherson wrote: > @@ -386,6 +386,7 @@ static struct kvm_vcpu *__aarch64_vcpu_add(struct kvm_vm > *vm, uint32_t vcpu_id, > aarch64_vcpu_setup(vcpu, init); > > vcpu_set_reg(vcpu, ARM64_CORE_REG(sp_el1), stack_vaddr +

Re: [RFC PATCH v5 09/29] KVM: selftests: TDX: Add report_fatal_error test

2024-02-29 Thread Binbin Wu
On 12/13/2023 4:46 AM, Sagi Shahar wrote: The test checks report_fatal_error functionality. Signed-off-by: Sagi Shahar Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji --- .../selftests/kvm/include/x86_64/tdx/tdx.h| 6 ++- .../kvm/include/x86_64/tdx/tdx_util.h | 1

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Laurent Pinchart
On Thu, Feb 29, 2024 at 02:20:41PM +0200, Laurent Pinchart wrote: > On Thu, Feb 29, 2024 at 12:53:38PM +0100, Guillaume Tucker wrote: > > On 29/02/2024 12:41, Mark Brown wrote: > > > On Thu, Feb 29, 2024 at 01:19:19PM +0200, Laurent Pinchart wrote: > > >> On Thu, Feb 29, 2024 at 01:10:16PM +0200,

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Guillaume Tucker
Hello, On 28/02/2024 23:55, Helen Koike wrote: > Dear Kernel Community, > > This patch introduces a `.gitlab-ci` file along with a `ci/` folder, defining > a > basic test pipeline triggered by code pushes to a GitLab-CI instance. This > initial version includes static checks (checkpatch and

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Laurent Pinchart
On Thu, Feb 29, 2024 at 12:53:38PM +0100, Guillaume Tucker wrote: > On 29/02/2024 12:41, Mark Brown wrote: > > On Thu, Feb 29, 2024 at 01:19:19PM +0200, Laurent Pinchart wrote: > >> On Thu, Feb 29, 2024 at 01:10:16PM +0200, Nikolai Kondrashov wrote: > > > >>> Of course. You're also welcome to

Re: [PATCH v2 0/3] RISC-V: mm: do not treat hint addr on mmap as the upper bound to search

2024-02-29 Thread Yangyu Chen
This patch has not been reviewed for more than a month. There is another patch that did the same fix but in another way and still has not been reviewed like this. I'm here to do a comparison of some choices briefly to let the maintainer understand the issues and the solutions. I think it's time

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Guillaume Tucker
On 29/02/2024 12:41, Mark Brown wrote: > On Thu, Feb 29, 2024 at 01:19:19PM +0200, Laurent Pinchart wrote: >> On Thu, Feb 29, 2024 at 01:10:16PM +0200, Nikolai Kondrashov wrote: > >>> Of course. You're also welcome to join the #kernelci channel on libera.chat. > >> Isn't that a bit pointless if

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Mark Brown
On Thu, Feb 29, 2024 at 01:19:19PM +0200, Laurent Pinchart wrote: > On Thu, Feb 29, 2024 at 01:10:16PM +0200, Nikolai Kondrashov wrote: > > Of course. You're also welcome to join the #kernelci channel on libera.chat. > Isn't that a bit pointless if it's no the main IM channel ? It *was* the

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nikolai Kondrashov
On 2/29/24 1:19 PM, Laurent Pinchart wrote: On Thu, Feb 29, 2024 at 01:10:16PM +0200, Nikolai Kondrashov wrote: On 2/29/24 11:34 AM, Laurent Pinchart wrote: On Thu, Feb 29, 2024 at 11:26:51AM +0200, Nikolai Kondrashov wrote: On 2/29/24 01:07, Laurent Pinchart wrote: On Wed, Feb 28, 2024 at

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Laurent Pinchart
On Thu, Feb 29, 2024 at 01:10:16PM +0200, Nikolai Kondrashov wrote: > On 2/29/24 11:34 AM, Laurent Pinchart wrote: > > On Thu, Feb 29, 2024 at 11:26:51AM +0200, Nikolai Kondrashov wrote: > >> On 2/29/24 01:07, Laurent Pinchart wrote: > >>> On Wed, Feb 28, 2024 at 07:55:24PM -0300, Helen Koike

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nikolai Kondrashov
On 2/29/24 11:34 AM, Laurent Pinchart wrote: On Thu, Feb 29, 2024 at 11:26:51AM +0200, Nikolai Kondrashov wrote: On 2/29/24 01:07, Laurent Pinchart wrote: On Wed, Feb 28, 2024 at 07:55:24PM -0300, Helen Koike wrote: **Join Our Slack Channel:** We have a Slack channel, #gitlab-ci, on the

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Mark Brown
On Thu, Feb 29, 2024 at 09:39:01AM +, Sakari Ailus wrote: > On Thu, Feb 29, 2024 at 01:07:25AM +0200, Laurent Pinchart wrote: > > > We have a Slack channel, #gitlab-ci, on the KernelCI Slack instance > > > https://kernelci.slack.com/ . > > > Feel free to join and contribute to the

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Laurent Pinchart
On Thu, Feb 29, 2024 at 10:56:58AM +0100, Maxime Ripard wrote: > Hi! > > On Thu, Feb 29, 2024 at 11:23:22AM +0200, Nikolai Kondrashov wrote: > > Hi everyone, > > > > On 2/29/24 11:02, Maxime Ripard wrote: > > > On Wed, Feb 28, 2024 at 07:55:25PM -0300, Helen Koike wrote: > > > > Which rating

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Maxime Ripard
Hi! On Thu, Feb 29, 2024 at 11:23:22AM +0200, Nikolai Kondrashov wrote: > Hi everyone, > > On 2/29/24 11:02, Maxime Ripard wrote: > > On Wed, Feb 28, 2024 at 07:55:25PM -0300, Helen Koike wrote: > > > Which rating would you select? > > > > 4.5 :) > > > > One thing I'm wondering here is how

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Sakari Ailus
Hi Laurent, Helen, On Thu, Feb 29, 2024 at 01:07:25AM +0200, Laurent Pinchart wrote: > > **Join Our Slack Channel:** > > We have a Slack channel, #gitlab-ci, on the KernelCI Slack instance > > https://kernelci.slack.com/ . > > Feel free to join and contribute to the conversation. The KernelCI

[PATCH 3/3] selftest/powerpc: make sub-folders buildable on it own

2024-02-29 Thread Madhavan Srinivasan
Build breaks when executing make with run_tests for sub-folders under powerpc. This is because, CFLAGS and GIT_VERSION macros are defined in Makefile of toplevel powerpc folder. make: Entering directory '/home/maddy/linux/tools/testing/selftests/powerpc/mm' gcc hugetlb_vs_thp_test.c

[PATCH 2/3] selftest/powerpc: Add flags.mk to support pmu buildable

2024-02-29 Thread Madhavan Srinivasan
When running `make -C powerpc/pmu run_tests` from top level selftests directory, currently this error is being reported make: Entering directory '/home/maddy/linux/tools/testing/selftests/powerpc/pmu' Makefile:40: warning: overriding recipe for target 'emit_tests' ../../lib.mk:111: warning:

[PATCH 1/3] selftest/powerpc: Re-order *FLAGS to follow lib.mk

2024-02-29 Thread Madhavan Srinivasan
In some powerpc/ sub-folder Makefiles, CFLAGS are defined before lib.mk include. Clean it up by re-ordering it to follow after the mk include. This is needed to support sub-folders in powerpc/ buildable on its own. Signed-off-by: Madhavan Srinivasan --- .../selftests/powerpc/benchmarks/Makefile

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Laurent Pinchart
On Thu, Feb 29, 2024 at 11:26:51AM +0200, Nikolai Kondrashov wrote: > On 2/29/24 01:07, Laurent Pinchart wrote: > > On Wed, Feb 28, 2024 at 07:55:24PM -0300, Helen Koike wrote: > >> **Join Our Slack Channel:** > >> We have a Slack channel, #gitlab-ci, on the KernelCI Slack instance > >>

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nikolai Kondrashov
On 2/29/24 01:07, Laurent Pinchart wrote: On Wed, Feb 28, 2024 at 07:55:24PM -0300, Helen Koike wrote: **Join Our Slack Channel:** We have a Slack channel, #gitlab-ci, on the KernelCI Slack instance https://kernelci.slack.com/ . Feel free to join and contribute to the conversation. The

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Nikolai Kondrashov
Hi everyone, On 2/29/24 11:02, Maxime Ripard wrote: On Wed, Feb 28, 2024 at 07:55:25PM -0300, Helen Koike wrote: Which rating would you select? 4.5 :) One thing I'm wondering here is how we're going to cope with the different requirements each user / framework has. Like, Linus probably

[PATCH v3 2/2] selftests: dmabuf-heap: add config file for the test

2024-02-29 Thread Muhammad Usama Anjum
The config fragment enlists all the config options needed for the test. This config is merged into the kernel's config on which this test is run. Reviewed-by: T.J. Mercier Signed-off-by: Muhammad Usama Anjum --- Changes since v1: - Add reviewed-by tag ---

[PATCH v3 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-29 Thread Muhammad Usama Anjum
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Signed-off-by: Muhammad Usama Anjum --- Changes since v2: - Minor improvements in test_alloc_zeroed() results Changes since v1: - Update some more error

Re: [PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-29 Thread Muhammad Usama Anjum
On 2/28/24 11:47 PM, T.J. Mercier wrote: > On Wed, Feb 28, 2024 at 3:46 AM Muhammad Usama Anjum > wrote: >> >> On 2/27/24 10:18 PM, T.J. Mercier wrote: >>> On Tue, Feb 27, 2024 at 4:21 AM Muhammad Usama Anjum >>> wrote: Conform the layout, informational and status messages to TAP. No

Re: [PATCH v3 0/2] selftests/vDSO: Fix errors on LoongArch

2024-02-29 Thread Tiezhu Yang
Hi Shuah and Andrew, On 01/29/2024 04:27 PM, Tiezhu Yang wrote: On 12/27/2023 03:55 PM, Tiezhu Yang wrote: + Andrew Morton + Mark Brown On 12/13/2023 09:22 AM, Tiezhu Yang wrote: v3: Rebase on the next branch of linux-kselftest.git, modify the patch title and update the commit

Re: lock warnings in dev_addr_lists test

2024-02-29 Thread Guenter Roeck
On 2/29/24 00:10, David Gow wrote: On Thu, 29 Feb 2024 at 03:45, Guenter Roeck wrote: Hi, when running the dev_addr_lists unit test with lock debugging enabled, I always get the following lockdep warning. [7.031327] [7.031393] WARNING:

Re: [PATCH v2 1/2] selftests/dmabuf-heap: conform test to TAP format output

2024-02-29 Thread Muhammad Usama Anjum
On 2/28/24 11:51 PM, T.J. Mercier wrote: > On Tue, Feb 27, 2024 at 4:21 AM Muhammad Usama Anjum > wrote: > > .. > >> +static int numer_of_heaps(void) >> +{ >> + DIR *d = opendir(DEVPATH); >> + struct dirent *dir; >> + int heaps = 0; >> + >> + while ((dir = readdir(d))) {

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Maxime Ripard
Hi Helen, Thanks for working on this On Wed, Feb 28, 2024 at 07:55:25PM -0300, Helen Koike wrote: > This patch introduces a `.gitlab-ci` file along with a `ci/` folder, > defininga basic test pipeline triggered by code pushes to a GitLab-CI > instance. This initial version includes static checks

Re: [PATCH v2 0/7] tracing/probes: Support function parameter access from return probe

2024-02-29 Thread Google
On Thu, 29 Feb 2024 16:13:20 +0900 Masami Hiramatsu (Google) wrote: > On Thu, 29 Feb 2024 15:38:55 +0900 > Masami Hiramatsu (Google) wrote: > > > Hmm, this seems arch_rethook_trampoline caused the issue. > > > > And curiously, it depends on the number of stored data. > > > > OK: > >

Re: [PATCH 0/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-02-29 Thread Maxime Ripard
On Thu, Feb 29, 2024 at 01:07:25AM +0200, Laurent Pinchart wrote: > > Chat Discussions > > > > > > For those interested in further discussions: > > > > **Join Our Slack Channel:** > > We have a Slack channel, #gitlab-ci, on the KernelCI Slack instance > >

Re: [RFC PATCH v5 06/29] KVM: selftests: TDX: Use KVM_TDX_CAPABILITIES to validate TDs' attribute configuration

2024-02-29 Thread Binbin Wu
On 12/13/2023 4:46 AM, Sagi Shahar wrote: From: Ackerley Tng This also exercises the KVM_TDX_CAPABILITIES ioctl. Suggested-by: Isaku Yamahata Signed-off-by: Ackerley Tng Signed-off-by: Ryan Afranji Signed-off-by: Sagi Shahar --- .../selftests/kvm/lib/x86_64/tdx/tdx_util.c | 69

Re: [PATCH net-next] selftests: vxlan_mdb: Avoid duplicate test names

2024-02-29 Thread Liu, Yujie
Hi Ido, On Tue, 2024-02-27 at 19:04 +0200, Ido Schimmel wrote: > Rename some test cases to avoid overlapping test names which is > problematic for the kernel test robot. No changes in the test's > logic. > > Suggested-by: Yujie Liu > Signed-off-by: Ido Schimmel > --- > Yujie Liu, please verify

Re: lock warnings in dev_addr_lists test

2024-02-29 Thread David Gow
On Thu, 29 Feb 2024 at 03:45, Guenter Roeck wrote: > > Hi, > > when running the dev_addr_lists unit test with lock debugging enabled, > I always get the following lockdep warning. > > [7.031327] > [7.031393] WARNING: kunit_try_catch/1886 still has

Re: [PATCH v10] lib: checksum: Use aligned accesses for ip_fast_csum and csum_ipv6_magic tests

2024-02-29 Thread David Gow
On Wed, 28 Feb 2024 at 23:40, Guenter Roeck wrote: > > On 2/28/24 02:15, Geert Uytterhoeven wrote: > > CC testing > > > > On Wed, Feb 28, 2024 at 8:59 AM Guenter Roeck wrote: > >> On 2/27/24 23:25, Christophe Leroy wrote: > >> [ ... ] > > This test case is supposed to be as true to the