On 3/18/24 04:35, Hangbin Liu wrote:
On Sun, Mar 17, 2024 at 12:19:12AM +0100, Mirsad Todorovac wrote:
Hi,
While running kselftest on vanilla torvalds tree kernel commit
v6.8-11167-g4438a810f396,
the test suite reported a number of errors.
I was using the latest iproute2-next suite on an
This patch adds a selftest for the `bpf_task_get_cgroup` kfunc. The test
focuses on the use case of obtaining the cgroup ID of the previous task
in a `sched_switch` tracepoint.
The selftest involves creating a test cgroup, attaching a BPF program
that utilizes the `bpf_task_get_cgroup` during a
This patch enhances the BPF helpers by adding a kfunc to retrieve the
cgroup v2 of a task, addressing a previous limitation where only
bpf_task_get_cgroup1 was available for cgroup v1. The new kfunc is
particularly useful for scenarios where obtaining the cgroup ID of a
task other than the
On 3/18/24 15:42, David Ahern wrote:
On 3/17/24 8:38 PM, Hangbin Liu wrote:
Wild guess, the last change of icmp_redirect is my netns update. Maybe
there are something default sysctl settings in netns cause the error?
It is most likely sysctl settings. It would be good to chase those down
and
On 24/03/18 10:58AM, Jiri Olsa wrote:
> On Sat, Mar 16, 2024 at 10:22:41AM -0600, Jose Fernandez wrote:
>
> SNIP
>
> > +void test_task_get_cgroup(void)
> > +{
> > + struct test_task_get_cgroup *skel;
> > + int err, fd;
> > + pid_t pid;
> > + __u64 cgroup_id, expected_cgroup_id;
> > +
On Fri, 2024-03-15 at 15:29 +0100, Benjamin Tissoires wrote:
> bpf_experimental.h and ../bpf_testmod/bpf_testmod_kfunc.h are both
> including vmlinux.h, which is not compatible with including time.h
> or bpf_tcp_helpers.h.
>
> So prevent vmlinux.h to be included, and override the few missing
>
On Fri, 2024-03-15 at 15:29 +0100, Benjamin Tissoires wrote:
[...]
> @@ -5279,7 +5281,8 @@ static int map_kptr_match_type(struct bpf_verifier_env
> *env,
>
> static bool in_sleepable(struct bpf_verifier_env *env)
> {
> - return env->prog->sleepable;
> + return env->prog->sleepable ||
On Sun, Mar 17, 2024 at 07:49:43PM -0700, David Wei wrote:
> I'm working on a similar proposal for zero copy Rx but to host memory
> and depend on this memory provider API.
How do you need a different provider for that vs just udmabuf?
> Jakub also designed this API for hugepages too IIRC.
On Fri, 2024-03-15 at 15:29 +0100, Benjamin Tissoires wrote:
This patch looks good to me, please see two nitpicks below.
Acked-by: Eduard Zingerman
[...]
> @@ -1350,6 +1358,11 @@ BPF_CALL_3(bpf_timer_start, struct bpf_timer_kern *,
> timer, u64, nsecs, u64, fla
> goto out;
>
Hi Tony,
On 3/18/2024 3:00 PM, Luck, Tony wrote:
>> Perhaps ... in this case it may make things easier to understand if
>> those "mon_NODE_*" directories are sub-directories of the appropriate
>> "mon_L3_*" directories.
>
> Reinette,
>
> Like this?
>
> $ tree mon_data/
> mon_data/
> ├──
> Could you please help me understand the details by answering my first
> question: What is the use case for needing to expose the individual cluster
> counts?
>
> This is a model specific feature so if this is something needed for just a
> couple of systems I think we should be less inclined to
> Perhaps ... in this case it may make things easier to understand if
> those "mon_NODE_*" directories are sub-directories of the appropriate
> "mon_L3_*" directories.
Reinette,
Like this?
$ tree mon_data/
mon_data/
├── mon_L3_00
│ ├── llc_occupancy
│ ├── mbm_local_bytes
│ ├──
On Fri, 2024-03-15 at 15:29 +0100, Benjamin Tissoires wrote:
[...]
> @@ -12021,6 +12034,12 @@ static int check_kfunc_args(struct bpf_verifier_env
> *env, struct bpf_kfunc_call_
> if (ret)
> return ret;
> break;
> +
Add ability to parse multiple files. Additionally add the
ability to parse all results in the KUnit debugfs repository.
How to parse multiple files:
./tools/testing/kunit/kunit.py parse results.log results2.log
How to parse all files in directory:
./tools/testing/kunit/kunit.py parse
On 3/18/2024 2:04 PM, Luck, Tony wrote:
>>> What is the use case for needing to expose the individual cluster counts?
>>> What if
>>> resctrl just summed the cluster counts and presented the data as before -
>>> per L3
>>> cache instance? I doubt that resctrl would be what applications would
Hi Tony,
On 3/18/2024 1:47 PM, Luck, Tony wrote:
>> What is the use case for needing to expose the individual cluster counts?
>> What if
>> resctrl just summed the cluster counts and presented the data as before -
>> per L3
>> cache instance? I doubt that resctrl would be what applications
On Fri, Mar 15, 2024 at 7:16 PM Daniel Latypov wrote:
>
> On Thu, Mar 7, 2024 at 2:29 PM Rae Moar wrote:
> >
> > Add ability to parse multiple files. Additionally add the
> > ability to parse all results in the KUnit debugfs repository.
> >
> > How to parse multiple files:
> >
> >
> > What is the use case for needing to expose the individual cluster counts?
> > What if
> > resctrl just summed the cluster counts and presented the data as before -
> > per L3
> > cache instance? I doubt that resctrl would be what applications would use
> > to verify
> > whether they are
> What is the use case for needing to expose the individual cluster counts?
> What if
> resctrl just summed the cluster counts and presented the data as before - per
> L3
> cache instance? I doubt that resctrl would be what applications would use to
> verify
> whether they are "well behaved"
Hi Tony,
On 3/18/2024 12:34 PM, Luck, Tony wrote:
While that is in some ways a more accurate view, it breaks a lot of
legacy monitoring applications that expect the "L3" names.
>>>
>>> True - but the behaviour is different from a non SNC system, if this
>>> software can read the
>>>
> >> While that is in some ways a more accurate view, it breaks a lot of
> >> legacy monitoring applications that expect the "L3" names.
> >
> > True - but the behaviour is different from a non SNC system, if this
> > software can read the
> > file - but goes wrong because the contents of the
On 3/15/2024 11:02 AM, James Morse wrote:
> On 08/03/2024 18:42, Tony Luck wrote:
>> On Fri, Mar 08, 2024 at 06:06:45PM +, James Morse wrote:
>>> Hi guys,
>>>
>>> On 07/03/2024 23:16, Tony Luck wrote:
On Thu, Mar 07, 2024 at 02:39:08PM -0800, Reinette Chatre wrote:
> Thank you for
As was intended with commit 17107429947b ("selftests/exec: Perform script
checks with /bin/bash"), convert the other instance of /bin/sh to
/bin/bash. It appears that at least Debian Bookworm's /bin/sh (dash)
does not conform to POSIX's "return 127 when script not found"
requirement.
Fixes:
On Wed, Mar 13, 2024 at 04:11:41PM +0800, Yi Liu wrote:
> yes. how about your opinion? @Jason. I noticed the set_dev_pasid callback
> and pasid_array update is under the group->lock, so update it should be
> fine to adjust the order to update pasid_array after set_dev_pasid returns.
Yes, it
On 03/16, Jose Fernandez wrote:
> This patch enhances the BPF helpers by adding a kfunc to retrieve the
> cgroup v2 of a task, addressing a previous limitation where only
> bpf_task_get_cgroup1 was available for cgroup v1. The new kfunc is
> particularly useful for scenarios where obtaining the
On 3/16/24 9:22 AM, Jose Fernandez wrote:
This patch enhances the BPF helpers by adding a kfunc to retrieve the
cgroup v2 of a task, addressing a previous limitation where only
bpf_task_get_cgroup1 was available for cgroup v1. The new kfunc is
particularly useful for scenarios where obtaining
On 3/17/24 8:38 PM, Hangbin Liu wrote:
> Wild guess, the last change of icmp_redirect is my netns update. Maybe
> there are something default sysctl settings in netns cause the error?
It is most likely sysctl settings. It would be good to chase those down
and make sure we have the script setting
On Mon, Mar 11, 2024 at 04:28:01PM +0100, Matthieu Baerts wrote:
Hi Sasha,
On 11/03/2024 16:11, Sasha Levin wrote:
From: Paolo Abeni
[ Upstream commit b4b51d36bbaa3ddb93b3e1ca3a1ef0aa629d6521 ]
Thank you for having backported this patch to v6.7 and v6.6 versions.
But it looks like it
On 18.03.24 03:34, Vitaly Chikunov wrote:
Add missing flags argument to open(2) call with O_CREAT.
Some tests fail to compile if _FORTIFY_SOURCE is defined (to any valid
value) (together with -O), resulting in similar error messages such as:
In file included from /usr/include/fcntl.h:342,
On Sat, Mar 16, 2024 at 10:22:41AM -0600, Jose Fernandez wrote:
SNIP
> +void test_task_get_cgroup(void)
> +{
> + struct test_task_get_cgroup *skel;
> + int err, fd;
> + pid_t pid;
> + __u64 cgroup_id, expected_cgroup_id;
> + const struct timespec req = {
> +
30 matches
Mail list logo
