Re: [PATCH net 0/2] mptcp: fix fallback MIB counter and wrong var in selftests

2024-04-01 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net.git (main) by Jakub Kicinski : On Fri, 29 Mar 2024 13:08:51 +0100 you wrote: > Here are two fixes related to MPTCP. > > The first patch fixes when the MPTcpExtMPCapableFallbackACK MIB counter > is modified: it should only be incremented when a connect

Re: [PATCH net] selftests: reuseaddr_conflict: add missing new line at the end of the output

2024-04-01 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Fri, 29 Mar 2024 09:05:59 -0700 you wrote: > The netdev CI runs in a VM and captures serial, so stdout and > stderr get combined. Because there's a missing new line in > stderr the test ends up corrupting KTAP: > > #

[PATCH net-next 7/7] testing: net-drv: add a driver test for stats reporting

2024-04-01 Thread Jakub Kicinski
Add a very simple test to make sure drivers report expected stats. Drivers which implement FEC or pause configuration should report relevant stats. Qstats must be reported, at least packet and byte counts, and they must match total device stats. Tested with netdevsim, bnxt, in-tree and installed.

[PATCH net-next 6/7] selftests: drivers: add scaffolding for Netlink tests in Python

2024-04-01 Thread Jakub Kicinski
Add drivers/net as a target for mixed-use tests. The setup is expected to work similarly to the forwarding tests. Since we only need one interface (unlike forwarding tests) read the target device name from NETIF. If not present we'll try to run the test against netdevsim. Signed-off-by: Jakub Kici

[PATCH net-next 5/7] netdevsim: report stats by default, like a real device

2024-04-01 Thread Jakub Kicinski
Real devices should implement qstats. Devices which support pause or FEC configuration should also report the relevant stats. nsim was missing FEC stats completely, some of the qstats and pause stats required toggling a debugfs knob. Note that the tests which used pause always initialize the sett

[PATCH net-next 4/7] selftests: nl_netdev: add a trivial Netlink netdev test

2024-04-01 Thread Jakub Kicinski
Add a trivial test using YNL. $ ./tools/testing/selftests/net/nl_netdev.py KTAP version 1 1..2 ok 1 nl_netdev.empty_check ok 2 nl_netdev.lo_check Instantiate the family once, it takes longer than the test itself. Signed-off-by: Jakub Kicinski --- CC: sh...@kernel.org CC: linux-kselfte

[PATCH net-next 3/7] selftests: net: add scaffolding for Netlink tests in Python

2024-04-01 Thread Jakub Kicinski
Add glue code for accessing the YNL library which lives under tools/net and YAML spec files from under Documentation/. Automatically figure out if tests are run in tree or not. Since we'll want to use this library both from net and drivers/net test targets make the library a target as well, and aut

[PATCH net-next 2/7] tools: ynl: copy netlink error to NlError

2024-04-01 Thread Jakub Kicinski
Typing e.nl_msg.error when processing exception is a bit tedious and counter-intuitive. Set a local .error member to the positive value of the netlink level error. Signed-off-by: Jakub Kicinski --- CC: donald.hun...@gmail.com CC: j...@resnulli.us --- tools/net/ynl/lib/ynl.py | 3 ++- 1 file chan

[PATCH net-next 1/7] netlink: specs: define ethtool header flags

2024-04-01 Thread Jakub Kicinski
When interfacing with the ethtool commands it's handy to be able to use the names of the flags. Example: ethnl.pause_get({"header": {"dev-index": cfg.ifindex, "flags": {'stats'}}}) Note that not all commands accept all the flags, but the meaning of the bits doe

[PATCH net-next 0/7] selftests: net: groundwork for YNL-based tests

2024-04-01 Thread Jakub Kicinski
Currently the options for writing networking tests are C, bash or some mix of the two. YAML/Netlink gives us the ability to easily interface with Netlink in higher level laguages. In particular, there is a Python library already available in tree, under tools/net. Add the scaffolding which allows w

Re: [PATCH v4 10/15] RISC-V: KVM: Support 64 bit firmware counters on RV32

2024-04-01 Thread Atish Patra
On Sat, Mar 2, 2024 at 2:52 AM Andrew Jones wrote: > > On Wed, Feb 28, 2024 at 05:01:25PM -0800, Atish Patra wrote: > > The SBI v2.0 introduced a fw_read_hi function to read 64 bit firmware > > counters for RV32 based systems. > > > > Add infrastructure to support that. > > > > Reviewed-by: Anup P

Re: [PATCH v4 07/15] RISC-V: KVM: No need to exit to the user space if perf event failed

2024-04-01 Thread Atish Patra
On Sat, Mar 2, 2024 at 12:16 AM Andrew Jones wrote: > > On Wed, Feb 28, 2024 at 05:01:22PM -0800, Atish Patra wrote: > > Currently, we return a linux error code if creating a perf event failed > > in kvm. That shouldn't be necessary as guest can continue to operate > > without perf profiling or pr

Re: [PATCH v4 08/15] RISC-V: KVM: Implement SBI PMU Snapshot feature

2024-04-01 Thread Atish Patra
On Sat, Mar 2, 2024 at 1:49 AM Andrew Jones wrote: > > On Wed, Feb 28, 2024 at 05:01:23PM -0800, Atish Patra wrote: > > PMU Snapshot function allows to minimize the number of traps when the > > guest access configures/access the hpmcounters. If the snapshot feature > > is enabled, the hypervisor u

[PATCH] Add test for more file systems in landlock - ext4

2024-04-01 Thread Saasha Gupta
>From 7bb9c34291b295e192155d2b800d2ef7ce910dfc Mon Sep 17 00:00:00 2001 From: Saasha Gupta Date: Mon, 1 Apr 2024 19:59:56 +0530 Subject: [PATCH] Add test for more file systems in landlock - ext4 Landlock LSM, a part of the security subsystem, has some tests in place for synthetic filesystems such

Re: [PATCH v6 1/2] posix-timers: Prefer delivery of signals to the current thread

2024-04-01 Thread John Stultz
On Thu, Mar 16, 2023 at 5:30 AM Marco Elver wrote: > > From: Dmitry Vyukov > > POSIX timers using the CLOCK_PROCESS_CPUTIME_ID clock prefer the main > thread of a thread group for signal delivery. However, this has a > significant downside: it requires waking up a potentially idle thread. > >

Re: [RFC PATCH net-next v6 02/15] net: page_pool: create hooks for custom page providers

2024-04-01 Thread Mina Almasry
On Thu, Mar 28, 2024 at 12:31 AM Christoph Hellwig wrote: > > On Tue, Mar 26, 2024 at 01:19:20PM -0700, Mina Almasry wrote: > > > > Are you envisioning that dmabuf support would be added to the block > > layer > > Yes. > > > (which I understand is part of the VFS and not driver specific), > > The

Re: [PATCH bpf-next v3] selftests/bpf: Move test_dev_cgroup to prog_tests

2024-04-01 Thread Yonghong Song
On 4/1/24 5:34 AM, Muhammad Usama Anjum wrote: Move test_dev_cgroup.c to prog_tests/dev_cgroup.c to be able to run it with test_progs. Replace dev_cgroup.bpf.o with skel header file, dev_cgroup.skel.h and load program from it accourdingly. ./test_progs -t dev_cgroup mknod: /tmp/test_dev_

Re: [PATCH v2 27/27] kselftest/riscv: kselftest for user mode cfi

2024-04-01 Thread Deepak Gupta
On Mon, Apr 1, 2024 at 10:34 AM Deepak Gupta wrote: > > On Mon, Apr 1, 2024 at 2:48 AM Muhammad Usama Anjum > wrote: > > > > >>> Signed-off-by: Deepak Gupta > > >>> --- > > >>> tools/testing/selftests/riscv/Makefile| 2 +- > > >>> tools/testing/selftests/riscv/cfi/Makefile| 10 +

Re: [PATCH v2 27/27] kselftest/riscv: kselftest for user mode cfi

2024-04-01 Thread Deepak Gupta
On Mon, Apr 1, 2024 at 2:48 AM Muhammad Usama Anjum wrote: > > >>> Signed-off-by: Deepak Gupta > >>> --- > >>> tools/testing/selftests/riscv/Makefile| 2 +- > >>> tools/testing/selftests/riscv/cfi/Makefile| 10 + > >>> .../testing/selftests/riscv/cfi/cfi_rv_test.h | 85 > >>>

Re: [PATCH v2 2/3] KVM: selftests: Extend @shape to allow creation of VM without in-kernel APIC

2024-04-01 Thread Sean Christopherson
On Mon, Apr 01, 2024, Manali Shukla wrote: > Currently, all the VMs are created with in-kernel APIC support in KVM > selftests because KVM_CREATE_IRQCHIP ioctl is called by default from > kvm_arch_vm_post_create(). > > Carve out space in the @shape passed to the various VM creation helpers to > al

Re: [PATCH v2 3/3] KVM: selftests: Add a test case for KVM_X86_DISABLE_EXITS_HLT

2024-04-01 Thread Dongli Zhang
On 4/1/24 08:20, Manali Shukla wrote: > By default, HLT instruction executed by guest is intercepted by hypervisor. > However, KVM_CAP_X86_DISABLE_EXITS capability can be used to not intercept > HLT by setting KVM_X86_DISABLE_EXITS_HLT. > > Add a test case to test KVM_X86_DISABLE_EXITS_HLT func

Re: [External] Re: [PATCH bpf-next v2 1/9] bpf: tracing: add support to record and check the accessed args

2024-04-01 Thread Steven Rostedt
On Mon, 1 Apr 2024 10:28:17 +0800 梦龙董 wrote: > On Sun, Mar 31, 2024 at 3:34 AM Steven Rostedt wrote: > > > > On Sat, 30 Mar 2024 11:18:29 +0800 > > 梦龙董 wrote: > > > > > > If you really want to have thousands of functions, why not just > > > > register it > > > > with ftrace itself. It will g

[PATCH v2 3/3] KVM: selftests: Add a test case for KVM_X86_DISABLE_EXITS_HLT

2024-04-01 Thread Manali Shukla
By default, HLT instruction executed by guest is intercepted by hypervisor. However, KVM_CAP_X86_DISABLE_EXITS capability can be used to not intercept HLT by setting KVM_X86_DISABLE_EXITS_HLT. Add a test case to test KVM_X86_DISABLE_EXITS_HLT functionality. Suggested-by: Sean Christopherson Sign

[PATCH v2 0/3] Add a test case for KVM_X86_DISABLE_EXIT

2024-04-01 Thread Manali Shukla
By default, HLT instruction executed by guest is intercepted by hypervisor. However, KVM_CAP_X86_DISABLE_EXITS capability can be used to not intercept HLT by setting KVM_X86_DISABLE_EXITS_HLT. By default, vms are created with in-kernel APIC support in KVM selftests. VM needs to be created without

[PATCH v2 2/3] KVM: selftests: Extend @shape to allow creation of VM without in-kernel APIC

2024-04-01 Thread Manali Shukla
Currently, all the VMs are created with in-kernel APIC support in KVM selftests because KVM_CREATE_IRQCHIP ioctl is called by default from kvm_arch_vm_post_create(). Carve out space in the @shape passed to the various VM creation helpers to allow using the shape to control creation of a VM without

[PATCH v2 1/3] KVM: selftests: Add safe_halt() and cli() helpers to common code

2024-04-01 Thread Manali Shukla
Add safe_halt() and cli() helpers to processor.h to make them broadly available in KVM selftests. Suggested-by: Sean Christopherson Signed-off-by: Manali Shukla --- .../selftests/kvm/include/x86_64/processor.h| 17 + 1 file changed, 17 insertions(+) diff --git a/tools/testi

[PATCH 1/2] cgroup/cpuset: Make cpuset hotplug processing synchronous

2024-04-01 Thread Waiman Long
Since commit 3a5a6d0c2b03("cpuset: don't nest cgroup_mutex inside get_online_cpus()"), cpuset hotplug was done asynchronously via a work function. This is to avoid recursive locking of cgroup_mutex. Since then, the cgroup locking scheme has changed quite a bit. A cpuset_mutex was introduced to pro

[PATCH 2/2] cgroup/cpuset: Add test_cpuset_v1_hp.sh

2024-04-01 Thread Waiman Long
Add a simple test to verify that an empty v1 cpuset will force its tasks to be moved to an ancestor node. It is based on the test case documented in commit 76bb5ab8f6e3 ("cpuset: break kernfs active protection in cpuset_write_resmask()"). Signed-off-by: Waiman Long --- tools/testing/selftests/cg

[PATCH 0/2] cgroup/cpuset: Make cpuset hotplug processing synchronous

2024-04-01 Thread Waiman Long
As discussed in the LKML thread [1], the asynchronous nature of cpuset hotplug handling code is causing problem with RCU testing. With recent changes in the way locking is being handled in the cpuset code, it is now possible to make the cpuset hotplug code synchronous again without major changes.

[PATCH bpf-next v3] selftests/bpf: Move test_dev_cgroup to prog_tests

2024-04-01 Thread Muhammad Usama Anjum
Move test_dev_cgroup.c to prog_tests/dev_cgroup.c to be able to run it with test_progs. Replace dev_cgroup.bpf.o with skel header file, dev_cgroup.skel.h and load program from it accourdingly. ./test_progs -t dev_cgroup mknod: /tmp/test_dev_cgroup_null: Operation not permitted 64+0 records i

Re: [PATCH v1 3/3] KVM: selftests: Add a test case for KVM_X86_DISABLE_EXITS_HLT

2024-04-01 Thread Manali Shukla
On 4/1/2024 3:11 PM, Muhammad Usama Anjum wrote: > On 4/1/24 10:28 AM, Manali Shukla wrote: >> Hi Muhammad Usama Anjum, >> >> Thank you for reviewing my patch. >> >> On 3/30/2024 1:43 AM, Muhammad Usama Anjum wrote: >>> On 3/27/24 10:42 AM, Manali Shukla wrote: By default, HLT instruction exec

Re: [PATCH bpf-next v2] selftests/bpf: Move test_dev_cgroup to prog_tests

2024-04-01 Thread Muhammad Usama Anjum
Trying the BPF CI job again by changing test_dev_cgroup to serial_test_dev_cgroup. I'm not sure if it'll trigger the job or not. Is there any other way to trigger a CI job for a test patch? Signed-off-by: Muhammad Usama Anjum --- .../selftests/bpf/prog_tests/dev_cgroup.c | 58 +

Re: [PATCH] selftests/mm: import strings.h for ffsl

2024-04-01 Thread Muhammad Usama Anjum
On 3/30/24 1:33 AM, Edward Liaw wrote: > On Fri, Mar 29, 2024 at 12:32 PM Muhammad Usama Anjum > wrote: >> >> On 3/29/24 10:42 PM, Edward Liaw wrote: >>> Got a compilation error for ffsl after 91b80cc5b39f ("selftests: mm: fix >>> map_hugetlb failure on 64K page size systems") imported vm_util.h.

Re: [PATCH v2 27/27] kselftest/riscv: kselftest for user mode cfi

2024-04-01 Thread Muhammad Usama Anjum
On 3/30/24 1:02 AM, Deepak Gupta wrote: > On Fri, Mar 29, 2024 at 12:50 PM Muhammad Usama Anjum > wrote: >> >> On 3/29/24 9:44 AM, Deepak Gupta wrote: >>> Adds kselftest for RISC-V control flow integrity implementation for user >>> mode. There is not a lot going on in kernel for enabling landing p

Re: [PATCH v1 3/3] KVM: selftests: Add a test case for KVM_X86_DISABLE_EXITS_HLT

2024-04-01 Thread Muhammad Usama Anjum
On 4/1/24 10:28 AM, Manali Shukla wrote: > Hi Muhammad Usama Anjum, > > Thank you for reviewing my patch. > > On 3/30/2024 1:43 AM, Muhammad Usama Anjum wrote: >> On 3/27/24 10:42 AM, Manali Shukla wrote: >>> By default, HLT instruction executed by guest is intercepted by hypervisor. >>> However,

[PATCH] KVM: riscv: selftests: Add SBI base extension test

2024-04-01 Thread Haibo Xu
This is the first patch to enable the base extension selftest for the SBI implementation in KVM. Test for other extensions will be added later. Signed-off-by: Haibo Xu --- tools/testing/selftests/kvm/Makefile | 1 + .../selftests/kvm/include/riscv/processor.h | 8 +- tools/testing/s