Re: [PATCH v8 24/24] KVM: riscv: selftests: Add commandline option for SBI PMU test

2024-04-21 Thread Anup Patel
On Sat, Apr 20, 2024 at 5:18 AM Atish Patra wrote: > > SBI PMU test comprises of multiple tests and user may want to run > only a subset depending on the platform. The most common case would > be to run all to validate all the tests. However, some platform may > not support all events or all ISA

Re: [PATCH v8 18/24] KVM: riscv: selftests: Add helper functions for extension checks

2024-04-21 Thread Anup Patel
On Sat, Apr 20, 2024 at 5:18 AM Atish Patra wrote: > > __vcpu_has_ext can check both SBI and ISA extensions when the first > argument is properly converted to SBI/ISA extension IDs. Introduce > two helper functions to make life easier for developers so they > don't have to worry about the

Re: [PATCH v8 17/24] KVM: riscv: selftests: Move sbi definitions to its own header file

2024-04-21 Thread Anup Patel
On Sat, Apr 20, 2024 at 5:18 AM Atish Patra wrote: > > The SBI definitions will continue to grow. Move the sbi related > definitions to its own header file from processor.h > > Suggested-by: Andrew Jones > Reviewed-by: Andrew Jones > Signed-off-by: Atish Patra LGTM. Reviewed-by: Anup Patel

Re: [PATCH v8 16/24] RISC-V: KVM: Improve firmware counter read function

2024-04-21 Thread Anup Patel
On Sat, Apr 20, 2024 at 5:18 AM Atish Patra wrote: > > Rename the function to indicate that it is meant for firmware > counter read. While at it, add a range sanity check for it as > well. > > Reviewed-by: Andrew Jones > Signed-off-by: Atish Patra LGTM. Reviewed-by: Anup Patel Regards, Anup

Re: [PATCH v8 10/24] RISC-V: KVM: Fix the initial sample period value

2024-04-21 Thread Anup Patel
On Sat, Apr 20, 2024 at 5:18 AM Atish Patra wrote: > > The initial sample period value when counter value is not assigned > should be set to maximum value supported by the counter width. > Otherwise, it may result in spurious interrupts. > > Reviewed-by: Andrew Jones > Signed-off-by: Atish Patra

Re: [PATCH v2 1/1] selftest mm/mseal: fix compile warning

2024-04-21 Thread Muhammad Usama Anjum
On 4/20/24 5:35 AM, jef...@chromium.org wrote: > From: Jeff Xu > > fix compile warning reported by test robot > > Signed-off-by: Jeff Xu > Reported-by: kernel test robot > Closes: https://lore.kernel.org/r/202404190226.ofjoewv8-...@intel.com/ > Suggested-by: Pedro Falcato Reviewed-by:

Re: [PATCH] selftests: filesystems: add missing stddef header

2024-04-21 Thread Muhammad Usama Anjum
On 4/20/24 8:56 PM, Amer Al Shanawany wrote: > On 4/19/24 18:45, Muhammad Usama Anjum wrote: >> On 4/17/24 9:16 PM, Amer Al Shanawany wrote: >>> fix compiler warning and errors when compiling statmount test. Following can be added to the description: statmount_test.c:572:24: warning: implicit

Re: [PATCH] selftests/bpf: Add ring_buffer__consume_n test.

2024-04-21 Thread Jiri Olsa
On Sat, Apr 20, 2024 at 05:59:04PM +0200, Andrea Righi wrote: > Add a testcase for the ring_buffer__consume_n() API. > > The test produces multiple samples in a ring buffer, using a > sys_getpid() fentry prog, and consumes them from user-space in batches, > rather than consuming all of them

Re: [PATCH net-next 1/4] netdev: support dumping a single netdev in qstats

2024-04-21 Thread David Ahern
On 4/21/24 1:17 PM, Eric Dumazet wrote: > I wonder if NLM_F_DUMP_FILTERED should not be reported to user space ? good point. We do set that flag for other dumps when a filter has been used to limit data returned.

Re: [PATCH net-next 1/4] netdev: support dumping a single netdev in qstats

2024-04-21 Thread Eric Dumazet
On Sat, Apr 20, 2024 at 4:35 AM Jakub Kicinski wrote: > > Having to filter the right ifindex in the tests is a bit tedious. > Add support for dumping qstats for a single ifindex. > > Signed-off-by: Jakub Kicinski > --- > Documentation/netlink/specs/netdev.yaml | 1 + >

Re: [PATCH net-next v5 7/7] selftests: drv-net: add require_XYZ() helpers for validating env

2024-04-21 Thread Willem de Bruijn
Jakub Kicinski wrote: > Wrap typical checks like whether given command used by the test > is available in helpers. > > Signed-off-by: Jakub Kicinski > def test_v4(cfg) -> None: > +cfg.require_v4() > + Probably every platform has ping. But since it is not a built-int and this patch adds

Re: [PATCH net-next v5 0/7] selftests: drv-net: support testing with a remote system

2024-04-21 Thread Willem de Bruijn
Jakub Kicinski wrote: > Hi! > > Implement support for tests which require access to a remote system / > endpoint which can generate traffic. > This series concludes the "groundwork" for upstream driver tests. > > I wanted to support the three models which came up in discussions: > - SW testing