On Fri, May 10, 2024 at 1:23 AM Jakub Kicinski wrote:
>
Hi Jakub,
Thanks a lot for the review and looking into the bug.
> On Wed, 8 May 2024 04:06:43 + Taehee Yoo wrote:
> > In the forwarding testcase, it opens a server and a client with the nc.
> > The server receives the correct message
On Thu, May 9, 2024 at 6:36 PM Paolo Abeni wrote:
>
Hi Paolo,
Thank you for the review!
> On Wed, 2024-05-08 at 04:06 +, Taehee Yoo wrote:
>
> > @@ -210,40 +217,52 @@ check_features()
> >
> > test_ipv4_forward()
> > {
> > - RESULT4=$(ip netns exec "${LISTENER}" nc -w 1 -l -u 239.0.0.1 4000)
On Thu, May 9, 2024 at 5:38 PM Simon Horman wrote:
>
Hi Simon,
Thanks a lot for the review!
> On Wed, May 08, 2024 at 04:06:43AM +, Taehee Yoo wrote:
> > In the forwarding testcase, it opens a server and a client with the nc.
> > The server receives the correct message from NC, it prints
On Fri, 10 May 2024 11:15:58 +0800 Hangbin Liu wrote:
> I may missed something, I saw there is already a log_test_xfail() in lib.sh
>
> log_test_skip()
> {
> RET=$ksft_skip retmsg= log_test "$@"
> }
>
> log_test_xfail()
> {
> RET=$ksft_xfail retmsg= log_test "$@"
> }
>
>
Hi Jakub,
On Thu, May 09, 2024 at 04:55:53PM -0700, Jakub Kicinski wrote:
> Vladimir said when adding this test:
>
> The bridge driver fares particularly badly [...] mainly because
> it does not implement IFF_UNICAST_FLT.
>
> See commit 90b9566aa5cd ("selftests: forwarding: add a test for
>
Jakub Kicinski wrote:
> On slow machines the SND timestamp sometimes doesn't arrive before
> we quit. The test only waits as long as the packet delay, so it's
> easy for a race condition to happen.
>
> Double the wait but do a bit of polling, once the SND timestamp
> arrives there's no point to
Jakub Kicinski wrote:
> Slow machines can delay scheduling of the packets for milliseconds.
> Increase the delay to 8ms if KSFT_MACHINE_SLOW. Try to limit the
> variability by moving setsockopts earlier (before we read time).
>
> This fixes the "TXTIME rel" failures on debug kernels, like:
>
>
On Wed, Apr 03, 2024 at 04:35:17PM -0700, Deepak Gupta wrote:
> Adds kselftest for RISC-V control flow integrity implementation for user
> mode. There is not a lot going on in kernel for enabling landing pad for
> user mode. cfi selftest are intended to be compiled with zicfilp and
> zicfiss
Slow machines can delay scheduling of the packets for milliseconds.
Increase the delay to 8ms if KSFT_MACHINE_SLOW. Try to limit the
variability by moving setsockopts earlier (before we read time).
This fixes the "TXTIME rel" failures on debug kernels, like:
Case ICMPv4 - TXTIME rel returned
On slow machines the SND timestamp sometimes doesn't arrive before
we quit. The test only waits as long as the packet delay, so it's
easy for a race condition to happen.
Double the wait but do a bit of polling, once the SND timestamp
arrives there's no point to wait any longer.
This fixes the
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Drop #define __USE_GNU too, as it is bad practice and the GNU extensions
aren't actually being used in test_FCMOV, etc. where it is being defined.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/wireguard/qemu/init.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/wireguard/qemu/init.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/vDSO/vdso_test_abi.c | 1 -
tools/testing/selftests/vDSO/vdso_test_clock_getres.c | 2 --
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/user_events/abi_test.c | 2 --
1 file changed, 2 deletions(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/uevent/uevent_filtering.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/uevent/uevent_filtering.c
-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/tmpfs/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/tmpfs/Makefile
b/tools/testing/selftests/tmpfs/Makefile
index
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/timens/clock_nanosleep.c | 1 -
tools/testing/selftests/timens/exec.c| 1 -
tools/testing/selftests/timens/futex.c | 1 -
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
.../selftests/thermal/intel/power_floor/power_floor_test.c | 3 ---
.../selftests/thermal/intel/workload_hint/workload_hint_test.c | 3 ---
2 files changed, 6
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/syscall_user_dispatch/sud_benchmark.c | 2 --
tools/testing/selftests/syscall_user_dispatch/sud_test.c | 2 --
2 files changed, 4 deletions(-)
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/splice/default_file_splice_read.c | 1 -
tools/testing/selftests/splice/splice_read.c | 1 -
2 files changed, 2 deletions(-)
diff
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/sigaltstack/sas.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/sigaltstack/sas.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/seccomp/seccomp_benchmark.c | 1 -
tools/testing/selftests/seccomp/seccomp_bpf.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/sched/cs_prctl_test.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/sched/cs_prctl_test.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/safesetid/safesetid-test.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/safesetid/safesetid-test.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/rseq/basic_percpu_ops_test.c | 1 -
tools/testing/selftests/rseq/basic_test.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/rlimits/rlimits-per-userns.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/rlimits/rlimits-per-userns.c
-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/riscv/mm/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/riscv/mm/Makefile
b/tools/testing/selftests/riscv/mm/Makefile
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/riscv/hwprobe/cbo.c| 1 -
tools/testing/selftests/riscv/hwprobe/which-cpus.c | 1 -
2 files changed, 2 deletions(-)
diff --git
-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Acked-by: Reinette Chatre
Signed-off-by: Edward Liaw
---
tools/testing/selftests/resctrl/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/ptp/testptp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/ptp/testptp.c
b/tools/testing/selftests/ptp/testptp.c
-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/proc/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/proc/Makefile
b/tools/testing/selftests/proc/Makefile
index
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/proc/proc-empty-vm.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/proc/proc-empty-vm.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/powerpc/benchmarks/context_switch.c| 2 --
tools/testing/selftests/powerpc/benchmarks/exec_target.c | 2 --
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/ptrace/get_set_sud.c | 1 -
tools/testing/selftests/ptrace/peeksiginfo.c | 1 -
2
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/pidfd/pidfd.h | 1 -
tools/testing/selftests/pidfd/pidfd_fdinfo_test.c |
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/pid_namespace/regression_enomem.c | 1 -
1 file changed, 1 deletion(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/perf_events/remove_on_exec.c | 2 --
tools/testing/selftests/perf_events/sigtrap_threads.c | 2 --
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/openat2/helpers.c| 2 --
tools/testing/selftests/openat2/helpers.h| 1 -
tools/testing/selftests/openat2/openat2_test.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/nsfs/owner.c | 1 -
tools/testing/selftests/nsfs/pidns.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/tools/testing/selftests/nsfs/owner.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/nolibc/nolibc-test.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/nolibc/nolibc-test.c
-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/net/tcp_ao/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/net/af_unix/diag_uid.c | 2 --
tools/testing/selftests/net/af_unix/scm_pidfd.c | 1 -
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/mqueue/mq_perf_tests.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/mqueue/mq_perf_tests.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
.../selftests/move_mount_set_group/move_mount_set_group_test.c | 1 -
1 file changed, 1 deletion(-)
diff
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/mount_setattr/mount_setattr_test.c | 1 -
1 file changed, 1 deletion(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/mount/nosymfollow-test.c | 1 -
tools/testing/selftests/mount/unprivileged-remount-test.c | 1 -
2 files changed, 2 deletions(-)
diff
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/mm/cow.c | 1 -
tools/testing/selftests/mm/gup_longterm.c | 1 -
tools/testing/selftests/mm/hugepage-mmap.c | 1
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/mincore/mincore_selftest.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/tools/testing/selftests/mincore/mincore_selftest.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/memfd/common.c | 1 -
tools/testing/selftests/memfd/fuse_test.c | 2 --
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/membarrier/membarrier_test_impl.h| 1 -
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/lsm/common.c | 2 --
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/landlock/base_test.c | 2 --
tools/testing/selftests/landlock/fs_test.c | 2 --
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/kcmp/kcmp_test.c | 2 --
1 file changed, 2 deletions(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/ipc/msgque.c | 1 -
1 file changed, 1 deletion(-)
diff --git
-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/iommu/Makefile | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/iommu/Makefile
-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/intel_pstate/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/intel_pstate/Makefile
-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/futex/functional/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/futex/functional/futex_requeue_pi.c | 3 ---
1 file changed, 3 deletions(-)
diff
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/fpu/test_fpu.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/fpu/test_fpu.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/firmware/fw_namespace.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/firmware/fw_namespace.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/filesystems/binderfs/binderfs_test.c | 2 --
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/filelock/ofdlocks.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/filelock/ofdlocks.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/fchmodat2/fchmodat2_test.c | 2 --
1 file changed, 2 deletions(-)
diff --git
-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/exec/Makefile | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/selftests/exec/Makefile
b/tools/testing/selftests/exec/Makefile
index
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/drivers/dma-buf/udmabuf.c | 1 -
1 file changed, 1 deletion(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: SeongJae Park
Signed-off-by: Edward Liaw
---
tools/testing/selftests/damon/debugfs_target_ids_pid_leak.c | 2 --
.../damon/debugfs_target_ids_read_before_terminate_race.c | 1 -
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/core/close_range_test.c | 2 --
1 file changed, 2 deletions(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/clone3/clone3.c| 2 --
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/cgroup/cgroup_util.c| 3 ---
tools/testing/selftests/cgroup/test_core.c | 2 --
tools/testing/selftests/cgroup/test_cpu.c
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/capabilities/test_execve.c | 2 --
1 file changed, 2 deletions(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
tools/testing/selftests/cachestat/test_cachestat.c | 2 --
1 file changed, 2 deletions(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/breakpoints/breakpoint_test_arm64.c | 3 ---
tools/testing/selftests/breakpoints/step_after_suspend_test.c | 3 ---
2 files changed, 6
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/bpf/bench.c| 1 -
tools/testing/selftests/bpf/benchs/bench_trigger.c | 1 -
-D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/arm64/signal/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/arm64/signal/Makefile
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Signed-off-by: Edward Liaw
---
tools/testing/selftests/arm64/fp/fp-ptrace.c | 3 ---
tools/testing/selftests/arm64/fp/fp-stress.c | 2 --
lib.mk will add -D_GNU_SOURCE to CFLAGS by default. This will make it
unnecessary to add #define _GNU_SOURCE in the source code.
Suggested-by: John Hubbard
Signed-off-by: Edward Liaw
---
tools/testing/selftests/Makefile | 4 ++--
tools/testing/selftests/lib.mk | 5 -
2 files changed, 6
GNU_SOURCE directly to CFLAGS in lib.mk.
- Delete additional _GNU_SOURCE definitions from source code in
linux-next.
- Delete additional -D_GNU_SOURCE flags from Makefiles.
v4:
- Rebase onto linux-next 20240509.
- Remove Fixes tag from patches that drop _GNU_SOURCE definition.
- Restore space betwe
Vladimir said when adding this test:
The bridge driver fares particularly badly [...] mainly because
it does not implement IFF_UNICAST_FLT.
See commit 90b9566aa5cd ("selftests: forwarding: add a test for
local_termination.sh").
We don't want to hide the known gaps, but having a test which
On Thu, May 09, 2024 at 09:32:49PM +0100, Conor Dooley wrote:
On Thu, May 09, 2024 at 11:46:26AM -0700, Deepak Gupta wrote:
On Thu, May 09, 2024 at 07:14:26PM +0100, Conor Dooley wrote:
> On Tue, Apr 16, 2024 at 08:44:16AM -0700, Deepak Gupta wrote:
> > On Mon, Apr 15, 2024 at 02:41:05PM -0500,
On Thu, May 9, 2024 at 2:25 PM John Hubbard wrote:
>
> On 5/9/24 12:57 PM, Edward Liaw wrote:
> > lib.mk will add -D_GNU_SOURCE to CFLAGS by default. This will make it
> > unnecessary to add #define _GNU_SOURCE in the source code.
> >
> > Fixes: 809216233555 ("selftests/harness: remove use of
On Thu, May 09, 2024 at 09:25:25AM +0100, Conor Dooley wrote:
> On Thu, May 09, 2024 at 08:48:09AM +0100, Conor Dooley wrote:
> > On Thu, May 09, 2024 at 02:56:30PM +0800, Andy Chiu wrote:
> > > Hi Conor,
> > >
> > > Should we check if "v" presents for vector crypto extensions in
> > >
Hi Edward,
On 5/9/2024 12:58 PM, Edward Liaw wrote:
> -D_GNU_SOURCE can be de-duplicated here, as it is added by lib.mk.
>
> Reviewed-by: John Hubbard
> Reviewed-by: Muhammad Usama Anjum
> Signed-off-by: Edward Liaw
> ---
Thank you very much.
Acked-by: Reinette Chatre
Reinette
On 5/9/24 12:57 PM, Edward Liaw wrote:
lib.mk will add -D_GNU_SOURCE to CFLAGS by default. This will make it
unnecessary to add #define _GNU_SOURCE in the source code.
Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
Suggested-by: John Hubbard
Signed-off-by: Edward Liaw
---
On Thu, May 9, 2024 at 1:31 PM SeongJae Park wrote:
>
> Hi Edward,
>
> On Thu, 9 May 2024 19:58:05 + Edward Liaw wrote:
>
> > _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
> > redefinition warnings.
> >
> > Fixes: 809216233555 ("selftests/harness: remove use of
On Thu, May 9, 2024 at 1:16 PM Mathieu Desnoyers
wrote:
>
> On 2024-05-09 15:58, Edward Liaw wrote:
> > _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
> > redefinition warnings.
> >
> > Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
>
> The patch per se
On 4/26/2024 12:06 AM, Ilpo Järvinen wrote:
> On Thu, 25 Apr 2024, Babu Moger wrote:
>
>> Enable MBA/MBM tests if UMC (Unified Memory Controller) support is
>> available on the system. Tests will be skipped otherwise.
>>
>> Update noncont_cat_run_test to check for vendor. AMD supports
>> non
Hi Babu,
On 4/25/2024 1:17 PM, Babu Moger wrote:
> Add support to read UMC (Unified Memory Controller) perf events to compare
> the numbers with QoS monitor for AMD.
>
> Signed-off-by: Babu Moger
> ---
> tools/testing/selftests/resctrl/resctrl_val.c | 67 ---
> 1 file changed,
Hi Babu,
On 4/25/2024 1:17 PM, Babu Moger wrote:
> Detect the vendor and pass the sysfs name for the vendor for searching
> the controller information.
Could you please write a proper changelog?
>
> Signed-off-by: Babu Moger
> ---
> tools/testing/selftests/resctrl/resctrl_val.c | 16
Hi Babu,
On 4/25/2024 1:16 PM, Babu Moger wrote:
> In an effort to support MBM and MBA tests for AMD, renaming for variable
> and functions to generic names. For Intel, the memory controller is called
> Integrated Memory Controllers (IMC). For AMD, it is called Unified
> Memory Controller (UMC).
Hi Babu,
On 4/25/2024 1:16 PM, Babu Moger wrote:
>
> The MBM (Memory Bandwidth Monitoring) and MBA (Memory Bandwidth Allocation)
> features are not enabled for AMD systems. The reason was lack of perf
> counters to compare the resctrl test results.
>
> Starting with the commit
> 25e56847821f
On 5/5/24 4:35 AM, Geliang Tang wrote:
From: Geliang Tang
Include network_helpers.h in prog_tests/sockopt_inherit.c, use public
helper start_server_addr() instead of the local defined function
start_server(). This can avoid duplicate code.
Add a helper custom_cb() to set SOL_CUSTOM sockopt
Hello:
This series was applied to bpf/bpf-next.git (master)
by Martin KaFai Lau :
On Sun, 5 May 2024 19:35:07 +0800 you wrote:
> From: Geliang Tang
>
> This patchset adds post_socket_cb pointer together with 'struct
> post_socket_opts cb_opts' into struct network_helper_opts to make
>
On Thu, May 09, 2024 at 11:46:26AM -0700, Deepak Gupta wrote:
> On Thu, May 09, 2024 at 07:14:26PM +0100, Conor Dooley wrote:
> > On Tue, Apr 16, 2024 at 08:44:16AM -0700, Deepak Gupta wrote:
> > > On Mon, Apr 15, 2024 at 02:41:05PM -0500, Rob Herring wrote:
> > > > On Wed, Apr 10, 2024 at
Hi Edward,
On Thu, 9 May 2024 19:58:05 + Edward Liaw wrote:
> _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
> redefinition warnings.
>
> Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
I show Mathieu's comment on this[1]. I have no strong
On 5/5/24 4:35 AM, Geliang Tang wrote:
From: Geliang Tang
__start_server() sets SO_REUSPORT through setsockopt() when the parameter
'reuseport' is set. This patch makes it more flexible by adding a function
pointer post_socket_cb, together with 'struct post_socket_opts cb_opts'
for future
On 2024-05-09 15:58, Edward Liaw wrote:
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
The patch per se looks fine, except for the "Fixes" tag.
Commit 809216233555 introduces use
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Drop #define __USE_GNU too, as it is bad practice and the GNU extensions
aren't actually being used in test_FCMOV, etc. where it is being defined.
Fixes: 809216233555 ("selftests/harness: remove use of
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
Signed-off-by: Edward Liaw
---
tools/testing/selftests/wireguard/qemu/init.c | 2 --
1 file changed, 2 deletions(-)
diff --git
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
Signed-off-by: Edward Liaw
---
tools/testing/selftests/vDSO/vdso_test_abi.c | 1 -
_GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent
redefinition warnings.
Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX")
Reviewed-by: John Hubbard
Reviewed-by: Muhammad Usama Anjum
Signed-off-by: Edward Liaw
---
1 - 100 of 221 matches
Mail list logo
