Re: [PATCH v4 02/27] ntsync: Introduce NTSYNC_IOC_WAIT_ALL.

On Friday, April 19, 2024 11:28:14 AM CDT Peter Zijlstra wrote: > On Thu, Apr 18, 2024 at 11:35:11AM +0200, Peter Zijlstra wrote: > > On Wed, Apr 17, 2024 at 03:03:05PM -0500, Elizabeth Figura wrote: > > > Ach. I wrote this with the idea that the race isn't meaningful, but > > > looking at it

Re: [PATCH v4 05/10] platform: Add test managed platform_device/driver APIs

Quoting Stephen Boyd (2024-04-22 16:23:58) > diff --git a/drivers/base/test/platform_kunit.c > b/drivers/base/test/platform_kunit.c > new file mode 100644 > index ..54af6db2a6d8 > --- /dev/null > +++ b/drivers/base/test/platform_kunit.c > @@ -0,0 +1,174 @@ [...] > +struct

[PATCH net] selftests/net/lib: no need to record ns name if it already exist

There is no need to add the name to ns_list again if the netns already recoreded. Fixes: 25ae948b4478 ("selftests/net: add lib.sh") Signed-off-by: Hangbin Liu --- tools/testing/selftests/net/lib.sh | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git

Re: [PATCH v3] kunit: Cover 'assert.c' with tests

On Thu, May 9, 2024 at 5:05 AM Ivan Orlov wrote: > > There are multiple assertion formatting functions in the `assert.c` > file, which are not covered with tests yet. Implement the KUnit test > for these functions. > > The test consists of 11 test cases for the following functions: > > 1)

Re: [PATCH net-next v9 00/14] Device Memory TCP

On Fri, 10 May 2024 16:21:11 -0700 Mina Almasry wrote: > Device Memory TCP Sorry Mina, this is too big to apply during the merge window :( -- pw-bot: defer

Re: [net-next PATCH] test: hsr: Extend the hsr_redbox.sh to have more SAN devices connected

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 10 May 2024 16:37:10 +0200 you wrote: > After this change the single SAN device (ns3eth1) is now replaced with > two SAN devices - respectively ns4eth1 and ns5eth1. > > It is possible to extend this script

Re: [PATCH net-next v10 0/3] net: gro: remove network_header use, move p->{flush/flush_id} calculations to L4

Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Thu, 9 May 2024 21:08:16 +0200 you wrote: > The cb fields network_offset and inner_network_offset are used instead of > skb->network_header throughout GRO. > > These fields are then leveraged in the next commit

Re: [PATCH v3 10/29] riscv/mm : ensure PROT_WRITE leads to VM_READ | VM_WRITE

On Mon, May 13, 2024 at 11:41:34AM -0700, Deepak Gupta wrote: > On Mon, May 13, 2024 at 11:36:49AM -0700, Charlie Jenkins wrote: > > On Mon, May 13, 2024 at 10:47:25AM -0700, Deepak Gupta wrote: > > > On Fri, May 10, 2024 at 02:02:54PM -0700, Charlie Jenkins wrote: > > > > On Wed, Apr 03, 2024 at

Re: [PATCH] selftest: epoll_busy_poll: Fix spelling mistake "couldnt" -> "couldn't"

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 10 May 2024 09:48:11 +0100 you wrote: > There is a spelling mistake in a TH_LOG message. Fix it. > > Signed-off-by: Colin Ian King > --- > tools/testing/selftests/net/epoll_busy_poll.c | 2 +- > 1 file

Re: [PATCH net-next] selftests: net: use upstream mtools

Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 10 May 2024 14:28:56 +0300 you wrote: > Joachim kindly merged the IPv6 support in > https://github.com/troglobit/mtools/pull/2, so we can just use his > version now. A few more fixes subsequently came in for

[PATCH v1] memfd: `MFD_NOEXEC_SEAL` should not imply `MFD_ALLOW_SEALING`

`MFD_NOEXEC_SEAL` should remove the executable bits and set `F_SEAL_EXEC` to prevent further modifications to the executable bits as per the comment in the uapi header file: not executable and sealed to prevent changing to executable However, currently, it also unsets `F_SEAL_SEAL`,

Re: [PATCH v3 10/29] riscv/mm : ensure PROT_WRITE leads to VM_READ | VM_WRITE

On Mon, May 13, 2024 at 11:36:49AM -0700, Charlie Jenkins wrote: On Mon, May 13, 2024 at 10:47:25AM -0700, Deepak Gupta wrote: On Fri, May 10, 2024 at 02:02:54PM -0700, Charlie Jenkins wrote: > On Wed, Apr 03, 2024 at 04:34:58PM -0700, Deepak Gupta wrote: > > `arch_calc_vm_prot_bits` is

Re: [PATCH v3 10/29] riscv/mm : ensure PROT_WRITE leads to VM_READ | VM_WRITE

On Mon, May 13, 2024 at 10:47:25AM -0700, Deepak Gupta wrote: > On Fri, May 10, 2024 at 02:02:54PM -0700, Charlie Jenkins wrote: > > On Wed, Apr 03, 2024 at 04:34:58PM -0700, Deepak Gupta wrote: > > > `arch_calc_vm_prot_bits` is implemented on risc-v to return VM_READ | > > > VM_WRITE if

Re: [PATCH v3 02/29] riscv: define default value for envcfg for task

On Fri, May 10, 2024 at 03:33:36PM -0700, Charlie Jenkins wrote: On Wed, Apr 03, 2024 at 04:34:50PM -0700, Deepak Gupta wrote: Defines a base default value for envcfg per task. By default all tasks should have cache zeroing capability. Any future base capabilities that apply to all tasks can be

Re: [PATCH v3 17/29] prctl: arch-agnostic prctl for indirect branch tracking

On Fri, May 10, 2024 at 04:29:19PM -0700, Charlie Jenkins wrote: On Wed, Apr 03, 2024 at 04:35:05PM -0700, Deepak Gupta wrote: Three architectures (x86, aarch64, riscv) have support for indirect branch tracking feature in a very similar fashion. On a very high level, indirect branch tracking is

Re: [PATCH v3 10/29] riscv/mm : ensure PROT_WRITE leads to VM_READ | VM_WRITE

On Sun, May 12, 2024 at 06:24:45PM +0200, Alexandre Ghiti wrote: Hi Deepak, On 04/04/2024 01:34, Deepak Gupta wrote: `arch_calc_vm_prot_bits` is implemented on risc-v to return VM_READ | VM_WRITE if PROT_WRITE is specified. Similarly `riscv_sys_mmap` is updated to convert all incoming

Re: [PATCH v3 10/29] riscv/mm : ensure PROT_WRITE leads to VM_READ | VM_WRITE

On Fri, May 10, 2024 at 02:02:54PM -0700, Charlie Jenkins wrote: On Wed, Apr 03, 2024 at 04:34:58PM -0700, Deepak Gupta wrote: `arch_calc_vm_prot_bits` is implemented on risc-v to return VM_READ | VM_WRITE if PROT_WRITE is specified. Similarly `riscv_sys_mmap` is updated to convert all incoming

[GIT PULL] Kselftest update for Linux 6.10-rc1

Hi Linus, Please pull the kselftest update for Linux 6.10-rc1. This kselftest update for Linux 6.10-rc1 consists of: - changes to make framework and tests reporting KTAP compliant - changes to make ktap_helpers and power_supply test POSIX compliant - adds ksft_exit_fail_perror() to include

Re: [PATCH v3 12/29] riscv mmu: teach pte_mkwrite to manufacture shadow stack PTEs

On Sun, May 12, 2024 at 06:28:59PM +0200, Alexandre Ghiti wrote: On 04/04/2024 01:35, Deepak Gupta wrote: pte_mkwrite creates PTEs with WRITE encodings for underlying arch. Underlying arch can have two types of writeable mappings. One that can be written using regular store instructions.

Re: [PATCH v3 13/29] riscv mmu: write protect and shadow stack

On Sun, May 12, 2024 at 06:31:24PM +0200, Alexandre Ghiti wrote: On 04/04/2024 01:35, Deepak Gupta wrote: `fork` implements copy on write (COW) by making pages readonly in child and parent both. ptep_set_wrprotect and pte_wrprotect clears _PAGE_WRITE in PTE. Assumption is that page is readable

Re: [PATCH v3 14/29] riscv/mm: Implement map_shadow_stack() syscall

On Sun, May 12, 2024 at 06:50:18PM +0200, Alexandre Ghiti wrote: On 04/04/2024 01:35, Deepak Gupta wrote: As discussed extensively in the changelog for the addition of this syscall on x86 ("x86/shstk: Introduce map_shadow_stack syscall") the existing mmap() and madvise() syscalls do not map

Re: [GIT PULL] Kselftest fixes for v6.9

On 5/12/24 04:56, Mickaël Salaün wrote: Hi Linus, Without reply from Shuah, and given the importance of these fixes [1], here is a PR to fix Kselftest (broken since v6.9-rc1) for at least KVM, pidfd, and Landlock. I cannot test against all kselftests though. This has been in linux-next since

Re: [PATCH v3 15/29] riscv/shstk: If needed allocate a new shadow stack on clone

On Sun, May 12, 2024 at 07:05:27PM +0200, Alexandre Ghiti wrote: On 04/04/2024 01:35, Deepak Gupta wrote: Userspace specifies VM_CLONE to share address space and spawn new thread. CLONE_VM? Yes I meant CLONE_VM, will fix it. `clone` allow userspace to specify a new stack for new

Re: [PATCH v3 27/29] riscv: Documentation for landing pad / indirect branch tracking

On Fri, May 10, 2024 at 01:30:32PM -0700, Charlie Jenkins wrote: On Wed, Apr 03, 2024 at 04:35:15PM -0700, Deepak Gupta wrote: Adding documentation on landing pad aka indirect branch tracking on riscv and kernel interfaces exposed so that user tasks can enable it. Signed-off-by: Deepak Gupta

Re: [PATCH v4 08/66] selftests/cgroup: Drop define _GNU_SOURCE

On Fri, May 10, 2024 at 12:06:25AM +, Edward Liaw wrote: > _GNU_SOURCE is provided by lib.mk, so it should be dropped to prevent > redefinition warnings. > > Signed-off-by: Edward Liaw Applied to cgroup/for-6.10. Thanks. -- tejun

Re: [PATCH v6 13/17] riscv: vector: Support xtheadvector save/restore

On Mon, May 13, 2024 at 04:45:18PM +0800, Andy Chiu wrote: > Hi Charlie, > > Sorry, I am late on this. I haven't looked through the entire series > yet, but here is something that I thought worth bringing up sooner. > > On Sat, May 4, 2024 at 2:22 AM Charlie Jenkins wrote: > > > > Use

[GIT PULL] KUnit update for Linux 6.10-rc1

Hi Linus, Please pull the following KUnit next update for Linux 6.10-rc1. This kunit update for Linux 6.10-rc1 consists of: - fix to race condition in try-catch completion - change to __kunit_test_suites_init() to exit early if there is nothing to test - change to string-stream-test to use

[GIT PULL] nolibc changes for Linux 6.10-rc1

Hi Linus, Please pull the nolibc update for Linux 6.10-rc1. This nolibc update for Linux 6.10-rc1 - adds support for uname(2) - removes open-coded strnlen() - exports strlen() - adds tests for strlcat() and strlcpy() - fixes memory error in realloc() - fixes strlcat() return code and size

Re: [PATCH net-next] selftests: net: local_termination: annotate the expected failures

Jakub Kicinski writes: > @@ -157,7 +168,7 @@ run_test() > > check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address" \ > "$smac > $UNKNOWN_UC_ADDR1, ethertype IPv4 (0x0800)" \ > - false > + false true > > check_rcv $rcv_if_name "Unicast

Re: [PATCH v1 1/1] selftests/sgx: Fix the implicit declaration of asprintf() compiler error

On Mon May 13, 2024 at 12:43 PM EEST, Mirsad Todorovac wrote: > Thanks for your explanation. > > I did not realise that __USE_GNU is evil. :-/ It's not "evil" IMHO. It is not just part of defined API :-) Thus the official man pages are your friend. > > FWIW, there is a sound explanation of the

Re: [PATCH v1 1/1] selftests/sgx: Fix the implicit declaration of asprintf() compiler error

Thanks for your explanation. I did not realise that __USE_GNU is evil. :-/ FWIW, there is a sound explanation of the difference between _GNU_SOURCE and __USE_GNU here: https://stackoverflow.com/questions/7296963/gnu-source-and-use-gnu Thanks, Mirsad On Mon, May 13, 2024 at 1:02 AM Jarkko

Re: [PATCH v6 13/17] riscv: vector: Support xtheadvector save/restore

Hi Charlie, Sorry, I am late on this. I haven't looked through the entire series yet, but here is something that I thought worth bringing up sooner. On Sat, May 4, 2024 at 2:22 AM Charlie Jenkins wrote: > > Use alternatives to add support for xtheadvector vector save/restore > routines. > >

[PATCH] selftests/mm: compaction_test: Fix trivial test pass on Aarch64 when nr_hugepages = 0

Currently, if at runtime we are not able to allocate a huge page, the test will trivially pass on Aarch64 due to no exception being raised on division by zero while computing compaction_index. Fix that by checking for nr_hugepages == 0. Anyways, in general, avoid a division by zero by exiting the

Re: [PATCH AUTOSEL 6.1 08/25] KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF

On Mon, 13 May 2024 09:20:38 +0100, Pavel Machek wrote: > > Hi! > > > Assert that accesses to a non-existent vgic-v2 CPU interface > > consistently fail across the various KVM device attr ioctls. This also > > serves as a regression test for a bug wherein KVM hits a NULL > > dereference when

Re: [PATCH AUTOSEL 6.1 08/25] KVM: selftests: Add test for uaccesses to non-existent vgic-v2 CPUIF

Hi! > Assert that accesses to a non-existent vgic-v2 CPU interface > consistently fail across the various KVM device attr ioctls. This also > serves as a regression test for a bug wherein KVM hits a NULL > dereference when the CPUID specified in the ioctl is invalid. > > Note that there is no

Re: [PATCH bpf-next v2 1/4] selftests/bpf: Add some null pointer checks

> There is a 'malloc' call, which can be unsuccessful. two calls? > This patch will add the malloc failure checking … Please use imperative wordings for improved change descriptions also in your patches.

Re: [PATCH bpf-next v2 1/4] selftests/bpf: Add some null pointer checks

On 2024/5/10 19:20, Muhammad Usama Anjum wrote: On 5/10/24 2:58 PM, kunwu.c...@linux.dev wrote: From: Kunwu Chan There is a 'malloc' call, which can be unsuccessful. This patch will add the malloc failure checking to avoid possible null dereference. Signed-off-by: Kunwu Chan ---

[PATCH net v2] selftests: net: kill smcrouted in the cleanup logic in amt.sh

The amt.sh requires smcrouted for multicasting routing. So, it starts smcrouted before forwarding tests. It must be stopped after all tests, but it isn't. To fix this issue, it kills smcrouted in the cleanup logic. Fixes: c08e8baea78e ("selftests: add amt interface selftest script")