On Tue, May 14, 2024 at 09:14:37PM -0700, Linus Torvalds wrote:
> On Tue, 14 May 2024 at 20:36, Linus Torvalds
> wrote:
> >
> > Guys, if you let untrusted code execute random system calls, the whole
> > "look, now unmap() acts oddly" IS THE LEAST OF YOUR ISSUES.
I totally agree with this, I'm mor
From: Geliang Tang
This patch uses netns helpers create_netns() and cleanup_netns() in
test_tunnel.c instead of using open_netns() and close_netns() directly.
Signed-off-by: Geliang Tang
---
.../selftests/bpf/prog_tests/test_tunnel.c| 19 +--
1 file changed, 9 insertions(+)
From: Geliang Tang
This patch uses netns helpers create_netns() and cleanup_netns() in
lwt_helpers.h instead of using the local function netns_create() and
netns_delete().
For using these helpers. network_helpers.h needs to be included in
lwt_helpers.h. Then '#include "network_helpers.h"' in lwt
From: Geliang Tang
This patch uses cleanup_netns() helper in BPF tests wide to replace
close_netns() and "ip netns del", included assign_reuse.c, crypto_sanity.c,
decap_sanity.c, fib_lookup.c, ns_current_pid_tgid.c, sock_destroy.c,
sock_iter_batch.c, xdp_dev_bound_only.c and xdp_do_redirect.c. Th
From: Geliang Tang
This patch adds a new struct member name in struct nstoken, to save
the name of the given network namespace. It dups the name string in
open_netns() and freed in close_netns().
Then move cleanup_netns() from mptcp.c into network_helpers.c as a
public helper. In it the newly ad
From: Geliang Tang
The newly added helper create_netns() can be used in assign_reuse.c,
fib_lookup.c, ns_current_pid_tgid.c, sock_destroy.c and sock_iter_batch.c
to simplify the code.
It changes the behavior of test fib_lookup.c a little bit, but doesn't
affect the results.
Signed-off-by: Gelia
From: Geliang Tang
This patch moves create_netns() from mptcp.c into network_helpers.c, and
export it in network_helpers.h as a public helper.
The new helper accepts a string parameter, and uses SYS_NOFAIL() instead
of SYS() to execute the command, since SYS() deponds on test__fail()
which is de
From: Geliang Tang
This patch drops the duplicate local functions create_netns() in
bind_perm.c, bpf_iter_setsockopt.c, setget_sockopt.c, sock_fields.c
and tcp_hdr_options.c and uses unshare_netns() instead.
A new helper create_netns() will be added in network_helpers.c as a
public one.
Signed-
From: Geliang Tang
The newly added helper unshare_netns() can be used to replace unshare()
and "ip link set dev lo up" in sk_assign.c, btf_skc_cls_ingress.c and
tcp_custom_syncookie.c to simplify the code.
Signed-off-by: Geliang Tang
---
.../testing/selftests/bpf/prog_tests/btf_skc_cls_ingress
From: Geliang Tang
Many BPF selftests create new test network namespaces by using CLONE_NEWNET
flag to unshare the network namespace, so that the calling process is moved
into a new network namespace which is not shared with any previously
existing process. So this patch adds a new helper in netw
From: Geliang Tang
This patchset addresses Alexei's comment for commit "Handle SIGINT
when creating netns" [1]. Export local helpers create_netns() and
cleanup_netns() defined in mptcp.c into network_helpers.c as generic
ones. For this another helper unshare_netns() is added to replace
the existi
From: "Steven Rostedt (Google)"
The function "scheduler_tick" was renamed to "sched_tick" and a selftest
that used that function for testing function trace filtering used that
function as part of the test.
But the change causes it to fail when run on older kernels. As tests
should not fail on ol
On 2024-05-14 at 20:55:11 -0700, Kuppuswamy, Sathyanarayanan wrote:
>
> On 4/29/24 8:31 PM, Pengfei Xu wrote:
> > To verify IFS (In Field Scan [1]) driver functionality, add the following 6
> > test cases:
> > 1. Verify that IFS sysfs entries are created after loading the IFS module
> > 2. Che
* Theo de Raadt [240514 22:42]:
> Linus Torvalds wrote:
>
> > On Tue, 14 May 2024 at 18:47, Theo de Raadt wrote:
> > >
> > > Linus Torvalds wrote:
> > >
> > > Regarding mprotect(), POSIX also says:
> > >
> > > An implementation may permit accesses other than those specified by
> > > pr
Adding Shuah Khan to cc.
-Abhinav.
On Wed, May 15, 2024 at 01:08:01AM +, Abhinav Saxena wrote:
> Hi everyone,
>
> My name is Abhinav Saxena. I am a graduate student at the University
> of Calgary. This is my first patch series for the Linux kernel. I am
> applying for the "Linux kernel Bug F
From: Geliang Tang
For getting rid of the second parameter of do_test(), this patch adds a
new callback post_connect_cb in struct network_helper_opts, it will be
invoked after connect_fd_to_addr() in connect_to_fd_opts().
Then define a dctcp dedicated post_connect_cb callback, invoking
bpf_map_l
From: Geliang Tang
This patch uses connect_to_fd_opts() instead of using connect_fd_to_fd()
and settcpca() in do_test() in prog_tests/bpf_tcp_ca.c to accept a struct
network_helper_opts argument.
Then define a dctcp dedicated post_socket_cb callback stg_post_socket_cb(),
invoking both cc_cb() an
From: Geliang Tang
This patch uses start_server_addr() in do_test() in prog_tests/bpf_tcp_ca.c
to accept a struct network_helper_opts argument instead of using
start_server() and settcpca(). Then change the type of the first paramenter
of do_test() into a struct network_helper_opts one.
Define i
From: Geliang Tang
Since the post_socket_cb() callback is added in struct network_helper_opts,
it's make sense to use it not only in __start_server(), but also in
connect_to_fd_opts(). Then it can be used to set TCP_CONGESTION sockopt.
Add a post_socket_opts type member cb_opts into struct netwo
From: Geliang Tang
This patchset uses post_socket_cb and post_connect_cb callbacks of struct
network_helper_opts to refactor do_test() in bpf_tcp_ca.c to move dctcp
test dedicated code out of do_test() into test_dctcp().
Patch 3 adds a new member in post_socket_opts and patch 4 adds a new
callba
On Tue, 14 May 2024 at 20:36, Linus Torvalds
wrote:
>
> Guys, if you let untrusted code execute random system calls, the whole
> "look, now unmap() acts oddly" IS THE LEAST OF YOUR ISSUES.
Side note: it doesn't even help to make things "atomic". munmap() acts
oddly whether it fals completely or w
On 4/29/24 8:31 PM, Pengfei Xu wrote:
> To verify IFS (In Field Scan [1]) driver functionality, add the following 6
> test cases:
> 1. Verify that IFS sysfs entries are created after loading the IFS module
> 2. Check if loading an invalid IFS test image fails and loading a valid
> one su
On Tue, 14 May 2024 at 20:13, Willy Tarreau wrote:
>
> Wouldn't it be more effective to have a non-resettable prctl() allowing
> the application to prefer to be killed upon such an munmap() failure in
> order to stay consistent and more robust against such class of attacks?
This whole argument is
On Tue, May 14, 2024 at 05:47:30PM -0600, Theo de Raadt wrote:
> Andrew Morton wrote:
>
> > > I worry that the non-atomicity will one day be used by an attacker.
> >
> > How might an attacker exploit this?
>
> Various ways which are going to be very application specific. Most ways
> will depend
Linus Torvalds wrote:
> On Tue, 14 May 2024 at 18:47, Theo de Raadt wrote:
> >
> > Linus Torvalds wrote:
> >
> > Regarding mprotect(), POSIX also says:
> >
> > An implementation may permit accesses other than those specified by
> > prot; however, no implementation shall permit a write t
On Tue, 14 May 2024 at 18:47, Theo de Raadt wrote:
>
> Linus Torvalds wrote:
>
> Regarding mprotect(), POSIX also says:
>
> An implementation may permit accesses other than those specified by
> prot; however, no implementation shall permit a write to succeed where
> PROT_WRITE has not
Linus Torvalds wrote:
Regarding mprotect(), POSIX also says:
An implementation may permit accesses other than those specified by
prot; however, no implementation shall permit a write to succeed where
PROT_WRITE has not been set or shall permit any access where PROT_NONE
alone has
Hi Geliang,
kernel test robot noticed the following build errors:
[auto build test ERROR on bpf-next/master]
url:
https://github.com/intel-lab-lkp/linux/commits/Geliang-Tang/selftests-bpf-Use-post_socket_cb-in-connect_to_fd_opts/20240511-111755
base: https://git.kernel.org/pub/scm/linux/ke
On Tue, 14 May 2024 at 17:57, Theo de Raadt wrote:
>
> Let's wait and see.
You may not be aware, but the Open Group literally endorses the Linux model:
"When mprotect() fails for reasons other than [EINVAL], the
protections on some of the pages in the range [addr,addr+len) may have
been change
Adds a blank line after declarations and fixes some more formatting
issues.
Signed-off-by: Abhinav Saxena
---
.../testing/selftests/filesystems/binderfs/binderfs_test.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/tools/testing/selftests/filesystems/binderfs/binderf
Change the macro argument 'fd' to '(fd)' to avoid potential precedence
issues. Without parentheses, the macro expansion could lead to
unexpected behavior when used with an expression having different
precedence levels.
Example Code:
#define CALC_SQR_BAD(x) (x*x)
#define CALC_SQR_GOOD(x) (
This commit adds some fixes towards making
`filesystems/binderfs/binderfs_test.c` conform to the kernel coding
standards, improving readability and maintainability.
Signed-off-by: Abhinav Saxena
---
.../filesystems/binderfs/binderfs_test.c | 187 +++---
1 file changed, 116 inser
Enclosing the close_prot_errno_disarm macro in do {...} while (false)
structure could prevent potential bugs and undefined behavior.
Example code:
#define BINDERFUNC(x) f(x); g(x);
if (condition)
BINDERFUNC(x);
When BINDERFUNC(x) expands, g(x) would be executed outside of if
bloc
Hi everyone,
My name is Abhinav Saxena. I am a graduate student at the University
of Calgary. This is my first patch series for the Linux kernel. I am
applying for the "Linux kernel Bug Fixing Summer Unpaid
2024". Apologies in advance if I made any trivial mistakes :)
This patch mainly includes i
> > I worry that the non-atomicity will one day be used by an attacker.
>
> Blah blah blah. That's a made-up scare tactic if I ever heard one.
> It's unworthy of you.
Let's wait and see.
(Linus, don't be a jerk)
On Tue, 14 May 2024 at 15:48, Theo de Raadt wrote:
>
> and can't imagine it affecting a single application
Honestly, that's the reason for not caring.
You have to do actively wrong things for this to matter AT ALL.
So no, we're not making gratuitous changes for stupid reasons.
> I worry that t
On Mon, 13 May 2024 15:25:38 +0200 Petr Machata wrote:
> For veth specifically there is xfail_on_veth:
>
> xfail_on_veth $rcv_if_name \
> check_rcv $rcv_if_name "Unicast IPv4 to unknown MAC address" \
> "$smac > $UNKNOWN_UC_ADDR1, ethertype IPv4 (0x0800)" \
>
On Tue, 14 May 2024 16:48:47 -0600 "Theo de Raadt" wrote:
> Matthew Wilcox wrote:
>
> > > Not taking a position on merging, but I have to ask: are we convinced at
> > > this point that mseal() isn't a chrome-only system call? Did we ever
> > > see the glibc patches that were promised?
> >
> >
Matthew Wilcox wrote:
> > Not taking a position on merging, but I have to ask: are we convinced at
> > this point that mseal() isn't a chrome-only system call? Did we ever
> > see the glibc patches that were promised?
>
> I think _this_ version of mseal() is OpenBSD's mimmutable() with a
> basi
On Thu, 28 Mar 2024 at 22:20, Brendan Jackman wrote:
>
> It seems obvious once you know, but at first I didn't realise that the
> suite name is part of this format. Document it and add example.
>
> Signed-off-by: Brendan Jackman
> ---
We can take this via KUnit -- sorry for the delay.
Reviewed-
Brendan Jackman writes:
> On Wed, Apr 03, 2024 at 02:59:43PM -0700, Daniel Latypov wrote:
>> Reviewed-by: Daniel Latypov
>
> Hi Jonathan, I think this is ready to be applied?
I'm happy to take this, but normally these patches go through the kunit
tree, so I've not been paying much attention. L
Quoting Stephen Boyd (2024-05-02 18:27:42)
> Quoting David Gow (2024-05-01 01:08:11)
> >
> > The other thing I've noted so far is that the
> > of_apply_kunit_platform_device and of_overlay_apply_kunit_cleanup
> > tests fail (and BUG() with a NULL pointer) on powerpc:
> > > [15:18:51] # of_over
* Andrew Morton [240514 13:47]:
> On Mon, 15 Apr 2024 16:35:19 + jef...@chromium.org wrote:
>
> > This patchset proposes a new mseal() syscall for the Linux kernel.
>
> I have not moved this into mm-stable for a 6.10 merge. Mainly because
> of the total lack of Reviewed-by:s and Acked-by:s.
On Tue, May 14, 2024 at 02:59:57PM -0600, Jonathan Corbet wrote:
> Andrew Morton writes:
>
> > On Mon, 15 Apr 2024 16:35:19 + jef...@chromium.org wrote:
> >
> >> This patchset proposes a new mseal() syscall for the Linux kernel.
> >
> > I have not moved this into mm-stable for a 6.10 merge.
On Wed, Apr 03, 2024 at 02:59:43PM -0700, Daniel Latypov wrote:
> Reviewed-by: Daniel Latypov
Hi Jonathan, I think this is ready to be applied?
Thanks,
Brendan
Andrew Morton writes:
> On Mon, 15 Apr 2024 16:35:19 + jef...@chromium.org wrote:
>
>> This patchset proposes a new mseal() syscall for the Linux kernel.
>
> I have not moved this into mm-stable for a 6.10 merge. Mainly because
> of the total lack of Reviewed-by:s and Acked-by:s.
>
> The cod
On 5/14/24 20:55, 'Rae Moar' via KUnit Development wrote:
Thank you once again,
--
Kind regards,
Ivan Orlov
Hello!
This sounds like a great approach! Happy to review the new patch
series when it comes in.
Thanks,
Rae
Awesome, thank you!
--
Kind regards,
Ivan Orlov
On Tue, May 14, 2024 at 10:31 AM Ivan Orlov wrote:
>
> On 5/14/24 01:17, Rae Moar wrote:
> > On Thu, May 9, 2024 at 5:05 AM Ivan Orlov wrote:
> >>
> >> There are multiple assertion formatting functions in the `assert.c`
> >> file, which are not covered with tests yet. Implement the KUnit test
> >
On Tue, May 14, 2024 at 10:46:46AM -0700, Andrew Morton wrote:
> On Mon, 15 Apr 2024 16:35:19 + jef...@chromium.org wrote:
>
> > This patchset proposes a new mseal() syscall for the Linux kernel.
>
> I have not moved this into mm-stable for a 6.10 merge. Mainly because
> of the total lack of
The pull request you sent on Mon, 13 May 2024 11:38:51 -0600:
> git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
> tags/linux_kselftest-next-6.10-rc1
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4b95dc87362aa57bdd0dcbad109ca5e5ef3cbb6c
Thank you!
The pull request you sent on Mon, 13 May 2024 10:10:38 -0600:
> git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
> tags/linux_kselftest-kunit-6.10-rc1
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/896d3fce84e7798520eb11b0e53abdcfb47b21be
Thank you
The pull request you sent on Mon, 13 May 2024 09:13:47 -0600:
> git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest
> tags/linux_kselftest-nolibc-6.10-rc1
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/4b768bf062db22e042a731e4c385bb0b4fa21a0e
Thank yo
Hello:
This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski :
On Tue, 14 May 2024 19:06:15 +0200 you wrote:
> Add 2 byte padding to napi_gro_cb struct to ensure zeroed member is
> aligned after flush_id member was removed in the original commit.
>
> Fixes: 4b0ebbca3e16 ("net: g
On Mon, 15 Apr 2024 16:35:19 + jef...@chromium.org wrote:
> This patchset proposes a new mseal() syscall for the Linux kernel.
I have not moved this into mm-stable for a 6.10 merge. Mainly because
of the total lack of Reviewed-by:s and Acked-by:s.
The code appears to be stable enough for a
On Mon, Apr 29, 2024 at 05:04:55PM +0200, Clément Léger wrote:
> Since a few extensions (Zicbom/Zicboz) already needs validation and
> future ones will need it as well (Zc*) add a validate() callback to
> struct riscv_isa_ext_data. This require to rework the way extensions are
> parsed and split it
Hi Shuah,
On 5/14/2024 9:45 AM, Shuah Khan wrote:
> On 4/29/24 21:31, Pengfei Xu wrote:
>> To verify IFS (In Field Scan [1]) driver functionality, add the following 6
>> test cases:
...
>>
>
> I am fine with adding a test. I would need ifs ack or reviewed-by.
> I don't see ifs maintainer on on t
On Mon, May 13, 2024 at 4:31 PM Jakub Kicinski wrote:
>
> On Fri, 10 May 2024 16:21:11 -0700 Mina Almasry wrote:
> > Device Memory TCP
>
> Sorry Mina, this is too big to apply during the merge window :(
No worries at all. I'll repost once it re-opens with any feedback I
get in the meantime.
--
Add 2 byte padding to napi_gro_cb struct to ensure zeroed member is
aligned after flush_id member was removed in the original commit.
Fixes: 4b0ebbca3e16 ("net: gro: move L3 flush checks to tcp_gro_receive and
udp_gro_receive_segment")
Suggested-by: Geert Uytterhoeven
Signed-off-by: Richard Gobe
On 4/29/24 21:31, Pengfei Xu wrote:
To verify IFS (In Field Scan [1]) driver functionality, add the following 6
test cases:
1. Verify that IFS sysfs entries are created after loading the IFS module
2. Check if loading an invalid IFS test image fails and loading a valid
one succeeds
From: Vincent Donnefort
Map a ring-buffer, validate the meta-page before and after emitting few
events. Also check ring-buffer mapping boundaries and finally ensure the
tracing snapshot is mutually exclusive.
Link:
https://lore.kernel.org/linux-trace-kernel/20240510140435.3550353-6-vdonnef...@g
On Tue, 14 May 2024 17:56:44 +0200 Richard Gobert wrote:
> > Hi Richard, any chance of getting this fixed within the next 2 hours?
> > I can't send the net-next PR if it doesn't build on one of the arches..
>
> Hi Jakub and Geert,
> I'm only seeing this mail now, sorry for the late response.
> I
net-next:
>>> 10.09% [kernel] [k] inet_gro_receive
>>> 2.08% [kernel] [k] tcp_gro_receive
>>>
>>> patch applied:
>>> 6.97% [kernel] [k] inet_gro_receive
>>> 3.68% [kernel] [k] tcp_gro_receive
>>>
&g
On Tue, May 14, 2024 at 02:48:01PM +0200, Clément Léger wrote:
>
>
> On 14/05/2024 14:43, Conor Dooley wrote:
> > On Tue, May 14, 2024 at 09:53:08AM +0200, Clément Léger wrote:
> >>
> >>
> >> On 30/04/2024 13:44, Conor Dooley wrote:
> >>> On Tue, Apr 30, 2024 at 09:18:47AM +0200, Clément Léger wr
On 5/14/24 01:17, Rae Moar wrote:
On Thu, May 9, 2024 at 5:05 AM Ivan Orlov wrote:
There are multiple assertion formatting functions in the `assert.c`
file, which are not covered with tests yet. Implement the KUnit test
for these functions.
The test consists of 11 test cases for the following
tch applied:
> > 6.97% [kernel] [k] inet_gro_receive
> > 3.68% [kernel] [k] tcp_gro_receive
> >
> > Signed-off-by: Richard Gobert
>
> Thanks for your patch, which is now commit 4b0ebbca3e167976 ("net: gro:
> move L3 flush checks to tcp_gro_receiv
On Fri, 2024-05-10 at 17:03 +0800, Chenyi Qiang wrote:
>
> Do we need to track vcpu->arch.this_tsc_nsec/this_tsc_write? At least
> they are still used in compute_guest_tsc() to calculate the guest
> tsc.
Ah yes, that's true. Good catch; thanks.
That should be caught by a test case which runs the
On 14/05/2024 14:43, Conor Dooley wrote:
> On Tue, May 14, 2024 at 09:53:08AM +0200, Clément Léger wrote:
>>
>>
>> On 30/04/2024 13:44, Conor Dooley wrote:
>>> On Tue, Apr 30, 2024 at 09:18:47AM +0200, Clément Léger wrote:
On 30/04/2024 00:15, Conor Dooley wrote:
> On Mon, Apr
On Tue, May 14, 2024 at 09:53:08AM +0200, Clément Léger wrote:
>
>
> On 30/04/2024 13:44, Conor Dooley wrote:
> > On Tue, Apr 30, 2024 at 09:18:47AM +0200, Clément Léger wrote:
> >>
> >>
> >> On 30/04/2024 00:15, Conor Dooley wrote:
> >>> On Mon, Apr 29, 2024 at 05:04:55PM +0200, Clément Léger wr
[kernel] [k] tcp_gro_receive
>
> patch applied:
> 6.97% [kernel] [k] inet_gro_receive
> 3.68% [kernel] [k] tcp_gro_receive
>
> Signed-off-by: Richard Gobert
Thanks for your patch, which is now commit 4b0ebbca3e167976 ("net: gro:
move L3 flush checks to
6.6-stable review patch. If anyone has any objections, please let me know.
--
From: Mark Rutland
[ Upstream commit 8ecab2e64572f1aecdfc5a8feae748abda6e3347 ]
The event filter function test has been failing in our internal test
farm:
| # not ok 33 event filter function - test
6.8-stable review patch. If anyone has any objections, please let me know.
--
From: Mark Rutland
[ Upstream commit 8ecab2e64572f1aecdfc5a8feae748abda6e3347 ]
The event filter function test has been failing in our internal test
farm:
| # not ok 33 event filter function - test
On Tue, May 14, 2024 at 10:33:59AM +0800, Hangbin Liu wrote:
> There is no need to add the name to ns_list again if the netns already
> recoreded.
>
> Fixes: 25ae948b4478 ("selftests/net: add lib.sh")
> Signed-off-by: Hangbin Liu
Reviewed-by: Simon Horman
The check_random_order test add/get plenty of xfrm rules, which consume
a lot time on debug kernel and always TIMEOUT. Let's reduce the test
loop and see if it works.
Signed-off-by: Hangbin Liu
---
tools/testing/selftests/net/xfrm_policy.sh | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(
On 30/04/2024 13:44, Conor Dooley wrote:
> On Tue, Apr 30, 2024 at 09:18:47AM +0200, Clément Léger wrote:
>>
>>
>> On 30/04/2024 00:15, Conor Dooley wrote:
>>> On Mon, Apr 29, 2024 at 05:04:55PM +0200, Clément Léger wrote:
Since a few extensions (Zicbom/Zicboz) already needs validation and
Test arp_ndisc_untracked_subnets use tcpdump to filter the unsolicited
and untracked na messages. It set -e before calling tcpdump. But if
tcpdump filters 0 packet, it will return none zero, and cause the script
to exit.
Instead of using slow tcpdump to capture packets, let's using tc rule
to filt
75 matches
Mail list logo
