Re: [PATCH net-next v12 00/13] Device Memory TCP

2024-06-13 Thread Mina Almasry
On Thu, Jun 13, 2024 at 6:35 PM Jakub Kicinski wrote: > > On Thu, 13 Jun 2024 01:35:37 + Mina Almasry wrote: > > v12: > > https://patchwork.kernel.org/project/netdevbpf/list/?series=859747&state=* > > patches 5 and 6 transiently break the build > > ../include/trace/events/page_pool.h:65:23: e

Re: [PATCH v2 2/3] selftest/mm: test enable_soft_offline behaviors

2024-06-13 Thread Miaohe Lin
On 2024/6/12 5:55, Jiaqi Yan wrote: > Add regression and new tests when hugepage has correctable memory > errors, and how userspace wants to deal with it: > * if enable_soft_offline=0, mapped hugepage is soft offlined > * if enable_soft_offline=1, mapped hugepage is intact This shoule be something

Re: [PATCH v2 1/3] mm/memory-failure: userspace controls soft-offlining pages

2024-06-13 Thread Miaohe Lin
On 2024/6/12 5:55, Jiaqi Yan wrote: > Correctable memory errors are very common on servers with large > amount of memory, and are corrected by ECC. Soft offline is kernel's > additional recovery handling for memory pages having (excessive) > corrected memory errors. Impacted page is migrated to a h

[PATCH v2 6/6] selftests/mm: remove local __NR_* definitions

2024-06-13 Thread John Hubbard
This continues the work on getting the selftests to build without requiring people to first run "make headers" [1]. Now that the system call numbers are in the correct, checked-in locations in the kernel tree (./tools/include/uapi/asm/unistd*.h), make sure that the mm selftests include that file (

[PATCH v2 1/6] selftests/mm: mseal, self_elf: fix missing __NR_mseal

2024-06-13 Thread John Hubbard
The selftests/mm build isn't exactly "broken", according to the current documentation, which still claims that one must run "make headers", before building the kselftests. However, according to the new plan to get rid of that requirement [1], they are future-broken: attempting to build selftests/mm

[PATCH v2 5/6] selftests/mm: kvm, mdwe fixes to avoid requiring "make headers"

2024-06-13 Thread John Hubbard
On Ubuntu 23.04, the kvm and mdwe selftests/mm build fails due to missing a few items that are found in prctl.h. Here is an excerpt of the build failures: ksm_tests.c:252:13: error: use of undeclared identifier 'PR_SET_MEMORY_MERGE' ... mdwe_test.c:26:18: error: use of undeclared identifier 'PR_SE

[PATCH v2 3/6] selftests/mm: mseal, self_elf: rename TEST_END_CHECK to REPORT_TEST_PASS

2024-06-13 Thread John Hubbard
Now that the test macros are factored out into their final location, and simplified, it's time to rename TEST_END_CHECK to something that represents its new functionality: REPORT_TEST_PASS. Cc: David Hildenbrand Reviewed-by: Jeff Xu Tested-by: Jeff Xu Signed-off-by: John Hubbard --- tools/tes

[PATCH v2 4/6] selftests/mm: fix vm_util.c build failures: add snapshot of fs.h

2024-06-13 Thread John Hubbard
On Ubuntu 23.04, on a clean git tree, the selftests/mm build fails due 10 or 20 missing items, all of which are found in fs.h, which is created via "make headers". However, as per [1], the idea is to stop requiring "make headers", and instead, take a snapshot of the files and check them in. Here a

[PATCH v2 2/6] selftests/mm: mseal, self_elf: factor out test macros and other duplicated items

2024-06-13 Thread John Hubbard
Clean up and move some copy-pasted items into a new mseal_helpers.h. 1. The test macros can be made safer and simpler, by observing that they are invariably called when about to return. This means that the macros do not need an intrusive label to goto; they can simply return. 2. PKEY* items. We c

[PATCH v2 0/6] cleanups, fixes, and progress towards avoiding "make headers"

2024-06-13 Thread John Hubbard
Jeff Xu, I apologize for this churn: I was forced to drop your Reviewed-by and Tested-by tags from 2 of the 3 mseal patches, because the __NR_mseal fix is completely different now. Changes since v1: a) Reworked the mseal fix to use the kernel's in-tree unistd*.h files, instead of hacking in a __N

Re: [PATCH bpf-next v2 0/4] use network helpers, part 7

2024-06-13 Thread Geliang Tang
Superseded, will send a v3 soon. Thanks, -Geliang On Wed, 2024-06-12 at 22:41 +0800, Geliang Tang wrote: > From: Geliang Tang > > v2: >  - update patch 2, extract a new helper start_client. >  - drop patch 3, keep must_fail in network_helper_opts. > > Drop type and noconnect from network_helpe

Re: [PATCH v2] sefltests: net: Add on/off checks for network interface non fixed features

2024-06-13 Thread Jakub Kicinski
On Sun, 9 Jun 2024 13:21:24 + Abhinav Jain wrote: > This patch addresses the TODO (add non fixed feature on/off check). > I have tested it manually on my system and made changes as suggested in v1 > echo "PASS: $netdev: ethtool list features" > - #TODO for each non fixed features, t

Re: [PATCH net-next v12 00/13] Device Memory TCP

2024-06-13 Thread Jakub Kicinski
On Thu, 13 Jun 2024 01:35:37 + Mina Almasry wrote: > v12: > https://patchwork.kernel.org/project/netdevbpf/list/?series=859747&state=* patches 5 and 6 transiently break the build ../include/trace/events/page_pool.h:65:23: error: use of undeclared identifier 'NET_IOV' 65 |

RE: [PATCH v2 00/25] Enable FRED with KVM VMX

2024-06-13 Thread Li, Xin3
> On Wed, Mar 27, 2024, Shan Kang wrote: > > On Wed, 2024-02-07 at 09:26 -0800, Xin Li wrote: > > > This patch set enables the Intel flexible return and event delivery > > > (FRED) architecture with KVM VMX to allow guests to utilize FRED. > > > > > We tested this FRED KVM patch set on a 7th Intel(

[PATCH v15 9/9] selftests/udmabuf: Add tests to verify data after page migration

2024-06-13 Thread Vivek Kasireddy
Since the memfd pages associated with a udmabuf may be migrated as part of udmabuf create, we need to verify the data coherency after successful migration. The new tests added in this patch try to do just that using 4k sized pages and also 2 MB sized huge pages for the memfd. Successful completion

[RFC net-next 7/7] selftests: net: add config for openvswitch

2024-06-13 Thread Aaron Conole
The pmtu testing will require that the OVS module is installed, so do that. Signed-off-by: Aaron Conole --- tools/testing/selftests/net/config | 5 + 1 file changed, 5 insertions(+) diff --git a/tools/testing/selftests/net/config b/tools/testing/selftests/net/config index 04de7a6ba6f3..d85

Re: [PATCH 0/5] cleanups, fixes, and progress towards avoiding "make headers"

2024-06-13 Thread John Hubbard
On 6/12/24 7:11 PM, John Hubbard wrote: On 6/12/24 1:24 AM, David Hildenbrand wrote: On 11.06.24 22:54, John Hubbard wrote: On 6/11/24 2:36 AM, David Hildenbrand wrote: On 08.06.24 04:10, John Hubbard wrote: ... You remembered correctly, but the situation is slighly muddier than one would pr

Re: [PATCH v2 11/25] KVM: x86: Add kvm_is_fred_enabled()

2024-06-13 Thread Sean Christopherson
On Wed, Feb 07, 2024, Xin Li wrote: > Add kvm_is_fred_enabled() to get if FRED is enabled on a vCPU. > > Signed-off-by: Xin Li > Tested-by: Shan Kang > --- > > Change since v1: > * Explain why it is ok to only check CR4.FRED (Chao Gao). > --- > arch/x86/kvm/kvm_cache_regs.h | 17 ++

Re: [PATCH v2 4/4] bpf,lsm: Allow editing capabilities in BPF-LSM hooks

2024-06-13 Thread Paul Moore
On Thu, Jun 13, 2024 at 4:45 AM Jonathan Calmels wrote: > On Wed, Jun 12, 2024 at 08:54:28PM GMT, John Johansen wrote: > > On 6/12/24 10:29, Paul Moore wrote: > > > On Wed, Jun 12, 2024 at 4:15 AM Jonathan Calmels > > > wrote: > > > > On Tue, Jun 11, 2024 at 06:38:31PM GMT, Paul Moore wrote: > >

Re: [PATCH v2 4/4] bpf,lsm: Allow editing capabilities in BPF-LSM hooks

2024-06-13 Thread Paul Moore
On Wed, Jun 12, 2024 at 11:54 PM John Johansen wrote: > On 6/12/24 10:29, Paul Moore wrote: > > On Wed, Jun 12, 2024 at 4:15 AM Jonathan Calmels wrote: > >> On Tue, Jun 11, 2024 at 06:38:31PM GMT, Paul Moore wrote: > >>> On Tue, Jun 11, 2024 at 6:15 PM Jonathan Calmels > >>> wrote: > > > > ...

Re: [RFC net-next 6/7] selftests: net: Use the provided dpctl rather than the vswitchd for tests.

2024-06-13 Thread Stefano Brivio
On Thu, 13 Jun 2024 14:13:32 -0400 Aaron Conole wrote: > The current pmtu test infrastucture requires an installed copy of the > ovs-vswitchd userspace. This means that any automated or constrained > environments may not have the requisite tools to run the tests. However, > the pmtu tests don't

[RFC net-next 2/7] selftests: openvswitch: Refactor actions parsing.

2024-06-13 Thread Aaron Conole
Until recently, the ovs-dpctl utility was used with a limited actions set and didn't need to have support for multiple similar actions. However, when adding support for tunnels, it will be important to support multiple set() actions in a single flow. When printing these actions, the existing code

Re: [PATCH v2 14/25] KVM: VMX: Disable FRED if FRED consistency checks fail

2024-06-13 Thread Sean Christopherson
On Tue, Apr 30, 2024, Chao Gao wrote: > On Thu, Feb 08, 2024 at 01:26:34AM +0800, Xin Li wrote: > >Refuse to virtualize FRED if FRED consistency checks fail. > > After reading this, I realize some consistency checks are missing in > setup_vmcs_config(). Actually Sean requested some infrastructure

[RFC net-next 1/7] selftests: openvswitch: Support explicit tunnel port creation.

2024-06-13 Thread Aaron Conole
The OVS module can operate in conjunction with various types of tunnel ports. These are created as either explicit tunnel vport types, OR by creating a tunnel interface which acts as an anchor for the lightweight tunnel support. This patch adds the ability to add tunnel ports to an OVS datapath f

Re: [PATCH v2 12/25] KVM: VMX: Handle FRED event data

2024-06-13 Thread Sean Christopherson
On Wed, Feb 07, 2024, Xin Li wrote: > @@ -7382,6 +7419,24 @@ static noinstr void vmx_vcpu_enter_exit(struct > kvm_vcpu *vcpu, > > vmx_disable_fb_clear(vmx); > > + /* > + * %cr2 needs to be saved after a VM exit and restored before a VM > + * entry in case a VM exit happens

Re: [PATCH 2/2] selftests: kvm: replace exit() with ksft_exit_fail_msg()

2024-06-13 Thread Sean Christopherson
On Thu, Jun 13, 2024, Muhammad Usama Anjum wrote: > > As above, AFAICT it comes from Google's internal test infrastructure (KVM > > selftests > > came from Google). > > > >> Its even better if we use ksft_exit_fail_msg() which will print out "Bail > >> out" meaning the test exited without complet

Re: [PATCH v2 22/25] KVM: x86: Allow FRED/LKGS/WRMSRNS to be exposed to guests

2024-06-13 Thread Sean Christopherson
On Wed, Feb 07, 2024, Xin Li wrote: > Allow FRED/LKGS/WRMSRNS to be exposed to guests, thus a guest OS could see > these features when the guest is configured with FRED/LKGS/WRMSRNS in Qemu. (a) please describe what these features are, and (b) one patch per feature unless they _must_ be bundled t

Re: [PATCH v2 00/25] Enable FRED with KVM VMX

2024-06-13 Thread Sean Christopherson
On Wed, Mar 27, 2024, Shan Kang wrote: > On Wed, 2024-02-07 at 09:26 -0800, Xin Li wrote: > > This patch set enables the Intel flexible return and event delivery > > (FRED) architecture with KVM VMX to allow guests to utilize FRED. > > > We tested this FRED KVM patch set on a 7th Intel(R) Core(TM)

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Paul E. McKenney
On Thu, Jun 13, 2024 at 10:10:38AM -0600, Keith Busch wrote: > On Thu, Jun 13, 2024 at 09:01:47AM -0700, Paul E. McKenney wrote: > > > > Is there a way to avoid this issue by making this be a statement parameter > > to a macro? > > Something like this? It appears to work for the intended use, at

[RFC net-next 5/7] selftests: openvswitch: Support implicit ipv6 arguments.

2024-06-13 Thread Aaron Conole
The current iteration of IPv6 support requires explicit fields to be set in addition to not properly support the actual IPv6 addresses properly. With this change, make it so that the ipv6() bare option is usable to create wildcarded flows to match broad swaths of ipv6 traffic. Signed-off-by: Aaron

[PATCH bpf-next 2/2] bpf: selftests: Do not use generated kfunc prototypes for arena progs

2024-06-13 Thread Daniel Xu
When selftests are built with a new enough clang, the arena selftests opt-in to use LLVM address_space attribute annotations for arena pointers. These annotations are not emitted by kfunc prototype generation. This causes compilation errors when clang sees conflicting prototypes. Fix by opting ar

Re: [PATCH v2 19/25] KVM: nVMX: Add FRED VMCS fields

2024-06-13 Thread Sean Christopherson
On Wed, Feb 07, 2024, Xin Li wrote: > Add FRED VMCS fields to nested VMX context management. > > Todo: change VMCS12_REVISION, as struct vmcs12 is changed. It actually doesn't, the comment is just stale. At this point, KVM must _never_ change VMCS12_REVISION as doing so will break backwards comp

Re: [PATCH v2 18/25] KVM: nVMX: Add a prerequisite to SHADOW_FIELD_R[OW] macros

2024-06-13 Thread Sean Christopherson
On Wed, Feb 07, 2024, Xin Li wrote: > @@ -32,48 +32,48 @@ BUILD_BUG_ON(1) > */ > > /* 16-bits */ > -SHADOW_FIELD_RW(GUEST_INTR_STATUS, guest_intr_status) > -SHADOW_FIELD_RW(GUEST_PML_INDEX, guest_pml_index) > -SHADOW_FIELD_RW(HOST_FS_SELECTOR, host_fs_selector) > -SHADOW_FIELD_RW(HOST_GS_SELEC

[RFC net-next 6/7] selftests: net: Use the provided dpctl rather than the vswitchd for tests.

2024-06-13 Thread Aaron Conole
The current pmtu test infrastucture requires an installed copy of the ovs-vswitchd userspace. This means that any automated or constrained environments may not have the requisite tools to run the tests. However, the pmtu tests don't require any special classifier processing. Indeed they are only

[RFC net-next 4/7] selftests: openvswitch: Add support for tunnel() key.

2024-06-13 Thread Aaron Conole
This will be used when setting details about the tunnel to use as transport. There is a difference between the ODP format between tunnel(): the 'key' flag is not actually a flag field, so we don't support it in the same way that the vswitchd userspace supports displaying it. Signed-off-by: Aaron

[RFC net-next 3/7] selftests: openvswitch: Add set() and set_masked() support.

2024-06-13 Thread Aaron Conole
These will be used in upcoming commits to set specific attributes for interacting with tunnels. Since set() will use the key parsing routine, we also make sure to prepend it with an open paren, for the action parsing to properly understand it. Signed-off-by: Aaron Conole --- .../selftests/net/o

[RFC net-next 0/7] selftests: net: Switch pmtu.sh to use the internal ovs script.

2024-06-13 Thread Aaron Conole
Currently, if a user wants to run pmtu.sh and cover all the provided test cases, they need to install the Open vSwitch userspace utilities. This dependency is difficult for users as well as CI environments, because the userspace build and setup may require lots of support and devel packages to be

Re: [PATCH v2 17/25] KVM: nVMX: Add support for the secondary VM exit controls

2024-06-13 Thread Sean Christopherson
On Wed, Feb 07, 2024, Xin Li wrote: > @@ -6856,13 +6865,17 @@ static void nested_vmx_setup_exit_ctls(struct > vmcs_config *vmcs_conf, > VM_EXIT_HOST_ADDR_SPACE_SIZE | > #endif > VM_EXIT_LOAD_IA32_PAT | VM_EXIT_SAVE_IA32_PAT | > - VM_EXIT_CLEAR_BNDCFGS; > +

Re: [PATCH v2 13/25] KVM: VMX: Handle VMX nested exception for FRED

2024-06-13 Thread Sean Christopherson
On Wed, Feb 07, 2024, Xin Li wrote: > @@ -725,8 +733,28 @@ static void kvm_multiple_exception(struct kvm_vcpu *vcpu, > vcpu->arch.exception.injected = false; > vcpu->arch.exception.pending = false; > > + /* > + * A #DF is NOT a nested event per

RE: [PATCH v2 12/25] KVM: VMX: Handle FRED event data

2024-06-13 Thread Li, Xin3
> On Wed, Feb 07, 2024, Xin Li wrote: > > @@ -7382,6 +7419,24 @@ static noinstr void vmx_vcpu_enter_exit(struct > kvm_vcpu *vcpu, > > > > vmx_disable_fb_clear(vmx); > > > > + /* > > +* %cr2 needs to be saved after a VM exit and restored before a VM > > +* entry in case a VM exit happe

Re: [PATCH v2 12/25] KVM: VMX: Handle FRED event data

2024-06-13 Thread Sean Christopherson
On Thu, Jun 13, 2024, Chao Gao wrote: > On Wed, Jun 12, 2024 at 04:31:35PM -0700, Sean Christopherson wrote: > >On Sat, May 11, 2024, Chao Gao wrote: > >> On Fri, May 10, 2024 at 05:36:03PM +0800, Li, Xin3 wrote: > >> >> >+ if (kvm_is_fred_enabled(vcpu)) { > >> >> >+

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Paul E. McKenney
On Thu, Jun 13, 2024 at 08:47:26AM -0600, Keith Busch wrote: > On Thu, Jun 13, 2024 at 07:43:35AM -0700, Paul E. McKenney wrote: > > On Thu, Jun 13, 2024 at 08:36:44AM -0600, Keith Busch wrote: > > > On Thu, Jun 13, 2024 at 07:11:52PM +0530, Nilay Shroff wrote: > > > > On 6/13/24 18:26, Keith Busch

[PATCH 1/2] kselftest: devices: Allow specifying boards directory through parameter

2024-06-13 Thread Nícolas F . R . A . Prado
Add support for a --boards-dir parameter through which the directory in which the board files will be searched for can be specified. The 'boards' subdirectory is still used as default when the parameter is not specified. This allows more easily running the test with board files supplied by an exte

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Paul E. McKenney
On Thu, Jun 13, 2024 at 08:36:44AM -0600, Keith Busch wrote: > On Thu, Jun 13, 2024 at 07:11:52PM +0530, Nilay Shroff wrote: > > On 6/13/24 18:26, Keith Busch wrote: > > > But that's not the problem for the rcu case. It's the last line that's > > > the problem: > > > > > > list->prev->next = lis

[PATCH 2/2] kselftest: devices: Add of-fullname-regex property

2024-06-13 Thread Nícolas F . R . A . Prado
Introduce a new 'of-fullname-regex' property that takes a regular expression and matches against the OF_FULLNAME property. It allows matching controllers that don't have a unique DT address across sibling controllers, and thus dt-mmio can't be used. One particular example of where this is needed i

[PATCH bpf-next 0/2] Fixes for kfunc prototype generation

2024-06-13 Thread Daniel Xu
This patchset fixes new warnings and errors that kfunc prototype generation caused. Daniel Xu (2): bpf: Fix bpf_dynptr documentation comments bpf: selftests: Do not use generated kfunc prototypes for arena progs kernel/bpf/helpers.c | 4 ++-- tools/testing

Re: [PATCH v2 09/13] riscv: vector: Support xtheadvector save/restore

2024-06-13 Thread Conor Dooley
Andy, On Mon, Jun 10, 2024 at 03:56:46PM -0700, Charlie Jenkins wrote: > Use alternatives to add support for xtheadvector vector save/restore > routines. > > Signed-off-by: Charlie Jenkins Could you review this please? Cheers, Conor. > --- > arch/riscv/include/asm/csr.h | 6 + >

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Keith Busch
On Thu, Jun 13, 2024 at 09:01:47AM -0700, Paul E. McKenney wrote: > > Is there a way to avoid this issue by making this be a statement parameter > to a macro? Something like this? It appears to work for the intended use, at least. --- diff --git a/include/linux/rculist.h b/include/linux/rculist.

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Paul E. McKenney
On Thu, Jun 13, 2024 at 09:40:36AM -0600, Keith Busch wrote: > On Thu, Jun 13, 2024 at 08:15:06AM -0700, Paul E. McKenney wrote: > > On Thu, Jun 13, 2024 at 08:47:26AM -0600, Keith Busch wrote: > > > > > > > > Just make a helper function like this: > > > > > > > > static void my_synchroni

Re: [PATCH v2 02/13] dt-bindings: cpus: add a thead vlen register length property

2024-06-13 Thread Conor Dooley
On Mon, Jun 10, 2024 at 03:56:39PM -0700, Charlie Jenkins wrote: > Add a property analogous to the vlenb CSR so that software can detect > the vector length of each CPU prior to it being brought online. > Currently software has to assume that the vector length read from the > boot CPU applies to al

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Keith Busch
On Thu, Jun 13, 2024 at 08:15:06AM -0700, Paul E. McKenney wrote: > On Thu, Jun 13, 2024 at 08:47:26AM -0600, Keith Busch wrote: > > > > > > Just make a helper function like this: > > > > > > static void my_synchronize_srcu(void) > > > { > > > synchronize_srcu(&my_srcu_struct); > >

[PATCH 0/2] kselftest: devices: Allow running test on more platforms

2024-06-13 Thread Nícolas F . R . A . Prado
This series adds two new features required to be able to run the test on more platforms on KernelCI. The first patch adds a parameter to allow overriding the directory in which the board files will be looked for. Since the board files are hosted in a separate repository [1], this parameter allows

Re: [PATCH v2 03/13] riscv: dts: allwinner: Add xtheadvector to the D1/D1s devicetree

2024-06-13 Thread Conor Dooley
On Mon, Jun 10, 2024 at 03:56:40PM -0700, Charlie Jenkins wrote: > The D1/D1s SoCs support xtheadvector so it can be included in the > devicetree. Also include vlenb for the cpu. > > Signed-off-by: Charlie Jenkins Reviewed-by: Conor Dooley > --- > arch/riscv/boot/dts/allwinner/sun20i-d1s.dtsi

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Keith Busch
On Thu, Jun 13, 2024 at 07:43:35AM -0700, Paul E. McKenney wrote: > On Thu, Jun 13, 2024 at 08:36:44AM -0600, Keith Busch wrote: > > On Thu, Jun 13, 2024 at 07:11:52PM +0530, Nilay Shroff wrote: > > > On 6/13/24 18:26, Keith Busch wrote: > > > > But that's not the problem for the rcu case. It's the

Re: [PATCH v2 04/13] riscv: Add thead and xtheadvector as a vendor extension

2024-06-13 Thread Conor Dooley
On Mon, Jun 10, 2024 at 03:56:41PM -0700, Charlie Jenkins wrote: > Add support to the kernel for THead vendor extensions with the target of > the new extension xtheadvector. > > Signed-off-by: Charlie Jenkins Reviewed-by: Conor Dooley signature.asc Description: PGP signature

Re: [PATCH v2 08/13] riscv: Add xtheadvector instruction definitions

2024-06-13 Thread Conor Dooley
On Mon, Jun 10, 2024 at 03:56:45PM -0700, Charlie Jenkins wrote: > xtheadvector uses different encodings than standard vector for > vsetvli and vector loads/stores. Write the instruction formats to be > used in assembly code. > > Co-developed-by: Heiko Stuebner > Signed-off-by: Charlie Jenkins

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Keith Busch
On Thu, Jun 13, 2024 at 07:11:52PM +0530, Nilay Shroff wrote: > On 6/13/24 18:26, Keith Busch wrote: > > But that's not the problem for the rcu case. It's the last line that's > > the problem: > > > > list->prev->next = list; > > > > We can't change forward pointers for any element being deta

Re: [PATCH net-next v12 05/13] page_pool: convert to use netmem

2024-06-13 Thread Mina Almasry
On Thu, Jun 13, 2024 at 1:36 AM Paul Barker wrote: > > On 13/06/2024 02:35, Mina Almasry wrote: > > Abstrace the memory type from the page_pool so we can later add support > > s/Abstrace/Abstract/ > Thanks, will do. > > for new memory types. Convert the page_pool to use the new netmem type > > a

[PATCH net-next 5/5] selftests: forwarding: Add test for minimum and maximum MTU

2024-06-13 Thread Petr Machata
From: Amit Cohen Add cases to check minimum and maximum MTU which are exposed via "ip -d link show". Test configuration and traffic. Use VLAN devices as usually VLAN header (4 bytes) is not included in the MTU, and drivers should configure hardware correctly to send maximum MTU payload size in VL

selftests: arm64: fp-stress: KERNEL-1-0/3-0/4-0/6-0 - gcc-13 - Failed - clang-pass

2024-06-13 Thread Naresh Kamboju
-6-0 # # KERNEL-6-0 exited with error code 1 # not ok 74 KERNEL-6-0 # ok 75 SVE-VL-64-6 ... # # Totals: pass:92 fail:4 xfail:0 xpass:0 skip:0 error:0 ok 16 selftests: arm64: fp-stress metadata: -- git_describe: next-20240613 git_ref: master git_repo: https://gitlab.com/Linaro/lkft

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Nilay Shroff
On 6/13/24 18:26, Keith Busch wrote: > On Thu, Jun 13, 2024 at 10:26:11AM +0530, Nilay Shroff wrote: >> On 6/12/24 21:21, Keith Busch wrote: >>> +static inline void list_cut(struct list_head *list, >>> + struct list_head *head, struct list_head *entry) >>> +{ >>> + list->next = entry

selftests: ftrace: WARNING: at arch/arm64/kernel/stacktrace.c:112 arch_stack_walk

2024-06-13 Thread Naresh Kamboju
The following kernel warning noticed on arm64 qemu-arm64 and rk3399-rock-pi-4 device while running selftests ftrace tests on Linux next-20240613. This is always reproducible on qemu-arm64 and rock-pi-4 device with kselftest merge configs Reported-by: Linux Kernel Functional Testing Test log

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Keith Busch
On Thu, Jun 13, 2024 at 10:10:16AM +0200, Christoph Hellwig wrote: > On Thu, Jun 13, 2024 at 10:26:11AM +0530, Nilay Shroff wrote: > > I am wondering whether we really need the _rcu version of list_cut here? > > I think that @head could point to an _rcu protected list and that's true > > for this

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Keith Busch
On Thu, Jun 13, 2024 at 10:26:11AM +0530, Nilay Shroff wrote: > On 6/12/24 21:21, Keith Busch wrote: > > +static inline void list_cut(struct list_head *list, > > + struct list_head *head, struct list_head *entry) > > +{ > > + list->next = entry; > > + list->prev = head->prev; > > +

Re: [PATCH v2 4/4] bpf,lsm: Allow editing capabilities in BPF-LSM hooks

2024-06-13 Thread Dr. Greg
On Wed, Jun 12, 2024 at 08:54:28PM -0700, John Johansen wrote: Good morning, I hope the day is going well for everyone. > On 6/12/24 10:29, Paul Moore wrote: > >On Wed, Jun 12, 2024 at 4:15???AM Jonathan Calmels > >wrote: > >>On Tue, Jun 11, 2024 at 06:38:31PM GMT, Paul Moore wrote: > >>>On Tue

Re: [PATCH][next] kselftest/arm64: Fix a couple of spelling mistakes

2024-06-13 Thread Catalin Marinas
On Thu, 13 Jun 2024 08:34:29 +0100, Colin Ian King wrote: > There are two spelling mistakes in some error messages. Fix them. > > Applied to arm64 (for-next/kselftest), thanks! [1/1] kselftest/arm64: Fix a couple of spelling mistakes https://git.kernel.org/arm64/c/963c5d496822 -- Catali

Re: [PATCH 2/2] selftests: kvm: replace exit() with ksft_exit_fail_msg()

2024-06-13 Thread Muhammad Usama Anjum
Hi Sean, Thank you for replying in detail. I wasn't aware of true origin of these tests. On 6/13/24 12:01 AM, Sean Christopherson wrote: > On Wed, Jun 12, 2024, Muhammad Usama Anjum wrote: >> The KSFT_FAIL, exit code must be used instead of exit(254). > > This needs more justification. KVM self

Re: [PATCH v2 2/2] selftests: Add a test mangling with uc_sigmask

2024-06-13 Thread Mark Brown
On Thu, Jun 13, 2024 at 10:21:39AM +0530, Dev Jain wrote: > I guess we agree on the same thing; so, how about I rephrase the delivery > and blocking code comments this way: > "A process can request blocking of a signal by masking it into its set of > blocked signals; such a signal, when sent to th

Re: [PATCH][next] kselftest/arm64: Fix a couple of spelling mistakes

2024-06-13 Thread Mark Brown
On Thu, Jun 13, 2024 at 08:34:29AM +0100, Colin Ian King wrote: > There are two spelling mistakes in some error messages. Fix them. Reviewed-by: Mark Brown signature.asc Description: PGP signature

Re: [RFC PATCH v1 0/2] KVM: arm64: Making BT Field in ID_AA64PFR1_EL1 writable

2024-06-13 Thread Oliver Upton
On Thu, Jun 13, 2024 at 04:31:45PM +0800, Shaoqin Huang wrote: > Hi Marc, > > On 6/12/24 18:07, Marc Zyngier wrote: > > On Wed, 12 Jun 2024 06:30:51 +0100, > > Oliver Upton wrote: > > > > > > Hi Shaoqin, > > > > > > On Tue, Jun 11, 2024 at 10:35:50PM -0400, Shaoqin Huang wrote: > > > > Hi guys,

[PATCH v9 2/3] KVM: selftests: aarch64: Introduce pmu_event_filter_test

2024-06-13 Thread Shaoqin Huang
Introduce pmu_event_filter_test for arm64 platforms. The test configures PMUv3 for a vCPU, and sets different pmu event filters for the vCPU, and check if the guest can see those events which user allow and can't use those events which use deny. This test refactor the create_vpmu_vm() and make it

[PATCH v9 0/3] KVM: selftests: aarch64: Introduce pmu_event_filter_test

2024-06-13 Thread Shaoqin Huang
The test is inspired by the pmu_event_filter_test which implemented by x86. On the arm64 platform, there is the same ability to set the pmu_event_filter through the KVM_ARM_VCPU_PMU_V3_FILTER attribute. So add the test for arm64. The series first create the helper function which can be used for th

Re: [PATCH v2 4/4] bpf,lsm: Allow editing capabilities in BPF-LSM hooks

2024-06-13 Thread Jonathan Calmels
On Wed, Jun 12, 2024 at 08:54:28PM GMT, John Johansen wrote: > On 6/12/24 10:29, Paul Moore wrote: > > On Wed, Jun 12, 2024 at 4:15 AM Jonathan Calmels wrote: > > > On Tue, Jun 11, 2024 at 06:38:31PM GMT, Paul Moore wrote: > > > > On Tue, Jun 11, 2024 at 6:15 PM Jonathan Calmels > > > > wrote: >

Re: [RFC PATCH v1 0/2] KVM: arm64: Making BT Field in ID_AA64PFR1_EL1 writable

2024-06-13 Thread Marc Zyngier
On Thu, 13 Jun 2024 09:31:45 +0100, Shaoqin Huang wrote: > > If we don't care about the FEAT_CNTSC right now. Could I fix the > compile issue and respin this again without the background of enabling > migration between MtCollins and AmpereOne, and just keep the > information of the different BT f

Re: [PATCH net-next v12 05/13] page_pool: convert to use netmem

2024-06-13 Thread Paul Barker
On 13/06/2024 02:35, Mina Almasry wrote: > Abstrace the memory type from the page_pool so we can later add support s/Abstrace/Abstract/ > for new memory types. Convert the page_pool to use the new netmem type > abstraction, rather than use struct page directly. > > As of this patch the netmem ty

Re: [RFC PATCH v1 0/2] KVM: arm64: Making BT Field in ID_AA64PFR1_EL1 writable

2024-06-13 Thread Shaoqin Huang
Hi Marc, On 6/12/24 18:07, Marc Zyngier wrote: On Wed, 12 Jun 2024 06:30:51 +0100, Oliver Upton wrote: Hi Shaoqin, On Tue, Jun 11, 2024 at 10:35:50PM -0400, Shaoqin Huang wrote: Hi guys, I'm trying to enable migration from MtCollins(Ampere Altra, ARMv8.2+) to AmpereOne(AmpereOne, ARMv8.6+)

[PATCH v9 3/3] KVM: selftests: aarch64: Add invalid filter test in pmu_event_filter_test

2024-06-13 Thread Shaoqin Huang
Add the invalid filter test which sets the filter beyond the event space and sets the invalid action to double check if the KVM_ARM_VCPU_PMU_V3_FILTER will return the expected error. Reviewed-by: Eric Auger Signed-off-by: Shaoqin Huang --- .../kvm/aarch64/pmu_event_filter_test.c | 37

[PATCH v9 1/3] KVM: selftests: aarch64: Add helper function for the vpmu vcpu creation

2024-06-13 Thread Shaoqin Huang
Create a vcpu with vpmu would be a common requirement for the vpmu test, so add the helper function for the vpmu vcpu creation. And use those helper function in the vpmu_counter_access.c test. Use this chance to delete the meaningless ASSERT about the pmuver, because KVM does not advertise an IMP_

Re: [PATCH 1/2] list: introduce a new cutting helper

2024-06-13 Thread Christoph Hellwig
On Thu, Jun 13, 2024 at 10:26:11AM +0530, Nilay Shroff wrote: > I am wondering whether we really need the _rcu version of list_cut here? > I think that @head could point to an _rcu protected list and that's true > for this patch. So there might be concurrent readers accessing @head using > _rcu li

Re: [PATCH v5 11/11] clk: Add KUnit tests for clks registered with struct clk_parent_data

2024-06-13 Thread David Gow
On Tue, 4 Jun 2024 at 06:38, Stephen Boyd wrote: > > Test that clks registered with 'struct clk_parent_data' work as > intended and can find their parents. > > Cc: Christian Marangi > Cc: Brendan Higgins > Cc: David Gow > Cc: Rae Moar > Signed-off-by: Stephen Boyd > --- This seems good to me

Re: [PATCH v5 06/11] platform: Add test managed platform_device/driver APIs

2024-06-13 Thread David Gow
On Tue, 4 Jun 2024 at 06:38, Stephen Boyd wrote: > > Introduce KUnit resource wrappers around platform_driver_register(), > platform_device_alloc(), and platform_device_add() so that test authors > can register platform drivers/devices from their tests and have the > drivers/devices automatically

Re: [PATCH v5 05/11] of: Add a KUnit test for overlays and test managed APIs

2024-06-13 Thread David Gow
On Tue, 4 Jun 2024 at 06:38, Stephen Boyd wrote: > > Test the KUnit test managed overlay APIs. Confirm that platform devices > are created and destroyed properly. This provides us confidence that the > test managed APIs work correctly and can be relied upon to provide tests > with fake platform de

Re: [PATCH v5 02/11] of: Add test managed wrappers for of_overlay_apply()/of_node_put()

2024-06-13 Thread David Gow
On Tue, 4 Jun 2024 at 06:38, Stephen Boyd wrote: > > Add test managed wrappers for of_overlay_apply() that automatically > removes the overlay when the test is finished. This API is intended for > use by KUnit tests that test code which relies on 'struct device_node's > and of_*() APIs. > > KUnit

[PATCH][next] kselftest/arm64: Fix a couple of spelling mistakes

2024-06-13 Thread Colin Ian King
There are two spelling mistakes in some error messages. Fix them. Signed-off-by: Colin Ian King --- tools/testing/selftests/arm64/fp/kernel-test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/arm64/fp/kernel-test.c b/tools/testing/selftests/arm