Re: [PATCH] selftests/vDSO: support DT_GNU_HASH

2024-08-14 Thread Xi Ruoyao
On Wed, 2024-08-14 at 20:26 -0700, Fangrui Song wrote: > glibc added support for DT_GNU_HASH in 2006 and DT_HASH has been > obsoleted for more than one decade in many Linux distributions. > > Many vDSOs support DT_GNU_HASH. This patch adds selftests support. > > Signed-off-by: Fangrui Song Test

Re: [PATCH net v3] selftest: af_unix: Fix kselftest compilation warnings

2024-08-14 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Wed, 14 Aug 2024 13:37:43 +0530 you wrote: > Change expected_buf from (const void *) to (const char *) > in function __recvpair(). > This change fixes the below warnings during test compilation: > > ``` > In file inclu

Re: [PATCH v1 0/2] mremap refactor: check src address for vma boundaries first.

2024-08-14 Thread Jeff Xu
On Wed, Aug 14, 2024 at 12:55 PM Liam R. Howlett wrote: > The majority of the comments to V2 are mine, you only told us that > splitting a sealed vma is wrong (after I asked you directly to answer) > and then you made a comment about testing of the patch set. Besides the > direct responses to me,

Re: [PATCH] arm64/vdso: Remove --hash-style=sysv

2024-08-14 Thread Fangrui Song
On Wed, Aug 14, 2024 at 6:23 PM Fangrui Song wrote: > > On Wed, Aug 14, 2024 at 12:56 PM Xi Ruoyao wrote: > > > > On Thu, 2024-07-18 at 10:34 -0700, Fangrui Song wrote: > > > glibc added support for .gnu.hash in 2006 and .hash has been obsoleted > > > for more than one decade in many Linux distri

[PATCH] selftests/vDSO: support DT_GNU_HASH

2024-08-14 Thread Fangrui Song
glibc added support for DT_GNU_HASH in 2006 and DT_HASH has been obsoleted for more than one decade in many Linux distributions. Many vDSOs support DT_GNU_HASH. This patch adds selftests support. Signed-off-by: Fangrui Song --- tools/testing/selftests/vDSO/parse_vdso.c | 105 ---

Re: [PATCH net-next v13 04/14] mm: page_frag: add '_va' suffix to page_frag API

2024-08-14 Thread Yunsheng Lin
On 2024/8/14 23:49, Alexander H Duyck wrote: > On Thu, 2024-08-08 at 20:37 +0800, Yunsheng Lin wrote: >> Currently the page_frag API is returning 'virtual address' >> or 'va' when allocing and expecting 'virtual address' or >> 'va' as input when freeing. >> >> As we are about to support new use cas

Re: [PATCH bpf-next v4 4/4] selftests/bpf: convert test_skb_cgroup_id_user to test_progs

2024-08-14 Thread Martin KaFai Lau
On 8/13/24 5:45 AM, Alexis Lothoré (eBPF Foundation) wrote: +#define DST_ADDR "ff02::1" [ ... ] +static int wait_local_ip(void) +{ + char *ping_cmd = ping_command(AF_INET6); + int i, err; + + for (i = 0; i < WAIT_AUTO_IP_MAX_ATTEMPT; i++) { + err = SYS_NOFAIL(

Re: [PATCH bpf-next v4 0/4] selftests/bpf: convert three other cgroup tests to test_progs

2024-08-14 Thread patchwork-bot+netdevbpf
Hello: This series was applied to bpf/bpf-next.git (master) by Martin KaFai Lau : On Tue, 13 Aug 2024 14:45:04 +0200 you wrote: > Hello, > this series brings a new set of test converted to the test_progs framework. > Since the tests are quite small, I chose to group three tests conversion in > th

[PATCH] lib/math: Add int_pow test suite

2024-08-14 Thread Luis Felipe Hernandez
Adds test suite for integer based power function. Signed-off-by: Luis Felipe Hernandez --- lib/math/Makefile | 1 + lib/math/test_int_pow.c | 70 + 2 files changed, 71 insertions(+) create mode 100644 lib/math/test_int_pow.c diff --git a/lib/math/

Re: [PATCH] arm64/vdso: Remove --hash-style=sysv

2024-08-14 Thread Fangrui Song
On Wed, Aug 14, 2024 at 12:56 PM Xi Ruoyao wrote: > > On Thu, 2024-07-18 at 10:34 -0700, Fangrui Song wrote: > > glibc added support for .gnu.hash in 2006 and .hash has been obsoleted > > for more than one decade in many Linux distributions. Using > > --hash-style=sysv might imply unaddressed iss

Re: [PATCH net v6 0/2] Enhance network interface feature testing

2024-08-14 Thread Jakub Kicinski
On Wed, 14 Aug 2024 17:56:51 -0700 Jakub Kicinski wrote: > On Wed, 14 Aug 2024 19:15:15 + Abhinav Jain wrote: > > Changes in v6: > > Use XFAIL for ethtool operations that are unsupported instead of SKIP. > > One more: > > tools/testing/selftests/net/netdevice.sh: echo "SKIP: $netdev:

Re: [PATCH net v6 0/2] Enhance network interface feature testing

2024-08-14 Thread Jakub Kicinski
On Wed, 14 Aug 2024 19:15:15 + Abhinav Jain wrote: > Changes in v6: > Use XFAIL for ethtool operations that are unsupported instead of SKIP. One more: tools/testing/selftests/net/netdevice.sh: echo "SKIP: $netdev: set IP address" I think the SKIP -> XFAIL conversion should be a separa

Re: [PATCH RFT v8 0/9] fork: Support shadow stacks in clone3()

2024-08-14 Thread Edgecombe, Rick P
On Thu, 2024-08-08 at 10:54 -0700, Kees Cook wrote: > Tested-by: Kees Cook I regression tested it with the CET enabled glibc selftests. No issues.

Re: [PATCH RFT v8 4/9] fork: Add shadow stack support to clone3()

2024-08-14 Thread Edgecombe, Rick P
On Thu, 2024-08-08 at 09:15 +0100, Mark Brown wrote: > +int arch_shstk_post_fork(struct task_struct *t, struct kernel_clone_args > *args) > +{ > +   /* > +    * SSP is aligned, so reserved bits and mode bit are a zero, just mark > +    * the token 64-bit. > +    */ > +   struct

[PATCH net 14/14] net: mscc: ocelot: treat 802.1ad tagged traffic as 802.1Q-untagged

2024-08-14 Thread Vladimir Oltean
I was revisiting the topic of 802.1ad treatment in the Ocelot switch [0] and realized that not only is its basic VLAN classification pipeline improper for offloading vlan_protocol 802.1ad bridges, but also improper for offloading regular 802.1Q bridges already. Namely, 802.1ad-tagged traffic shoul

[PATCH net 13/14] net: dsa: felix: fix VLAN tag loss on CPU reception with ocelot-8021q

2024-08-14 Thread Vladimir Oltean
There is a major design bug with ocelot-8021q, which is that it expects more of the hardware than the hardware can actually do. The short summary of the issue is that when a port is under a VLAN-aware bridge and we use this tagging protocol, VLAN upper interfaces of this port do not see RX traffic.

[PATCH net 12/14] net: dsa: provide a software untagging function on RX for VLAN-aware bridges

2024-08-14 Thread Vladimir Oltean
Through code analysis, I realized that the ds->untag_bridge_pvid logic is contradictory - see the newly added FIXME above the kernel-doc for dsa_software_untag_vlan_unaware_bridge(). Moreover, for the Felix driver, I need something very similar, but which is actually _not_ contradictory: untag the

[PATCH net 11/14] net: mscc: ocelot: serialize access to the injection/extraction groups

2024-08-14 Thread Vladimir Oltean
As explained by Horatiu Vultur in commit 603ead96582d ("net: sparx5: Add spinlock for frame transmission from CPU") which is for a similar hardware design, multiple CPUs can simultaneously perform injection or extraction. There are only 2 register groups for injection and 2 for extraction, and the

[PATCH net 10/14] net: mscc: ocelot: fix QoS class for injected packets with "ocelot-8021q"

2024-08-14 Thread Vladimir Oltean
There are 2 distinct code paths (listed below) in the source code which set up an injection header for Ocelot(-like) switches. Code path (2) lacks the QoS class and source port being set correctly. Especially the improper QoS classification is a problem for the "ocelot-8021q" alternative DSA taggin

[PATCH net 09/14] net: mscc: ocelot: use ocelot_xmit_get_vlan_info() also for FDMA and register injection

2024-08-14 Thread Vladimir Oltean
Problem description --- On an NXP LS1028A (felix DSA driver) with the following configuration: - ocelot-8021q tagging protocol - VLAN-aware bridge (with STP) spanning at least swp0 and swp1 - 8021q VLAN upper interfaces on swp0 and swp1: swp0.700, swp1.700 - ptp4l on swp0.700 and

[PATCH net 08/14] selftests: net: bridge_vlan_aware: test that other TPIDs are seen as untagged

2024-08-14 Thread Vladimir Oltean
The bridge VLAN implementation w.r.t. VLAN protocol is described in merge commit 1a0b20b25732 ("Merge branch 'bridge-next'"). We are only sensitive to those VLAN tags whose TPID is equal to the bridge's vlan_protocol. Thus, an 802.1ad VLAN should be treated as 802.1Q-untagged. Add 3 tests which va

[PATCH net 07/14] selftests: net: local_termination: add PTP frames to the mix

2024-08-14 Thread Vladimir Oltean
A breakage in the felix DSA driver shows we do not have enough test coverage. More generally, it is sufficiently special that it is likely drivers will treat it differently. This is not meant to be a full PTP test, it just makes sure that PTP packets sent to the different addresses corresponding t

[PATCH net 06/14] selftests: net: local_termination: don't use xfail_on_veth()

2024-08-14 Thread Vladimir Oltean
xfail_on_veth() for this test is an incorrect approximation which gives false positives and false negatives. When local_termination fails with "reception succeeded, but should have failed", it is because the DUT ($h2) accepts packets even when not configured as promiscuous. This is not something s

[PATCH net 05/14] selftests: net: local_termination: introduce new tests which capture VLAN behavior

2024-08-14 Thread Vladimir Oltean
Add more coverage to the local termination selftest as follows: - 8021q upper of $h2 - 8021q upper of $h2, where $h2 is a port of a VLAN-unaware bridge - 8021q upper of $h2, where $h2 is a port of a VLAN-aware bridge - 8021q upper of VLAN-unaware br0, which is the upper of $h2 - 8021q upper of VLAN

[PATCH net 04/14] selftests: net: local_termination: add one more test for VLAN-aware bridges

2024-08-14 Thread Vladimir Oltean
The current bridge() test is for packet reception on a VLAN-unaware bridge. Some things are different enough with VLAN-aware bridges that it's worth renaming this test into vlan_unaware_bridge(), and add a new vlan_aware_bridge() test. The two will share the same implementation: bridge() becomes a

[PATCH net 03/14] selftests: net: local_termination: parameterize test name

2024-08-14 Thread Vladimir Oltean
There are upcoming tests which verify the RX filtering of a bridge (or bridge port), but under differing vlan_filtering conditions. Since we currently print $h2 (the DUT) in the log_test() output, it becomes necessary to make a further distinction between tests, to not give the user the impression

[PATCH net 02/14] selftests: net: local_termination: parameterize sending interface

2024-08-14 Thread Vladimir Oltean
In future changes we will want to subject the DUT, $h2, to additional VLAN-tagged traffic. For that, we need to run the tests using $h1.100 as a sending interface, rather than the currently hardcoded $h1. Add a parameter to run_test() and modify its 2 callers to explicitly pass $h1, as was implici

[PATCH net 01/14] selftests: net: local_termination: refactor macvlan creation/deletion

2024-08-14 Thread Vladimir Oltean
This will be used in other subtests as well; make new macvlan_create() and macvlan_destroy() functions. Signed-off-by: Vladimir Oltean --- .../net/forwarding/local_termination.sh | 30 +++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/tools/testing/selftes

[PATCH net 00/14] VLAN fixes for Ocelot driver

2024-08-14 Thread Vladimir Oltean
This is a collection of patches I've gathered over the past several months. Patches 1-6/14 are supporting patches for selftests. Patch 9/14 fixes PTP TX from a VLAN upper of a VLAN-aware bridge port when using the "ocelot-8021q" tagging protocol. Patch 7/14 is its supporting selftest. Patch 10/1

Re: [PATCH bpf-next v4 2/2] selftests/bpf: Add mptcp subflow subtest

2024-08-14 Thread Martin KaFai Lau
On 8/14/24 3:04 AM, Matthieu Baerts wrote: Hi Martin, Thank you for your reply! On 14/08/2024 03:12, Martin KaFai Lau wrote: On 8/5/24 2:52 AM, Matthieu Baerts (NGI0) wrote: +static int endpoint_init(char *flags) +{ +    SYS(fail, "ip -net %s link add veth1 type veth peer name veth2", NS_TEST

Re: [PATCH bpf-next v4 2/2] selftests/bpf: Add mptcp subflow subtest

2024-08-14 Thread Martin KaFai Lau
On 8/5/24 2:52 AM, Matthieu Baerts (NGI0) wrote: +static void run_subflow(char *new) +{ + int server_fd, client_fd, err; + char cc[TCP_CA_NAME_MAX]; + socklen_t len = sizeof(cc); + + server_fd = start_mptcp_server(AF_INET, ADDR_1, PORT_1, 0); + if (!ASSERT_GE(server_

Re: [PATCH v1 05/16] iommufd/viommu: Add IOMMU_VIOMMU_SET/UNSET_VDEV_ID ioctl

2024-08-14 Thread Jason Gunthorpe
On Wed, Aug 14, 2024 at 10:09:22AM -0700, Nicolin Chen wrote: > This helps us to build a device-based virq report function: > +void iommufd_device_report_virq(struct device *dev, unsigned int data_type, > + void *data_ptr, size_t data_len); > > I built a link from de

Re: [PATCH net-next v13 02/14] mm: move the page fragment allocator from page_alloc into its own file

2024-08-14 Thread Andrew Morton
On Thu, 8 Aug 2024 20:37:02 +0800 Yunsheng Lin wrote: > Inspired by [1], move the page fragment allocator from page_alloc > into its own c file and header file, as we are about to make more > change for it to replace another page_frag implementation in > sock.c Acked-by: Andrew Morton This pre

Re: [PATCH v1 0/2] mremap refactor: check src address for vma boundaries first.

2024-08-14 Thread Liam R. Howlett
* Jeff Xu [240814 12:57]: > On Wed, Aug 14, 2024 at 7:40 AM Liam R. Howlett > wrote: > > > > * jef...@chromium.org [240814 03:14]: > > > From: Jeff Xu > > > > > > mremap doesn't allow relocate, expand, shrink across VMA boundaries, > > > refactor the code to check src address range before doin

Re: [PATCH] arm64/vdso: Remove --hash-style=sysv

2024-08-14 Thread Xi Ruoyao
On Thu, 2024-07-18 at 10:34 -0700, Fangrui Song wrote: > glibc added support for .gnu.hash in 2006 and .hash has been obsoleted > for more than one decade in many Linux distributions.  Using > --hash-style=sysv might imply unaddressed issues and confuse readers. > > Just drop the option and rely o

[PATCH net v6 2/2] selftests: net: Add on/off checks for non-fixed features of interface

2024-08-14 Thread Abhinav Jain
Implement on/off testing for all non-fixed features via while loop. Save the initial state so that it can be restored after on/off checks. Use XFAIL for unsupported ethtool API. Signed-off-by: Abhinav Jain --- tools/testing/selftests/net/netdevice.sh | 39 ++-- 1 file changed

[PATCH net v6 1/2] selftests: net: Create veth pair for testing in networkless kernel

2024-08-14 Thread Abhinav Jain
Check if the netdev list is empty and create veth pair to be used for feature on/off testing. Remove the veth pair after testing is complete. Signed-off-by: Abhinav Jain --- tools/testing/selftests/net/netdevice.sh | 16 1 file changed, 16 insertions(+) diff --git a/tools/testi

[PATCH net v6 0/2] Enhance network interface feature testing

2024-08-14 Thread Abhinav Jain
This small series includes fixes for creation of veth pairs for networkless kernels & adds tests for turning the different network interface features on and off in selftests/net/netdevice.sh script. Changes in v6: Use XFAIL for ethtool operations that are unsupported instead of SKIP. Changes in v

[PATCH] selftests/net/pmtu.sh: Fix typo in error message

2024-08-14 Thread Abhash Jha
The word 'expected' was spelled as 'exepcted'. Fixed the typo in this patch. Signed-off-by: Abhash Jha --- tools/testing/selftests/net/pmtu.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh index cfc8

Re: [PATCH net-next v19 00/13] Device Memory TCP

2024-08-14 Thread Jakub Kicinski
On Tue, 13 Aug 2024 21:13:02 + Mina Almasry wrote: > v18 got a thorough review (thanks!), and this iteration addresses the > feedback. > > Major changes: > - Prevent deactivating mp bound queues. > - Prevent installing xdp on mp bound netdevs, or installing mps on xdp > installed netdevs. >

Re: [PATCH] selftests/net/pmtu.sh: Fix typo in error message

2024-08-14 Thread Jakub Kicinski
On Wed, 14 Aug 2024 22:44:03 +0530 Abhash Jha wrote: > The word 'expected' was spelled as 'exepcted'. > Fixed the typo in this patch. > > Signed-off-by: Abhash Jha Missing cc: netdev@ please repost

[PATCH] selftests/net/pmtu.sh: Fix typo in error message

2024-08-14 Thread Abhash Jha
The word 'expected' was spelled as 'exepcted'. Fixed the typo in this patch. Signed-off-by: Abhash Jha --- tools/testing/selftests/net/pmtu.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/pmtu.sh b/tools/testing/selftests/net/pmtu.sh index cfc8

Re: [PATCH v1 05/16] iommufd/viommu: Add IOMMU_VIOMMU_SET/UNSET_VDEV_ID ioctl

2024-08-14 Thread Nicolin Chen
On Wed, Aug 07, 2024 at 01:10:46PM -0700, Nicolin Chen wrote: > @@ -135,7 +135,14 @@ void iommufd_device_destroy(struct iommufd_object *obj) > { > struct iommufd_device *idev = > container_of(obj, struct iommufd_device, obj); > + struct iommufd_vdev_id *vdev_id, *curr

Re: [PATCH 0/6] Extend pmu_counters_test to AMD CPUs

2024-08-14 Thread Colton Lewis
Sean Christopherson writes: On Tue, Aug 13, 2024, Colton Lewis wrote: Sean Christopherson writes: > On Tue, Aug 13, 2024, Colton Lewis wrote: > > (I was positive I had sent this already, but I couldn't find it on the > > mailing list to reply to and ask for reviews.) > You did[*], it

Re: [PATCH v1 0/2] mremap refactor: check src address for vma boundaries first.

2024-08-14 Thread Jeff Xu
On Wed, Aug 14, 2024 at 7:40 AM Liam R. Howlett wrote: > > * jef...@chromium.org [240814 03:14]: > > From: Jeff Xu > > > > mremap doesn't allow relocate, expand, shrink across VMA boundaries, > > refactor the code to check src address range before doing anything on > > the destination, i.e. dest

Re: [PATCH v1 01/16] iommufd/viommu: Add IOMMUFD_OBJ_VIOMMU and IOMMU_VIOMMU_ALLOC ioctl

2024-08-14 Thread Nicolin Chen
On Wed, Aug 07, 2024 at 01:10:42PM -0700, Nicolin Chen wrote: > /** > @@ -876,4 +877,33 @@ struct iommu_fault_alloc { > __u32 out_fault_fd; > }; > #define IOMMU_FAULT_QUEUE_ALLOC _IO(IOMMUFD_TYPE, > IOMMUFD_CMD_FAULT_QUEUE_ALLOC) > + > +/** > + * enum iommu_viommu_type - Virtual IOMMU

Re: [PATCH v10 24/40] arm64/signal: Expose GCS state in signal frames

2024-08-14 Thread Mark Brown
On Wed, Aug 14, 2024 at 04:09:51PM +0100, Dave Martin wrote: > On Thu, Aug 01, 2024 at 01:06:51PM +0100, Mark Brown wrote: > > + if (add_all || task_gcs_el0_enabled(current)) { > > + err = sigframe_alloc(user, &user->gcs_offset, > > +sizeof(struct gcs_co

Re: [PATCH net-next v19 06/13] memory-provider: dmabuf devmem memory provider

2024-08-14 Thread Pavel Begunkov
On 8/14/24 15:55, Mina Almasry wrote: On Wed, Aug 14, 2024 at 10:11 AM Pavel Begunkov wrote: ... diff --git a/net/core/devmem.c b/net/core/devmem.c index 301f4250ca82..2f2a7f4dee4c 100644 --- a/net/core/devmem.c +++ b/net/core/devmem.c @@ -17,6 +17,7 @@ #include #include #include +#

[PATCH 3/3] selftests/bpf: Add selftest for sockmap/hashmap redirection

2024-08-14 Thread Michal Luczaj
Test redirection logic. BPF_MAP_TYPE_SOCKMAP BPF_MAP_TYPE_SOCKHASH ✕ sk_msg-to-egress sk_msg-to-ingress sk_skb-to-egress sk_skb-to-ingress ✕ AF_INET, SOCK_STREAM AF_INET6, SOCK_STREAM AF_INET, SOCK_DGRAM AF_INET6, SOCK_DGRAM AF_UNIX, SOCK_STREAM AF_UNIX, SOCK_DGRAM AF_VSOCK, SOCK_S

Re: [PATCH bpf-next v2 0/6] selftests/bpf: Various sockmap-related fixes

2024-08-14 Thread Michal Luczaj
On 8/6/24 19:45, Jakub Sitnicki wrote: > On Tue, Aug 06, 2024 at 07:18 PM +02, Michal Luczaj wrote: >> Great, thanks for the review. With this completed, I guess we can unwind >> the (mail) stack to [1]. Is that ingress-to-local et al. something you >> wanted to take care of yourself or can I give

[PATCH 2/3] selftests/bpf: Allow setting BPF_F_INGRESS in prog_msg_verdict()

2024-08-14 Thread Michal Luczaj
Let a selftest set BPF_F_INGRESS for map/hash redirect. In run_tests(), explicitly reset skel->bss->test_ingress to false. Earlier tests might have left it flipped. Signed-off-by: Michal Luczaj --- tools/testing/selftests/bpf/prog_tests/sockmap_listen.c | 2 ++ tools/testing/selftests/bpf/progs

[PATCH 1/3] selftests/bpf: Support AF_UNIX SOCK_DGRAM socket pair creation

2024-08-14 Thread Michal Luczaj
Handle AF_UNIX in init_addr_loopback(). For pair creation, bind() the peer socket to make SOCK_DGRAM connect() happy. Signed-off-by: Michal Luczaj --- .../bpf/prog_tests/sockmap_helpers.h | 29 +++ 1 file changed, 24 insertions(+), 5 deletions(-) diff --git a/tools/test

Re: [PATCH net-next v2] net: netconsole: selftests: Create a new netconsole selftest

2024-08-14 Thread Breno Leitao
On Wed, Aug 14, 2024 at 12:24:46PM +0200, Petr Machata wrote: > > Breno Leitao writes: > > + fi > > + > > + if ! grep -q "${MSG}" "${TMPFILENAME}"; then > > + echo "FAIL: ${MSG} not found in ${TMPFILENAME}" >&2 > > + cat "${TMPFILENAME}" >&2 > > + return ${ksft_fail} > > +

Re: [PATCH v10 23/40] arm64/signal: Set up and restore the GCS context for signal handlers

2024-08-14 Thread Mark Brown
On Wed, Aug 14, 2024 at 03:51:42PM +0100, Dave Martin wrote: > On Thu, Aug 01, 2024 at 01:06:50PM +0100, Mark Brown wrote: > > + put_user_gcs((unsigned long)sigtramp, gcspr_el0 - 2, &ret); > > + put_user_gcs(GCS_SIGNAL_CAP(gcspr_el0 - 1), gcspr_el0 - 1, &ret); > > + if (ret != 0) > > +

Re: [PATCH net-next v13 04/14] mm: page_frag: add '_va' suffix to page_frag API

2024-08-14 Thread Alexander H Duyck
On Thu, 2024-08-08 at 20:37 +0800, Yunsheng Lin wrote: > Currently the page_frag API is returning 'virtual address' > or 'va' when allocing and expecting 'virtual address' or > 'va' as input when freeing. > > As we are about to support new use cases that the caller > need to deal with 'struct page

Re: [PATCH v3 3/3] selftests/tracing: Add hist poll() support test

2024-08-14 Thread Google
On Wed, 14 Aug 2024 05:38:24 -0600 Shuah Khan wrote: > On 8/13/24 18:11, Masami Hiramatsu (Google) wrote: > > From: Masami Hiramatsu (Google) > > > > Add a testcase for poll() on hist file. This introduces a helper binary > > to the ftracetest, because there is no good way to reliably execute >

Re: [PATCH] selftests/ftrace: Add required dependency for kprobe tests

2024-08-14 Thread Google
On Wed, 14 Aug 2024 05:43:29 -0600 Shuah Khan wrote: > On 8/13/24 18:53, Masami Hiramatsu (Google) wrote: > > Hi Shuah, > > > > Can you pick this? I confirmed this can be applied on v6.11-rc3. > > > > > > > > On Thu, 13 Jun 2024 07:12:10 +0900 > > "Masami Hiramatsu (Google)" wrote: > > > >>

Re: [PATCH net-next v13 02/14] mm: move the page fragment allocator from page_alloc into its own file

2024-08-14 Thread Alexander H Duyck
On Thu, 2024-08-08 at 20:37 +0800, Yunsheng Lin wrote: > Inspired by [1], move the page fragment allocator from page_alloc > into its own c file and header file, as we are about to make more > change for it to replace another page_frag implementation in > sock.c > > As this patchset is going to re

Re: [PATCH v10 24/40] arm64/signal: Expose GCS state in signal frames

2024-08-14 Thread Dave Martin
On Thu, Aug 01, 2024 at 01:06:51PM +0100, Mark Brown wrote: > Add a context for the GCS state and include it in the signal context when > running on a system that supports GCS. We reuse the same flags that the > prctl() uses to specify which GCS features are enabled and also provide the > current G

Re: [PATCH net-next v19 06/13] memory-provider: dmabuf devmem memory provider

2024-08-14 Thread Mina Almasry
On Wed, Aug 14, 2024 at 10:11 AM Pavel Begunkov wrote: ... > > diff --git a/net/core/devmem.c b/net/core/devmem.c > > index 301f4250ca82..2f2a7f4dee4c 100644 > > --- a/net/core/devmem.c > > +++ b/net/core/devmem.c > > @@ -17,6 +17,7 @@ > > #include > > #include > > #include > > +#include

Re: [PATCH v10 23/40] arm64/signal: Set up and restore the GCS context for signal handlers

2024-08-14 Thread Dave Martin
On Thu, Aug 01, 2024 at 01:06:50PM +0100, Mark Brown wrote: > When invoking a signal handler we use the GCS configuration and stack > for the current thread. > > Since we implement signal return by calling the signal handler with a > return address set up pointing to a trampoline in the vDSO we ne

Re: [PATCH net v2] selftest: af_unix: Fix kselftest compilation warnings

2024-08-14 Thread Jakub Kicinski
On Wed, 14 Aug 2024 13:40:54 +0530 Abhinav Jain wrote: > Also, @Jakub, please kindly check this and revert (another patch on which you > have helped a lot already, need one small input and I can send the next > version): > https://lore.kernel.org/all/20240810175509.404094-1-jain.abhinav...@gmail.c

Re: [PATCH v1 0/2] mremap refactor: check src address for vma boundaries first.

2024-08-14 Thread Liam R. Howlett
* jef...@chromium.org [240814 03:14]: > From: Jeff Xu > > mremap doesn't allow relocate, expand, shrink across VMA boundaries, > refactor the code to check src address range before doing anything on > the destination, i.e. destination won't be unmapped, if src address > failed the boundaries che

Re: [PATCH net 1/2] selftests: udpgro: report error when receive failed

2024-08-14 Thread Hangbin Liu
On Wed, Aug 14, 2024 at 12:19:22PM +0200, Paolo Abeni wrote: > > --- a/tools/testing/selftests/net/udpgro.sh > > +++ b/tools/testing/selftests/net/udpgro.sh > > @@ -49,14 +49,15 @@ run_one() { > > cfg_veth > > - ip netns exec "${PEER_NS}" ./udpgso_bench_rx -C 1000 -R 10 ${rx_args} > > && \ >

Re: [PATCH net 1/2] selftests: udpgro: report error when receive failed

2024-08-14 Thread Hangbin Liu
On Wed, Aug 14, 2024 at 03:57:57PM +0800, Hangbin Liu wrote: > --- > tools/testing/selftests/net/udpgro.sh | 41 --- > 1 file changed, 24 insertions(+), 17 deletions(-) > > diff --git a/tools/testing/selftests/net/udpgro.sh > b/tools/testing/selftests/net/udpgro.sh > inde

Re: [PATCH net-next v19 06/13] memory-provider: dmabuf devmem memory provider

2024-08-14 Thread Pavel Begunkov
On 8/13/24 22:13, Mina Almasry wrote: Implement a memory provider that allocates dmabuf devmem in the form of net_iov. The provider receives a reference to the struct netdev_dmabuf_binding via the pool->mp_priv pointer. The driver needs to set this pointer for the provider in the net_iov. The p

Re: [PATCH] kselftest/arm64: signal: fix/refactor SVE vector length enumeration

2024-08-14 Thread Dave Martin
On Tue, Aug 13, 2024 at 01:55:46PM +0100, Andre Przywara wrote: > On Tue, 13 Aug 2024 12:00:06 +0100 > Mark Brown wrote: > > Hi broonie, > > > On Mon, Aug 12, 2024 at 03:09:24PM +0100, Andre Przywara wrote: > > > > > + /* Did we find the lowest supported VL? */ > > > + if (use_s

Re: [PATCH RFT v8 4/9] fork: Add shadow stack support to clone3()

2024-08-14 Thread Mark Brown
On Wed, Aug 14, 2024 at 10:38:54AM +0100, Catalin Marinas wrote: > On Tue, Aug 13, 2024 at 07:58:26PM +0100, Mark Brown wrote: > > ISTR the concerns were around someone being clever with vfork() but I > > don't remember anything super concrete. In terms of the inconsistency > > here that was actu

Re: [PATCH v2] selftests: fix relative rpath usage

2024-08-14 Thread Eugene Syromiatnikov
On Wed, Aug 14, 2024 at 05:14:08AM -0600, Shuah Khan wrote: > On 8/13/24 10:33, Eugene Syromiatnikov wrote: > >On Mon, Aug 12, 2024 at 05:03:45PM -0600, Shuah Khan wrote: > >>On 8/12/24 10:56, Eugene Syromiatnikov wrote: > >>>The relative RPATH ("./") supplied to linker options in CFLAGS is resolve

Re: [PATCH] selftests/ftrace: Add required dependency for kprobe tests

2024-08-14 Thread Shuah Khan
On 8/13/24 18:53, Masami Hiramatsu (Google) wrote: Hi Shuah, Can you pick this? I confirmed this can be applied on v6.11-rc3. On Thu, 13 Jun 2024 07:12:10 +0900 "Masami Hiramatsu (Google)" wrote: From: Masami Hiramatsu (Google) kprobe_args_{char,string}.tc are using available_filter_func

Re: [PATCH v3 3/3] selftests/tracing: Add hist poll() support test

2024-08-14 Thread Shuah Khan
On 8/13/24 18:11, Masami Hiramatsu (Google) wrote: From: Masami Hiramatsu (Google) Add a testcase for poll() on hist file. This introduces a helper binary to the ftracetest, because there is no good way to reliably execute poll() on hist file. Signed-off-by: Masami Hiramatsu (Google) --- Ch

Re: [PATCH net-next v2] net: netconsole: selftests: Create a new netconsole selftest

2024-08-14 Thread Matthieu Baerts
Hi Petr, Breno, On 14/08/2024 12:24, Petr Machata wrote: > > Breno Leitao writes: > >> Adds a selftest that creates two virtual interfaces, assigns one to a >> new namespace, and assigns IP addresses to both. >> >> It listens on the destination interface using socat and configures a >> dynamic

Re: [PATCH v2] selftests: fix relative rpath usage

2024-08-14 Thread Shuah Khan
On 8/13/24 10:33, Eugene Syromiatnikov wrote: On Mon, Aug 12, 2024 at 05:03:45PM -0600, Shuah Khan wrote: On 8/12/24 10:56, Eugene Syromiatnikov wrote: The relative RPATH ("./") supplied to linker options in CFLAGS is resolved relative to current working directory and not the executable directo

Re: [PATCH net-next v2] net: netconsole: selftests: Create a new netconsole selftest

2024-08-14 Thread Petr Machata
Breno Leitao writes: > Adds a selftest that creates two virtual interfaces, assigns one to a > new namespace, and assigns IP addresses to both. > > It listens on the destination interface using socat and configures a > dynamic target on netconsole, pointing to the destination IP address. > > Th

Re: [PATCH RFT v8 3/9] mm: Introduce ARCH_HAS_USER_SHADOW_STACK

2024-08-14 Thread Catalin Marinas
On Thu, Aug 08, 2024 at 09:15:24AM +0100, Mark Brown wrote: > Since multiple architectures have support for shadow stacks and we need to > select support for this feature in several places in the generic code > provide a generic config option that the architectures can select. > > Suggested-by: Da

Re: [PATCH RFT v8 1/9] Documentation: userspace-api: Add shadow stack API documentation

2024-08-14 Thread Catalin Marinas
On Thu, Aug 08, 2024 at 09:15:22AM +0100, Mark Brown wrote: > There are a number of architectures with shadow stack features which we are > presenting to userspace with as consistent an API as we can (though there > are some architecture specifics). Especially given that there are some > important

Re: [PATCH net 2/2] selftests: udpgro: no need to load xdp for gro

2024-08-14 Thread Paolo Abeni
On 8/14/24 09:57, Hangbin Liu wrote: After commit d7db7775ea2e ("net: veth: do not manipulate GRO when using XDP"), there is no need to load XDP program to enable GRO. On the other hand, the current test is failed due to loading the XDP program. e.g. # selftests: net: udpgro.sh # ipv4 # n

Re: [PATCH net 2/2] selftests: udpgro: no need to load xdp for gro

2024-08-14 Thread Toke Høiland-Jørgensen
Hangbin Liu writes: > After commit d7db7775ea2e ("net: veth: do not manipulate GRO when using > XDP"), there is no need to load XDP program to enable GRO. On the other > hand, the current test is failed due to loading the XDP program. e.g. > > # selftests: net: udpgro.sh > # ipv4 > # no GRO

Re: [PATCH net 1/2] selftests: udpgro: report error when receive failed

2024-08-14 Thread Paolo Abeni
On 8/14/24 09:57, Hangbin Liu wrote: Currently, we only check the latest senders's exit code. If the receiver report failed, it is not recoreded. Fix it by checking the exit code of all the involved processes. Before: bad GRO lookup ok multiple GRO socks

Re: [PATCH bpf-next v4 2/2] selftests/bpf: Add mptcp subflow subtest

2024-08-14 Thread Matthieu Baerts
Hi Martin, Thank you for your reply! On 14/08/2024 03:12, Martin KaFai Lau wrote: > On 8/5/24 2:52 AM, Matthieu Baerts (NGI0) wrote: >> +static int endpoint_init(char *flags) >> +{ >> +    SYS(fail, "ip -net %s link add veth1 type veth peer name veth2", >> NS_TEST); >> +    SYS(fail, "ip -net %s

Re: [PATCH RFT v8 4/9] fork: Add shadow stack support to clone3()

2024-08-14 Thread Catalin Marinas
On Tue, Aug 13, 2024 at 07:58:26PM +0100, Mark Brown wrote: > On Tue, Aug 13, 2024 at 05:25:47PM +0100, Catalin Marinas wrote: > > However, the x86 would be slightly inconsistent here between clone() and > > clone3(). I guess it depends how you look at it. The classic clone() > > syscall, if one do

Re: [PATCH net-next v2] net: netconsole: selftests: Create a new netconsole selftest

2024-08-14 Thread Breno Leitao
Hello Jakub, On Tue, Aug 13, 2024 at 03:37:16PM -0700, Jakub Kicinski wrote: > On Tue, 13 Aug 2024 11:38:16 -0700 Breno Leitao wrote: > > Adds a selftest that creates two virtual interfaces, assigns one to a > > new namespace, and assigns IP addresses to both. > > > > It listens on the destinatio

Re: [PATCH net v2] selftest: af_unix: Fix kselftest compilation warnings

2024-08-14 Thread Abhinav Jain
On Tue, 13 Aug 2024 18:21:06 -0700, Jakub Kicinski wrote: > Some patchwork malfunction, the patch didn't get registered :( > Could you resend? > > Please keep Kuniyuki's review tag and address his feedback. Sure. I have submitted v3 keeping the above in mind, please review: https://lore.kernel.org

[PATCH net v3] selftest: af_unix: Fix kselftest compilation warnings

2024-08-14 Thread Abhinav Jain
Change expected_buf from (const void *) to (const char *) in function __recvpair(). This change fixes the below warnings during test compilation: ``` In file included from msg_oob.c:14: msg_oob.c: In function ‘__recvpair’: ../../kselftest_harness.h:106:40: warning: format ‘%s’ expects argument of

[PATCH net 2/2] selftests: udpgro: no need to load xdp for gro

2024-08-14 Thread Hangbin Liu
After commit d7db7775ea2e ("net: veth: do not manipulate GRO when using XDP"), there is no need to load XDP program to enable GRO. On the other hand, the current test is failed due to loading the XDP program. e.g. # selftests: net: udpgro.sh # ipv4 # no GRO ok

[PATCH net 1/2] selftests: udpgro: report error when receive failed

2024-08-14 Thread Hangbin Liu
Currently, we only check the latest senders's exit code. If the receiver report failed, it is not recoreded. Fix it by checking the exit code of all the involved processes. Before: bad GRO lookup ok multiple GRO socks ./udpgso_bench_rx: recv: bad p

[PATCH net 0/2] selftests: Fix udpgro failures

2024-08-14 Thread Hangbin Liu
There are 2 issues for the current udpgro test. The first one is the testing doesn't record all the failures, which may report pass but the test actually failed. e.g. https://netdev-3.bots.linux.dev/vmksft-net/results/725661/45-udpgro-sh/stdout The other one is after commit d7db7775ea2e ("net: vet

[PATCH v1 2/2] mseal: refactor mremap to remove can_modify_mm

2024-08-14 Thread jeffxu
From: Jeff Xu mremap doesn't allow relocate, expand, shrink across VMA boundaries, refactor the code to check src address range before doing anything on the destination. This also allow we remove can_modify_mm from mremap, since the src address must be single VMA, use can_modify_vma instead. Si

[PATCH v1 1/2] mseal:selftest mremap across VMA boundaries.

2024-08-14 Thread jeffxu
From: Jeff Xu Add selftest to mremap across VMA boundaries, i.e. mremap will fail. Signed-off-by: Jeff Xu --- tools/testing/selftests/mm/mseal_test.c | 293 +++- 1 file changed, 292 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/mm/mseal_test.c b/tools/

[PATCH v1 0/2] mremap refactor: check src address for vma boundaries first.

2024-08-14 Thread jeffxu
From: Jeff Xu mremap doesn't allow relocate, expand, shrink across VMA boundaries, refactor the code to check src address range before doing anything on the destination, i.e. destination won't be unmapped, if src address failed the boundaries check. This also allows us to remove can_modify_mm fr