Re: [PATCH 1/2] mm: Retry migration earlier upon refcount mismatch

2024-09-01 Thread Huang, Ying
Dev Jain writes: > On 8/19/24 12:28, Huang, Ying wrote: >> Dev Jain writes: >> >>> On 8/13/24 12:52, Dev Jain wrote: On 8/13/24 10:30, Dev Jain wrote: > On 8/12/24 17:38, Dev Jain wrote: >> On 8/12/24 13:01, Huang, Ying wrote: >>> Dev Jain writes: >>> On 8/12/24 11

Re: [PATCH v2 02/19] iommufd/viommu: Add IOMMUFD_OBJ_VIOMMU and IOMMU_VIOMMU_ALLOC ioctl

2024-09-01 Thread Nicolin Chen
On Sun, Sep 01, 2024 at 10:39:17AM +0800, Baolu Lu wrote: > On 2024/8/28 0:59, Nicolin Chen wrote: > > +int iommufd_viommu_alloc_ioctl(struct iommufd_ucmd *ucmd) > > +{ > > + struct iommu_viommu_alloc *cmd = ucmd->cmd; > > + struct iommufd_hwpt_paging *hwpt_paging; > > + struct iommufd_

Re: [PATCH net-next] selftests: add selftest for UDP SO_PEEK_OFF support

2024-09-01 Thread Jason Xing
On Mon, Sep 2, 2024 at 9:07 AM Stanislav Fomichev wrote: > > On 09/01, Jason Xing wrote: > > From: Jason Xing > > > > Add the SO_PEEK_OFF selftest for UDP. In this patch, I mainly do > > three things: > > 1. rename tcp_so_peek_off.c > > 2. adjust for UDP protocol > > 3. add selftests into it > >

Re: [PATCH] selftests/futex: Create test for robust list

2024-09-01 Thread kernel test robot
rnel.org/r/20240829183509.446934-1-andrealmeid%40igalia.com patch subject: [PATCH] selftests/futex: Create test for robust list :: branch date: 3 days ago :: commit date: 3 days ago compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240901/20

Re: [PATCH] selftests: vDSO: Also test counter in vdso_test_chacha

2024-09-01 Thread Jason A. Donenfeld
On Sun, Sep 01, 2024 at 08:08:13PM +0200, Jason A. Donenfeld wrote: > While you're doing this, also add the remaining, `0, 0` elements. > > counter2 will always be counter2. You meant for the first argument to be > counter1. > > Also, same issue with counter2 used twice in that memcmp. Fixed these

Re: [PATCH] selftests: vDSO: Also test counter in vdso_test_chacha

2024-09-01 Thread Jason A. Donenfeld
On Sun, Sep 01, 2024 at 08:08:13PM +0200, Jason A. Donenfeld wrote: > > + reference_chacha20_blocks(output1, key, counter1, BLOCKS); > > + __arch_chacha20_blocks_nostack(output2, key, counter2, BLOCKS); > > + if (memcmp(output1, output2, sizeof(output1)) || > > + memcmp(counter2, counte

Re: [PATCH] selftests: vDSO: Do not rely on $ARCH for vdso_test_getrandom && vdso_test_chacha

2024-09-01 Thread Jason A. Donenfeld
On Sun, Sep 01, 2024 at 08:43:10PM +0200, Christophe Leroy wrote: > >> How would this fit in the logic where IIUC you just remove '_64' from > >> 'x86_64' to get 'x86' > > > > Huh? That's not what tools/scripts/Makefile.arch does. > > Hum ... yes sorry I looked at it too quickly and mixed things

Re: [PATCH net-next] selftests: add selftest for UDP SO_PEEK_OFF support

2024-09-01 Thread Stanislav Fomichev
On 09/01, Jason Xing wrote: > From: Jason Xing > > Add the SO_PEEK_OFF selftest for UDP. In this patch, I mainly do > three things: > 1. rename tcp_so_peek_off.c > 2. adjust for UDP protocol > 3. add selftests into it > > Suggested-by: Jon Maloy > Signed-off-by: Jason Xing > --- > Link: > htt

Re: [PATCH net-next RFC] selftests/net: integrate packetdrill with ksft

2024-09-01 Thread Willem de Bruijn
Willem de Bruijn wrote: > Jakub Kicinski wrote: > > On Fri, 30 Aug 2024 14:47:43 -0400 Willem de Bruijn wrote: > > > > We have directories in net/lib, and it's a target, and it works, no? > > > > > > net/lib is not a TARGET in tools/testing/selftests/Makefile. Its > > > Makefile only generates d

Re: [PATCH] selftests: vDSO: Do not rely on $ARCH for vdso_test_getrandom && vdso_test_chacha

2024-09-01 Thread Christophe Leroy
Le 01/09/2024 à 20:02, Jason A. Donenfeld a écrit : On Sun, Sep 01, 2024 at 08:00:30PM +0200, Christophe Leroy wrote: Hi Jason, Le 01/09/2024 à 15:22, Jason A. Donenfeld a écrit : Hi Christophe, Hmm, I'm not so sure I like this very much. I think it's important for these tests to fail when

Re: [PATCH] selftests: vDSO: Build vDSO tests with O2 optimisation

2024-09-01 Thread Jason A. Donenfeld
On Sun, Sep 01, 2024 at 07:24:03PM +0200, Christophe Leroy wrote: > Without -O2, the generated code for testing chacha function is awful. > GCC even implements rol32() as a function instead of just using the > rotlwi instruction, that function is 20 instructions long. > > ~# time ./vdso_test

Re: [PATCH] selftests: vDSO: Also test counter in vdso_test_chacha

2024-09-01 Thread Jason A. Donenfeld
On Sun, Sep 01, 2024 at 07:40:33PM +0200, Christophe Leroy wrote: > -static void reference_chacha20_blocks(uint8_t *dst_bytes, const uint32_t > *key, size_t nblocks) > +static void reference_chacha20_blocks(uint8_t *dst_bytes, const uint32_t > *key, uint32_t *counter, size_t nblocks) > { >

Re: [PATCH] selftests: vDSO: Do not rely on $ARCH for vdso_test_getrandom && vdso_test_chacha

2024-09-01 Thread Jason A. Donenfeld
On Sun, Sep 01, 2024 at 08:00:30PM +0200, Christophe Leroy wrote: > Hi Jason, > > Le 01/09/2024 à 15:22, Jason A. Donenfeld a écrit : > > Hi Christophe, > > > > Hmm, I'm not so sure I like this very much. I think it's important for > > these tests to fail when an arch tries to hook up the functio

Re: [PATCH] selftests: vDSO: Do not rely on $ARCH for vdso_test_getrandom && vdso_test_chacha

2024-09-01 Thread Christophe Leroy
Hi Jason, Le 01/09/2024 à 15:22, Jason A. Donenfeld a écrit : Hi Christophe, Hmm, I'm not so sure I like this very much. I think it's important for these tests to fail when an arch tries to hook up the function to the vDSO, but it's still not exported for some reason. This also regresses the AR

[PATCH] selftests: vDSO: Also test counter in vdso_test_chacha

2024-09-01 Thread Christophe Leroy
The chacha vDSO selftest doesn't check the way the counter is handled by __arch_chacha20_blocks_nostack(). It indirectly checks that the counter is writen on exit and read back on new entry, but it doesn't check that the format is correct. It has led to an invisible erroneous implementation on powe

[PATCH] selftests: vDSO: Build vDSO tests with O2 optimisation

2024-09-01 Thread Christophe Leroy
Without -O2, the generated code for testing chacha function is awful. GCC even implements rol32() as a function instead of just using the rotlwi instruction, that function is 20 instructions long. ~# time ./vdso_test_chacha TAP version 13 1..1 ok 1 chacha: PASS

Re: [PATCH] selftests: vDSO: Do not rely on $ARCH for vdso_test_getrandom && vdso_test_chacha

2024-09-01 Thread kernel test robot
submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Christophe-Leroy/selftests-vDSO-Do-not-rely-on-ARCH-for-vdso_test_getrandom-vdso_test_chacha/20240901-0

Re: [PATCH] selftests: vDSO: Do not rely on $ARCH for vdso_test_getrandom && vdso_test_chacha

2024-09-01 Thread Jason A. Donenfeld
Hi Christophe, Hmm, I'm not so sure I like this very much. I think it's important for these tests to fail when an arch tries to hook up the function to the vDSO, but it's still not exported for some reason. This also regresses the ARCH=x86_64 vs ARCH=x86 thing, which SRCARCH fixes. What about, in

Re: [PATCH v3 1/5] mm: Define VM_DROPPABLE for powerpc/32

2024-09-01 Thread Michael Ellerman
Christophe Leroy writes: > Commit 9651fcedf7b9 ("mm: add MAP_DROPPABLE for designating always > lazily freeable mappings") only adds VM_DROPPABLE for 64 bits > architectures. > > In order to also use the getrandom vDSO implementation on powerpc/32, > use VM_ARCH_1 for VM_DROPPABLE on powerpc/32. T