On Wed, 21 Aug 2024 09:00:41 -0700, Jakub Kicinski wrote:
>> I presumed that we would want to run the interface up/down, setup and
>> ethtool tests on both veth.
>> If this is not required, should I submit a v9 removing veth1 from the temp
>> list?
>
> Yes, please.
>
>> Also, while sending v9, do
Check if veth pair was created and if yes, xfail on setting IP address
logging an informational message.
Use XFAIL instead of SKIP for unsupported ethtool APIs.
Signed-off-by: Abhinav Jain
Reviewed-by: Simon Horman
---
tools/testing/selftests/net/netdevice.sh | 10 +++---
1 file changed, 7
Implement on/off testing for all non-fixed features via while loop.
Signed-off-by: Abhinav Jain
Reviewed-by: Simon Horman
---
tools/testing/selftests/net/netdevice.sh | 35 +++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net
Check if the netdev list is empty and create veth pair to be used for
feature on/off testing.
Remove the veth pair after testing is complete.
Signed-off-by: Abhinav Jain
Reviewed-by: Simon Horman
---
tools/testing/selftests/net/netdevice.sh | 15 +++
1 file changed, 15 insertions
# XFAIL: veth0: ethtool dump not supported
# PASS: veth0: ethtool stats
# PASS: veth0: stop interface
```
Abhinav Jain (3):
selftests: net: Create veth pair for testing in networkless kernel
selftests: net: Add on/off checks for non-fixed features of interface
selftests: net: Use XFAIL for ope
On Tue, 20 Aug 2024 16:50:06 -0700, Jakub Kicinski wrote:
> On Mon, 19 Aug 2024 17:42:33 +0530 Abhinav Jain wrote:
> > + echo "veth0" > "$TMP_LIST_NETDEV"
> > + echo "veth1" >> "$TMP_LIST_NETDEV"
>
> Why test both ends?
Check if veth pair was created and if yes, xfail on setting IP address
logging an informational message.
Use XFAIL instead of SKIP for unsupported ethtool APIs.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 10 +++---
1 file changed, 7 insertions(+), 3 deletions
Implement on/off testing for all non-fixed features via while loop.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 35 +++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/netdevice.sh
b/tools/testing
Check if the netdev list is empty and create veth pair to be used for
feature on/off testing.
Remove the veth pair after testing is complete.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 16
1 file changed, 16 insertions(+)
diff --git a/tools
udp-gro-forwarding
# PASS: veth0: Restore feature rx-udp-gro-forwarding to initial state off
# Cannot get register dump: Operation not supported
# XFAIL: veth0: ethtool dump not supported
# PASS: veth0: ethtool stats
# PASS: veth0: stop interface
```
Abhinav Jain (3):
selftests: net: Create veth p
On Thu, 15 Aug 2024 14:03:53 +0100, Simon Horman wrote:
> Hi Abhinav,
>
> Isn't the value being read into $initial_state here already present in $VALUE?
Yes, that is correct. I will wait for a day and send v8 using $VALUE.
Thanks.
---
On Wed, 14 Aug 2024 17:57:48 -0700, Jakub Kicinski wrote:
> On Wed, 14 Aug 2024 17:56:51 -0700 Jakub Kicinski wrote:
> > On Wed, 14 Aug 2024 19:15:15 +0000 Abhinav Jain wrote:
> > > Changes in v6:
> > > Use XFAIL for ethtool operations that are unsupported instead
Check if veth pair was created and if yes, xfail on setting IP address.
Use XFAIL instead of SKIP for unsupported ethtool APIs.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tools/testing
Implement on/off testing for all non-fixed features via while loop.
Save the initial state so that it can be restored after on/off checks.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 37 +++-
1 file changed, 36 insertions(+), 1 deletion
Check if the netdev list is empty and create veth pair to be used for
feature on/off testing.
Remove the veth pair after testing is complete.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 16
1 file changed, 16 insertions(+)
diff --git a/tools
ethtool dump not supported
# PASS: veth0: ethtool stats
# PASS: veth0: stop interface
```
Abhinav Jain (3):
selftests: net: Create veth pair for testing in networkless kernel
selftests: net: Add on/off checks for non-fixed features of interface
selftests: net: Use XFAIL for operations not suppo
Implement on/off testing for all non-fixed features via while loop.
Save the initial state so that it can be restored after on/off checks.
Use XFAIL for unsupported ethtool API.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 39 ++--
1 file
Check if the netdev list is empty and create veth pair to be used for
feature on/off testing.
Remove the veth pair after testing is complete.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 16
1 file changed, 16 insertions(+)
diff --git a/tools
get register dump: Operation not supported
# XFAIL: veth0: ethtool dump not supported
# PASS: veth0: ethtool stats
# PASS: veth0: stop interface
```
Abhinav Jain (2):
selftests: net: Create veth pair for testing in networkless kernel
selftests: net: Add on/off checks for non-fixed feature
On Tue, 13 Aug 2024 18:21:06 -0700, Jakub Kicinski wrote:
> Some patchwork malfunction, the patch didn't get registered :(
> Could you resend?
>
> Please keep Kuniyuki's review tag and address his feedback.
Sure. I have submitted v3 keeping the above in mind, please review:
https://lore.kernel.org
has type ‘const void *’ [-Wformat=]
../../kselftest_harness.h:101:17: note: in expansion of macro ‘__TH_LOG’
msg_oob.c:259:25: note: in expansion of macro ‘TH_LOG’
```
Fixes: d098d77232c3 ("selftest: af_unix: Add msg_oob.c.")
Signed-off-by: Abhinav Jain
Reviewed-by: Kuniyuki Iwashim
On Mon, 12 Aug 2024 11:39:44 -0700, Kuniyuki Iwashima wrote:
> Fixes: tag is needed here (no space between SOB tag)
Thank you, I have added it in v2 here:
> I don't remember why I defined expected_buf as (void *), but more simple
> fix would be the following ?
>
> ---8<---
> diff --git a/tools/
/20240810134037.669765-1-jain.abhinav...@gmail.com
Fixes: d098d77232c3 ("selftest: af_unix: Add msg_oob.c.")
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/af_unix/msg_oob.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/af_unix/msg_oob.c
b/too
On Fri, 9 Aug 2024 21:19:11 -0700, Jakub Kicinski wrote:
> > On Thu, 8 Aug 2024 09:23:09 -0700, Jakub Kicinski wrote:
> > > A number of checks now return SKIP because veth doesn't support all
> > > ethtool APIs.
> > >
> > > In netdev selftests we try to make sure SKIP is only used when test
> > >
bute ‘warn_unused_result’ [-Wunused-result]
statmount_test_ns.c:323:17: warning: ignoring return value of ‘read’
declared with attribute ‘warn_unused_result’ [-Wunused-result]
```
Signed-off-by: Abhinav Jain
---
.../selftests/filesystems/statmount/statmount_test_ns.c| 7 +--
1 file changed, 5 insertions(+
*’,but argument 6 has type ‘const void *’ [-Wformat=]
../../kselftest_harness.h:101:17: note: in expansion of macro ‘__TH_LOG’
msg_oob.c:259:25: note: in expansion of macro ‘TH_LOG’
```
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/af_unix/msg_oob.c | 6 --
1 file changed, 4
On Thu, 8 Aug 2024 09:23:09 -0700, Jakub Kicinski wrote:
> A number of checks now return SKIP because veth doesn't support all
> ethtool APIs.
>
> In netdev selftests we try to make sure SKIP is only used when test
> cannot be performed because of limitations of the environment.
> For example some
On Wed, 7 Aug 2024 18:28:34 -0700 Jakub Kicinski wrote:
> That's not the right syntax..
Thanks for the feedback Jakub. I have rectified this and while at it,
I tested using vng on a network based kernel and found another issue in
veth removal logic. I have fixed that as well.
Please kindly check
Implement on/off testing for all non-fixed features via while loop.
Save the initial state so that it can be restored after on/off checks.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 37 +++-
1 file changed, 36 insertions(+), 1 deletion
Check if the netdev list is empty and create veth pair to be used for
feature on/off testing.
Remove the veth pair after testing is complete.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 16
1 file changed, 16 insertions(+)
diff --git a/tools
face
# Removed veth pair
ok 12 selftests: net: netdevice.sh
```
Abhinav Jain (2):
selftests: net: Create veth pair for testing in networkless kernel
selftests: net: Add on/off checks for non-fixed features of interface
tools/testing/selftests/net/netdevice.sh | 53 +++-
1
Implement on/off testing for all non-fixed features via while loop.
Save the initial state so that it can be restored after on/off checks.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 37 +++-
1 file changed, 36 insertions(+), 1 deletion
Check if the netdev list is empty and create veth pair to be used for
feature on/off testing.
Remove the veth pair after testing is complete.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 18 ++
1 file changed, 18 insertions(+)
diff --git a/tools
ster dump: Operation not supported
# SKIP: veth1: ethtool dump not supported
# PASS: veth1: ethtool stats
# PASS: veth1: stop interface
# Removed veth pair
ok 12 selftests: net: netdevice.sh
```
Abhinav Jain (2):
selftests: net: Create veth pair for testing in networkless kernel
selftests: net: Ad
On Fri, 28 Jun 2024 13:30:14 -0700, Andrew Morton wrote:
> Well, it's all inside `if (0)', so just remove it.
Removed and shared v2 version of the patch here:
https://lore.kernel.org/all/20240629050449.990451-1-jain.abhinav...@gmail.com/
Please review. Thanks.
]
385 | write(1, buf, rv);
Signed-off-by: Abhinav Jain
---
Changes since v1:
- Remove the redundant if(0) block as per the feedback
- Patch v1:
https://lore.kernel.org/all/20240625152139.16412-1-jain.abhinav...@gmail.com/
---
tools/testing/selftests/proc/proc-empty-vm.c | 8
On Tue, 25 Jun 2024 11:05:26 -0700, Andrew Morton wrote:
> Thanks. There's a patch queued which simply deletes this code.
>
> https://lkml.kernel.org/r/20240603124220.33778-1-amer.shanaw...@gmail.com
Thank you for sharing the queued patch Andrew.
There has been no update/revert on it, may I know
]
385 | write(1, buf, rv);
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/proc/proc-empty-vm.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/proc/proc-empty-vm.c
b/tools/testing/selftests/proc/proc-empty-vm.c
index
On Thu, 13 Jun 2024 18:49:38 -0700, Jakub Kicinski wrote:
> You do off then on, so you assume the feature was on to begin with.
> Not all features will be on. You gotta change the order based on
> the initial state so that the feature goes back to what it was.
Thanks for sharing feedback, I have s
This patch addresses the TODO (add non fixed feature on/off check).
I have tested it manually on my system after making changes as suggested
in v1 and v2 linked below for reference.
Patch now restores the features being tested to their initial state.
Signed-off-by: Abhinav Jain
---
PATCH v2
root);
| ^
statmount_test.c:128:2: warning: ignoring return value of ‘chroot’,
declared with attribute warn_unused_result [-Wunused-result]
128 | chroot(".");
| ^~~
Signed-off-by: Abhinav Jain
---
.../filesystems/statmount/statmount_test.c | 13 +++
On Fri, 7 Jun 2024 19:01:27 +0100, Simon Horman wrote:
> Hi Abhinav,
>
> I suspect this will now only report a failure if tail fails,
> but ignore ethtool failures.
Hi Simon,
I agree, I missed this part earlier. After taking other suggestion
into account, we don't need this tail and I have remov
This patch addresses the TODO (add non fixed feature on/off check).
I have tested it manually on my system and made changes as suggested in v1
Signed-off-by: Abhinav Jain
---
PATCH v1:
https://lore.kernel.org/all/20240606212714.27472-1-jain.abhinav...@gmail.com/
Changes since v1:
- Removed
This patch addresses the present TODO in the file.
I have tested it manually on my system and added relevant filtering to
ensure that the correct feature list is being checked.
Signed-off-by: Abhinav Jain
---
tools/testing/selftests/net/netdevice.sh | 21 +++--
1 file changed
44 matches
Mail list logo
