On Wed, 2024-02-21 at 12:26 +0100, Heiko Carstens wrote:
> On Wed, Feb 21, 2024 at 08:49:58AM +0100, Janosch Frank wrote:
> > On 2/20/24 22:12, Eric Farman wrote:
> > > Hi Janosch,
> > >
> > > Here is a new (final?) version for the AR/MEM_OP issue I'm
>
used anyway. AR[1] is
selected for this test because the host AR[1] is usually non-zero,
and KVM needs to correctly swap those values.
Reviewed-by: Nina Schoetterl-Glausch
Acked-by: Christian Borntraeger
Signed-off-by: Eric Farman
---
tools/testing/selftests/kvm/s390x/memop.c | 31
v1: https://lore.kernel.org/r/20240209204539.4150550-1-far...@linux.ibm.com/
[CB] Store access registers around memop ioctl
[JF] Add a kernel selftest
RFC: https://lore.kernel.org/r/20240131205832.2179029-1-far...@linux.ibm.com/
Eric Farman (2):
KVM: s390: fix access register usage in ioctls
path), the
AR can be read from vcpu->run without stashing the current contents.
Reviewed-by: Heiko Carstens
Reviewed-by: Nina Schoetterl-Glausch
Acked-by: Christian Borntraeger
Reviewed-by: Christian Borntraeger
Signed-off-by: Eric Farman
---
arch/s390/include/asm/kvm_host.h | 2 +
On Tue, 2024-02-20 at 15:19 +0100, Janosch Frank wrote:
> On 2/20/24 15:15, Christian Borntraeger wrote:
> >
> >
> > Am 16.02.24 um 22:36 schrieb Eric Farman:
> > > The routine ar_translation() can be reached by both the
> > > instruction
> > > int
On Tue, 2024-02-20 at 14:34 +0100, Nina Schoetterl-Glausch wrote:
> On Thu, 2024-02-15 at 21:53 +0100, Eric Farman wrote:
> > There is a selftest that checks for an (expected) error when an
> > invalid AR is specified, but not one that exercises the AR path.
> >
> > Add
RFC: https://lore.kernel.org/r/20240131205832.2179029-1-far...@linux.ibm.com/
Eric Farman (2):
KVM: s390: fix access register usage in ioctls
KVM: s390: selftests: memop: add a simple AR test
arch/s390/include/asm/kvm_host.h | 1 +
arch/s390/kvm/gaccess.c | 3 ++-
arc
path), the
AR can be read from vcpu->run without stashing the current contents.
Signed-off-by: Eric Farman
---
arch/s390/include/asm/kvm_host.h | 1 +
arch/s390/kvm/gaccess.c | 3 ++-
arch/s390/kvm/kvm-s390.c | 3 +++
3 files changed, 6 insertions(+), 1 deletion(-)
diff -
used anyway. AR[1] is
selected for this test because the host AR[1] is usually non-zero,
and KVM needs to correctly swap those values.
Signed-off-by: Eric Farman
---
tools/testing/selftests/kvm/s390x/memop.c | 28 +++
1 file changed, 28 insertions(+)
diff --git a/tools
On Fri, 2024-02-16 at 11:33 -0500, Eric Farman wrote:
> On Fri, 2024-02-16 at 10:40 +0100, Heiko Carstens wrote:
> > On Thu, Feb 15, 2024 at 09:53:43PM +0100, Eric Farman wrote:
> > > The routine ar_translation() can be reached by both the
> > > instruction
> > &
On Fri, 2024-02-16 at 10:40 +0100, Heiko Carstens wrote:
> On Thu, Feb 15, 2024 at 09:53:43PM +0100, Eric Farman wrote:
> > The routine ar_translation() can be reached by both the instruction
> > intercept path (where the access registers had been loaded with the
> > guest re
ound memop ioctl
[JF] Add a kernel selftest
RFC: https://lore.kernel.org/r/20240131205832.2179029-1-far...@linux.ibm.com/
Eric Farman (2):
KVM: s390: load guest access registers in MEM_OP ioctl
KVM: s390: selftests: memop: add a simple AR test
arch/s390/include/asm/kvm_host.h
struct to indicate the
guest ARs have been loaded into the registers. This permits a
warning to be emitted if entering this path without a proper
register setup.
Suggested-by: Christian Borntraeger
Signed-off-by: Eric Farman
---
arch/s390/include/asm/kvm_host.h | 1 +
arch/s390/kvm/gaccess.c
used anyway. AR[1] is
selected for this test because the host AR[1] is usually non-zero,
and KVM needs to correctly swap those values.
Signed-off-by: Eric Farman
---
tools/testing/selftests/kvm/s390x/memop.c | 28 +++
1 file changed, 28 insertions(+)
diff --git a/tools
On Mon, 2024-02-12 at 12:52 +0100, Heiko Carstens wrote:
> > On Mon, Feb 12, 2024 at 11:21:30AM +0100, Heiko Carstens wrote:
> > > > Or maybe a TIF flag with different semantics: "guest save area
> > > > does
> > > > not
> > > > reflect current state - which is within registers".
> >
> > Something
used anyway. AR[1] is
selected for this test because the host AR[1] is usually non-zero,
and KVM needs to correctly swap those values.
Signed-off-by: Eric Farman
---
tools/testing/selftests/kvm/s390x/memop.c | 28 +++
1 file changed, 28 insertions(+)
diff --git a/tools
registers around the
MEM_OP ioctl, in the same way that the KVM_RUN ioctl does with
sync_regs()/store_regs(). The full register swap isn't needed here,
since only the access registers are used in this interface.
Suggested-by: Christian Borntraeger
Signed-off-by: Eric Farman
---
arch/s390/kvm
system call)
Thoughts on this approach?
Thanks,
Eric
[1] https://lore.kernel.org/r/20240131205832.2179029-1-far...@linux.ibm.com/
Eric Farman (2):
KVM: s390: load guest access registers in MEM_OP ioctl
KVM: s390: selftests: memop: add a simple AR test
arch/s390/kvm/kvm-s390.c
18 matches
Mail list logo