Re: [PATCH] selftests/vDSO: support DT_GNU_HASH

2024-08-27 Thread Fangrui Song
On Tue, Aug 27, 2024 at 10:12 PM Shuah Khan wrote: > > On 8/26/24 00:07, Xi Ruoyao wrote: > > On Wed, 2024-08-14 at 20:26 -0700, Fangrui Song wrote: > >> glibc added support for DT_GNU_HASH in 2006 and DT_HASH has been > >> obsoleted for more than one deca

Re: [PATCH] arm64/vdso: Remove --hash-style=sysv

2024-08-14 Thread Fangrui Song
On Wed, Aug 14, 2024 at 6:23 PM Fangrui Song wrote: > > On Wed, Aug 14, 2024 at 12:56 PM Xi Ruoyao wrote: > > > > On Thu, 2024-07-18 at 10:34 -0700, Fangrui Song wrote: > > > glibc added support for .gnu.hash in 2006 and .hash has been obsoleted > > > fo

[PATCH] selftests/vDSO: support DT_GNU_HASH

2024-08-14 Thread Fangrui Song
glibc added support for DT_GNU_HASH in 2006 and DT_HASH has been obsoleted for more than one decade in many Linux distributions. Many vDSOs support DT_GNU_HASH. This patch adds selftests support. Signed-off-by: Fangrui Song --- tools/testing/selftests/vDSO/parse_vdso.c | 105

Re: [PATCH] arm64/vdso: Remove --hash-style=sysv

2024-08-14 Thread Fangrui Song
On Wed, Aug 14, 2024 at 12:56 PM Xi Ruoyao wrote: > > On Thu, 2024-07-18 at 10:34 -0700, Fangrui Song wrote: > > glibc added support for .gnu.hash in 2006 and .hash has been obsoleted > > for more than one decade in many Linux distributions. Using > > --hash-style=sysv

Re: [PATCH 0/8] selftests: x86: build suite with clang

2024-05-15 Thread Fangrui Song
On Mon, May 6, 2024 at 4:26 PM Fangrui Song wrote: > > On Wed, May 1, 2024 at 5:29 AM Muhammad Usama Anjum > wrote: > > > > This series fixes build errors found by clang to allow the x86 suite to > > get built with the clang. > > > > Unfortunately, there

Re: [PATCH v2] selftests: exec: make binaries position independent

2024-05-06 Thread Fangrui Song
On Mon, May 6, 2024 at 5:05 PM Kees Cook wrote: > > On Mon, May 06, 2024 at 04:30:27PM -0700, Fangrui Song wrote: > > On Tue, Apr 16, 2024 at 10:28 AM Kees Cook wrote: > > > > > > On Tue, Apr 16, 2024 at 08:28:29PM +0500, Muhammad Usama Anjum wrote: > > &g

Re: [PATCH v2] selftests: exec: make binaries position independent

2024-05-06 Thread Fangrui Song
On Tue, Apr 16, 2024 at 10:28 AM Kees Cook wrote: > > On Tue, Apr 16, 2024 at 08:28:29PM +0500, Muhammad Usama Anjum wrote: > > The -static overrides the -pie and binaries aren't position independent > > anymore. Use -static-pie instead which would produce a static and > > position independent bin

Re: [PATCH 0/8] selftests: x86: build suite with clang

2024-05-06 Thread Fangrui Song
On Wed, May 1, 2024 at 5:29 AM Muhammad Usama Anjum wrote: > > This series fixes build errors found by clang to allow the x86 suite to > get built with the clang. > > Unfortunately, there is one bug [1] in the clang becuase of which > extended asm isn't handled correctly by it and build fails for

Re: [PATCH 0/3] Update LLVM Phabricator and Bugzilla links

2024-01-11 Thread Fangrui Song
> -- > > Nathan Chancellor > > > > Excellent! Thanks for doing this. I spot checked a handful I was > familiar with and everything looks good to me. > > Reviewed-by: Kees Cook > > -- > Kees Cook > These reviews.llvm.org links would definitely be kept lik