Re: [RFC PATCH net-next v8 07/14] page_pool: devmem support

2024-05-01 Thread Jesper Dangaard Brouer
On 30/04/2024 20.55, Jens Axboe wrote: On 4/30/24 12:29 PM, Mina Almasry wrote: On Tue, Apr 30, 2024 at 6:46?AM Jens Axboe wrote: [...] In general, attempting to hide overhead behind config options is always a losing proposition. It merely serves to say "look, if these things aren't enable

Re: [PATCH net-next 1/6] net: page_pool: support error injection

2024-04-30 Thread Jesper Dangaard Brouer
:-) Acked-by: Jesper Dangaard Brouer --- CC: h...@kernel.org CC: ilias.apalodi...@linaro.org --- net/core/page_pool.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/core/page_pool.c b/net/core/page_pool.c index 273c24429bce..8bcc7014a61a 100644 --- a/net/core/page_pool.c +++ b/net/core

Re: [PATCH bpf-next v3 2/3] net: stmmac: add Launch Time support to XDP ZC

2023-12-04 Thread Jesper Dangaard Brouer
On 12/3/23 17:51, Song Yoong Siang wrote: This patch enables Launch Time (Time-Based Scheduling) support to XDP zero copy via XDP Tx metadata framework. Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ As requested before, I think we need to se

Re: [PATCH bpf-next v3 3/3] selftests/bpf: add Launch Time request to xdp_hw_metadata

2023-12-04 Thread Jesper Dangaard Brouer
On 12/3/23 17:51, Song Yoong Siang wrote: This patch is tested with stmmac on Intel Tiger Lake platform. Refer to result below, the delta between pre-determined launch time and actual HW transmit complete time is around 24 us. Is there any NIC setup (e.g. ethtool/qdisc) requirements to enabl

Re: [PATCH bpf-next v2 0/3] xsk: TX metadata txtime support

2023-12-01 Thread Jesper Dangaard Brouer
On 12/1/23 16:09, Willem de Bruijn wrote: Song, Yoong Siang wrote: On Friday, December 1, 2023 6:46 PM, Jesper Dangaard Brouer wrote: On 12/1/23 07:24, Song Yoong Siang wrote: This series expands XDP TX metadata framework to include ETF HW offload. Changes since v1: - rename Time-Based

Re: [PATCH bpf-next v2 2/3] net: stmmac: Add txtime support to XDP ZC

2023-12-01 Thread Jesper Dangaard Brouer
On 12/1/23 07:24, Song Yoong Siang wrote: This patch enables txtime support to XDP zero copy via XDP Tx metadata framework. Signed-off-by: Song Yoong Siang --- drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 ++ drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 13 +

Re: [PATCH bpf-next v2 0/3] xsk: TX metadata txtime support

2023-12-01 Thread Jesper Dangaard Brouer
On 12/1/23 07:24, Song Yoong Siang wrote: This series expands XDP TX metadata framework to include ETF HW offload. Changes since v1: - rename Time-Based Scheduling (TBS) to Earliest TxTime First (ETF) - rename launch-time to txtime I strongly disagree with this renaming (sorry to disagree