Re: kunit alltests runs broken in mainline

2024-03-28 Thread Johannes Berg
On Thu, 2024-03-28 at 14:08 -0600, Shuah Khan wrote: > On 3/26/24 04:09, David Gow wrote: > > On Tue, 26 Mar 2024 at 15:55, Johannes Berg > > wrote: > > > > > > On Tue, 2024-03-26 at 01:52 +, Jakub Kicinski wrote: > > > > > > > >

Re: [PATCH] kunit: configs: Enable CONFIG_DAMON_DBGFS_DEPRECATED for --alltests

2024-03-26 Thread Johannes Berg
On Tue, 2024-03-26 at 10:07 +, David Gow wrote: > > Johannes: Does this conflict with the CONFIG_NETDEVICES / CONFIG_WLAN > fixes to all_tests.config? I'd assume not, but I'm happy to take them > via KUnit if you'd prefer anyway. > I already have it in my tree, so I guess I'd prefer it to st

Re: kunit alltests runs broken in mainline

2024-03-26 Thread Johannes Berg
On Tue, 2024-03-26 at 01:52 +, Jakub Kicinski wrote: > > I'm late to the party, but FWIW I had to toss this into netdev testing > tree as a local patch: > > CONFIG_NETDEVICES=y > CONFIG_WLAN=y I'll send this in the next wireless pull, soon. > CONFIG_DAMON_DBGFS_DEPRECATED=y > The DAMON con

Re: kunit alltests runs broken in mainline

2024-03-25 Thread Johannes Berg
On Mon, 2024-03-25 at 16:23 +, Mark Brown wrote: > On Mon, Mar 25, 2024 at 05:16:35PM +0100, Johannes Berg wrote: > > > Anyway, does it fix it for you as well? if yes, where/how should we get > > that in? > > Seems to. Given the breakage I'd expect it to go to L

Re: kunit alltests runs broken in mainline

2024-03-25 Thread Johannes Berg
On Mon, 2024-03-25 at 15:55 +, Mark Brown wrote: > On Mon, Mar 25, 2024 at 04:29:53PM +0100, Johannes Berg wrote: > > > But I'm not sure why ARCH=um is different? > > It's probably something to do with it lacking a bunch of features of > normal architectu

Re: kunit alltests runs broken in mainline

2024-03-25 Thread Johannes Berg
On Mon, 2024-03-25 at 15:21 +, Mark Brown wrote: > Hi, > > Commit 28b3df1fe6ba2cb4 ("kunit: add wireless unit tests") which I can't > seem to find on lore breaks full kunit runs on non-UML builds and is now > present in mainline. If I run: > >./tools/testing/kunit/kunit.py run --alltests

Re: pull-request: wireless-2024-01-22

2024-01-23 Thread Johannes Berg
On Tue, 2024-01-23 at 13:42 -0800, Jakub Kicinski wrote: > > > We're also adding unit tests to iwlwifi (slowly), any idea if we should > > enable that here also? It _is_ now possible to build PCI stuff on kunit, > > but it requires some additional config options (virt-pci etc.), not sure > > that'

Re: pull-request: wireless-2024-01-22

2024-01-23 Thread Johannes Berg
On Tue, 2024-01-23 at 19:19 +0100, Johannes Berg wrote: > > We're also adding unit tests to iwlwifi (slowly), any idea if we should > enable that here also? It _is_ now possible to build PCI stuff on kunit, > but it requires some additional config options (virt-pci etc.),

Re: pull-request: wireless-2024-01-22

2024-01-23 Thread Johannes Berg
On Tue, 2024-01-23 at 08:45 -0800, Jakub Kicinski wrote: > On Mon, 22 Jan 2024 15:34:34 + (UTC) Kalle Valo wrote: > > Lukas Bulwahn (1): > > wifi: cfg80211/mac80211: remove dependency on non-existing option > > BTW we run all kernel's kunit tests on netdev periodically by doing: > > ./t

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-22 Thread Johannes Berg
Hi, Thanks for taking a look! On Fri, 2023-12-22 at 18:02 +0800, David Gow wrote: > The two initial KUnit patches look fine, modulo a couple of minor docs > issues and checkpatch warnings.  I can run checkpatch (even if I can't always take it seriously), but do you want to comment more specifica

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-21 Thread Johannes Berg
On Thu, 2023-12-21 at 13:06 -0700, Shuah Khan wrote: > On 12/21/23 12:39, Johannes Berg wrote: > > > > > > This patchset adds a couple of helpers for kunit as well as tests for > > > cfg80211 and mac80211 that use them. > > > > I can take this through th

Re: [PATCH 0/6] Add some more cfg80211 and mac80211 kunit tests

2023-12-21 Thread Johannes Berg
> > This patchset adds a couple of helpers for kunit as well as tests for > cfg80211 and mac80211 that use them. I can take this through the wireless tree, but then I'd like to have ACKs from kunit folks for the kunit patches: > kunit: add parameter generation macro using description from arra