Re: [PATCH bpf-next v3 2/3] bpf: do not walk twice the hash map on free

2024-04-30 Thread Kumar Kartikeya Dwivedi
the *pointer* to them for recycling without hitting the pcpu allocator, so should be fine (just in case this confuses anyone else). > > changes in v3: > - fix unloading of bpf_wq, again > > changes in v2: > - fix wq being not freed (and static call not used) > --- Acked-by: Kumar Kartikeya Dwivedi

Re: [PATCH bpf-next v3 3/3] selftests/bpf: drop an unused local variable

2024-04-30 Thread Kumar Kartikeya Dwivedi
On Tue, 30 Apr 2024 at 12:44, Benjamin Tissoires wrote: > > Some copy/paste leftover, this is never used > > Fixes: e3d9eac99afd ("selftests/bpf: wq: add bpf_wq_init() checks") > Signed-off-by: Benjamin Tissoires > > --- > > no changes in v3 > > no cha

Re: [PATCH bpf-next v3 1/3] bpf: do not walk twice the map on free

2024-04-30 Thread Kumar Kartikeya Dwivedi
a ("bpf: allow struct bpf_wq to be embedded in arraymaps > and hashmaps") > Signed-off-by: Benjamin Tissoires > > --- > > no changes in v3 > > no changes in v2 > --- Acked-by: Kumar Kartikeya Dwivedi > [...]

Re: [PATCH bpf-next v5 2/6] bpf/verifier: add bpf_timer as a kfunc capable type

2024-03-23 Thread Kumar Kartikeya Dwivedi
On Sun, 24 Mar 2024 at 05:38, Alexei Starovoitov wrote: > > On Sat, Mar 23, 2024 at 9:01 PM Kumar Kartikeya Dwivedi > wrote: > > > > On Sun, 24 Mar 2024 at 04:53, Alexei Starovoitov > > wrote: > > > > > > On Fri, Mar 22, 2024 at

Re: [PATCH bpf-next v5 2/6] bpf/verifier: add bpf_timer as a kfunc capable type

2024-03-23 Thread Kumar Kartikeya Dwivedi
On Sun, 24 Mar 2024 at 04:53, Alexei Starovoitov wrote: > > On Fri, Mar 22, 2024 at 9:31 AM Kumar Kartikeya Dwivedi > wrote: > > > > On Fri, 22 Mar 2024 at 15:57, Benjamin Tissoires wrote: > > > > > > We need to extend the bpf_timer API, but the way

Re: [PATCH bpf-next v5 3/6] bpf/helpers: introduce bpf_timer_set_sleepable_cb() kfunc

2024-03-22 Thread Kumar Kartikeya Dwivedi
On Fri, 22 Mar 2024 at 15:57, Benjamin Tissoires wrote: > > In this patch, bpf_timer_set_sleepable_cb() is functionally equivalent > to bpf_timer_set_callback(), to the exception that it enforces > the timer to be started with BPF_F_TIMER_SLEEPABLE. > > But given that bpf_timer_set_callback() is

Re: [PATCH bpf-next v5 2/6] bpf/verifier: add bpf_timer as a kfunc capable type

2024-03-22 Thread Kumar Kartikeya Dwivedi
On Fri, 22 Mar 2024 at 15:57, Benjamin Tissoires wrote: > > We need to extend the bpf_timer API, but the way forward relies on kfuncs. > So make bpf_timer known for kfuncs from the verifier PoV > > Signed-off-by: Benjamin Tissoires > > --- > > changes in v5: > - also check for the reg offset > >

Re: [PATCH RFC bpf-next 0/9] allow HID-BPF to do device IOs

2024-02-13 Thread Kumar Kartikeya Dwivedi
On Tue, 13 Feb 2024 at 18:46, Benjamin Tissoires wrote: > > On Feb 12 2024, Alexei Starovoitov wrote: > > On Mon, Feb 12, 2024 at 10:21 AM Benjamin Tissoires > > wrote: > > > > > > On Mon, Feb 12, 2024 at 6:46 PM Toke Høiland-Jørgensen > > > wrote: > > > > > > > > Benjamin Tissoires writes: >

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-14 Thread Kumar Kartikeya Dwivedi
On Thu, 14 Dec 2023 at 17:08, Kumar Kartikeya Dwivedi wrote: > > On Thu, 14 Dec 2023 at 00:49, Eyal Birger wrote: > > > > On Wed, Dec 13, 2023 at 3:15 PM Daniel Xu wrote: > > > > > [...] > > > > > > > > > > diff --git a/tools/te

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-14 Thread Kumar Kartikeya Dwivedi
On Thu, 14 Dec 2023 at 00:49, Eyal Birger wrote: > > On Wed, Dec 13, 2023 at 3:15 PM Daniel Xu wrote: > > > > [...] > > > > > > > > diff --git a/tools/testing/selftests/bpf/progs/test_tunnel_kern.c > > > > b/tools/testing/selftests/bpf/progs/test_tunnel_kern.c > > > > index

Re: [PATCH bpf-next v5 9/9] bpf: xfrm: Add selftest for bpf_xdp_get_xfrm_state()

2023-12-12 Thread Kumar Kartikeya Dwivedi
On Tue, 12 Dec 2023 at 20:52, Daniel Xu wrote: > > cc Kumar > > On Tue, Dec 12, 2023 at 09:17:02AM -0700, Daniel Xu wrote: > > On Mon, Dec 11, 2023 at 04:25:06PM -0800, Eyal Birger wrote: > > > On Mon, Dec 11, 2023 at 3:49 PM Daniel Xu wrote: > > > > > > > > On Mon, Dec 11, 2023 at 03:13:07PM