Re: [PATCH 2/2] selftests: rust: config: disable GCC_PLUGINS

On Fri, Aug 2, 2024 at 2:45 PM Anders Roxell wrote: > > CONFIG_RUST depends on !CONFIG_GCC_PLUGINS. Disable CONFIG_GCC_PLUGINS > in rust/config file to make sure it doesn't get enabled. > > Signed-off-by: Anders Roxell Acked-by: Miguel Ojeda When https://lore.kerne

Re: [PATCH 1/2] selftests: rust: config: add trailing newline

nfig.sh` be improved too? Shuah, if you plan to pick this: Acked-by: Miguel Ojeda Thanks! Cheers, Miguel

Re: [PATCH] rust: str: Use `core::CStr`, remove the custom `CStr` implementation

On Mon, Jul 15, 2024 at 6:12 PM Michal Rostecki wrote: > > @@ -71,11 +75,11 @@ macro_rules! kunit_assert { > // > // This mimics KUnit's failed assertion format. > $crate::kunit::err(format_args!( > -"# {}: ASSERTION FAI

Re: [PATCH] rust: str: Use `core::CStr`, remove the custom `CStr` implementation

Hi Michal, Thanks for the patch! Some notes below... On Sun, Jul 14, 2024 at 6:02 PM Michal Rostecki wrote: > > `CStr` became a part of `core` library in Rust 1.75, therefore there is > no need to keep the custom implementation. It would depend on the differences, right? i.e. for a reader, is t

Re: [PATCH] kbuild: rust: remove unneeded `@rustc_cfg` to avoid ICE

On Mon, Apr 22, 2024 at 11:13 AM Miguel Ojeda wrote: > > When KUnit tests are enabled, under very big kernel configurations > (e.g. `allyesconfig`), we can trigger a `rustdoc` ICE [1]: > > RUSTDOC TK rust/kernel/lib.rs > error: the compiler unexpectedly panicked. this

[PATCH] kbuild: rust: remove unneeded `@rustc_cfg` to avoid ICE

...@vger.kernel.org Fixes: a66d733da801 ("rust: support running Rust documentation tests as KUnit ones") Link: https://github.com/rust-lang/rust/issues/122722 [1] Link: https://github.com/rust-lang/rust/pull/122840 [2] Signed-off-by: Miguel Ojeda --- rust/Makefile | 1 - 1 file changed, 1 deletio

Re: [PATCH] kunit: Fix race condition in try-catch completion

> https://lore.kernel.org/lkml/20240410102710.35911-1-naresh.kamb...@linaro.org/ > Tested-by: Linux Kernel Functional Testing > Acked-by: Mickaël Salaün > Signed-off-by: David Gow I noticed it with the Rust tests too, and indeed this fixed it: Tested-by: Miguel Ojeda Thanks! Cheers, Miguel

Re: [PATCH v1 12/13] tools headers: Sync compiler.h headers

On Sun, Mar 10, 2024 at 3:06 AM Ian Rogers wrote: > > compiler_attributes.h - added from > include/linux/compiler_attributes.h, > guards were added to definitions to avoid redefinition of macros > in libc. Do you have an example for context? Thanks! Cheers, Miguel

Re: [PATCH v1 13/13] tools headers: Rename noinline to __noinline

On Sun, Mar 10, 2024 at 3:06 AM Ian Rogers wrote: > > [1] https://clang.llvm.org/docs/AttributeReference.html#noinline > Reported-by: Christopher Di Bella Out of curiosity, was this due to the `[[gnu::noinline]]` or similar in e.g. `src/string/memset_explicit.h`? > -#define noinline

Re: [PATCH v5] kselftest: Add basic test for probing the rust sample modules

On Fri, Mar 1, 2024 at 4:22 PM Laura Nao wrote: > > Adding --first-time (you meant --first-time, right?) definitely makes > sense, thanks for the pointer. I think having the modules being built-in > should be treated as a skip, same as when they are not there at all. Yeah, I meant `--first-time`,

Re: [PATCH v5] kselftest: Add basic test for probing the rust sample modules

On Thu, Feb 29, 2024 at 4:53 PM Laura Nao wrote: > > Add new basic kselftest that checks if the available rust sample modules > can be added and removed correctly. > > Signed-off-by: Laura Nao > Reviewed-by: Sergio Gonzalez Collado > Reviewed-by: Muhammad Usama Anjum Thanks for this Laura! Re

Re: [PATCH] kselftest: Add basic test for probing the rust sample modules

On Fri, Dec 15, 2023 at 2:21 PM Laura Nao wrote: > > Add new basic kselftest that checks if the available rust sample modules > can be added and removed correctly. > > Signed-off-by: Laura Nao Thanks Laura! Shuah: do you want that we pick this one? If so, your `Acked-by` would be nice -- thanks