Re: [PATCH v1 1/1] selftests/sgx: Fix the implicit declaration of asprintf() compiler error

2024-05-13 Thread Mirsad Todorovac
Sakkinen wrote: > > On Sat May 11, 2024 at 12:02 AM EEST, Mirsad Todorovac wrote: > > On 5/10/24 22:52, John Hubbard wrote: > > > On 5/10/24 1:37 PM, Mirsad Todorovac wrote: > > > ... > > >> The fix defines __USE_GNU before including in case it i

Re: [PATCH v1 1/1] selftests/sgx: Fix the implicit declaration of asprintf() compiler error

2024-05-10 Thread Mirsad Todorovac
On 5/10/24 22:52, John Hubbard wrote: > On 5/10/24 1:37 PM, Mirsad Todorovac wrote: > ... >> The fix defines __USE_GNU before including in case it isn't already >> defined. After this intervention the module compiles OK. > > Instead of interventions, I believ

[PATCH v1 1/1] selftests/sgx: Fix the implicit declaration of asprintf() compiler error

2024-05-10 Thread Mirsad Todorovac
on. Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") Cc: Edward Liaw Cc: Jarkko Sakkinen Cc: Dave Hansen Cc: Shuah Khan Cc: linux-...@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Mirsad Todorovac --- tools/testi

[PATCH v1 1/1] selftests/sgx: Fix the implicit declaration of asprintf() compiler error

2024-05-10 Thread Mirsad Todorovac
on. Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") Cc: Edward Liaw Cc: Jarkko Sakkinen Cc: Dave Hansen Cc: Shuah Khan Cc: linux-...@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Mirsad Todorovac --- tools/testi

[BUG selftests/pidfd] pidfd_setns_test HANG

2024-05-07 Thread Mirsad Todorovac
als: pass:3 fail:4 xfail:0 xpass:0 skip:0 error:0 Thanks for your time and patience for reviewing this BUG report. Best regards, Mirsad Todorovac P.S. I have changed the email address because of the uncertainty whether the employer would continue to support my work on the Linux kernel testing as the part of my work research. Thank you. config-6.9.0-rc7.gz Description: application/gzip

Re: [BUG] seltests/iommu: runaway ./iommufd consuming 99% CPU after a failed assert()

2024-03-27 Thread Mirsad Todorovac
On 3/27/24 11:41, Joao Martins wrote: On 25/03/2024 13:52, Jason Gunthorpe wrote: On Mon, Mar 25, 2024 at 12:17:28PM +, Joao Martins wrote: However, I am not smart enough to figure out why ... Apparently, from the source, mmap() fails to allocate pages on the desired address:   1746 

Re: [BUG] seltests/iommu: runaway ./iommufd consuming 99% CPU after a failed assert()

2024-03-23 Thread Mirsad Todorovac
On 3/19/24 14:58, Jason Gunthorpe wrote: On Tue, Mar 12, 2024 at 07:35:40AM +0100, Mirsad Todorovac wrote: Hi, (This is verified on the second test box.) In the most recent 6.8.0 release of torvalds tree kernel with selftest configs on, process ./iommufd appears to consume 99% of a CPU

Re: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]

2024-03-21 Thread Mirsad Todorovac
On 3/20/24 12:01, Ido Schimmel wrote: On Wed, Mar 20, 2024 at 01:47:36AM +0100, Mirsad Todorovac wrote: On 3/19/24 15:25, Ido Schimmel wrote: Will look into it today or later this week. Thank you for considering this. Can you please try the following patch? https://github.com/idosch

Re: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]

2024-03-21 Thread Mirsad Todorovac
On 3/20/24 12:01, Ido Schimmel wrote: On Wed, Mar 20, 2024 at 01:47:36AM +0100, Mirsad Todorovac wrote: On 3/19/24 15:25, Ido Schimmel wrote: Will look into it today or later this week. Thank you for considering this. Can you please try the following patch? https://github.com/idosch

Re: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]

2024-03-19 Thread Mirsad Todorovac
On 3/19/24 15:25, Ido Schimmel wrote: On Tue, Mar 19, 2024 at 06:05:16AM +0100, Mirsad Todorovac wrote: On 3/18/24 04:35, Hangbin Liu wrote: On Sun, Mar 17, 2024 at 12:19:12AM +0100, Mirsad Todorovac wrote: Hi, While running kselftest on vanilla torvalds tree kernel commit v6.8-11167

Re: [BUG] selftests/net: test_vxlan_mdb.sh: 84 out of 642 tests [FAIL]

2024-03-18 Thread Mirsad Todorovac
On 3/18/24 04:35, Hangbin Liu wrote: On Sun, Mar 17, 2024 at 12:19:12AM +0100, Mirsad Todorovac wrote: Hi, While running kselftest on vanilla torvalds tree kernel commit v6.8-11167-g4438a810f396, the test suite reported a number of errors. I was using the latest iproute2-next suite

Re: [BUG] selftests/net: icmp_redirect.sh: 12 out of 40 test result with [FAIL]

2024-03-18 Thread Mirsad Todorovac
On 3/18/24 15:42, David Ahern wrote: On 3/17/24 8:38 PM, Hangbin Liu wrote: Wild guess, the last change of icmp_redirect is my netns update. Maybe there are something default sysctl settings in netns cause the error? It is most likely sysctl settings. It would be good to chase those down and

[BUG] selftests/net: icmp_redirect.sh: 12 out of 40 test result with [FAIL]

2024-03-16 Thread Mirsad Todorovac
These errors are not introduced with this commit, but were already present at least in 6.8-rc7. Hope this helps. Best regards, Mirsad Todorovac

[BUG] seltests/iommu: runaway ./iommufd consuming 99% CPU after a failed assert()

2024-03-12 Thread Mirsad Todorovac
at ../kselftest_harness.h:1199 #6 main (argc=1, argv=0x7ffdcdce61a8) at iommufd.c:2349 (gdb) list iommufd.c:2349 2344 _cmd)); 2345} 2346} 2347} 2348 2349TEST_HARNESS_MAIN (gdb) Hope this helps someone. Best regards, Mirsad Todorovac config-6.8.0-torv-00711-g045395d86acd-dirty.xz Description: application/xz

[BUG net-next] fcnal-test.sh: 4 (four) tests FAIL

2024-03-09 Thread Mirsad Todorovac
3452->[2001:db8:1::1].12345 [S]L3 index 0 Mar 9 19:15:58 defiant kernel: [75240.777430] TCP: MD5 Hash mismatch for [2001:db8:1::2].48658->[2001:db8:1::1].12345 [S]L3 index 13 Mar 9 19:15:59 defiant kernel: [75241.783727] TCP: MD5 Hash mismatch for [2001:db8:1::2].48658->[2001:db8:1::

Re: [BUG net-next selftests/pidfd] Hang in ./pidfd_setns_test pidfd_send_signal()

2024-03-09 Thread Mirsad Todorovac
] signal: resolve_test[1025139] overflowed sigaltstack Best regards, Mirsad Todorovac

Re: [BUG net-next selftests/pidfd] Hang in ./pidfd_setns_test pidfd_send_signal()

2024-03-09 Thread Mirsad Todorovac
, Mirsad Todorovac

[BUG net-next selftests/pidfd] Hang in ./pidfd_setns_test pidfd_send_signal()

2024-03-09 Thread Mirsad Todorovac
NULL, 0) = 0 pidfd_send_signal(20, SIGKILL, NULL, 0) = 0 pidfd_send_signal(20, SIGKILL, NULL, 0) = 0 pidfd_send_signal(20, SIGKILL, NULL, 0) = 0 pidfd_send_signal(20, SIGKILL, NULL, 0) = 0 pidfd_send_signal(20, SIGKILL, NULL, 0) = 0 pidfd_send_signal(20, SIGKILL, NULL, 0) = 0 pidfd_send_signal(20, SIG

[BUG] selftests: cgroup: KMEMLEAK in cgroup/test_cpuset_prs.sh

2024-02-27 Thread Mirsad Todorovac
on two boxes, and both have AMD Ryzen processors 7 and 9. Please find attached the build .config Best regards, Mirsad Todorovac # cat /sys/kernel/debug/kmemleak [stack decoded] unreferenced object 0x8d49bd92a720 (size 8): comm "test_cpuset_prs", pid 9213, jiffies 4294953562 hex dum

[PATCH v1 2/2] selftest: breakpoints: clear the format string warning and secure the output

2024-01-09 Thread Mirsad Todorovac
el.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Mirsad Todorovac --- tools/testing/selftests/breakpoints/breakpoint_test.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/breakpoints/breakpoint_test.c b/tools/testing/selftests/breakpoints/bre

[PATCH v1 1/2] selftest: breakpoints: fix a minor typo in the format string

2024-01-09 Thread Mirsad Todorovac
rror(errno)); |^~~~ Fixing the typo $s into %s resolves the issue. Fixes: 3fa72f2c784b5 ("selftests: breakpoints: step_after_suspend_test use ksft_* var arg msg api") Cc: Shuah Khan Cc: linux-kselftest@vger.kernel.org Cc: linux-ker...@vger.kernel.org S

[PATCH v1 0/2] selftest: breakpoints: minor format string fixes

2024-01-09 Thread Mirsad Todorovac
Minor consistency fixes. They clear a couple of compiler format string warnings. [1/2] is the fix of an obvious typo in the format specifier [2/2] is securing the print function against spurious format specifiers in passed paramater string Mirsad Todorovac (2): selftest: breakpoints

Re: [PATCH v1 3/4] ksellftest: alsa: Fix the printf format specifier to unsigned int

2024-01-07 Thread Mirsad Todorovac
On 07. 01. 2024. 19:40, Andreas Schwab wrote: > s/ksellftest/kselftest/ Thx. Fixed in v2. Thanks, Mirsad -- Mirsad Goran Todorovac Sistem inženjer Grafički fakultet | Akademija likovnih umjetnosti Sveučilište u Zagrebu System engineer Faculty of Graphic Arts | Academy of Fine Arts

Re: [PATCH v1 3/4] ksellftest: alsa: Fix the printf format specifier to unsigned int

2024-01-07 Thread Mirsad Todorovac
On 07. 01. 2024. 19:14, Mark Brown wrote: > On Sun, Jan 07, 2024 at 05:21:00PM +0100, Mirsad Todorovac wrote: > >> I guess I can keep the Acked-by tags. Will the patchwork find the tag in >> the v1 patch set? > > No, you need to include it. Great. Sent

[PATCH v2 4/4] kselftest/alsa - conf: Stringify the printed errno in sysfs_get()

2024-01-07 Thread Mirsad Todorovac
h Khan Cc: linux-so...@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Mirsad Todorovac --- v1 -> v2: Changed the subject line as suggested to reflect the style of the subsystem. No change to the code. tools/testing/selftests/alsa/conf.c | 2 +- 1 fi

[PATCH v2 3/4] kselftest/alsa - mixer-test: Fix the print format specifier warning

2024-01-07 Thread Mirsad Todorovac
"kselftest: alsa: Validate values read from enumerations") Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Shuah Khan Cc: linux-so...@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Mirsad Todorovac --- v1 -> v2: Changed

[PATCH v2 2/4] kselftest/alsa - mixer-test: Fix the print format specifier warning

2024-01-07 Thread Mirsad Todorovac
s: 3f48b137d88e7 ("kselftest: alsa: Factor out check that values meet constraints") Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Shuah Khan Cc: linux-so...@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Mirsad Todorovac Ac

[PATCH v2 1/4] kselftest/alsa - mixer-test: fix the number of parameters to ksft_exit_fail_msg()

2024-01-07 Thread Mirsad Todorovac
ernel.org Signed-off-by: Mirsad Todorovac Acked-by: Mark Brown --- v1 -> v2: Changed the subject line as suggested to reflect the style of the subsystem. No change to the reviewed code. tools/testing/selftests/alsa/mixer-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) dif

[PATCH v2 0/4] kselftest: alsa: Fix a couple of format specifiers and function parameters

2024-01-07 Thread Mirsad Todorovac
ust the subject line (done). (code unchanged) - 3/4 The format specifier was changed from %d to %u as suggested. - The 4/4 submitted for review (in the v1 it was delayed by an omission). (code unchanged) Mirsad Todorovac (4): kselftest/alsa - mixer-test: fix the number of paramet

Re: [PATCH v1 3/4] ksellftest: alsa: Fix the printf format specifier to unsigned int

2024-01-07 Thread Mirsad Todorovac
On 07. 01. 2024. 16:33, Mark Brown wrote: > On Sun, Jan 07, 2024 at 04:12:20PM +0100, Mirsad Todorovac wrote: > >> mixer-test.c:350:80: warning: format ‘%ld’ expects argument of type ‘long >> int’, \ >>but argument 5 has type

[PATCH v1 4/4] selftests: alsa: Fix the exit error message parameter in sysfs_get()

2024-01-07 Thread Mirsad Todorovac
h Khan Cc: linux-so...@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Mirsad Todorovac --- tools/testing/selftests/alsa/conf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/alsa/conf.c b/tools/testing/selftes

Re: [PATCH v1 1/1] selftests: net: increase timeout value for tests

2024-01-07 Thread Mirsad Todorovac
On 07. 01. 2024. 13:49, Hangbin Liu wrote: > On Sun, Jan 07, 2024 at 01:39:29AM +0100, Mirsad Todorovac wrote: >> In particular, fcnal-test.sh timed out on slower hardware after >> some new permutations of tests were added. >> >> This single test ran for almost an h

[PATCH v1 3/4] ksellftest: alsa: Fix the printf format specifier to unsigned int

2024-01-07 Thread Mirsad Todorovac
"kselftest: alsa: Validate values read from enumerations") Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Shuah Khan Cc: linux-so...@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Mirsad Todorovac --- tools/testing/selftests/alsa/m

[PATCH v1 2/4] kselftest: alsa: Fix the printf format specifier in call to ksft_print_msg()

2024-01-07 Thread Mirsad Todorovac
s: 3f48b137d88e7 ("kselftest: alsa: Factor out check that values meet constraints") Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Shuah Khan Cc: linux-so...@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Cc: linux-ker...@vger.kernel.org Signed-off-by: Mirsad Todorovac --

[PATCH v1 1/4] kselftest: alsa: fix the number of parameters to ksft_exit_fail_msg()

2024-01-07 Thread Mirsad Todorovac
ernel.org Signed-off-by: Mirsad Todorovac --- tools/testing/selftests/alsa/mixer-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/alsa/mixer-test.c b/tools/testing/selftests/alsa/mixer-test.c index 23df154fcdd7..208c2170c074 100644 --- a/tools/testing/

[PATCH v1 0/4] kselftest: alsa: Fix a couple of format specifiers and function parameters

2024-01-07 Thread Mirsad Todorovac
suite. Mirsad Todorovac (4): kselftest: alsa: fix the number of parameters to ksft_exit_fail_msg() kselftest: alsa: Fix the printf format specifier in call to ksft_print_msg() ksellftest: alsa: Fix the printf format specifier to unsigned int selftests: alsa: Fix the exit error message

[BUG] selftests: memfd: run_hugetlbfs_test.sh: Hang in fuse_mnt?

2024-01-06 Thread Mirsad Todorovac
Hi all, I'm running the 6.7.0-rc8-00174-g95c8a35f1c01 kernel from torvalds tree on a Ubuntu 23.10 Mantic Minotaur system. What I get are these errors. memfd selftests are actually counted as "ok", but they give errors and/or hang. Please find the strace output attached, and the config used.

[PATCH v1 1/1] selftests: net: increase timeout value for tests

2024-01-06 Thread Mirsad Todorovac
umazet Cc: Jakub Kicinski Cc: Paolo Abeni Cc: Shuah Khan Cc: net...@vger.kernel.org Cc: linux-kselftest@vger.kernel.org Signed-off-by: Mirsad Todorovac --- tools/testing/selftests/net/settings | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/net/setting

Re: selftest: net: fcnal-test.sh TIMEOUT

2024-01-06 Thread Mirsad Todorovac
On 06. 01. 2024. 22:02, Mirsad Todorovac wrote: > On 06. 01. 2024. 17:16, David Ahern wrote: >> On 1/5/24 2:41 AM, Mirsad Todorovac wrote: >>> diff --git a/tools/testing/selftests/net/settings >>> b/tools/testing/selftests/net/settings index dfc27cdc6c05..ed8418e8

[BUG] selftests: alsa: conf.c: wrong parm passed to printf [FIXED]

2024-01-06 Thread Mirsad Todorovac
Hi, all, There is a minor omission in selftests/alsa/conf.c, returning errno where there is strerror(errno) passed in the sibling calls to printf(). The bug was apparently introduced with the commit aba51cd0949ae ("selftests: alsa - add PCM test"). As a diff speaks like a thousand words, the

Re: selftest: net: fcnal-test.sh TIMEOUT

2024-01-06 Thread Mirsad Todorovac
On 06. 01. 2024. 17:16, David Ahern wrote: > On 1/5/24 2:41 AM, Mirsad Todorovac wrote: >> diff --git a/tools/testing/selftests/net/settings >> b/tools/testing/selftests/net/settings index dfc27cdc6c05..ed8418e8217a >> 100644 --- a/tools/testing/selftests/net/settings +

selftest: net: fcnal-test.sh TIMEOUT

2024-01-05 Thread Mirsad Todorovac
Hi, all, The default timeout for tools/testing/selftest/net groups of tests is 1500s (25m). This is less than half of what is required to run the full fcnal-test.sh on my hardware (53m48s). With the timeout adjusted, tests passed 914 of 914 OK. Best regards, Mirsad Todorovac diff --git