Re: [PATCH net-next] selftests/tc-testing: require an up to date iproute2 for blockcast tests

2024-03-01 Thread Pedro Tammela
On 01/03/2024 09:24, Naresh Kamboju wrote: Hi Pedro, On Thu, 29 Feb 2024 at 20:08, Pedro Tammela wrote: Add the dependsOn test check for all the mirred blockcast tests. It will prevent the issue reported by LKFT which happens when an older iproute2 is used to run the current tdc. Thank you

[PATCH net-next] selftests/tc-testing: require an up to date iproute2 for blockcast tests

2024-02-29 Thread Pedro Tammela
Add the dependsOn test check for all the mirred blockcast tests. It will prevent the issue reported by LKFT which happens when an older iproute2 is used to run the current tdc. Tests are skipped if the dependsOn check fails. Reported-by: Linux Kernel Functional Testing Signed-off-by: Pedro

[PATCH net-next v2 5/5] selftests: tc-testing: return fail if a test fails in setup/teardown

2024-01-24 Thread Pedro Tammela
As of today tests throwing exceptions in setup/teardown phase are treated as skipped but they should really be failures. Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/tdc.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/tc

[PATCH net-next v2 4/5] selftests: tc-testing: enable all tdc tests

2024-01-24 Thread Pedro Tammela
For the longest time tdc ran only actions and qdiscs tests. It's time to enable all the remaining tests so every user visible piece of TC is tested by the downstream CIs. Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/tdc.sh | 3 +-- 1 file changed, 1 insertion(

[PATCH net-next v2 3/5] selftests: tc-testing: adjust fq test to latest iproute2

2024-01-24 Thread Pedro Tammela
Adjust the fq verify regex to the latest iproute2 Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/tc-tests/qdiscs/fq.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/fq.json b/tools/testing/selftests

[PATCH net-next v2 2/5] selftests: tc-testing: check if 'jq' is available in taprio tests

2024-01-24 Thread Pedro Tammela
If 'jq' is not available the taprio tests might enter an infinite loop, use the "dependsOn" feature from tdc to check if jq is present. If it's not the test is skipped. Suggested-by: Davide Caratti Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/tc

[PATCH net-next v2 1/5] selftests: tc-testing: add missing netfilter config

2024-01-24 Thread Pedro Tammela
On a default config + tc-testing config build, tdc will miss all the netfilter related tests because it's missing: CONFIG_NETFILTER=y Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/config | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftes

[PATCH net-next v2 0/5] selftests: tc-testing: misc changes for tdc

2024-01-24 Thread Pedro Tammela
;v2: Suggestions by Davide Pedro Tammela (5): selftests: tc-testing: add missing netfilter config selftests: tc-testing: check if 'jq' is available in taprio tests selftests: tc-testing: adjust fq test to latest iproute2 selftests: tc-testing: enable all tdc tests selftests: tc-testing

Re: [PATCH net-next 2/4] selftests: tc-testing: check if 'jq' is available in taprio script

2024-01-24 Thread Pedro Tammela
On 24/01/2024 07:31, Davide Caratti wrote: hello Pedro, thanks for your answer! On Tue, Jan 23, 2024 at 5:47 PM Pedro Tammela wrote: On 23/01/2024 10:17, Davide Caratti wrote: hi Pedro, On Tue, Jan 23, 2024 at 1:28 PM Pedro Tammela wrote: If 'jq' is not available the taprio

Re: [PATCH net-next 2/4] selftests: tc-testing: check if 'jq' is available in taprio script

2024-01-23 Thread Pedro Tammela
On 23/01/2024 10:17, Davide Caratti wrote: hi Pedro, On Tue, Jan 23, 2024 at 1:28 PM Pedro Tammela wrote: If 'jq' is not available the taprio tests that use this script will run forever. Check if it exists before entering the while loop. Signed-off-by: Pedro Tammela --- .../se

[PATCH net-next 4/4] selftests: tc-testing: enable all tdc tests

2024-01-23 Thread Pedro Tammela
For the longest time tdc ran only actions and qdiscs tests. It's time to enable all the remaining tests so every user visible piece of TC is tested by the downstream CIs. Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/tdc.sh | 3 +-- 1 file changed, 1 insertion(

[PATCH net-next 3/4] selftests: tc-testing: adjust fq test to latest iproute2

2024-01-23 Thread Pedro Tammela
Adjust the fq verify regex to the latest iproute2 Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/tc-tests/qdiscs/fq.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/tc-testing/tc-tests/qdiscs/fq.json b/tools/testing/selftests

[PATCH net-next 2/4] selftests: tc-testing: check if 'jq' is available in taprio script

2024-01-23 Thread Pedro Tammela
If 'jq' is not available the taprio tests that use this script will run forever. Check if it exists before entering the while loop. Signed-off-by: Pedro Tammela --- .../selftests/tc-testing/scripts/taprio_wait_for_admin.sh| 5 + 1 file changed, 5 insertions(+) diff --gi

[PATCH net-next 1/4] selftests: tc-testing: add missing netfilter config

2024-01-23 Thread Pedro Tammela
On a default config + tc-testing config build, tdc will miss all the netfilter related tests because it's missing: CONFIG_NETFILTER=y Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/config | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/selftes

[PATCH net-next 0/4] selftests: tc-testing: misc changes for tdc

2024-01-23 Thread Pedro Tammela
Patches 1 and 3 are fixes for tdc that were discovered when running it using defconfig + tc-testing config and against the latest iproute2. Patch 2 improves the taprio script that waits for scheduler changes. Finally, Patch 4 enables all tdc tests. Pedro Tammela (4): selftests: tc-testing

[PATCH net-next 4/4] selftests: tc-testing: remove filters/tests.json

2023-11-29 Thread Pedro Tammela
Remove this generic file and move the tests to their appropriate files Signed-off-by: Pedro Tammela --- .../tc-testing/tc-tests/filters/flower.json | 98 ++ .../tc-testing/tc-tests/filters/matchall.json | 23 .../tc-testing/tc-tests/filters/tests.json| 123

[PATCH net-next 2/4] selftests: tc-testing: remove spurious './' from Makefile

2023-11-29 Thread Pedro Tammela
Patchwork CI didn't like the extra './', so remove it. Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/tc-testing/Makefile b/tools/testing/selftests/tc-t

[PATCH net-next 3/4] selftests: tc-testing: rename concurrency.json to flower.json

2023-11-29 Thread Pedro Tammela
All tests in this file pertain to flower, so name it appropriately Signed-off-by: Pedro Tammela --- .../tc-testing/tc-tests/filters/{concurrency.json => flower.json} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename tools/testing/selftests/tc-testing/tc-tests/filt

[PATCH net-next 1/4] selftests: tc-testing: remove spurious nsPlugin usage

2023-11-29 Thread Pedro Tammela
Tests using DEV2 should not be run in a dedicated net namespace, and in parallel, as this device cannot be shared. Signed-off-by: Pedro Tammela --- .../selftests/tc-testing/tc-tests/filters/tests.json| 6 -- 1 file changed, 6 deletions(-) diff --git a/tools/testing/selftests/tc

[PATCH net-next 0/4] selftests: tc-testing: more tdc updates

2023-11-29 Thread Pedro Tammela
Follow-up on a feedback from Jakub and random cleanups from related net/sched patches Pedro Tammela (4): selftests: tc-testing: remove spurious nsPlugin usage selftests: tc-testing: remove spurious './' from Makefile selftests: tc-testing: rename concurrency.json to flower.json

[PATCH net-next 5/5] selftests: tc-testing: remove unused import

2023-11-24 Thread Pedro Tammela
Remove this leftover from the times we pre-allocated everything Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/plugin-lib/nsPlugin.py | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/testing/selftests/tc-testing/plugin-lib/nsPlugin.py b/tools/testing/selftests/tc

[PATCH net-next 4/5] selftests: tc-testing: cleanup on Ctrl-C

2023-11-24 Thread Pedro Tammela
ssing keyword replacement for nsPlugin is also included. Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/plugin-lib/nsPlugin.py | 2 +- tools/testing/selftests/tc-testing/tdc.py | 6 +- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/tools/te

[PATCH net-next 3/5] selftests: tc-testing: prefix iproute2 functions with "ipr2"

2023-11-24 Thread Pedro Tammela
As suggested by Simon, prefix the functions that operate on iproute2 commands in contrast with the "nl" netlink prefix. Cc: Simon Horman Signed-off-by: Pedro Tammela --- .../selftests/tc-testing/plugin-lib/nsPlugin.py | 16 1 file changed, 8 insertions(+), 8

[PATCH net-next 2/5] selftests: tc-testing: remove unnecessary time.sleep

2023-11-24 Thread Pedro Tammela
This operation is redundant and it's not stabilizing nor waiting for anything. Signed-off-by: Pedro Tammela --- tools/testing/selftests/tc-testing/tdc.py | 5 - 1 file changed, 5 deletions(-) diff --git a/tools/testing/selftests/tc-testing/tdc.py b/tools/testing/selftests/tc-te

[PATCH net-next 1/5] selftests: tc-testing: remove buildebpf plugin

2023-11-24 Thread Pedro Tammela
As tdc only tests loading/deleting and anything more complicated is better left to the ebpf test suite, provide a pre-compiled version of 'action.c' and don't bother compiling it in kselftests or on the fly at all. Cc: Davide Caratti Signed-off-by: Pedro Tammela --- tools/testi

[PATCH net-next 0/5] selftests: tc-testing: updates and cleanups for tdc

2023-11-24 Thread Pedro Tammela
Address the recommendations from the previous series and cleanup some leftovers. Pedro Tammela (5): selftests: tc-testing: remove buildebpf plugin selftests: tc-testing: remove unnecessary time.sleep selftests: tc-testing: prefix iproute2 functions with "ipr2" selftests: