Re: [PATCH v2 3/6] ALSA: control: Apply sanity check of input values for user elements

2024-06-15 Thread Takashi Sakamoto
d-by: Jaroslav Kysela > Reviewed-by: Mark Brown > Signed-off-by: Takashi Iwai > --- > sound/core/control.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Takashi Sakamoto Thanks Takashi Sakamoto

Re: [PATCH v2 3/6] ALSA: control: Apply sanity check of input values for user elements

2024-06-15 Thread Takashi Sakamoto
to extend current implementation of user-defined element set. Thus I suggest to put the validation into the put callback function, regardless of the optimization to which you address. Regards Takashi Sakamoto

Re: [PATCH v2 3/6] ALSA: control: Apply sanity check of input values for user elements

2024-06-14 Thread Takashi Sakamoto
d idea, since the ALSA control core function loses transparency against control elements somehow. Furthermore, I can see "there is no corresponding driver", however it is suspicious somehow. It would be smart to charge the validation implementation for user-defined control element set if forcing it. Regards Takashi Sakamoto