[PATCH v2 2/2] selftests/harness: Use 1024 in place of LINE_MAX

2024-05-08 Thread Tao Su
name once") Signed-off-by: Tao Su --- tools/testing/selftests/kselftest_harness.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/selftests/kselftest_harness.h b/tools/testing/selftests/kselftest_harness.h index ba3ddeda24bf..610642f50977 100644 --- a/too

[PATCH v2 1/2] Revert "selftests/harness: remove use of LINE_MAX"

2024-05-08 Thread Tao Su
16233555 ("selftests/harness: remove use of LINE_MAX") Signed-off-by: Tao Su --- tools/testing/selftests/kselftest_harness.h | 12 tools/testing/selftests/mm/mdwe_test.c | 1 - 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/tools/testing/selftests/kselft

[PATCH v2 0/2] Selftests: Fix compilation warnings due to missing _GNU_SOURCE definition

2024-05-08 Thread Tao Su
] https://lore.kernel.org/linux-kselftest/zjua3ay_ihkjp...@google.com v1 -> v2: - Stop defining _GNU_SOURCE in related selftests - Revert commit 809216233555 - Use 1024 in place of LINE_MAX to fix 38c957f07038 v1: https://lore.kernel.org/all/20240507063534.4191447-1-tao1...@linux.intel.com/ Tao

Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h

2024-05-08 Thread Tao Su
On Wed, May 08, 2024 at 10:57:47AM -0700, Edward Liaw wrote: > On Wed, May 8, 2024 at 7:00 AM Jakub Kicinski wrote: > > > > On Wed, 8 May 2024 10:55:05 +0800 Tao Su wrote: > > > Back to commit 38c957f07038, I don't see any advantage in using LINE_MAX. > > &g

Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h

2024-05-08 Thread Tao Su
On Wed, May 08, 2024 at 07:00:03AM -0700, Jakub Kicinski wrote: > On Wed, 8 May 2024 10:55:05 +0800 Tao Su wrote: > > Back to commit 38c957f07038, I don't see any advantage in using LINE_MAX. > > Can we use a fixed value instead of LINE_MAX? E.g., 1024, 2048. Then we > >

Re: [PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h

2024-05-07 Thread Tao Su
On Tue, May 07, 2024 at 10:06:51AM -0700, Andrew Morton wrote: > On Tue, 7 May 2024 14:35:34 +0800 Tao Su wrote: > > > asprintf() is declared in stdio.h when defining _GNU_SOURCE, but stdio.h > > is so common that many files don’t define _GNU_SOURCE before including > &g

[PATCH] selftests: Add _GNU_SOURCE definition when including kselftest_harness.h

2024-05-06 Thread Tao Su
_GNU_SOURCE definition in the tests that have compilation warnings. Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") Signed-off-by: Tao Su --- tools/testing/selftests/alsa/test-pcmtest-driver.c | 1 + tools/testing/selftests/kvm/x86_64/fix_hypercall_test.c | 1 + too