Re: [FIX PATCH] selftests: tracing: Fix to unmount tracefs for recovering environment

2023-09-11 Thread Steven Rostedt
On Tue, 12 Sep 2023 09:54:57 +0900 Masami Hiramatsu (Google) wrote: > > Shouldn't the above be: > > > > if [ ! -z "${UNMOUNT_DIR}" ]; then > > > > ? > > I think both are good. > What about using '-n' explictly? > > [ -n "${UNMOUNT_DIR}" ] Even better. Heh, I never even knew about that

Re: [FIX PATCH] selftests: tracing: Fix to unmount tracefs for recovering environment

2023-09-11 Thread Google
On Mon, 11 Sep 2023 13:09:09 -0400 Steven Rostedt wrote: > On Sat, 9 Sep 2023 18:36:39 +0900 > "Masami Hiramatsu (Google)" wrote: > > > From: Masami Hiramatsu (Google) > > > > Fix to unmount the tracefs if the ftracetest mounted it for recovering > > system environment. If the tracefs is alr