Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-15 Thread Mark Brown
On Mon, Jul 15, 2024 at 03:23:24PM +0200, Takashi Iwai wrote: > Mark Brown wrote: > > Interesting - I was mainly developing on a system with multiple HDA > > cards and was getting fairly clearly unique names. > An AMD system usually has two HD-audio entries, and both are "HD-audio > Generic". Ri

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-15 Thread Takashi Iwai
On Mon, 15 Jul 2024 15:18:44 +0200, Mark Brown wrote: > > On Sat, Jul 13, 2024 at 08:46:43AM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > OTOH, if the former is the problem, using longname won't help, > > either, rather it can be confusing. I noticed that the test output > > truncates

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-15 Thread Mark Brown
On Sat, Jul 13, 2024 at 08:46:43AM +0200, Takashi Iwai wrote: > Mark Brown wrote: > > Sure, but the genesis of this patch is that probe order isn't > > sufficiently stable and we want to avoid names based on it... using the > > ID will be more likely to work out stable than just pure probe order

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-15 Thread Mark Brown
On Sat, Jul 13, 2024 at 09:35:36AM +0200, Jaroslav Kysela wrote: > On 12. 07. 24 20:19, Mark Brown wrote: > > Sure, but the genesis of this patch is that probe order isn't > > sufficiently stable and we want to avoid names based on it... using the > > ID will be more likely to work out stable tha

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-13 Thread Jaroslav Kysela
On 12. 07. 24 20:19, Mark Brown wrote: On Fri, Jul 12, 2024 at 06:25:21PM +0200, Jaroslav Kysela wrote: On 12. 07. 24 15:00, Mark Brown wrote: The trouble with the ID field is that it's too short and seems likely to create collisions, for example HDA stuff just seems to default to NVidia for

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-12 Thread Takashi Iwai
On Fri, 12 Jul 2024 20:19:33 +0200, Mark Brown wrote: > > On Fri, Jul 12, 2024 at 06:25:21PM +0200, Jaroslav Kysela wrote: > > On 12. 07. 24 15:00, Mark Brown wrote: > > > > The trouble with the ID field is that it's too short and seems likely to > > > create collisions, for example HDA stuff jus

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-12 Thread Mark Brown
On Fri, Jul 12, 2024 at 06:25:21PM +0200, Jaroslav Kysela wrote: > On 12. 07. 24 15:00, Mark Brown wrote: > > The trouble with the ID field is that it's too short and seems likely to > > create collisions, for example HDA stuff just seems to default to NVidia > > for nVidia cards which seems very

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-12 Thread Jaroslav Kysela
On 12. 07. 24 15:00, Mark Brown wrote: On Fri, Jul 12, 2024 at 11:20:05AM +0200, Jaroslav Kysela wrote: On 12. 07. 24 10:21, Takashi Iwai wrote: OTOH, longname can be really ugly to read, and it can vary because it often embeds address or irq numbers in the string. Capturing that variation

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-12 Thread Mark Brown
On Fri, Jul 12, 2024 at 11:20:05AM +0200, Jaroslav Kysela wrote: > On 12. 07. 24 10:21, Takashi Iwai wrote: > > OTOH, longname can be really ugly to read, and it can vary because it > > often embeds address or irq numbers in the string. Capturing that variation is one of the goals - it should mos

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-12 Thread Jaroslav Kysela
On 12. 07. 24 10:21, Takashi Iwai wrote: On Thu, 11 Jul 2024 18:19:25 +0200, Mark Brown wrote: On Thu, Jul 11, 2024 at 06:08:38PM +0200, Jaroslav Kysela wrote: On 11. 07. 24 16:33, Mark Brown wrote: Address this by replacing our use of card numbers with card names which are more likely to b

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-12 Thread Takashi Iwai
On Thu, 11 Jul 2024 18:19:25 +0200, Mark Brown wrote: > > On Thu, Jul 11, 2024 at 06:08:38PM +0200, Jaroslav Kysela wrote: > > On 11. 07. 24 16:33, Mark Brown wrote: > > > > Address this by replacing our use of card numbers with card names which > > > are > > > more likely to be stable across ru

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-11 Thread Mark Brown
On Thu, Jul 11, 2024 at 06:08:38PM +0200, Jaroslav Kysela wrote: > On 11. 07. 24 16:33, Mark Brown wrote: > > Address this by replacing our use of card numbers with card names which are > > more likely to be stable across runs. We use the long name since in the > I think that a combination of car

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-11 Thread Jaroslav Kysela
On 11. 07. 24 16:33, Mark Brown wrote: Currently for the PCM and mixer tests we report test names which identify the card being tested with the card number. This ensures we have unique names but since card numbers are dynamically assigned at runtime the names we end up with will often not be stab

[PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-11 Thread Mark Brown
Currently for the PCM and mixer tests we report test names which identify the card being tested with the card number. This ensures we have unique names but since card numbers are dynamically assigned at runtime the names we end up with will often not be stable on systems with multiple cards especia