Re: [PATCH] selftests/vDSO: open code basic chacha instead of linking to libsodium

2024-08-28 Thread Jason A. Donenfeld
On Wed, Aug 28, 2024 at 6:54 PM Christophe Leroy wrote: > The only thing is that you must describe this behaviour change in your > commit message, you can't just let people believe it is a one-to-one > replacement of the previous test implementation that used Sodium. Good point, will do.

Re: [PATCH] selftests/vDSO: open code basic chacha instead of linking to libsodium

2024-08-28 Thread Christophe Leroy
Le 28/08/2024 à 16:49, Jason A. Donenfeld a écrit : Hi Christophe, On Wed, Aug 28, 2024 at 4:38 PM LEROY Christophe wrote: - key[0], key[1], key[2], key[3], key[4], key[5], key[6], key[7] + le32toh(key[0]), le32toh(key[1]), le32toh(key[2]), le32toh(key[3]), +

Re: [PATCH] selftests/vDSO: open code basic chacha instead of linking to libsodium

2024-08-28 Thread Jason A. Donenfeld
Hi Christophe, On Wed, Aug 28, 2024 at 4:38 PM LEROY Christophe wrote: > - key[0], key[1], key[2], key[3], key[4], key[5], key[6], key[7] > + le32toh(key[0]), le32toh(key[1]), le32toh(key[2]), > le32toh(key[3]), > + le32toh(key[4]), le32toh(key[5]), le3

Re: [PATCH] selftests/vDSO: open code basic chacha instead of linking to libsodium

2024-08-28 Thread LEROY Christophe
Hi Jason, Le 28/08/2024 à 15:55, Jason A. Donenfeld a écrit : > Linking to libsodium makes building this test annoying in cross > compilation environments and is just way too much. Since this is just a > basic correctness test, simply open code a simple, unoptimized, dumb > chacha, rather than lin

[PATCH] selftests/vDSO: open code basic chacha instead of linking to libsodium

2024-08-28 Thread Jason A. Donenfeld
Linking to libsodium makes building this test annoying in cross compilation environments and is just way too much. Since this is just a basic correctness test, simply open code a simple, unoptimized, dumb chacha, rather than linking to libsodium. Signed-off-by: Jason A. Donenfeld --- tools/testi