Re: [PATCH] selftests:net change ifconfig with ip command

2023-10-23 Thread David Ahern
On 10/23/23 1:12 AM, Jiri Pirko wrote: >> ip addr add ... > > Why not "address" then? :) no objection from me. > What's wrong with "a"? 1-letter commands can be ambiguous. Test scripts should be clear and obvious.

Re: [PATCH] selftests:net change ifconfig with ip command

2023-10-23 Thread Jiri Pirko
Sun, Oct 22, 2023 at 07:50:52PM CEST, dsah...@kernel.org wrote: >On 10/22/23 5:31 AM, Swarup Laxman Kotiaklapudi wrote: >> diff --git a/tools/testing/selftests/net/route_localnet.sh >> b/tools/testing/selftests/net/route_localnet.sh >> index 116bfeab72fa..3ab9beb4462c 100755 >> ---

Re: [PATCH] selftests:net change ifconfig with ip command

2023-10-22 Thread David Ahern
On 10/22/23 5:31 AM, Swarup Laxman Kotiaklapudi wrote: > diff --git a/tools/testing/selftests/net/route_localnet.sh > b/tools/testing/selftests/net/route_localnet.sh > index 116bfeab72fa..3ab9beb4462c 100755 > --- a/tools/testing/selftests/net/route_localnet.sh > +++

[PATCH] selftests:net change ifconfig with ip command

2023-10-22 Thread Swarup Laxman Kotiaklapudi
Change ifconfig with ip command, on a system where ifconfig is not used this script will not work correcly. Test result with this patchset: sudo make TARGETS="net" kselftest TAP version 13 1..1 timeout set to 1500 selftests: net: route_localnet.sh run arp_announce test