Re: [PATCH 08/19] riscv: Introduce vendor variants of extension helpers

2024-04-12 Thread Charlie Jenkins
On Fri, Apr 12, 2024 at 10:34:10PM +0100, Conor Dooley wrote: > On Fri, Apr 12, 2024 at 02:03:48PM -0700, Charlie Jenkins wrote: > > On Fri, Apr 12, 2024 at 09:40:03PM +0100, Conor Dooley wrote: > > > On Fri, Apr 12, 2024 at 10:43:02AM -0700, Charlie Jenkins wrote: > > > > On Fri, Apr 12, 2024 at 1

Re: [PATCH 08/19] riscv: Introduce vendor variants of extension helpers

2024-04-12 Thread Conor Dooley
On Fri, Apr 12, 2024 at 02:03:48PM -0700, Charlie Jenkins wrote: > On Fri, Apr 12, 2024 at 09:40:03PM +0100, Conor Dooley wrote: > > On Fri, Apr 12, 2024 at 10:43:02AM -0700, Charlie Jenkins wrote: > > > On Fri, Apr 12, 2024 at 12:49:57PM +0100, Conor Dooley wrote: > > > > On Thu, Apr 11, 2024 at 0

Re: [PATCH 08/19] riscv: Introduce vendor variants of extension helpers

2024-04-12 Thread Charlie Jenkins
On Fri, Apr 12, 2024 at 09:40:03PM +0100, Conor Dooley wrote: > On Fri, Apr 12, 2024 at 10:43:02AM -0700, Charlie Jenkins wrote: > > On Fri, Apr 12, 2024 at 12:49:57PM +0100, Conor Dooley wrote: > > > On Thu, Apr 11, 2024 at 09:11:14PM -0700, Charlie Jenkins wrote: > > > > Create vendor variants of

Re: [PATCH 08/19] riscv: Introduce vendor variants of extension helpers

2024-04-12 Thread Conor Dooley
On Fri, Apr 12, 2024 at 10:43:02AM -0700, Charlie Jenkins wrote: > On Fri, Apr 12, 2024 at 12:49:57PM +0100, Conor Dooley wrote: > > On Thu, Apr 11, 2024 at 09:11:14PM -0700, Charlie Jenkins wrote: > > > Create vendor variants of the existing extension helpers. If the > > > existing functions were

Re: [PATCH 08/19] riscv: Introduce vendor variants of extension helpers

2024-04-12 Thread Charlie Jenkins
On Fri, Apr 12, 2024 at 12:49:57PM +0100, Conor Dooley wrote: > On Thu, Apr 11, 2024 at 09:11:14PM -0700, Charlie Jenkins wrote: > > Create vendor variants of the existing extension helpers. If the > > existing functions were instead modified to support vendor extensions, a > > branch based on the

Re: [PATCH 08/19] riscv: Introduce vendor variants of extension helpers

2024-04-12 Thread Conor Dooley
On Thu, Apr 11, 2024 at 09:11:14PM -0700, Charlie Jenkins wrote: > Create vendor variants of the existing extension helpers. If the > existing functions were instead modified to support vendor extensions, a > branch based on the ext value being greater than > RISCV_ISA_VENDOR_EXT_BASE would have to

[PATCH 08/19] riscv: Introduce vendor variants of extension helpers

2024-04-11 Thread Charlie Jenkins
Create vendor variants of the existing extension helpers. If the existing functions were instead modified to support vendor extensions, a branch based on the ext value being greater than RISCV_ISA_VENDOR_EXT_BASE would have to be introduced. This additional branch would have an unnecessary performa