Re: [PATCH 1/3] selftests/exec: Build both static and non-static load_address tests

2024-08-19 Thread John Hubbard
On 8/19/24 12:41 PM, John Hubbard wrote: On 8/18/24 8:55 PM, Muhammad Usama Anjum wrote: On 8/7/24 3:22 PM, Muhammad Usama Anjum wrote: On 5/9/24 11:16 AM, Kees Cook wrote: ... make ARCH=arm CROSS_COMPILE=arm-linux-gnueabihf- arm-linux-gnueabihf-gcc -Wall -Wno-nonnull -D_GNU_SOURCE= -Wl,-z,ma

Re: [PATCH 1/3] selftests/exec: Build both static and non-static load_address tests

2024-08-19 Thread John Hubbard
On 8/18/24 8:55 PM, Muhammad Usama Anjum wrote: On 8/7/24 3:22 PM, Muhammad Usama Anjum wrote: On 5/9/24 11:16 AM, Kees Cook wrote: On Wed, May 08, 2024 at 07:54:13PM -0700, John Hubbard wrote: Didn't we learn recently, though, that -static-pie is gcc 8.1+, while the kernel's minimum gcc versi

Re: [PATCH 1/3] selftests/exec: Build both static and non-static load_address tests

2024-08-18 Thread Muhammad Usama Anjum
On 8/7/24 3:22 PM, Muhammad Usama Anjum wrote: > On 5/9/24 11:16 AM, Kees Cook wrote: >> On Wed, May 08, 2024 at 07:54:13PM -0700, John Hubbard wrote: >>> Didn't we learn recently, though, that -static-pie is gcc 8.1+, while the >>> kernel's minimum gcc version is 5? >> >> Yes, that's true. If we e

Re: [PATCH 1/3] selftests/exec: Build both static and non-static load_address tests

2024-08-07 Thread Muhammad Usama Anjum
On 5/9/24 11:16 AM, Kees Cook wrote: > On Wed, May 08, 2024 at 07:54:13PM -0700, John Hubbard wrote: >> Didn't we learn recently, though, that -static-pie is gcc 8.1+, while the >> kernel's minimum gcc version is 5? > > Yes, that's true. If we encounter anyone trying to build the selftests > with

Re: [PATCH 1/3] selftests/exec: Build both static and non-static load_address tests

2024-05-08 Thread Kees Cook
On Wed, May 08, 2024 at 07:54:13PM -0700, John Hubbard wrote: > Didn't we learn recently, though, that -static-pie is gcc 8.1+, while the > kernel's minimum gcc version is 5? Yes, that's true. If we encounter anyone trying to build the selftests with <8.1 I think we'll have to add a compiler versi

Re: [PATCH 1/3] selftests/exec: Build both static and non-static load_address tests

2024-05-08 Thread John Hubbard
On 5/8/24 10:31 AM, Kees Cook wrote: After commit 4d1cd3b2c5c1 ("tools/testing/selftests/exec: fix link error"), the load address alignment tests tried to build statically. This was silently ignored in some cases. However, after attempting to further fix the build by switching to "-static-pie", t

[PATCH 1/3] selftests/exec: Build both static and non-static load_address tests

2024-05-08 Thread Kees Cook
After commit 4d1cd3b2c5c1 ("tools/testing/selftests/exec: fix link error"), the load address alignment tests tried to build statically. This was silently ignored in some cases. However, after attempting to further fix the build by switching to "-static-pie", the test started failing. This appears t