Re: [PATCH 2/3] bpf: do not walk twice the hash map on free

2024-04-30 Thread Benjamin Tissoires
On Apr 25 2024, Alexei Starovoitov wrote: > On Thu, Apr 25, 2024 at 6:59 AM Benjamin Tissoires wrote: > > > > If someone stores both a timer and a workqueue in a hash map, on free, we > > would walk it twice. > > Add a check in htab_free_malloced_timers_or_wq and free the timers > > and workqueues

Re: [PATCH 2/3] bpf: do not walk twice the hash map on free

2024-04-25 Thread kernel test robot
: 52578f7f53ff8fe3a8f6f3bc8b5956615c07a16e patch link: https://lore.kernel.org/r/20240425-bpf-next-v1-2-1d8330e6c643%40kernel.org patch subject: [PATCH 2/3] bpf: do not walk twice the hash map on free config: arc-randconfig-002-20240426 (https://download.01.org/0day-ci/archive/20240426/202404260653.ulrcgrp2

Re: [PATCH 2/3] bpf: do not walk twice the hash map on free

2024-04-25 Thread Alexei Starovoitov
On Thu, Apr 25, 2024 at 6:59 AM Benjamin Tissoires wrote: > > If someone stores both a timer and a workqueue in a hash map, on free, we > would walk it twice. > Add a check in htab_free_malloced_timers_or_wq and free the timers > and workqueues if they are present. > > Fixes: 246331e3f1ea ("bpf: a

[PATCH 2/3] bpf: do not walk twice the hash map on free

2024-04-25 Thread Benjamin Tissoires
If someone stores both a timer and a workqueue in a hash map, on free, we would walk it twice. Add a check in htab_free_malloced_timers_or_wq and free the timers and workqueues if they are present. Fixes: 246331e3f1ea ("bpf: allow struct bpf_wq to be embedded in arraymaps and hashmaps") Signed-of