Re: [PATCH net] selftests: netdevsim: fix the udp_tunnel_nic test

2024-01-24 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Jakub Kicinski : On Mon, 22 Jan 2024 22:05:29 -0800 you wrote: > This test is missing a whole bunch of checks for interface > renaming and one ifup. Presumably it was only used on a system > with renaming disabled and NetworkManager runnin

Re: [PATCH net] selftests: netdevsim: fix the udp_tunnel_nic test

2024-01-24 Thread Simon Horman
On Mon, Jan 22, 2024 at 10:05:29PM -0800, Jakub Kicinski wrote: > This test is missing a whole bunch of checks for interface > renaming and one ifup. Presumably it was only used on a system > with renaming disabled and NetworkManager running. > > Fixes: 91f430b2c49d ("selftests: net: add a test fo

Re: [PATCH net] selftests: netdevsim: fix the udp_tunnel_nic test

2024-01-23 Thread Jakub Kicinski
On Tue, 23 Jan 2024 07:39:25 -0800 Jakub Kicinski wrote: > On Tue, 23 Jan 2024 09:27:17 +0100 Paolo Abeni wrote: > > > @@ -270,6 +270,7 @@ for port in 0 1; do > > > echo 1 > $NSIM_DEV_SYS/new_port > > > fi > > > NSIM_NETDEV=`get_netdev_name old_netdevs` > > > +ifconfig $NSIM_NETDEV

Re: [PATCH net] selftests: netdevsim: fix the udp_tunnel_nic test

2024-01-23 Thread Jakub Kicinski
On Tue, 23 Jan 2024 09:27:17 +0100 Paolo Abeni wrote: > > @@ -270,6 +270,7 @@ for port in 0 1; do > > echo 1 > $NSIM_DEV_SYS/new_port > > fi > > NSIM_NETDEV=`get_netdev_name old_netdevs` > > +ifconfig $NSIM_NETDEV up > > WoW! I initially thought the above was a typo, before not

Re: [PATCH net] selftests: netdevsim: fix the udp_tunnel_nic test

2024-01-23 Thread Paolo Abeni
On Mon, 2024-01-22 at 22:05 -0800, Jakub Kicinski wrote: > This test is missing a whole bunch of checks for interface > renaming and one ifup. Presumably it was only used on a system > with renaming disabled and NetworkManager running. > > Fixes: 91f430b2c49d ("selftests: net: add a test for UDP t

[PATCH net] selftests: netdevsim: fix the udp_tunnel_nic test

2024-01-22 Thread Jakub Kicinski
This test is missing a whole bunch of checks for interface renaming and one ifup. Presumably it was only used on a system with renaming disabled and NetworkManager running. Fixes: 91f430b2c49d ("selftests: net: add a test for UDP tunnel info infra") Signed-off-by: Jakub Kicinski --- CC: sh...@ker